Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-20 Thread Amine Khaldi
> That is an implementation detail. It should not make a difference > whether the precompiled header is used through your existing header or > through an autogenerated header that forward includes your existing > header. This forward inclusion is important at least for GCC: The > compiler searches

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-20 Thread Daniel Pfeifer
On Fri, Mar 20, 2015 at 6:35 PM, Amine Khaldi wrote: > Two requests please: > > * The option to use existing headers instead of autogenerated ones. That is an implementation detail. It should not make a difference whether the precompiled header is used through your existing header or through an a

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-20 Thread Daniel Pfeifer
On Fri, Mar 20, 2015 at 6:13 PM, Brad King wrote: > On 03/13/2015 08:44 AM, Daniel Pfeifer wrote: >> I pushed some work to https://github.com/purpleKarrot/CMake/commits/pch > > Thanks for working on this. I'm hoping others will respond because > I have little experience with PCH. > >> target_prec

[cmake-developers] [CMake 0015461]: Ninja generator does not honor COMMENT for TARGET POST_BUILD commands

2015-03-20 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15461 == Reported By:Chris Green Assigned To:

Re: [cmake-developers] Support of codesign

2015-03-20 Thread Eric Wing
Sorry, I'm also very late on this thread, but there was a suggestion that codesigning should be in CMake instead of CPack. I agree and also say it needs to be integrated as part of the build process when specified. Here's a real world workflow. I use JavaScriptCore in my Mac application which allo

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-20 Thread Amine Khaldi
> My solution needs to generate additional target indeed for one pre-generated > header, so if all your 1000+ targets will share same precompiled header > (given the compiler flags don't change) then you will have just one (single) > additional target. It's very rare (not to mention risky) to b

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-20 Thread Adam Strzelecki
> * The option to use existing headers instead of autogenerated ones. My solution (which is about PCH support to existing CMake version) does not auto generate any headers. > * Implementing PCH support without additional targets. ReactOS already has > like 1000+ targets, and we currently use PC

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-20 Thread Amine Khaldi
Two requests please: * The option to use existing headers instead of autogenerated ones. * Implementing PCH support without additional targets. ReactOS already has like 1000+ targets, and we currently use PCH on almost all of them, so imagine if this official implementation doubles our targets n

Re: [cmake-developers] FW: FW: Initial Attempt at Green Hill MULTI IDE Generator Support

2015-03-20 Thread Brad King
On 03/19/2015 09:57 AM, Geoffrey Viola wrote: > Fixed. Great, thanks. I'll take another look at the updated patch next week. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to

Re: [cmake-developers] RFC: Helper macros for writing Find modules

2015-03-20 Thread Brad King
On 03/18/2015 05:50 PM, Alex Merry wrote: > I made some changes in a copy of this module for work that separated out the > target creation, as well as adding debug/release support. I'll check about > being allowed to release that work, but I doubt it'll be an issue. Great. Will you be able to t

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

2015-03-20 Thread Brad King
On 03/13/2015 08:44 AM, Daniel Pfeifer wrote: > I pushed some work to https://github.com/purpleKarrot/CMake/commits/pch Thanks for working on this. I'm hoping others will respond because I have little experience with PCH. > target_precompile_headers(bar INTERFACE bar.h) [snip] > This command is

Re: [cmake-developers] patch that adds -KPIC flag to SunPro Fortran compiler

2015-03-20 Thread Brad King
On 03/20/2015 04:23 AM, Steven Vancoillie wrote: > I ran into a problem with SunPro Fortran compiler not being able to > create a shared library since the -KPIC flag was missing. The patch > that is attached fixes this. I didn't add a -KPIE as that doesn't > exist for SunPro. Applied, thanks: Su

Re: [cmake-developers] AutogenInfo.cmake With Read-Only Modules

2015-03-20 Thread Brad King
On 03/18/2015 09:46 PM, Justin Borodinsky wrote: > ConfigureFile use the source file's permissions, but > cmQtAutoGenerators::SetupAutoGenerateTarget requires write access. Great! That resolves this issue: http://www.cmake.org/Bug/view.php?id=15416 Applied: QtAutogen: Ensure write access to

Re: [cmake-developers] BlueGene/Q Platform files

2015-03-20 Thread Brad King
On 03/19/2015 02:53 AM, Todd Gamblin wrote: > Let me know if I can merge this topic to next. Yes, please. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the

[cmake-developers] patch that adds -KPIC flag to SunPro Fortran compiler

2015-03-20 Thread Steven Vancoillie
Hi, I ran into a problem with SunPro Fortran compiler not being able to create a shared library since the -KPIC flag was missing. The patch that is attached fixes this. I didn't add a -KPIE as that doesn't exist for SunPro. Looking at other compiler configurations, it seems it might be better to