Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-12 Thread Brad King
On 09/12/2014 03:42 AM, Bach, Pascal wrote: > Now in order to have it fully working on WindowsCE the following issues > remain: > 1. The subsystem for EXE and DLL currently it is set to Console or Windows > depending on the WIN32_EXECUTABLE property of the target. For WinCE the > subsystem needs

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-12 Thread Bach, Pascal
> On 09/05/2014 03:53 PM, Brad King wrote: > > I think "CMAKE_GENERATOR_PLATFORM" may be a suitable name. Ideally > > this setting should be added as a general-purpose replacement for > > putting "ARM" or "Win64" in the generator name. The changes for > > that are more sweeping than I'd like to a

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-11 Thread Brad King
On 09/05/2014 03:53 PM, Brad King wrote: > I think "CMAKE_GENERATOR_PLATFORM" may be a suitable name. Ideally > this setting should be added as a general-purpose replacement for > putting "ARM" or "Win64" in the generator name. The changes for > that are more sweeping than I'd like to ask of you

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-05 Thread Brad King
On 09/05/2014 10:02 AM, Bach, Pascal wrote: >> On 09/05/2014 09:16 AM, Bach, Pascal wrote: >> Since CMakeSystem.cmake loads the CMAKE_TOOLCHAIN_FILE, try_compile >> should use CMAKE_VS_WINCE_SDK when the value is set in the toolchain >> file. Is this the case when you test the changes locally? >

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-05 Thread Bach, Pascal
> On 09/05/2014 09:16 AM, Bach, Pascal wrote: > > I'm not clear what you mean. > > As far as I understand the solution files that do try compile > > are generated using the same generator that generates the > > final solution file. > > A generator with the same name is used but it is not the sa

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-05 Thread Brad King
On 09/05/2014 09:16 AM, Bach, Pascal wrote: > I'm not clear what you mean. > As far as I understand the solution files that do try compile > are generated using the same generator that generates the > final solution file. A generator with the same name is used but it is not the same instance of cm

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-05 Thread Bach, Pascal
Here is an update version of my patchset: It also works with older versions of Windows CE but it tells the user that he might to manually se the CMAKE_PLATFORM_TOOLSET (I hope the resubmission is OK like this) >From 145c3189abf84aca046f555c5452396f0e5936eb Mon Sep 17 00:00:00 2001 From: Pascal

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-05 Thread Bach, Pascal
>> Right, it gets called inside try_compile projects too. Actually >> the SDK information will have to be propagated into those too. >> That means it needs to go in files like CMakeSystem.cmake or >> CMakeCCompiler.cmake that are configured in the build tree, >> or be explicitly propagated by cmMa

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-04 Thread Brad King
On 09/04/2014 09:31 AM, Bach, Pascal wrote: > With the current implementation I sent this seems to work and the SDK ends up > in > The generated vxproj files for try compile. I don't see anything in the patch that could do that. CMakeDetermineCompilerId generates a test .vcxproj file that gets

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-04 Thread Bach, Pascal
> > This won't' work as the code gets called multiple times > > Right, it gets called inside try_compile projects too. Actually > the SDK information will have to be propagated into those too. > That means it needs to go in files like CMakeSystem.cmake or > CMakeCCompiler.cmake that are configure

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-04 Thread Brad King
On 09/04/2014 06:42 AM, Bach, Pascal wrote: > This won't' work as the code gets called multiple times Right, it gets called inside try_compile projects too. Actually the SDK information will have to be propagated into those too. That means it needs to go in files like CMakeSystem.cmake or CMakeCC

[cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-04 Thread Pascal Bach
- Allow setting CMAKE_VS_WINCE_SDK to specify the SDK. - The user is warned if he uses a version different Windows CE different from 8.0 and not CMAKE_PLATFORM_TOOLSET is specified. - Docuentation for WINCE and CMAKE_VS_WINCE_SDK added. --- Help/variable/CMAKE_VS_WINCE_SDK.rst | 13 +++

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-04 Thread Bach, Pascal
> > + else if (this->SystemName == "WindowsCE") > > +{ > > +this->SystemIsWindowsCE = true; > > +if (!this->InitializeWindowsCE(mf)) > > At the beginning of this block you should check/reject when > the generator name specified a platform name. Something like: > > if(this->Pla

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-03 Thread Brad King
On 09/03/2014 01:21 PM, Bach, Pascal wrote: > This is only a first draft and I would like to hear if I am on the right > track. Yes, it looks good so far. > + else if (this->SystemName == "WindowsCE") > +{ > +this->SystemIsWindowsCE = true; > +if (!this->InitializeWindowsCE(mf)) At

Re: [cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-03 Thread Bach, Pascal
Looks like I missed the Description :( This is only a first draft and I would like to hear if I am on the right track. The patch implements the SDK selection for Windows CE. If CMAKE_SYSTEM_NAME="WindowsCE" the user has to specify an SDK using the variable: CMAKE_VS_WINCE_SDK The implementation

[cmake-developers] [PATCH] WINCE, VS: Allow selecting an SDK for Windows CE on Visual Studio

2014-09-03 Thread Pascal Bach
Set CMAKE_VS_WINCE_SDK to specify the SDK. --- Source/cmGlobalVisualStudio10Generator.cxx | 48 Source/cmGlobalVisualStudio10Generator.h |7 Source/cmGlobalVisualStudio11Generator.cxx | 12 +++ Source/cmGlobalVisualStudio11Generator.h |2 ++ So