Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-10-02 Thread Brad King
On 10/01/2015 09:04 AM, Brad King wrote: > Looks good, thanks. I've applied the series with minor tweaks: After a C++98 compilation fix and some documentation updates, this is now in 'master': Help: Improve CMAKE_SYSTEM_{NAME,VERSION} variable documentation

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-10-01 Thread Brad King
On 09/30/2015 05:05 PM, Gilles Khouzam wrote: > simply use the SystemVersion to determine the version of > the Windows 10 SDK to use. > > Now, by default on Windows 10 host devices with Visual Studio 2015, > the latest SDK will be used. Looks good, thanks. I've applied the series with minor

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-30 Thread Gilles Khouzam
ubject: RE: [cmake-developers] [Patch] Adding Windows 10 support The more I think about it, the more this makes sense and should work out well. Let me take your current changes and adapt them for this and test them out. -Original Message- From: Gilles Khouzam Sent: Friday, September 25, 2

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-28 Thread Gilles Khouzam
cmake-developers@cmake.org Subject: RE: [cmake-developers] [Patch] Adding Windows 10 support You're right, by targeting another version (8.1 or 6.3), the tag would not be written. Leveraging CMAKE_SYSTEM_VERSION is an interesting idea. Let me mull it over a little bit more and see how I would

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-25 Thread Brad King
On 09/25/2015 01:00 PM, Gilles Khouzam wrote: > This was done deliberately to only force a value for > CMAKE_WINDOWS_TARGET_PLATFORM_VERSION With the approach in my patch that variable is never set by the generator. It chooses a WindowsTargetPlatformVersion value and reports it in

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-25 Thread Gilles Khouzam
lles Khouzam <gilles.khou...@microsoft.com> Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [Patch] Adding Windows 10 support On 09/23/2015 06:48 PM, Gilles Khouzam wrote: > This adds only the WINDOWS_TARGET_PLATFORM_VERSION property as it > currently only supports the desktop scena

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-25 Thread Gilles Khouzam
[cmake-developers] [Patch] Adding Windows 10 support On 09/25/2015 01:00 PM, Gilles Khouzam wrote: > This was done deliberately to only force a value for > CMAKE_WINDOWS_TARGET_PLATFORM_VERSION With the approach in my patch that variable is never set by the generator.

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-24 Thread Brad King
On 09/23/2015 06:48 PM, Gilles Khouzam wrote: > This adds only the WINDOWS_TARGET_PLATFORM_VERSION property as it > currently only supports the desktop scenario and is extracted > from the rest of the Windows 10 Store support. Thanks. While reviewing this much simpler patch I realized that the

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-23 Thread Brad King
On 09/23/2015 01:29 AM, Gilles Khouzam wrote: > Now, for the default behavior, if > CMAKE_WINDOWS_TARGET_PLATFORM_VERSION is set through a toolchain > file or the project, then that will be the default which will > initialize the WINDOWS_TARGET_PLATFORM_VERSION for each target > through the

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-23 Thread Gilles Khouzam
as for Store apps. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Wednesday, September 23, 2015 05:38 To: Gilles Khouzam <gilles.khou...@microsoft.com> Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [Patch] Adding Windows 10 support On 09/23/20

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-23 Thread Gilles Khouzam
] Sent: Wednesday, September 23, 2015 07:17 To: Gilles Khouzam <gilles.khou...@microsoft.com> Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [Patch] Adding Windows 10 support On 09/23/2015 10:03 AM, Gilles Khouzam wrote: > If the property is not present then the default

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-22 Thread Gilles Khouzam
for example? -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Monday, September 21, 2015 08:09 To: Gilles Khouzam <gilles.khou...@microsoft.com> Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [Patch] Adding Windows 10 support On 09/10/2015 09

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-10 Thread Brad King
On 09/09/2015 05:48 PM, Gilles Khouzam wrote: > Even though GetVersionEx is deprecated, > it is the right way to get the system version, loading ntdll and > getting RtlGetVersion is not a good practice as those are private > APIs that could change. The change was contributed recently: Windows:

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-10 Thread Gilles Khouzam
ier. #2 and #3 could be a different patch that Windows 10 support depends on. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Thursday, September 10, 2015 06:39 To: Gilles Khouzam <gilles.khou...@microsoft.com> Cc: cmake-developers@cmake.org Subject: Re: [cmake-develop

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-10 Thread Brad King
On 09/10/2015 02:37 PM, Gilles Khouzam wrote: > I don't know that deprecating the API and making it require a > manifest was a better solution, but it does require more > intentional work on the developer before just using the API. The API should not be deprecated if there is any use case for

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-10 Thread Gilles Khouzam
bject: Re: [cmake-developers] [Patch] Adding Windows 10 support On 09/10/2015 03:04 PM, Brad King wrote: > On 09/10/2015 02:37 PM, Gilles Khouzam wrote: >> I can split it up in multiple patches if that makes it easier. > > Yes, please. That makes review and future reading of history

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-10 Thread Brad King
On 09/10/2015 03:04 PM, Brad King wrote: > On 09/10/2015 02:37 PM, Gilles Khouzam wrote: >> I can split it up in multiple patches if that makes it easier. > > Yes, please. That makes review and future reading of history easier > because we see a commit message associated with each corresponding

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-09 Thread Brad King
On 09/03/2015 03:19 PM, Gilles Khouzam wrote: > Perhaps the default selection (at least for Store apps since that's > the one that requires the flag) should be the newest SDK less than > the version of the host System. Yes, I think that makes sense. Thanks, -Brad -- Powered by www.kitware.com

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-09 Thread Gilles Khouzam
: Brad King [mailto:brad.k...@kitware.com] Sent: Wednesday, September 9, 2015 08:00 To: Gilles Khouzam <gilles.khou...@microsoft.com> Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [Patch] Adding Windows 10 support On 09/03/2015 03:19 PM, Gilles Khouzam wrote: > Perhaps th

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-03 Thread Gilles Khouzam
elopers@cmake.org Subject: Re: [cmake-developers] [Patch] Adding Windows 10 support On 09/01/2015 05:19 PM, Gilles Khouzam wrote: > For VS_DEFAULT_TARGET_PLATFORM_VERSION, what I'm trying to achieve is > almost an internal property that is used for the try_compile phase. > Since the gen

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-02 Thread Brad King
On 09/01/2015 05:19 PM, Gilles Khouzam wrote: > For VS_DEFAULT_TARGET_PLATFORM_VERSION, what I'm trying to > achieve is almost an internal property that is used for the > try_compile phase. Since the generator is not used in that > scenario, the project is using the template from >

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-09-01 Thread Gilles Khouzam
to handle this case. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Monday, August 31, 2015 13:06 To: Gilles Khouzam <gilles.khou...@microsoft.com> Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] [Patch] Adding Windows 10 support On 08/30/2015

Re: [cmake-developers] [Patch] Adding Windows 10 support

2015-08-31 Thread Brad King
On 08/30/2015 06:41 PM, Gilles Khouzam wrote: > http://www.cmake.org/Bug/view.php?id=15670 > Add support for setting "Windows target platform version" in VS2015 Most of your changes look good but I think this issue needs more discussion. There is already some discussion in the issue tracker