Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 27.10.2013 15:48, David Cole wrote: It's the tests in all the other projects in the world, that have not taken advantage of parallel testing yet that you will have to be concerned about. (For a notable example, the CDash project cannot use parallel testing. It's tests are highly dependent on

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

I just realized that CTest only prioritized failed tests in parallel test runs since it only modified COSTs in that case. So Casey was quite right noticing that there is a behavior change here. I created a topic "restore-serial-failed-test-order" which limits that behavior to parallel test

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

I just realized that CTest only prioritized failed tests in parallel test runs since it only modified COSTs in that case. So Casey was quite right noticing that there is a behavior change here. I created a topic "restore-serial-failed-test-order" which limits that behavior to parallel test run

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 10/24/2013 10:06 AM, Nils Gladitz wrote: > I think I can probably fix that by replacing the insert with a manual loop. > SSH access is being blocked here so I probably wont get to fix it before > I get home but looks like the client only builds nightly anyway :) Please also address the VS 6 bu

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

Thanks Bill, I think I can probably fix that by replacing the insert with a manual loop. SSH access is being blocked here so I probably wont get to fix it before I get home but looks like the client only builds nightly anyway :) Nils On 10/24/2013 03:40 PM, Bill Hoffman wrote: On 10/24/2013

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 10/24/2013 8:58 AM, Nils Gladitz wrote: Had some trouble with my new test and multi configuration generators at first but the incomming dashboard results look like I got that fixed now :) Thanks again! Looks like there was a build failure here: http://open.cdash.org/viewBuildError.php?buildi

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 10/23/2013 08:19 PM, Bill Hoffman wrote: Looks good to me. Feel free to merge into next. -Bill Had some trouble with my new test and multi configuration generators at first but the incomming dashboard results look like I got that fixed now :) Thanks again! Nils -- Powered by www.kitware

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 10/23/2013 2:01 PM, Casey Goodlett wrote: Thanks for the explanation. In that case, the change looks good to me. Looks good to me. Feel free to merge into next. -Bill -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

Thanks for the explanation. In that case, the change looks good to me. On Wed, Oct 23, 2013 at 1:43 PM, Nils Gladitz wrote: > On 23.10.2013 19:28, Casey Goodlett wrote: > >> >> Bill and Nils >> >> Does this change the logic to run previously failed tests first or was >> that already the case?

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 23.10.2013 19:28, Casey Goodlett wrote: Bill and Nils Does this change the logic to run previously failed tests first or was that already the case? I am not sure whether or not this is a better behavior. Can running failed tests first be considered a separate modification rather than par

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

Bill and Nils, I tried this on my large test suite under linux, and it seems to work. I checked that the serial tests in my suite were still run alone (although in my particular setup that happened to already occur). I also did not notice any violation of the RESOURCE_LOCK constraints which are

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 23.10.2013 15:15, Bill Hoffman wrote: I am traveling right now at our NC Kitware office. There is someone there that has a complicated system he wanted to try your changes on. He should be able to get to that today. He also did some work on this issue in the past. As soon as we try it wit

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 10/23/2013 3:53 AM, Nils Gladitz wrote: Hello Bill, Would you approve a merge of the topic into next? Who else should I be asking for approval? e.g. is there a CTest specific maintainer? Thanks in advance. I am traveling right now at our NC Kitware office. There is someone there that has a

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

Hello Bill, Would you approve a merge of the topic into next? Who else should I be asking for approval? e.g. is there a CTest specific maintainer? Thanks in advance. Nils -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.ht

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 10/21/2013 2:39 PM, Nils Gladitz wrote: I haven't see that fail on my local test runs. Is it sporadic or does it fail for you consistently? Never mind on this one. Looks like it fails for me without your changes. -Bill -- Powered by www.kitware.com Visit other Kitware open-source project

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 21.10.2013 19:04, Bill Hoffman wrote: It would also be good to merge your test case http://pastebin.com/3zXsTrem into its own test or one of these: I created a new test case " CTestTestSerialInDepends" which now detects the issue but because of the sporadic nature of the issue may falsly r

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

Hello Bill, thanks for checking up on the changes! On 21.10.2013 19:04, Bill Hoffman wrote: Can you add a few comments into the code that describe what you are doing so it will be easier to follow? Maybe a block comment that describes the high level approach? I've added comments to the

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 10/18/2013 6:50 PM, Nils Gladitz wrote: Hello Bill, I've updated the topic with (I think) improved sorting. Tests are now prioritized by depth within the dependency graph and within each depth level they are further ordered by cost. This gives better total test time for my test case and prese

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

Hello Bill, I've updated the topic with (I think) improved sorting. Tests are now prioritized by depth within the dependency graph and within each depth level they are further ordered by cost. This gives better total test time for my test case and preserves correctness in relation to RUN_SERIAL

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

StartTest() returns false without running the test if there are any dependencies remaining. Nils On 17.10.2013 23:57, Bill Hoffman wrote: On Thu, Oct 17, 2013 at 5:31 PM, Nils Gladitz > wrote: Hello Bill, thanks for looking into this! All four tests in m

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On Thu, Oct 17, 2013 at 5:31 PM, Nils Gladitz wrote: > Hello Bill, thanks for looking into this! > > All four tests in my example are still run (as you can see in the test > output I provided). > This includes the dependent test. > > What I did change is that all tests (from an dependency or othe

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

Hello Bill, thanks for looking into this! All four tests in my example are still run (as you can see in the test output I provided). This includes the dependent test. What I did change is that all tests (from an dependency or otherwise) are run from StartNextTests() which ensures that serial

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

On 10/17/2013 4:41 PM, Nils Gladitz wrote: I pushed my topic "ctest-fix-run-serial" to stage. I am taking a look. It has been a long time since I looked at this code. However, it seems like your patch removes the running of dependent tests. old code did this: StartTest(int test) ... for

[cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

Hello, I'm trying to fix: http://public.kitware.com/Bug/view.php?id=14484 which I reported earlier. I pushed my topic "ctest-fix-run-serial" to stage. Could some of you take a look at my changes? They seem to fix the issue for me and don't seem to break any of the existing tests but the code i