On 11/18/2013 10:09 AM, Nils Gladitz wrote:
> Can I keep the extracted method in cmGeneratorExpression or would there
> be a more appropriate location for it?
Perhaps a static method in cmGlobalGenerator would be best since
that (+subclasses) is where all the reserved names get defined.
Add it ne
On 11/15/2013 11:39 AM, Brad King wrote:
It looks like you added the reserved check to cmGeneratorExpression
in the IsValidTargetName method. This method is used in other
places to validate generator expression syntax, and in those places
the reserved target names may be allowed.
Can I keep the
On 11/15/2013 11:39 AM, Brad King wrote:
> The policy has not been released yet so I think it would be fine
> to extend it to cover this. Please include documentation and
> test cases.
Thanks for working on this. Here are some comments.
It looks like you added the reserved check to cmGeneratorE
On 11/15/2013 03:19 PM, Rolf Eike Beer wrote:
> Anything ending in "/fast"?
The policy-introduced restrictions already disallow "/" in names.
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages
Am Freitag, 15. November 2013, 10:05:13 schrieb Nils Gladitz:
> I would like to hijack/extend Stephen's changes in
> 05f5fde0eb83c0e49aab3214f28a098861aa3313
> to also disallow target names that have been implicitly reserved by some
> of the generators.
>
> This list might not be complete but I as
On 15.11.2013 17:24, Matthew Woehlke wrote:
I haven't done so yet, but I've considered once or twice creating a
'clean' target in case the generator is ninja. Possibly someone has
already done that. Maybe only disallow target names that the generator
actually uses? (Or should we teach CMake to
On 11/15/2013 04:05 AM, Nils Gladitz wrote:
> This list might not be complete but I assume it would be at least:
> all, help, clean, edit_cache, rebuild_cache, test, package,
> package_source, PACKAGE, ZERO_CHECK
>
> Would anyone be opposed to this?
> Could I extend the existing policy, shou
On 2013-11-15 04:05, Nils Gladitz wrote:
I would like to hijack/extend Stephen's changes in
05f5fde0eb83c0e49aab3214f28a098861aa3313
to also disallow target names that have been implicitly reserved by some
of the generators.
This list might not be complete but I assume it would be at least:
I would like to hijack/extend Stephen's changes in
05f5fde0eb83c0e49aab3214f28a098861aa3313
to also disallow target names that have been implicitly reserved by some
of the generators.
This list might not be complete but I assume it would be at least:
all, help, clean, edit_cache, rebuild_ca
