Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-13 Thread Stephen Kelly
On 06/13/2016 04:22 PM, Brad King wrote: > On 06/11/2016 08:14 AM, Stephen Kelly wrote: >> Thanks for your thorough review! I think I've fixed the errors I >> introduced while rebasing now. >> >> I'm not completely certain that the gymnastics I do with the >> cmListFileBacktrace in the parser in

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-11 Thread Stephen Kelly
On 06/10/2016 10:07 PM, Daniel Pfeifer wrote: > On Fri, Jun 10, 2016 at 8:17 PM, Stephen Kelly wrote: >> However, that's not a problem when messages are delivered through the >> daemon, so I suggest that >> >> https://github.com/steveire/cmake/tree/extract-cmMessenger >> >>

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-10 Thread Daniel Pfeifer
On Fri, Jun 10, 2016 at 8:17 PM, Stephen Kelly wrote: > Tobias Hunger wrote: >> Forcing messages into one consistent format will be a pain, agreed, but >> continuing to add messages in whatever form the developer likes at the >> time of writing the code is even worse. CMake

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-10 Thread Stephen Kelly
Tobias Hunger wrote: > Forcing messages into one consistent format will be a pain, agreed, but > continuing to add messages in whatever form the developer likes at the > time of writing the code is even worse. CMake has a lot of different error > message styles! This is something my branch

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Daniel Pfeifer
On Thu, Jun 9, 2016 at 2:17 PM, Brad King wrote: > On 06/09/2016 05:06 AM, Tobias Hunger wrote: >> CMake Error at src/1/app/CMakeLists.txt:70 (add_custom_target): >> Cannot find source file: >> >> unknownFile.qml >> >> Tried extensions .c .C .c++ .cc .cpp .cxx .m .M

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Brad King
On 06/09/2016 05:06 AM, Tobias Hunger wrote: > CMake Error at src/1/app/CMakeLists.txt:70 (add_custom_target): > Cannot find source file: > > unknownFile.qml > > Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp > > > CMake Error at src/1/CMakeLists.txt:8

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Tobias Hunger
On Do, 2016-06-09 at 10:18 +0200, Stephen Kelly wrote: > > What I would like to have, is separate subclasses for gcc-style and > > msvc-style messages. In gcc-style, messages look like this: > > > > :row:column: error: > > > > In msvc-style, messages look like this: > > > > (row,column):

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Stephen Kelly
On 06/09/2016 09:49 AM, Daniel Pfeifer wrote: > On Thu, Jan 28, 2016 at 10:42 PM, Stephen Kelly wrote: >> Hi, >> >> I have pushed a extract-cmMessenger branch to my clone: >> >> https://github.com/steveire/CMake/commits/extract-cmMessenger > I have rebased it to master and

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-09 Thread Daniel Pfeifer
On Thu, Jan 28, 2016 at 10:42 PM, Stephen Kelly wrote: > > Hi, > > I have pushed a extract-cmMessenger branch to my clone: > > https://github.com/steveire/CMake/commits/extract-cmMessenger I have rebased it to master and cherry-picked some minor changes. Once those minor

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-02-06 Thread Stephen Kelly
Michael Scott wrote: >> Yes. Did you have a close look at the commits? I'm not really sure they >> are correct, and I wonder if you have any thoughts on the first one which >> discusses interface? > I went back and had a closer look at the major changes. I think on the > whole the cmMessenger

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-02-02 Thread Michael Scott
Yes. Did you have a close look at the commits? I'm not really sure they are correct, and I wonder if you have any thoughts on the first one which discusses interface? I went back and had a closer look at the major changes. I think on the whole the cmMessenger class is good and a clear

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-01-30 Thread Stephen Kelly
Michael Scott wrote: >> * Make it possible to make add first-class handling of messages about >> missing packages (for example) to cmake-gui by making methods on >> cmMessenger virtual and subclassing > > This sounds like a good idea and makes a lot of sense. > > While working on the message

[cmake-developers] Review request: extract-cmMessenger branch

2016-01-28 Thread Stephen Kelly
Hi, I have pushed a extract-cmMessenger branch to my clone: https://github.com/steveire/CMake/commits/extract-cmMessenger The motivations are: * Decrease responsibilities of the cmake class. CMake uses too few classes for too many things * Make it possible to make add first-class handling of