Hello,
Now that SelectLibraryConfigurations is good enough for me, I updated
FindGTK2.cmake to use it. I pushed my changes in a FindGTK2Debug topic,
does anyone want to review them before I merge the changes to next?
Thanks,
Cheers,
Daniele
--
Powered by www.kitware.com
Visit other Kitware
On 07/25/2013 01:18 PM, Daniele E. Domenichelli wrote:
Now that SelectLibraryConfigurations is good enough for me, I updated
FindGTK2.cmake to use it. I pushed my changes in a FindGTK2Debug topic,
does anyone want to review them before I merge the changes to next?
I just glanced through and
On 07/19/2013 06:32 AM, Daniele E. Domenichelli wrote:
On 18/07/13 21:54, Brad King wrote:
Please update your topic to fix this and make sure tests pass
locally before publishing.
Done! Sorry about that!
Great, thanks.
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source
On 07/10/2013 08:53 AM, Brad King wrote:
Also please update the commit messages to include the explanations
from your email. Go ahead and push to Git by following the
directions at http://www.cmake.org/Wiki/CMake/Git/Develop
Thanks. Daniele, please also proceed with the merge to 'next':
On 18/07/13 16:32, Brad King wrote:
On 07/10/2013 08:53 AM, Brad King wrote:
Also please update the commit messages to include the explanations
from your email. Go ahead and push to Git by following the
directions at http://www.cmake.org/Wiki/CMake/Git/Develop
Thanks. Daniele, please also
On 7/18/2013 11:56 AM, Daniele E. Domenichelli wrote:
On 18/07/13 16:32, Brad King wrote:
Done, thanks. I'm sorry, I thought I had to wait for some review before
merging it.
Thanks. I added a sentence to the Git/Develop wiki instructions to
indicate that one should either merge or request a
On 7/18/2013 11:56 AM, Daniele E. Domenichelli wrote:
On 18/07/13 16:32, Brad King wrote:
Thanks. Daniele, please also proceed with the merge to 'next':
Done, thanks
The continuous build section of the dashboard reveals a test
failure caused by this change:
Hello,
On 03/07/13 20:21, Brad King wrote:
The open request's discussion identified some concerns about the
SelectLibraryConfigurations module, so please start another thread
to raise the concerns here (or respond to this message and change the
subject line).
I was discussing with Brad
Rolf Eike Beer wrote:
Brad King wrote:
On 10/19/2012 01:54 PM, Rolf Eike Beer wrote:
Doh! Good catch, thanks. Will push it soonish.
I think our emails crossed. I just pushed it.
Ok, feel free to ignore my branch then. I'll create a new topic to test this
module soonish, would be
Hi,
I have just found a regression in latest rc with
SelectLibraryConfigurations module.
Expected output (cmake 2.6.9) from the attached test case is:
-- mylib_LIBRARY_RELEASE mylib
-- mylib_LIBRARY_DEBUG mylibD
-- mylib_LIBRARIES optimized;mylib;debug;mylibD
while cmake 2.6.10-rc2 output is:
On 10/19/2012 12:17 PM, Thomas Arcila wrote:
I have just found a regression in latest rc with SelectLibraryConfigurations
module.
You will find attached a patch fixing the issue.
Applied:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1cd2ec10
Thanks!
-Brad
--
Powered by
Thomas Arcila wrote:
Hi,
I have just found a regression in latest rc with
SelectLibraryConfigurations module.
Expected output (cmake 2.6.9) from the attached test case is:
-- mylib_LIBRARY_RELEASE mylib
-- mylib_LIBRARY_DEBUG mylibD
-- mylib_LIBRARIES optimized;mylib;debug;mylibD
Hi,
I just did a git grep optimized Modules/Find* to search for any modules that
add the optimized and debug keywords by hand. We have a module for that:
SelectLibraryConfigurations.cmake. This has the advantage of e.g. taking care
for the case that only one of the debug and release library
13 matches
Mail list logo
