Re: [cmake-developers] SelectLibraryConfigurations cached/advanced variables

2013-07-25 Thread Daniele E. Domenichelli
Hello, Now that SelectLibraryConfigurations is good enough for me, I updated FindGTK2.cmake to use it. I pushed my changes in a FindGTK2Debug topic, does anyone want to review them before I merge the changes to next? Thanks, Cheers, Daniele -- Powered by www.kitware.com Visit other Kitware

Re: [cmake-developers] SelectLibraryConfigurations cached/advanced variables

2013-07-25 Thread Brad King
On 07/25/2013 01:18 PM, Daniele E. Domenichelli wrote: Now that SelectLibraryConfigurations is good enough for me, I updated FindGTK2.cmake to use it. I pushed my changes in a FindGTK2Debug topic, does anyone want to review them before I merge the changes to next? I just glanced through and

Re: [cmake-developers] SelectLibraryConfigurations cached/advanced variables

2013-07-19 Thread Brad King
On 07/19/2013 06:32 AM, Daniele E. Domenichelli wrote: On 18/07/13 21:54, Brad King wrote: Please update your topic to fix this and make sure tests pass locally before publishing. Done! Sorry about that! Great, thanks. -Brad -- Powered by www.kitware.com Visit other Kitware open-source

Re: [cmake-developers] SelectLibraryConfigurations cached/advanced variables

2013-07-18 Thread Brad King
On 07/10/2013 08:53 AM, Brad King wrote: Also please update the commit messages to include the explanations from your email. Go ahead and push to Git by following the directions at http://www.cmake.org/Wiki/CMake/Git/Develop Thanks. Daniele, please also proceed with the merge to 'next':

Re: [cmake-developers] SelectLibraryConfigurations cached/advanced variables

2013-07-18 Thread Daniele E. Domenichelli
On 18/07/13 16:32, Brad King wrote: On 07/10/2013 08:53 AM, Brad King wrote: Also please update the commit messages to include the explanations from your email. Go ahead and push to Git by following the directions at http://www.cmake.org/Wiki/CMake/Git/Develop Thanks. Daniele, please also

Re: [cmake-developers] SelectLibraryConfigurations cached/advanced variables

2013-07-18 Thread Brad King
On 7/18/2013 11:56 AM, Daniele E. Domenichelli wrote: On 18/07/13 16:32, Brad King wrote: Done, thanks. I'm sorry, I thought I had to wait for some review before merging it. Thanks. I added a sentence to the Git/Develop wiki instructions to indicate that one should either merge or request a

Re: [cmake-developers] SelectLibraryConfigurations cached/advanced variables

2013-07-18 Thread Brad King
On 7/18/2013 11:56 AM, Daniele E. Domenichelli wrote: On 18/07/13 16:32, Brad King wrote: Thanks. Daniele, please also proceed with the merge to 'next': Done, thanks The continuous build section of the dashboard reveals a test failure caused by this change:

[cmake-developers] SelectLibraryConfigurations cached/advanced variables

2013-07-09 Thread Daniele E. Domenichelli
Hello, On 03/07/13 20:21, Brad King wrote: The open request's discussion identified some concerns about the SelectLibraryConfigurations module, so please start another thread to raise the concerns here (or respond to this message and change the subject line). I was discussing with Brad