Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-19 Thread Brandon Hume
On 10/13/12 04:27 AM, Sebastian Harl wrote: Ack. I'm not sure, though, if it's a good idea to implement that before most/many/all parts of collectd actually support "reconfigure" as people might expect too much from SIGHUP else Just to toss this out there... as I mentioned on a different threa

Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-13 Thread Sebastian Harl
Hi, On Sat, Oct 13, 2012 at 10:51:34AM +0200, Fabien Wernli wrote: > On Sat, Oct 13, 2012 at 09:27:25AM +0200, Sebastian Harl wrote: > > most/many/all parts of collectd actually support "reconfigure" as people > > might expect too much from SIGHUP else. > > agreed > > Just to be sure: the main c

Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-13 Thread Fabien Wernli
On Sat, Oct 13, 2012 at 09:27:25AM +0200, Sebastian Harl wrote: > most/many/all parts of collectd actually support "reconfigure" as people > might expect too much from SIGHUP else. agreed Just to be sure: the main collectd thread has no control over its child threads in the current implementation

Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-13 Thread Sebastian Harl
Hi, On Fri, Oct 12, 2012 at 04:26:28PM +0200, Fabien Wernli wrote: > On Fri, Oct 12, 2012 at 02:46:00PM +0200, Yves Mettier wrote: > > For the step 2/ I suggest a new command of collectdctl. That command > > would allow to specify the plugin to reconfigure, or something like > > "all" to reconfigu

Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-12 Thread Fabien Wernli
Hi, On Fri, Oct 12, 2012 at 02:46:00PM +0200, Yves Mettier wrote: > For the step 2/ I suggest a new command of collectdctl. That command > would allow to specify the plugin to reconfigure, or something like > "all" to reconfigure all the plugins. Does that sound correct ? Adding support for signa

Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-12 Thread Yves Mettier
Hello, I also think this is a great idea. And basic_aggregator is probably a good candidate to experiment this new feature because there should be not so many changes to do (mainly replace the stat(filename) with... nothing) Now, here is the need : 1/ I update the configuration file 2/ ??? 3/

Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-12 Thread Fabien Wernli
Hi, Adding a configuration reload is an excellent idea, and is one of the big missing features of collectd IMHO. I quite agree with Lindsay's remarks: there should simply be a warning for the plugins that don't support reconfiguration. On the other hand, maybe there should be the option to restart

Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-12 Thread Lindsay Holmwood
On 11 October 2012 18:11, Sebastian Harl wrote: > > Now, my idea is to introduce a "reconfigure" callback that allows to > reconfigure a single plugin. This could then be exposed, for example, > through the 'unixsock' plugin. > > Example: > > /* plugin.h */ > int plugin_register_reconfig (cons

Re: [collectd] New aggregator plugin "basic_aggregator" (#136)

2012-10-11 Thread Sebastian Harl
Hi, On Wed, Oct 10, 2012 at 11:28:05PM -0700, ymettier wrote: > After some use of the aggregator, I noticed that when you change > something in the configuration of the aggregator (add,remove a > hostname, type...), you have to restart all collectd to take the > change into account. > > This new