[GitHub] [airflow] codecov-io edited a comment on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-12 Thread GitBox
codecov-io edited a comment on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#issuecomment-510755850 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5569?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-12 Thread GitBox
codecov-io edited a comment on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#issuecomment-510755850 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5569?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-12 Thread GitBox
codecov-io edited a comment on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#issuecomment-510755850 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5569?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-12 Thread GitBox
codecov-io edited a comment on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#issuecomment-510755850 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5569?src=pr=h1) Report > Merging

[GitHub] [airflow] ryanyuan commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
ryanyuan commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#issuecomment-511078908 > Hello. I see you add a lot of operators and GCP integration. > I have two question: > > 1. Do you have other GCP

[GitHub] [airflow] milton0825 commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
milton0825 commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#discussion_r303177274 ## File path: tests/operators/test_bash_operator.py ## @@ -33,6 +34,15 @@ class

[GitHub] [airflow] feng-tao merged pull request #5575: [AIRFLOW-XXX] Add Instacart to list of companies who use Airflow

2019-07-12 Thread GitBox
feng-tao merged pull request #5575: [AIRFLOW-XXX] Add Instacart to list of companies who use Airflow URL: https://github.com/apache/airflow/pull/5575 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] lubert opened a new pull request #5575: [AIRFLOW-XXX] Add Instacart to list of companies who use Airflow

2019-07-12 Thread GitBox
lubert opened a new pull request #5575: [AIRFLOW-XXX] Add Instacart to list of companies who use Airflow URL: https://github.com/apache/airflow/pull/5575 Adds Instacart to readme.md only This is an automated message from the

[jira] [Commented] (AIRFLOW-4941) default_args not applied when dag is assigned to task through setter

2019-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884225#comment-16884225 ] ASF GitHub Bot commented on AIRFLOW-4941: - milton0825 commented on pull request #5574:

[GitHub] [airflow] milton0825 opened a new pull request #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-12 Thread GitBox
milton0825 opened a new pull request #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Updated] (AIRFLOW-4941) default_args not applied when dag is assigned to task through setter

2019-07-12 Thread Chao-Han Tsai (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao-Han Tsai updated AIRFLOW-4941: --- Description: When the DAG is set to the task via

[jira] [Updated] (AIRFLOW-4941) default_args not applied when dag is assigned to task through setter

2019-07-12 Thread Chao-Han Tsai (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao-Han Tsai updated AIRFLOW-4941: --- Summary: default_args not applied when dag is assigned to task through setter (was: Apply

[jira] [Created] (AIRFLOW-4941) Apply default_args when dag is assigned to task through setter

2019-07-12 Thread Chao-Han Tsai (JIRA)
Chao-Han Tsai created AIRFLOW-4941: -- Summary: Apply default_args when dag is assigned to task through setter Key: AIRFLOW-4941 URL: https://issues.apache.org/jira/browse/AIRFLOW-4941 Project: Apache

[jira] [Commented] (AIRFLOW-4922) If a task crashes, host name is not committed to the database so logs aren't able to be seen in the UI

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884157#comment-16884157 ] Ash Berlin-Taylor commented on AIRFLOW-4922: This is an odd one, and on looking at the code

[GitHub] [airflow] milton0825 commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill

2019-07-12 Thread GitBox
milton0825 commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5498#issuecomment-511025184 People were advised not to use `SubDagOperator` because of the performance issues and the bugs. I hope this PR and

[jira] [Created] (AIRFLOW-4940) DynamoDB to S3 backup operator

2019-07-12 Thread Chao-Han Tsai (JIRA)
Chao-Han Tsai created AIRFLOW-4940: -- Summary: DynamoDB to S3 backup operator Key: AIRFLOW-4940 URL: https://issues.apache.org/jira/browse/AIRFLOW-4940 Project: Apache Airflow Issue Type:

[GitHub] [airflow] mik-laj commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#issuecomment-511021254 Hello. I see you add a lot of operators and GCP integration. I have two question: 1. Do you have other GCP operators in

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303131232 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303128380 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303131010 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303131994 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303130893 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303132163 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303131393 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303127684 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303126900 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303126900 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303126352 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303125436 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303124551 ## File path: airflow/contrib/hooks/gcp_dlp_hook.py ## @@ -0,0 +1,1362 @@ +# -*- coding: utf-8

[GitHub] [airflow] mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on a change in pull request #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#discussion_r303120668 ## File path: airflow/contrib/example_dags/example_gcp_dlp_operator.py ## @@ -0,0 +1,80 @@ +#

[GitHub] [airflow] knowsuchagency commented on a change in pull request #5543: Fix permission error when creating logs

2019-07-12 Thread GitBox
knowsuchagency commented on a change in pull request #5543: Fix permission error when creating logs URL: https://github.com/apache/airflow/pull/5543#discussion_r303120609 ## File path: airflow/utils/log/file_processor_handler.py ## @@ -84,7 +84,7 @@ def close(self):

[GitHub] [airflow] mik-laj edited a comment on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj edited a comment on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#issuecomment-511004086 I got a message. New operators should use google-cloud-python, if possible, so i do a review this PR.

[GitHub] [airflow] mik-laj commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators

2019-07-12 Thread GitBox
mik-laj commented on issue #5539: [AIRFLOW-4811] Implement GCP DLP' Hook and Operators URL: https://github.com/apache/airflow/pull/5539#issuecomment-511004086 I got a message. New operators should use google-cloud-python, if possible

[GitHub] [airflow] mik-laj commented on issue #5531: [AIRFLOW-4894]Add hook and operator for GCP DLP

2019-07-12 Thread GitBox
mik-laj commented on issue #5531: [AIRFLOW-4894]Add hook and operator for GCP DLP URL: https://github.com/apache/airflow/pull/5531#issuecomment-511003367 I contacted the Composer team. The best option is to use google-cloud-python. Discovery API is deprecated. All operators should use a

[jira] [Commented] (AIRFLOW-4894) Add hook and operator for GCP Data Loss Prevention API

2019-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884107#comment-16884107 ] ASF GitHub Bot commented on AIRFLOW-4894: - mik-laj commented on pull request #5531:

[GitHub] [airflow] mik-laj closed pull request #5531: [AIRFLOW-4894]Add hook and operator for GCP DLP

2019-07-12 Thread GitBox
mik-laj closed pull request #5531: [AIRFLOW-4894]Add hook and operator for GCP DLP URL: https://github.com/apache/airflow/pull/5531 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] Fokko commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill

2019-07-12 Thread GitBox
Fokko commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5498#issuecomment-510989789 I'm not using subdags either. It had some performance issues in the past, and therefore I always avoided it. Most of

[GitHub] [airflow] Fokko commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test

2019-07-12 Thread GitBox
Fokko commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test URL: https://github.com/apache/airflow/pull/5057#issuecomment-510979674 @ashb I see your point, but I think it is dangerous to share sessions between the tests since there might be lingering

[GitHub] [airflow] Fokko commented on a change in pull request #5057: [AIRFLOW-4257] Remove the global session from the core test

2019-07-12 Thread GitBox
Fokko commented on a change in pull request #5057: [AIRFLOW-4257] Remove the global session from the core test URL: https://github.com/apache/airflow/pull/5057#discussion_r303090398 ## File path: tests/core.py ## @@ -116,13 +117,9 @@ def setUp(self): def

[jira] [Commented] (AIRFLOW-4924) Loading DAGs asynchronously in Airflow webserver

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884038#comment-16884038 ] Ash Berlin-Taylor commented on AIRFLOW-4924: My initial thought is that while this does add

[jira] [Commented] (AIRFLOW-4937) Github reported security problem in lodash below 4.17.13

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884034#comment-16884034 ] ASF subversion and git services commented on AIRFLOW-4937: -- Commit

[jira] [Commented] (AIRFLOW-4868) Unable to make example work > Airflow on Kubernetes (Part 1): A Different Kind of Operator

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884029#comment-16884029 ] ASF subversion and git services commented on AIRFLOW-4868: -- Commit

[jira] [Commented] (AIRFLOW-4925) Improve css style for Variables Input File Field in RBAC UI

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884028#comment-16884028 ] ASF subversion and git services commented on AIRFLOW-4925: -- Commit

[jira] [Commented] (AIRFLOW-4934) ProxyFix not working as expected since Werkzeug v0.15

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884033#comment-16884033 ] ASF subversion and git services commented on AIRFLOW-4934: -- Commit

[jira] [Commented] (AIRFLOW-4934) ProxyFix not working as expected since Werkzeug v0.15

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884032#comment-16884032 ] ASF subversion and git services commented on AIRFLOW-4934: -- Commit

[jira] [Commented] (AIRFLOW-4937) Github reported security problem in lodash below 4.17.13

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884025#comment-16884025 ] ASF subversion and git services commented on AIRFLOW-4937: -- Commit

[jira] [Commented] (AIRFLOW-4934) ProxyFix not working as expected since Werkzeug v0.15

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884024#comment-16884024 ] ASF subversion and git services commented on AIRFLOW-4934: -- Commit

[jira] [Commented] (AIRFLOW-4906) Improve debugging for the SparkSubmitHook

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884027#comment-16884027 ] ASF subversion and git services commented on AIRFLOW-4906: -- Commit

[jira] [Commented] (AIRFLOW-3495) DataProcSparkSqlOperator and DataProcHiveOperator should raise error when query and query_uri are both provided

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884030#comment-16884030 ] ASF subversion and git services commented on AIRFLOW-3495: -- Commit

[jira] [Commented] (AIRFLOW-4904) Retrieve test config from $AIRFLOW_TEST_CONFIG

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884026#comment-16884026 ] ASF subversion and git services commented on AIRFLOW-4904: -- Commit

[jira] [Commented] (AIRFLOW-4136) Fix overwrite of key_file by constructor in SSHHook

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884031#comment-16884031 ] ASF subversion and git services commented on AIRFLOW-4136: -- Commit

[jira] [Commented] (AIRFLOW-4136) Fix overwrite of key_file by constructor in SSHHook

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884022#comment-16884022 ] ASF subversion and git services commented on AIRFLOW-4136: -- Commit

[jira] [Commented] (AIRFLOW-4934) ProxyFix not working as expected since Werkzeug v0.15

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884023#comment-16884023 ] ASF subversion and git services commented on AIRFLOW-4934: -- Commit

[GitHub] [airflow] PureW commented on issue #5556: [AIRFLOW-4901] Relaxes jinja2 version requirement

2019-07-12 Thread GitBox
PureW commented on issue #5556: [AIRFLOW-4901] Relaxes jinja2 version requirement URL: https://github.com/apache/airflow/pull/5556#issuecomment-510973019 @pgagnon We're running airflow inside a secure environment so I wont dig deeper into this. I'll use this fork and my (insecure) jinja

[GitHub] [airflow] PureW edited a comment on issue #5556: [AIRFLOW-4901] Relaxes jinja2 version requirement

2019-07-12 Thread GitBox
PureW edited a comment on issue #5556: [AIRFLOW-4901] Relaxes jinja2 version requirement URL: https://github.com/apache/airflow/pull/5556#issuecomment-510973019 @pgagnon We're running airflow inside a secure environment so I wont dig deeper into this. I'll use this fork and the insecure

[GitHub] [airflow] ashb commented on issue #5525: [AIRFLOW-4890] Fix Log link in TaskInstance's View for Non-RBAC

2019-07-12 Thread GitBox
ashb commented on issue #5525: [AIRFLOW-4890] Fix Log link in TaskInstance's View for Non-RBAC URL: https://github.com/apache/airflow/pull/5525#issuecomment-510958694 If we need a similar change in master please open a PR there - we don't merge anything forward from release branches to

[GitHub] [airflow] ashb commented on issue #5556: [AIRFLOW-4901] Relaxes jinja2 version requirement

2019-07-12 Thread GitBox
ashb commented on issue #5556: [AIRFLOW-4901] Relaxes jinja2 version requirement URL: https://github.com/apache/airflow/pull/5556#issuecomment-510958233 See also https://github.com/pypa/pipenv/issues/2596 - the dependency solver in pipenv isn't without it's problems and that might be what

[GitHub] [airflow] ashb commented on issue #4627: [AIRFLOW-3258] K8S executor environment variables section.

2019-07-12 Thread GitBox
ashb commented on issue #4627: [AIRFLOW-3258] K8S executor environment variables section. URL: https://github.com/apache/airflow/pull/4627#issuecomment-510957687 See https://github.com/apache/airflow/pull/5379 for an attempted fix

[GitHub] [airflow] ashb commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
ashb commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#discussion_r303065879 ## File path: tests/operators/test_bash_operator.py ## @@ -98,3 +105,22 @@ def test_return_value(self):

[GitHub] [airflow] msumit commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
msumit commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#discussion_r303064485 ## File path: tests/operators/test_bash_operator.py ## @@ -98,3 +105,22 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-12 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303056069 ## File path: scripts/ci/ci_mypy.sh ## @@ -0,0 +1,40 @@ +#!/usr/bin/env bash + +# +#

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-12 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303056781 ## File path: scripts/ci/docker-compose-local.yml ## @@ -0,0 +1,42 @@ +# +# Licensed to

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-12 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303061057 ## File path: scripts/ci/local_ci_enter_environment.sh ## @@ -0,0 +1,31 @@

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-12 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r299596889 ## File path: scripts/ci/in_container/grant_impersonation_permissions.sh ## @@ -0,0

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-12 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303054843 ## File path: Dockerfile ## @@ -278,42 +273,81 @@ RUN echo "Pip version:

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-12 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303062103 ## File path: tests/operators/test_latest_only_operator.py ## @@ -19,7 +19,6 @@

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-12 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303061653 ## File path: setup.py ## @@ -290,12 +275,12 @@ def write_version(filename: str =

[GitHub] [airflow] aoen commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
aoen commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#discussion_r303011897 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -196,6 +196,9 @@ worker_precheck =

[jira] [Commented] (AIRFLOW-4929) Pretty display of Json variables in UI

2019-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883954#comment-16883954 ] ASF GitHub Bot commented on AIRFLOW-4929: - eeshugerman commented on pull request #5573:

[jira] [Commented] (AIRFLOW-4597) Add DagStateSensor

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883928#comment-16883928 ] Ash Berlin-Taylor commented on AIRFLOW-4597: Similar but not quite the same - the

[GitHub] [airflow] ashb commented on a change in pull request #5543: Fix permission error when creating logs

2019-07-12 Thread GitBox
ashb commented on a change in pull request #5543: Fix permission error when creating logs URL: https://github.com/apache/airflow/pull/5543#discussion_r303041013 ## File path: airflow/utils/log/file_processor_handler.py ## @@ -84,7 +84,7 @@ def close(self):

[GitHub] [airflow] ashb merged pull request #5568: Add Premise to readme.md

2019-07-12 Thread GitBox
ashb merged pull request #5568: Add Premise to readme.md URL: https://github.com/apache/airflow/pull/5568 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ashb commented on issue #5568: Add Premise to readme.md

2019-07-12 Thread GitBox
ashb commented on issue #5568: Add Premise to readme.md URL: https://github.com/apache/airflow/pull/5568#issuecomment-510934726 Welcome aboard!  This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (AIRFLOW-4926) Fix example dags where its start_date is datetime.utcnow()

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4926. Resolution: Fixed Fix Version/s: 1.10.4 > Fix example dags where its

[jira] [Updated] (AIRFLOW-4900) Incompatible version of Werkzeug after Flask upgrade

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4900: --- Fix Version/s: (was: 2.0.0) 1.10.4 > Incompatible version

[jira] [Updated] (AIRFLOW-4767) Errors in the documentation of Dataproc Operator

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4767: --- Fix Version/s: (was: 2.0.0) > Errors in the documentation of Dataproc Operator

[jira] [Updated] (AIRFLOW-4510) Timezone set incorrectly if multiple DAGs defined in the same file

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4510: --- Fix Version/s: (was: 2.0.0) 1.10.4 > Timezone set

[jira] [Resolved] (AIRFLOW-3495) DataProcSparkSqlOperator and DataProcHiveOperator should raise error when query and query_uri are both provided

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3495. Resolution: Fixed Fix Version/s: 1.10.4 > DataProcSparkSqlOperator and

[jira] [Resolved] (AIRFLOW-4934) ProxyFix not working as expected since Werkzeug v0.15

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4934. Resolution: Done Fix Version/s: 1.10.4 > ProxyFix not working as expected

[jira] [Resolved] (AIRFLOW-4937) Github reported security problem in lodash below 4.17.13

2019-07-12 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4937. Resolution: Fixed Fix Version/s: 1.10.4 > Github reported security

[jira] [Commented] (AIRFLOW-4937) Github reported security problem in lodash below 4.17.13

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883916#comment-16883916 ] ASF subversion and git services commented on AIRFLOW-4937: -- Commit

[jira] [Commented] (AIRFLOW-4937) Github reported security problem in lodash below 4.17.13

2019-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883915#comment-16883915 ] ASF GitHub Bot commented on AIRFLOW-4937: - ashb commented on pull request #5572: [AIRFLOW-4937]

[GitHub] [airflow] ashb merged pull request #5572: [AIRFLOW-4937] Fix lodash security issue with version below 4.17.13

2019-07-12 Thread GitBox
ashb merged pull request #5572: [AIRFLOW-4937] Fix lodash security issue with version below 4.17.13 URL: https://github.com/apache/airflow/pull/5572 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (AIRFLOW-4934) ProxyFix not working as expected since Werkzeug v0.15

2019-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883905#comment-16883905 ] ASF subversion and git services commented on AIRFLOW-4934: -- Commit

[jira] [Commented] (AIRFLOW-4934) ProxyFix not working as expected since Werkzeug v0.15

2019-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883903#comment-16883903 ] ASF GitHub Bot commented on AIRFLOW-4934: - ashb commented on pull request #5571: [AIRFLOW-4934]

[GitHub] [airflow] ashb merged pull request #5571: [AIRFLOW-4934] Bump Flask to resolve Werkzeug ProxyFix

2019-07-12 Thread GitBox
ashb merged pull request #5571: [AIRFLOW-4934] Bump Flask to resolve Werkzeug ProxyFix URL: https://github.com/apache/airflow/pull/5571 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] aoen commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
aoen commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#discussion_r303011897 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -196,6 +196,9 @@ worker_precheck =

[GitHub] [airflow] aoen edited a comment on issue #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
aoen edited a comment on issue #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#issuecomment-510910400 LGTM after nit, tests pass, and default retries changed. For context to others: this is a pretty important change WRT reliability,

[GitHub] [airflow] aoen edited a comment on issue #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
aoen edited a comment on issue #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#issuecomment-510910400 LGTM after nit, tests pass, and default retries changed. For context to others: this is a pretty important change WRT reliability,

[GitHub] [airflow] aoen edited a comment on issue #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
aoen edited a comment on issue #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#issuecomment-510910400 LGTM after nit and default retries changed. For context to others: this is a pretty important change WRT reliability, since Airflow

[GitHub] [airflow] aoen commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
aoen commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#discussion_r303011897 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -196,6 +196,9 @@ worker_precheck =

[GitHub] [airflow] aoen commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
aoen commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#issuecomment-510910400 LGTM after nit. This is an automated message from the Apache Git Service.

[GitHub] [airflow] aoen commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
aoen commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#discussion_r303010379 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -196,6 +196,9 @@ worker_precheck =

[GitHub] [airflow] ashb commented on a change in pull request #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-12 Thread GitBox
ashb commented on a change in pull request #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#discussion_r303003619 ## File path: tests/test_utils/config.py ## @@ -0,0 +1,53 @@ +# -*- coding: utf-8

[GitHub] [airflow] ashb commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-12 Thread GitBox
ashb commented on a change in pull request #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#discussion_r303002450 ## File path: tests/operators/test_bash_operator.py ## @@ -98,3 +105,22 @@ def test_return_value(self):

[GitHub] [airflow] ashb commented on issue #5572: [AIRFLOW-4937] Fix lodash security issue with version below 4.17.13

2019-07-12 Thread GitBox
ashb commented on issue #5572: [AIRFLOW-4937] Fix lodash security issue with version below 4.17.13 URL: https://github.com/apache/airflow/pull/5572#issuecomment-510900857 Most of the securtiy vulns in JS code don't really affect us, we don't use many/most of them directly in our compiled

[GitHub] [airflow] potiuk commented on issue #5572: [AIRFLOW-4937] Fix lodash security issue with version below 4.17.13

2019-07-12 Thread GitBox
potiuk commented on issue #5572: [AIRFLOW-4937] Fix lodash security issue with version below 4.17.13 URL: https://github.com/apache/airflow/pull/5572#issuecomment-510900017 Hey @ashb - I have not tested the UI thoroughly after re-running the NPM to get the updated .lock file - but when we

[jira] [Commented] (AIRFLOW-4937) Github reported security problem in lodash below 4.17.13

2019-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883840#comment-16883840 ] ASF GitHub Bot commented on AIRFLOW-4937: - potiuk commented on pull request #5572:

[GitHub] [airflow] potiuk opened a new pull request #5572: [AIRFLOW-4937] Fix lodash security issue with version below 4.17.13

2019-07-12 Thread GitBox
potiuk opened a new pull request #5572: [AIRFLOW-4937] Fix lodash security issue with version below 4.17.13 URL: https://github.com/apache/airflow/pull/5572 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

  1   2   >