[GitHub] [airflow] boring-cyborg[bot] commented on issue #19834: Xcom: the parameters of key named value is too long

2021-11-25 Thread GitBox
boring-cyborg[bot] commented on issue #19834: URL: https://github.com/apache/airflow/issues/19834#issuecomment-979762775 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] byr18 opened a new issue #19834: Xcom: the parameters of key named value is too long

2021-11-25 Thread GitBox
byr18 opened a new issue #19834: URL: https://github.com/apache/airflow/issues/19834 ### Apache Airflow version 2.0.2 ### Operating System Ubuntu:18.04.1 ### Versions of Apache Airflow Providers apache-airflow-providers-ftp==1.0.0

[GitHub] [airflow] ephraimbuddy closed issue #19811: Helm scheduler HA : postgresql error on slot_pool lock

2021-11-25 Thread GitBox
ephraimbuddy closed issue #19811: URL: https://github.com/apache/airflow/issues/19811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy commented on issue #19811: Helm scheduler HA : postgresql error on slot_pool lock

2021-11-25 Thread GitBox
ephraimbuddy commented on issue #19811: URL: https://github.com/apache/airflow/issues/19811#issuecomment-979762022 This is expected, not an issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] raphaelauv commented on issue #19719: Future upstream tasks should be ignored for default "all_success" trigger rule

2021-11-25 Thread GitBox
raphaelauv commented on issue #19719: URL: https://github.com/apache/airflow/issues/19719#issuecomment-979761347 A task after another does not mean : " You can't run before that task " It mean : " You NEED that task to run before you " Example :

[GitHub] [airflow] ephraimbuddy commented on issue #13671: Task is set "upstream_failed" while upstream tasks are success

2021-11-25 Thread GitBox
ephraimbuddy commented on issue #13671: URL: https://github.com/apache/airflow/issues/13671#issuecomment-979754130 We fixed this in https://github.com/apache/airflow/pull/17819, upgrade to the latest airflow(2.2.2) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] ephraimbuddy commented on pull request #18439: Check and run migration in commands if necessary

2021-11-25 Thread GitBox
ephraimbuddy commented on pull request #18439: URL: https://github.com/apache/airflow/pull/18439#issuecomment-979752863 I'm currently hitting this issue https://github.com/apache/airflow/issues/15340 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] uranusjr commented on a change in pull request #19815: Amazon provider remove deprecation, second try

2021-11-25 Thread GitBox
uranusjr commented on a change in pull request #19815: URL: https://github.com/apache/airflow/pull/19815#discussion_r757275334 ## File path: airflow/providers/postgres/hooks/postgres.py ## @@ -184,7 +184,13 @@ def get_iam_token(self, conn: Connection) -> Tuple[str, str, int]:

[GitHub] [airflow] karry-li-lego closed issue #19833: sql_alchemy_conn_cmd cause failed connect to backend database and fallback to sqlite

2021-11-25 Thread GitBox
karry-li-lego closed issue #19833: URL: https://github.com/apache/airflow/issues/19833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19833: sql_alchemy_conn_cmd cause failed connect to backend database and fallback to sqlite

2021-11-25 Thread GitBox
boring-cyborg[bot] commented on issue #19833: URL: https://github.com/apache/airflow/issues/19833#issuecomment-979734957 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] karry-li-lego opened a new issue #19833: sql_alchemy_conn_cmd cause failed connect to backend database and fallback to sqlite

2021-11-25 Thread GitBox
karry-li-lego opened a new issue #19833: URL: https://github.com/apache/airflow/issues/19833 ### Apache Airflow version 2.2.2 (latest released) ### Operating System macOS 10.15.7 ### Versions of Apache Airflow Providers apache-airflow-providers-amazon

[GitHub] [airflow] yehoshuadimarsky commented on issue #15340: helm install airflow in namespace get error: File "", line 32, in TimeoutError: There are still unapplied migrations aft

2021-11-25 Thread GitBox
yehoshuadimarsky commented on issue #15340: URL: https://github.com/apache/airflow/issues/15340#issuecomment-979723055 > https://github.com/apache/airflow/blob/main/chart/values.yaml#L632 Make sure you put it in the correct parts of the YAML file. I was referring to the

[GitHub] [airflow] yehoshuadimarsky commented on issue #15340: helm install airflow in namespace get error: File "", line 32, in TimeoutError: There are still unapplied migrations aft

2021-11-25 Thread GitBox
yehoshuadimarsky commented on issue #15340: URL: https://github.com/apache/airflow/issues/15340#issuecomment-979722045 > I'm seeing the same issue when deploying using helm to k8s. > > Using versions: > > * chart: 1.3.0 > * app: 2.2.1 > > It seems that these hooks

[GitHub] [airflow] rsg17 commented on pull request #19727: Add test case for views connections muldelete function

2021-11-25 Thread GitBox
rsg17 commented on pull request #19727: URL: https://github.com/apache/airflow/pull/19727#issuecomment-979715065 > Assuming the test passes I think the tests passed with your fix for whitespaces. Thank you for helping me with my first PR! -- This is an automated message from the

[GitHub] [airflow] dstandish commented on a change in pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-25 Thread GitBox
dstandish commented on a change in pull request #18542: URL: https://github.com/apache/airflow/pull/18542#discussion_r757231198 ## File path: chart/templates/webserver/webserver-ingress.yaml ## @@ -39,12 +39,27 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} spec:

[GitHub] [airflow] fredthomsen commented on a change in pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-25 Thread GitBox
fredthomsen commented on a change in pull request #18542: URL: https://github.com/apache/airflow/pull/18542#discussion_r757229481 ## File path: chart/templates/webserver/webserver-ingress.yaml ## @@ -39,12 +39,27 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }}

[GitHub] [airflow] dstandish commented on a change in pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-25 Thread GitBox
dstandish commented on a change in pull request #18542: URL: https://github.com/apache/airflow/pull/18542#discussion_r757228791 ## File path: chart/templates/webserver/webserver-ingress.yaml ## @@ -39,12 +39,27 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} spec:

[GitHub] [airflow] fredthomsen commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-25 Thread GitBox
fredthomsen commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-979683371 > i'm in support of this change (and thanks, and nice work) > > but may have found an issue with backward compatibility that should be addressed (see review

[GitHub] [airflow] fredthomsen commented on a change in pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-25 Thread GitBox
fredthomsen commented on a change in pull request #18542: URL: https://github.com/apache/airflow/pull/18542#discussion_r757217269 ## File path: chart/templates/webserver/webserver-ingress.yaml ## @@ -39,12 +39,27 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }}

[GitHub] [airflow] fredthomsen commented on a change in pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-25 Thread GitBox
fredthomsen commented on a change in pull request #18542: URL: https://github.com/apache/airflow/pull/18542#discussion_r757209843 ## File path: chart/tests/test_ingress_web.py ## @@ -86,7 +112,7 @@ def test_should_ingress_host_still_work(self): assert (

[GitHub] [airflow] ctmikechen commented on issue #13671: Task is set "upstream_failed" while upstream tasks are success

2021-11-25 Thread GitBox
ctmikechen commented on issue #13671: URL: https://github.com/apache/airflow/issues/13671#issuecomment-979647159 I have the same issue on Airflow 2.1.4 any idea ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] smartnewsdingli opened a new issue #19832: Deadlock in worker pod

2021-11-25 Thread GitBox
smartnewsdingli opened a new issue #19832: URL: https://github.com/apache/airflow/issues/19832 ### Apache Airflow version 2.2.2 (latest released) ### Operating System ubuntu ### Versions of Apache Airflow Providers _No response_ ### Deployment

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19832: Deadlock in worker pod

2021-11-25 Thread GitBox
boring-cyborg[bot] commented on issue #19832: URL: https://github.com/apache/airflow/issues/19832#issuecomment-979594271 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on a change in pull request #19819: Rewrite image building tests to Python

2021-11-25 Thread GitBox
mik-laj commented on a change in pull request #19819: URL: https://github.com/apache/airflow/pull/19819#discussion_r757170177 ## File path: docker_tests/test_examples_of_prod_image_building.py ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] mik-laj commented on a change in pull request #19819: Rewrite image building tests to Python

2021-11-25 Thread GitBox
mik-laj commented on a change in pull request #19819: URL: https://github.com/apache/airflow/pull/19819#discussion_r757169435 ## File path: docs/docker-stack/docker-examples/restricted/restricted_environments.sh ## @@ -22,28 +22,29 @@ AIRFLOW_SOURCES="$(cd "$(dirname

[GitHub] [airflow] github-actions[bot] commented on issue #17190: Fetching remote s3 logs fails: An error occurred (AccessDenied) when calling the AssumeRole operation

2021-11-25 Thread GitBox
github-actions[bot] commented on issue #17190: URL: https://github.com/apache/airflow/issues/17190#issuecomment-979525029 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #18896: Set default wasb Azure http logging level to warning; fixes #16224

2021-11-25 Thread GitBox
github-actions[bot] commented on pull request #18896: URL: https://github.com/apache/airflow/pull/18896#issuecomment-979524993 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] closed issue #17190: Fetching remote s3 logs fails: An error occurred (AccessDenied) when calling the AssumeRole operation

2021-11-25 Thread GitBox
github-actions[bot] closed issue #17190: URL: https://github.com/apache/airflow/issues/17190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19758: Api add support bulk pause resume

2021-11-25 Thread GitBox
ephraimbuddy commented on a change in pull request #19758: URL: https://github.com/apache/airflow/pull/19758#discussion_r757137427 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -445,27 +428,22 @@ paths: summary: Update DAGs

[GitHub] [airflow] dstandish commented on a change in pull request #19505: XCom.serialize_value should have all params set does

2021-11-25 Thread GitBox
dstandish commented on a change in pull request #19505: URL: https://github.com/apache/airflow/pull/19505#discussion_r757135654 ## File path: airflow/models/xcom.py ## @@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any: return BaseXCom.deserialize_value(self)

[GitHub] [airflow] dstandish commented on a change in pull request #19505: XCom.serialize_value should have all params set does

2021-11-25 Thread GitBox
dstandish commented on a change in pull request #19505: URL: https://github.com/apache/airflow/pull/19505#discussion_r757135654 ## File path: airflow/models/xcom.py ## @@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any: return BaseXCom.deserialize_value(self)

[GitHub] [airflow] Davide95 commented on issue #15108: PostgresHook do not use the specified cursor

2021-11-25 Thread GitBox
Davide95 commented on issue #15108: URL: https://github.com/apache/airflow/issues/15108#issuecomment-979474652 Hi @scouvreur Nope, I had some issues configuring the dev env in my machine, it seems that there were issues with btrfs:) -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on a change in pull request #19505: XCom.serialize_value should have all params set does

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19505: URL: https://github.com/apache/airflow/pull/19505#discussion_r757128435 ## File path: airflow/models/xcom.py ## @@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any: return BaseXCom.deserialize_value(self)

[GitHub] [airflow] potiuk commented on a change in pull request #19505: XCom.serialize_value should have all params set does

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19505: URL: https://github.com/apache/airflow/pull/19505#discussion_r757127766 ## File path: airflow/models/xcom.py ## @@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any: return BaseXCom.deserialize_value(self)

[airflow] branch main updated (76c598a -> cab6d96)

2021-11-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 76c598a Fix example code in Doc (#19824) add cab6d96 Avoid using Proxy in subscript type alias (#19830) No

[GitHub] [airflow] potiuk merged pull request #19830: Avoid using Proxy in subscript type alias

2021-11-25 Thread GitBox
potiuk merged pull request #19830: URL: https://github.com/apache/airflow/pull/19830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] dimon222 commented on a change in pull request #19815: Amazon provider remove deprecation, second try

2021-11-25 Thread GitBox
dimon222 commented on a change in pull request #19815: URL: https://github.com/apache/airflow/pull/19815#discussion_r757117351 ## File path: airflow/providers/postgres/hooks/postgres.py ## @@ -184,7 +184,13 @@ def get_iam_token(self, conn: Connection) -> Tuple[str, str, int]:

[GitHub] [airflow] malthe commented on a change in pull request #19806: Psrp advanced options

2021-11-25 Thread GitBox
malthe commented on a change in pull request #19806: URL: https://github.com/apache/airflow/pull/19806#discussion_r757108644 ## File path: airflow/providers/microsoft/psrp/hooks/psrp.py ## @@ -31,13 +33,19 @@ class PSRPHook(BaseHook): Hook for PowerShell Remoting Protocol

[GitHub] [airflow] ferruzzi edited a comment on issue #19641: EKSCreateNodegroupOperator - missing kwargs

2021-11-25 Thread GitBox
ferruzzi edited a comment on issue #19641: URL: https://github.com/apache/airflow/issues/19641#issuecomment-978658741 How strongly do you feel about that? Leaving them explicitly called out like that makes it obvious they are mandatory and enforces that, which (maybe?) makes it easier

[GitHub] [airflow] uranusjr edited a comment on pull request #19821: Sanity check for MySQL's TIMESTAMP column

2021-11-25 Thread GitBox
uranusjr edited a comment on pull request #19821: URL: https://github.com/apache/airflow/pull/19821#issuecomment-979174521 Huh why is `TestPythonVirtualenvOperator::test_airflow_context` suddenly failing. Edit: Fix proposed in #19830. -- This is an automated message from the

[GitHub] [airflow] uranusjr commented on a change in pull request #19821: Sanity check for MySQL's TIMESTAMP column

2021-11-25 Thread GitBox
uranusjr commented on a change in pull request #19821: URL: https://github.com/apache/airflow/pull/19821#discussion_r757105118 ## File path: airflow/sensors/base.py ## @@ -41,6 +42,13 @@ # See https://github.com/apache/airflow/issues/16035 from airflow.utils.decorators

[GitHub] [airflow] uranusjr commented on pull request #19830: Avoid using Proxy in subscript type alias

2021-11-25 Thread GitBox
uranusjr commented on pull request #19830: URL: https://github.com/apache/airflow/pull/19830#issuecomment-979439563 Managed to reduce the problem and it became obvious. To properly “fake” an object, `lazy-object-proxy` uses a metaclass to “fake” things so `type(proxy).__module__` returns

[GitHub] [airflow] uranusjr commented on pull request #19830: Avoid using Proxy in subscript type alias

2021-11-25 Thread GitBox
uranusjr commented on pull request #19830: URL: https://github.com/apache/airflow/pull/19830#issuecomment-979421704 On further investigation, the `Union` part is irrelevant[^1]; I can trivially trigger a crash with ```python import io import pickle from lazy_object_proxy

[GitHub] [airflow] uranusjr commented on issue #14854: Backfill/execution_date from UI

2021-11-25 Thread GitBox
uranusjr commented on issue #14854: URL: https://github.com/apache/airflow/issues/14854#issuecomment-979417093 So basically replicating what’s possible from the CLI, right? If that’s the case, #18816 is our main blocker for this. -- This is an automated message from the Apache Git

[GitHub] [airflow] uranusjr commented on a change in pull request #19505: XCom.serialize_value should have all params set does

2021-11-25 Thread GitBox
uranusjr commented on a change in pull request #19505: URL: https://github.com/apache/airflow/pull/19505#discussion_r757082478 ## File path: airflow/models/xcom.py ## @@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any: return BaseXCom.deserialize_value(self)

[GitHub] [airflow] uranusjr opened a new pull request #19830: Avoid using Proxy in subscript type alias

2021-11-25 Thread GitBox
uranusjr opened a new pull request #19830: URL: https://github.com/apache/airflow/pull/19830 This should fix main. Python's pickle module (or typing?) seems to have a bug when `lazy_object_proxy.Proxy` is used in a subscript type (such as Union). `pickle` would somehow incorrectly

[GitHub] [airflow] dstandish commented on a change in pull request #19505: XCom.serialize_value should have all params set does

2021-11-25 Thread GitBox
dstandish commented on a change in pull request #19505: URL: https://github.com/apache/airflow/pull/19505#discussion_r757081246 ## File path: airflow/models/xcom.py ## @@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any: return BaseXCom.deserialize_value(self)

[GitHub] [airflow] parisni commented on issue #19822: Helm schduler HA: duplicate key value violates unique constraint "serialized_dag_pkey"

2021-11-25 Thread GitBox
parisni commented on issue #19822: URL: https://github.com/apache/airflow/issues/19822#issuecomment-979415050 @potiuk @kaxil see the log in the issue (not my last comment) they are indeed comming from the scheduler. ``` duplicate key value violates unique constraint

[GitHub] [airflow] pavel-lexyr commented on issue #14854: Backfill/execution_date from UI

2021-11-25 Thread GitBox
pavel-lexyr commented on issue #14854: URL: https://github.com/apache/airflow/issues/14854#issuecomment-979413846 > I understand the need to trigger backfills from the UI, but what do you mean by “manipulating execution_date”? Running a backfill for a date before the DAG start date,

[GitHub] [airflow] aresabalo commented on issue #19816: logging error

2021-11-25 Thread GitBox
aresabalo commented on issue #19816: URL: https://github.com/apache/airflow/issues/19816#issuecomment-979381659 The redact function already has a hard recursion limit (by default 5) in secrets_masker.py There must be another problem in that function. Setting

[GitHub] [airflow] ferruzzi edited a comment on issue #19641: EKSCreateNodegroupOperator - missing kwargs

2021-11-25 Thread GitBox
ferruzzi edited a comment on issue #19641: URL: https://github.com/apache/airflow/issues/19641#issuecomment-978658741 How strongly do you feel about that? Leaving them explicitly called out like that makes it obvious they are mandatory and enforces that, which (maybe?) makes it easier

[GitHub] [airflow] jplauri commented on pull request #19596: MsSqlHook: implement _generate_insert_sql

2021-11-25 Thread GitBox
jplauri commented on pull request #19596: URL: https://github.com/apache/airflow/pull/19596#issuecomment-979369199 @dstandish Would you be able to advise me further here, i.e., is there something more the PR should have? Should we just wait for a review/merge, or what's the process? I'm

[GitHub] [airflow] tsingh2k15 commented on pull request #19760: remove upper bound for MarkupSafe

2021-11-25 Thread GitBox
tsingh2k15 commented on pull request #19760: URL: https://github.com/apache/airflow/pull/19760#issuecomment-979367104 > > Rebase to latest `main` please - all the "serious" test failures shoud be fixed. > > Rebased to latest `main`. Thanks! I will monitor the tests as the workflow

[GitHub] [airflow] dimon222 commented on a change in pull request #19815: Amazon provider remove deprecation, second try

2021-11-25 Thread GitBox
dimon222 commented on a change in pull request #19815: URL: https://github.com/apache/airflow/pull/19815#discussion_r757049653 ## File path: airflow/providers/postgres/hooks/postgres.py ## @@ -184,7 +184,13 @@ def get_iam_token(self, conn: Connection) -> Tuple[str, str, int]:

[GitHub] [airflow] ilCatania commented on issue #19804: TypeError: entry_points() got an unexpected keyword argument 'group'

2021-11-25 Thread GitBox
ilCatania commented on issue #19804: URL: https://github.com/apache/airflow/issues/19804#issuecomment-979363879 Yes the issue is on Markdown's side. They bumped importlib-metadata from 1.x to 4.x when they released Markdown 3.3.5. Adding `Markdown==3.3.4` to my requirements file worked

[GitHub] [airflow] scouvreur commented on issue #15108: PostgresHook do not use the specified cursor

2021-11-25 Thread GitBox
scouvreur commented on issue #15108: URL: https://github.com/apache/airflow/issues/15108#issuecomment-979344848 Hey @Davide95 - are you still looking into addressing this issue ? I have a working dev environment with Airflow and Postgres is that's helpful I would be happy to open a pull

[GitHub] [airflow] potiuk commented on pull request #19189: Swtich both PROD and CI images to use virtual environments

2021-11-25 Thread GitBox
potiuk commented on pull request #19189: URL: https://github.com/apache/airflow/pull/19189#issuecomment-979338403 After the whole discussion, I somehow have a feeling (without recalling back all the sentiments during the discussion), that the case that airflow should run in venv in the

[GitHub] [airflow] MinusYuan commented on issue #16373: Pass triggering user information to DAG

2021-11-25 Thread GitBox
MinusYuan commented on issue #16373: URL: https://github.com/apache/airflow/issues/16373#issuecomment-979337428 > In manual jobs there is a specific user who triggered it - that doesn't exist for scheduled jobs. What value are you expecting to have for scheduled jobs? Hi, I want to

[GitHub] [airflow] potiuk commented on pull request #19189: Swtich both PROD and CI images to use virtual environments

2021-11-25 Thread GitBox
potiuk commented on pull request #19189: URL: https://github.com/apache/airflow/pull/19189#issuecomment-979335686 I will take a look tomorrow, but any hints are welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk commented on pull request #19189: Swtich both PROD and CI images to use virtual environments

2021-11-25 Thread GitBox
potiuk commented on pull request #19189: URL: https://github.com/apache/airflow/pull/19189#issuecomment-979335350 @uranusjr - I removed the "activation" and left only the variables setting to emulate what `activate` does - there are however problems with serializing Proxy, which makes me

[GitHub] [airflow] j143 commented on pull request #19756: gitpodify Apache Airflow - online development workspace

2021-11-25 Thread GitBox
j143 commented on pull request #19756: URL: https://github.com/apache/airflow/pull/19756#issuecomment-979333874 >I think maybe (not 100% sure if you think it's a good idea) you shoud add --db-reset in the command starting breeze in the gitpod configuration (./breeze --db-reset -y).

[GitHub] [airflow] dimon222 edited a comment on pull request #19815: Amazon provider remove deprecation, second try

2021-11-25 Thread GitBox
dimon222 edited a comment on pull request #19815: URL: https://github.com/apache/airflow/pull/19815#issuecomment-979332442 Postgres test requires modification to skip mocking of get_client_type maybe? The error is weird.

[GitHub] [airflow] dimon222 edited a comment on pull request #19815: Amazon provider remove deprecation, second try

2021-11-25 Thread GitBox
dimon222 edited a comment on pull request #19815: URL: https://github.com/apache/airflow/pull/19815#issuecomment-979332442 Postgres test requires modification to skip mocking of get_client_type maybe? The error is weird. ```

[GitHub] [airflow] dimon222 commented on pull request #19815: Amazon provider remove deprecation, second try

2021-11-25 Thread GitBox
dimon222 commented on pull request #19815: URL: https://github.com/apache/airflow/pull/19815#issuecomment-979332442 Postgres test requires modification to skip mocking of get_client_type maybe? The error is weird. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] potiuk edited a comment on pull request #19756: gitpodify Apache Airflow - online development workspace

2021-11-25 Thread GitBox
potiuk edited a comment on pull request #19756: URL: https://github.com/apache/airflow/pull/19756#issuecomment-979329162 > please provide any comments on that. :) I think maybe (not 100% sure if you think it's a good idea) you shoud add `--db-reset` in the command starting breeze in

[airflow] branch main updated (5482b6a -> 76c598a)

2021-11-25 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 5482b6a Fix typo (#19826) add 76c598a Fix example code in Doc (#19824) No new revisions were added

[GitHub] [airflow] potiuk commented on pull request #19756: gitpodify Apache Airflow - online development workspace

2021-11-25 Thread GitBox
potiuk commented on pull request #19756: URL: https://github.com/apache/airflow/pull/19756#issuecomment-979329162 > please provide any comments on that. :) I think maybe (not 100% sure if you think it's a good idea) you shoud add `--db-reset` in the command starting breeze in the

[GitHub] [airflow] ephraimbuddy merged pull request #19824: Fix example code in Doc

2021-11-25 Thread GitBox
ephraimbuddy merged pull request #19824: URL: https://github.com/apache/airflow/pull/19824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] paul-bormans commented on issue #15340: helm install airflow in namespace get error: File "", line 32, in TimeoutError: There are still unapplied migrations after 6

2021-11-25 Thread GitBox
paul-bormans commented on issue #15340: URL: https://github.com/apache/airflow/issues/15340#issuecomment-979328550 I'm seeing the same issue when deploying using helm to k8s. Using versions: - chart: 1.3.0 - app: 2.2.1 It seems that these hooks were recently made

[airflow] branch main updated (eb163c8 -> 5482b6a)

2021-11-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from eb163c8 Fix GCS system tests (#19227) add 5482b6a Fix typo (#19826) No new revisions were added by this

[GitHub] [airflow] potiuk commented on pull request #19826: Fix typo in logging for tasks documentation

2021-11-25 Thread GitBox
potiuk commented on pull request #19826: URL: https://github.com/apache/airflow/pull/19826#issuecomment-979325985 :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk merged pull request #19826: Fix typo in logging for tasks documentation

2021-11-25 Thread GitBox
potiuk merged pull request #19826: URL: https://github.com/apache/airflow/pull/19826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #19822: Helm schduler HA: duplicate key value violates unique constraint "serialized_dag_pkey"

2021-11-25 Thread GitBox
potiuk closed issue #19822: URL: https://github.com/apache/airflow/issues/19822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #19822: Helm schduler HA: duplicate key value violates unique constraint "serialized_dag_pkey"

2021-11-25 Thread GitBox
potiuk commented on issue #19822: URL: https://github.com/apache/airflow/issues/19822#issuecomment-979324896 I think we can close it. @parisni. If you see the errors in airflow logs as well please comment here - we will re-open it. -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk edited a comment on issue #19822: Helm schduler HA: duplicate key value violates unique constraint "serialized_dag_pkey"

2021-11-25 Thread GitBox
potiuk edited a comment on issue #19822: URL: https://github.com/apache/airflow/issues/19822#issuecomment-979323697 > Can you post the logs from your scheduler / processor logs. I _don't think_ you should see that error in scheduler/parser logs -- errors in postgres logs is expected

[GitHub] [airflow] potiuk commented on issue #19822: Helm schduler HA: duplicate key value violates unique constraint "serialized_dag_pkey"

2021-11-25 Thread GitBox
potiuk commented on issue #19822: URL: https://github.com/apache/airflow/issues/19822#issuecomment-979323697 > Can you post the logs from your scheduler / processor logs. I _don't think_ you should see that error in scheduler/parser logs -- errors in postgres logs is expected Ah

[GitHub] [airflow] subkanthi opened a new pull request #19827: 19489

2021-11-25 Thread GitBox
subkanthi opened a new pull request #19827: URL: https://github.com/apache/airflow/pull/19827 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] kaxil commented on issue #19822: Helm schduler HA: duplicate key value violates unique constraint "serialized_dag_pkey"

2021-11-25 Thread GitBox
kaxil commented on issue #19822: URL: https://github.com/apache/airflow/issues/19822#issuecomment-979311959 Can you post the logs from your scheduler / processor logs. I _don't think_ you should see that error in scheduler/parser logs -- errors in postgres logs is expected -- This is

[GitHub] [airflow] tsingh2k15 commented on pull request #19760: remove upper bound for MarkupSafe

2021-11-25 Thread GitBox
tsingh2k15 commented on pull request #19760: URL: https://github.com/apache/airflow/pull/19760#issuecomment-979310198 > Rebase to latest `main` please - all the "serious" test failures shoud be fixed. Rebased to latest `main`. Thanks! I will monitor the tests as the workflow

[GitHub] [airflow] merwan opened a new pull request #19826: Fix typo in logging for tasks documentation

2021-11-25 Thread GitBox
merwan opened a new pull request #19826: URL: https://github.com/apache/airflow/pull/19826 Fix typo in logging for tasks documentation --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] j143 edited a comment on pull request #19756: gitpodify Apache Airflow - online development workspace

2021-11-25 Thread GitBox
j143 edited a comment on pull request #19756: URL: https://github.com/apache/airflow/pull/19756#issuecomment-979299281 > How about the comments with `--db-reset` ? I thought, I have added a comment on breeze stop. I have added this notes as far I understood -

[GitHub] [airflow] j143 commented on pull request #19756: gitpodify Apache Airflow - online development workspace

2021-11-25 Thread GitBox
j143 commented on pull request #19756: URL: https://github.com/apache/airflow/pull/19756#issuecomment-979299281 > How about the comments with `--db-reset` ? I thought, I have added a comment on breeze stop. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk commented on pull request #19756: gitpodify Apache Airflow - online development workspace

2021-11-25 Thread GitBox
potiuk commented on pull request #19756: URL: https://github.com/apache/airflow/pull/19756#issuecomment-979298344 How about the comments with `--db-reset` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on pull request #18974: Allows to disable built-in secret variables individually in chart

2021-11-25 Thread GitBox
potiuk commented on pull request #18974: URL: https://github.com/apache/airflow/pull/18974#issuecomment-979292623 Hey @jedcunningham @kaxil - reviving some of my old PRs. how about this one? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] potiuk commented on pull request #19210: Optimizes building of Production image for non-modified www files

2021-11-25 Thread GitBox
potiuk commented on pull request #19210: URL: https://github.com/apache/airflow/pull/19210#issuecomment-979280015 I wil rebase that one but let's not comment in #1989 for the changes related to changes there (only last commit is relevant here) -- This is an automated message from the

[GitHub] [airflow] potiuk commented on a change in pull request #19210: Optimizes building of Production image for non-modified www files

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19210: URL: https://github.com/apache/airflow/pull/19210#discussion_r756957952 ## File path: setup.cfg ## @@ -157,6 +157,7 @@ install_requires = termcolor>=1.1.0 typing-extensions>=3.7.4;python_version<"3.8"

[GitHub] [airflow] potiuk commented on a change in pull request #19210: Optimizes building of Production image for non-modified www files

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19210: URL: https://github.com/apache/airflow/pull/19210#discussion_r756957574 ## File path: scripts/docker/install_airflow_dependencies_from_branch_tip.sh ## @@ -39,11 +39,11 @@ function

[GitHub] [airflow] potiuk commented on pull request #19189: Swtich both PROD and CI images to use virtual environments

2021-11-25 Thread GitBox
potiuk commented on pull request #19189: URL: https://github.com/apache/airflow/pull/19189#issuecomment-979276652 Finally had time to return to that one. I will make it pass and then I will look at the remaining comments about PythonVirtualenv operator -- This is an automated message

[GitHub] [airflow] potiuk commented on a change in pull request #19189: Swtich both PROD and CI images to use virtual environments

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19189: URL: https://github.com/apache/airflow/pull/19189#discussion_r756951513 ## File path: Dockerfile ## @@ -183,16 +183,19 @@ ENV INSTALL_MYSQL_CLIENT=${INSTALL_MYSQL_CLIENT} \

[GitHub] [airflow] georborodin commented on pull request #18189: Allow using default celery commands for custom Celery executors subclassed from existing

2021-11-25 Thread GitBox
georborodin commented on pull request #18189: URL: https://github.com/apache/airflow/pull/18189#issuecomment-979263163 @potiuk done! Glad that the issues are resolved now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk edited a comment on pull request #18189: Allow using default celery commands for custom Celery executors subclassed from existing

2021-11-25 Thread GitBox
potiuk edited a comment on pull request #18189: URL: https://github.com/apache/airflow/pull/18189#issuecomment-979260998 Apologies for that but the problem was really difficult to diagnose (but easy to fix) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #18189: Allow using default celery commands for custom Celery executors subclassed from existing

2021-11-25 Thread GitBox
potiuk commented on pull request #18189: URL: https://github.com/apache/airflow/pull/18189#issuecomment-979260998 Apologies for that but the problem was really difficult to diagnose and fix. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] potiuk commented on pull request #18189: Allow using default celery commands for custom Celery executors subclassed from existing

2021-11-25 Thread GitBox
potiuk commented on pull request #18189: URL: https://github.com/apache/airflow/pull/18189#issuecomment-979260608 We had some serious issues with memory (fixed yesterday with #19809 finally (two days of investigation!) if you could please rebase one more time @georborodin that woudl be

[GitHub] [airflow] potiuk commented on pull request #19819: Rewrite image building tests to Python

2021-11-25 Thread GitBox
potiuk commented on pull request #19819: URL: https://github.com/apache/airflow/pull/19819#issuecomment-979250098 BTW. It would be great if you actually run those examples for "build customization" @mik-laj. They are not run on CI as those "image customisation" take a lot of time (only

[GitHub] [airflow] potiuk commented on a change in pull request #19819: Rewrite image building tests to Python

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19819: URL: https://github.com/apache/airflow/pull/19819#discussion_r756924024 ## File path: docs/docker-stack/docker-examples/restricted/restricted_environments.sh ## @@ -22,28 +22,29 @@ AIRFLOW_SOURCES="$(cd "$(dirname

[GitHub] [airflow] github-actions[bot] commented on pull request #19819: Rewrite image building tests to Python

2021-11-25 Thread GitBox
github-actions[bot] commented on pull request #19819: URL: https://github.com/apache/airflow/pull/19819#issuecomment-979248559 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on a change in pull request #19819: Rewrite image building tests to Python

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19819: URL: https://github.com/apache/airflow/pull/19819#discussion_r756924024 ## File path: docs/docker-stack/docker-examples/restricted/restricted_environments.sh ## @@ -22,28 +22,29 @@ AIRFLOW_SOURCES="$(cd "$(dirname

[GitHub] [airflow] potiuk commented on a change in pull request #19819: Rewrite image building tests to Python

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19819: URL: https://github.com/apache/airflow/pull/19819#discussion_r756923358 ## File path: docs/docker-stack/docker-examples/restricted/restricted_environments.sh ## @@ -22,28 +22,29 @@ AIRFLOW_SOURCES="$(cd "$(dirname

[GitHub] [airflow] potiuk commented on a change in pull request #19819: Rewrite image building tests to Python

2021-11-25 Thread GitBox
potiuk commented on a change in pull request #19819: URL: https://github.com/apache/airflow/pull/19819#discussion_r756923132 ## File path: docs/docker-stack/docker-examples/restricted/restricted_environments.sh ## @@ -22,28 +22,29 @@ AIRFLOW_SOURCES="$(cd "$(dirname

[GitHub] [airflow] ashb commented on a change in pull request #19825: Deprecate passing execution_date to XCom methods

2021-11-25 Thread GitBox
ashb commented on a change in pull request #19825: URL: https://github.com/apache/airflow/pull/19825#discussion_r756920704 ## File path: airflow/models/taskinstance.py ## @@ -2237,27 +2237,40 @@ def xcom_push( :param value: A value for the XCom. The value is pickled

  1   2   >