[GitHub] [airflow] flrn77 commented on issue #12136: KubernetesPodOperator breaks with active log-collection for long running tasks

2021-12-28 Thread GitBox
flrn77 commented on issue #12136: URL: https://github.com/apache/airflow/issues/12136#issuecomment-1001946521 Hey there, I can confirm that the error still exists in version 2.2.x python3.8. For the setup I reference to @zappallot 2 comments above. We have logging with datad

[GitHub] [airflow] eladkal commented on pull request #20528: Change download_video parameter to resourceName

2021-12-28 Thread GitBox
eladkal commented on pull request #20528: URL: https://github.com/apache/airflow/pull/20528#issuecomment-1001953126 There are some test failures: ``` tests/providers/google/marketing_platform/operators/test_display_video.py::TestGoogleDisplayVideo360SDFtoGCSOperator::test_execute: Ke

[GitHub] [airflow] microhuang opened a new issue #20534: is not bound to a Session; lazy load operation of attribute 'dag_model'

2021-12-28 Thread GitBox
microhuang opened a new issue #20534: URL: https://github.com/apache/airflow/issues/20534 ### Apache Airflow version 2.2.3 (latest released) ### What happened An error occurred while browsing the page (/rendered-k8s?dag_id=xxx&task_id=yyy&execution_date=zzz): ```

[GitHub] [airflow] eladkal commented on pull request #20514: Rename `OpsgenieAlertOperator` to `OpsgenieCreateAlertOperator`

2021-12-28 Thread GitBox
eladkal commented on pull request #20514: URL: https://github.com/apache/airflow/pull/20514#issuecomment-1001955894 If someone has time to review :) I hope to merge it before we cut RC otherwise we will need additional depreciation -- This is an automated message from the Apache Git S

[GitHub] [airflow] wenjun93 commented on a change in pull request #20438: Cleanup pending pods

2021-12-28 Thread GitBox
wenjun93 commented on a change in pull request #20438: URL: https://github.com/apache/airflow/pull/20438#discussion_r775813899 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -108,11 +113,15 @@ def cleanup_pods(args): pod_phase = pod.status.phase.low

[GitHub] [airflow] wenjun93 commented on a change in pull request #20438: Cleanup pending pods

2021-12-28 Thread GitBox
wenjun93 commented on a change in pull request #20438: URL: https://github.com/apache/airflow/pull/20438#discussion_r775813899 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -108,11 +113,15 @@ def cleanup_pods(args): pod_phase = pod.status.phase.low

[GitHub] [airflow] mik-laj commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
mik-laj commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775829439 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

[GitHub] [airflow] mik-laj commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
mik-laj commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775830241 ## File path: dev/breeze/src/airflow_breeze/ci/build_image.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

[GitHub] [airflow] mik-laj commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
mik-laj commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775831326 ## File path: dev/breeze/src/airflow_breeze/ci/build_image.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

[GitHub] [airflow] mik-laj commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
mik-laj commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775831326 ## File path: dev/breeze/src/airflow_breeze/ci/build_image.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775831803 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775832312 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775832312 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775833079 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] mik-laj commented on pull request #20528: Change download_video parameter to resourceName

2021-12-28 Thread GitBox
mik-laj commented on pull request #20528: URL: https://github.com/apache/airflow/pull/20528#issuecomment-1001992618 Some tests failed: ``` tests/providers/google/marketing_platform/operators/test_display_video.py::TestGoogleDisplayVideo360SDFtoGCSOperator::test_execute: KeyError: 're

[GitHub] [airflow] mik-laj removed a comment on pull request #20528: Change download_video parameter to resourceName

2021-12-28 Thread GitBox
mik-laj removed a comment on pull request #20528: URL: https://github.com/apache/airflow/pull/20528#issuecomment-1001992618 Some tests failed: ``` tests/providers/google/marketing_platform/operators/test_display_video.py::TestGoogleDisplayVideo360SDFtoGCSOperator::test_execute: KeyEr

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775833718 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775834633 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775835746 ## File path: dev/breeze/src/airflow_breeze/ci/build_image.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775836507 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775837171 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775838929 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775839485 ## File path: dev/breeze/src/airflow_breeze/ci/build_image.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775839906 ## File path: dev/breeze/src/airflow_breeze/ci/build_image.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775840395 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775840621 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775840980 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775842262 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775843145 ## File path: dev/breeze/src/airflow_breeze/utils.py ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775843289 ## File path: dev/breeze/src/airflow_breeze/global_constants.py ## @@ -0,0 +1,161 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] wenjun93 commented on a change in pull request #20438: Cleanup pending pods

2021-12-28 Thread GitBox
wenjun93 commented on a change in pull request #20438: URL: https://github.com/apache/airflow/pull/20438#discussion_r775813899 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -108,11 +113,15 @@ def cleanup_pods(args): pod_phase = pod.status.phase.low

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775846822 ## File path: dev/breeze/src/airflow_breeze/utils.py ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775862078 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775862078 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775865797 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -95,13 +96,46 @@ def shell(verbose: bool): @option_verbose -@main.command() -def build_c

[GitHub] [airflow] potiuk commented on pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on pull request #20338: URL: https://github.com/apache/airflow/pull/20338#issuecomment-1002046623 Goes definitely in the right direction! And you are slowly cracking the most complex part of it, so kudos for getting as far as you did so far :). -- This is an automated

[GitHub] [airflow] potiuk commented on pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on pull request #20338: URL: https://github.com/apache/airflow/pull/20338#issuecomment-1002047047 Later on we should add some tests, but I think it would be great to get those comments sorted out first and then we can discuss writing tests! -- This is an automated messa

[GitHub] [airflow] stefanondisponibile closed issue #19460: Templated volumes for KubernetesExecutor.

2021-12-28 Thread GitBox
stefanondisponibile closed issue #19460: URL: https://github.com/apache/airflow/issues/19460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775838929 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775868681 ## File path: dev/breeze/src/airflow_breeze/utils.py ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775869187 ## File path: dev/breeze/src/airflow_breeze/utils.py ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775869276 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -95,13 +96,46 @@ def shell(verbose: bool): @option_verbose -@main.command() -def build_c

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775869648 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -95,13 +96,46 @@ def shell(verbose: bool): @option_verbose -@main.command() -def build_c

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775870534 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -95,13 +96,46 @@ def shell(verbose: bool): @option_verbose -@main.command() -def build_c

[GitHub] [airflow] Aakcht opened a new pull request #20535: Chart: Add custom labels for ingresses/PVCs

2021-12-28 Thread GitBox
Aakcht opened a new pull request #20535: URL: https://github.com/apache/airflow/pull/20535 Fix custom labels not being set for PVCs and ingresses created by the chart --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775871740 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk commented on a change in pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20239: URL: https://github.com/apache/airflow/pull/20239#discussion_r775873035 ## File path: airflow/providers/google/cloud/hooks/cloud_sql.py ## @@ -769,7 +775,7 @@ def __init__( @staticmethod def _get_bool(val: Any) ->

[GitHub] [airflow] potiuk commented on a change in pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20239: URL: https://github.com/apache/airflow/pull/20239#discussion_r775873035 ## File path: airflow/providers/google/cloud/hooks/cloud_sql.py ## @@ -769,7 +775,7 @@ def __init__( @staticmethod def _get_bool(val: Any) ->

[GitHub] [airflow] github-actions[bot] commented on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider

2021-12-28 Thread GitBox
github-actions[bot] commented on pull request #20239: URL: https://github.com/apache/airflow/pull/20239#issuecomment-1002057531 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] potiuk commented on pull request #20509: Improvements for `SnowflakeHook.get_sqlalchemy_engine`

2021-12-28 Thread GitBox
potiuk commented on pull request #20509: URL: https://github.com/apache/airflow/pull/20509#issuecomment-1002091381 I will include that one in the december release tool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] potiuk merged pull request #20509: Improvements for `SnowflakeHook.get_sqlalchemy_engine`

2021-12-28 Thread GitBox
potiuk merged pull request #20509: URL: https://github.com/apache/airflow/pull/20509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20509: Improvements for `SnowflakeHook.get_sqlalchemy_engine`

2021-12-28 Thread GitBox
boring-cyborg[bot] commented on pull request #20509: URL: https://github.com/apache/airflow/pull/20509#issuecomment-1002091456 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [airflow] potiuk closed issue #20032: Snowflake Provider - Hook's support for not providing a region is broken when using SQLAlchemy

2021-12-28 Thread GitBox
potiuk closed issue #20032: URL: https://github.com/apache/airflow/issues/20032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] github-actions[bot] commented on pull request #20509: Improvements for `SnowflakeHook.get_sqlalchemy_engine`

2021-12-28 Thread GitBox
github-actions[bot] commented on pull request #20509: URL: https://github.com/apache/airflow/pull/20509#issuecomment-1002091483 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[airflow] branch main updated (b7086f9 -> a632b74)

2021-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from b7086f9 Use Python3.7+ syntax in pyupgrade (#20501) add a632b74 Improvements for `SnowflakeHook.get_sqlalchemy_

[GitHub] [airflow] stablum commented on issue #19957: Airflow crashes with a psycopg2.errors.DeadlockDetected exception

2021-12-28 Thread GitBox
stablum commented on issue #19957: URL: https://github.com/apache/airflow/issues/19957#issuecomment-1002095615 Just upgraded to Airflow 2.2.3, and unfortunately it keeps crashing as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] aa3pankaj commented on a change in pull request #20459: Adding snowflake_to_s3 transfer operator, Updates in s3_to_snowflake

2021-12-28 Thread GitBox
aa3pankaj commented on a change in pull request #20459: URL: https://github.com/apache/airflow/pull/20459#discussion_r775921457 ## File path: airflow/providers/snowflake/transfers/snowflake_to_s3.py ## @@ -0,0 +1,153 @@ +# +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] [airflow] josh-fell commented on a change in pull request #19852: created SFTPBatchOperator which add batch function

2021-12-28 Thread GitBox
josh-fell commented on a change in pull request #19852: URL: https://github.com/apache/airflow/pull/19852#discussion_r775322203 ## File path: airflow/providers/sftp/operators/sftp_batch.py ## @@ -0,0 +1,283 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] potiuk merged pull request #20514: Rename `OpsgenieAlertOperator` to `OpsgenieCreateAlertOperator`

2021-12-28 Thread GitBox
potiuk merged pull request #20514: URL: https://github.com/apache/airflow/pull/20514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[airflow] branch main updated (a632b74 -> a637537)

2021-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a632b74 Improvements for `SnowflakeHook.get_sqlalchemy_engine` (#20509) add a637537 Rename `OpsgenieAlertOper

[GitHub] [airflow] github-actions[bot] commented on pull request #20438: Cleanup pending pods

2021-12-28 Thread GitBox
github-actions[bot] commented on pull request #20438: URL: https://github.com/apache/airflow/pull/20438#issuecomment-1002135747 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] potiuk commented on a change in pull request #20438: Cleanup pending pods

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20438: URL: https://github.com/apache/airflow/pull/20438#discussion_r775939000 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -108,11 +113,15 @@ def cleanup_pods(args): pod_phase = pod.status.phase.lower

[GitHub] [airflow] potiuk commented on pull request #20438: Cleanup pending pods

2021-12-28 Thread GitBox
potiuk commented on pull request #20438: URL: https://github.com/apache/airflow/pull/20438#issuecomment-1002145363 Static checks are sad though :(. Pre-commit to the rescue :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [airflow] potiuk commented on a change in pull request #20523: Update documentation for provider December 2021 release

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20523: URL: https://github.com/apache/airflow/pull/20523#discussion_r775947896 ## File path: airflow/providers/amazon/CHANGELOG.rst ## @@ -19,6 +19,56 @@ Changelog - +2.6.0 +. + +Features + + +* ``Add aws_con

[GitHub] [airflow] potiuk commented on a change in pull request #20523: Update documentation for provider December 2021 release

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20523: URL: https://github.com/apache/airflow/pull/20523#discussion_r775948783 ## File path: airflow/providers/snowflake/CHANGELOG.rst ## @@ -19,6 +19,20 @@ Changelog - +2.4.0 +. + +Features + + +* ``Support

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r775949996 ## File path: README.md ## @@ -284,14 +284,14 @@ They are based on the official release schedule of Python and Kubernetes, nicely 1. We drop support fo

[GitHub] [airflow] potiuk commented on pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on pull request #20517: URL: https://github.com/apache/airflow/pull/20517#issuecomment-1002148875 Luckily - next such thing: June 2023 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] josh-fell commented on a change in pull request #20530: Add sensor decorator

2021-12-28 Thread GitBox
josh-fell commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r775953545 ## File path: airflow/decorators/sensor.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[GitHub] [airflow] potiuk commented on a change in pull request #20200: [New] - Ci free space python

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20200: URL: https://github.com/apache/airflow/pull/20200#discussion_r775956062 ## File path: .github/workflows/ci.yml ## @@ -324,15 +324,23 @@ jobs: name: "Test examples of production image building" runs-on: ${{ fromJson(

[GitHub] [airflow] potiuk commented on a change in pull request #20200: [New] - Ci free space python

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20200: URL: https://github.com/apache/airflow/pull/20200#discussion_r775956062 ## File path: .github/workflows/ci.yml ## @@ -324,15 +324,23 @@ jobs: name: "Test examples of production image building" runs-on: ${{ fromJson(

[GitHub] [airflow] josh-fell commented on a change in pull request #20530: Add sensor decorator

2021-12-28 Thread GitBox
josh-fell commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r775953545 ## File path: airflow/decorators/sensor.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[GitHub] [airflow] josh-fell commented on a change in pull request #20530: Add sensor decorator

2021-12-28 Thread GitBox
josh-fell commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r775953545 ## File path: airflow/decorators/sensor.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[GitHub] [airflow] josh-fell commented on pull request #19608: Enhance `multiple_outputs` inference of dict typing

2021-12-28 Thread GitBox
josh-fell commented on pull request #19608: URL: https://github.com/apache/airflow/pull/19608#issuecomment-1002159180 @uranusjr I noticed in another PR that there were other references to tuples and lists in `multiple_outputs` docstrings. I figured I'd update them all here. -- This is an

[GitHub] [airflow] harishkrao commented on pull request #20527: Fixed has_calls to assert_has_calls

2021-12-28 Thread GitBox
harishkrao commented on pull request #20527: URL: https://github.com/apache/airflow/pull/20527#issuecomment-1002159501 > Some of the calls might need `any_order=True` --> `mock.assert_has_calls(calls, any_order=True)` > > You will have to take a look though - https://docs.python.org

[jira] [Assigned] (AIRFLOW-6647) Reduce the cluttering of Airflow UI by merging create and check into a single CHECK step.

2021-12-28 Thread Nidhi Chourasia (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nidhi Chourasia reassigned AIRFLOW-6647: Assignee: Golokesh Patra (was: Nidhi Chourasia) > Reduce the cluttering of Airf

[GitHub] [airflow] eskarimov opened a new pull request #20536: Add `wait_for_termination` option for Databricks Operators

2021-12-28 Thread GitBox
eskarimov opened a new pull request #20536: URL: https://github.com/apache/airflow/pull/20536 The PR intends to close the issue #10921 by adding an input argument and a property named `wait_for_termination` for the Databricks operator classes. The default behaviour doesn't change, the oper

[jira] [Assigned] (AIRFLOW-4470) RBAC Github Enterprise OAuth provider callback URL?

2021-12-28 Thread Nidhi Chourasia (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nidhi Chourasia reassigned AIRFLOW-4470: Assignee: Golokesh Patra > RBAC Github Enterprise OAuth provider callback URL? >

[GitHub] [airflow] potiuk commented on pull request #20536: Add `wait_for_termination` option for Databricks Operators

2021-12-28 Thread GitBox
potiuk commented on pull request #20536: URL: https://github.com/apache/airflow/pull/20536#issuecomment-1002170419 Just in time for the release @eskarimov ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [airflow] github-actions[bot] commented on pull request #20536: Add `wait_for_termination` option for Databricks Operators

2021-12-28 Thread GitBox
github-actions[bot] commented on pull request #20536: URL: https://github.com/apache/airflow/pull/20536#issuecomment-1002170556 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] raphaelauv commented on pull request #20411: Allow to except_skip None on BranchPythonOperator

2021-12-28 Thread GitBox
raphaelauv commented on pull request #20411: URL: https://github.com/apache/airflow/pull/20411#issuecomment-1002170816 @uranusjr could you re-review pls , thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk commented on pull request #19736: Add Databricks Deferrable Operators

2021-12-28 Thread GitBox
potiuk commented on pull request #19736: URL: https://github.com/apache/airflow/pull/19736#issuecomment-1002172319 This operator will not be clearly importing on Airflow 2.1 (see the errors in tests). Airlfow.trigger is not available in Airlfow 2.1. There are two approaches we can ta

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775982860 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775982860 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775989124 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

[GitHub] [airflow] potiuk opened a new pull request #20537: Removes unnecessary --upgrade option from our examples

2021-12-28 Thread GitBox
potiuk opened a new pull request #20537: URL: https://github.com/apache/airflow/pull/20537 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more info

[GitHub] [airflow] dstandish closed pull request #20529: Config patches (for tests) should patch before resolving

2021-12-28 Thread GitBox
dstandish closed pull request #20529: URL: https://github.com/apache/airflow/pull/20529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] derkuci commented on issue #20500: infinite recursion in StreamLogWriter

2021-12-28 Thread GitBox
derkuci commented on issue #20500: URL: https://github.com/apache/airflow/issues/20500#issuecomment-1002189756 > > This will change the growth of buffer from exponential to linear, and the users may hit the recursive stack limit before the out-of-memory error, and would more easily figure

[GitHub] [airflow] potiuk commented on issue #20500: infinite recursion in StreamLogWriter

2021-12-28 Thread GitBox
potiuk commented on issue #20500: URL: https://github.com/apache/airflow/issues/20500#issuecomment-1002192831 > Please be noted that the stripping is in the current airflow code; I copied the behavior to keep things the same when nothing bad happens (and if we don't strip, we get extra bla

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775996116 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775996116 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] jedcunningham commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
jedcunningham commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r775993794 ## File path: BREEZE.rst ## @@ -834,7 +834,7 @@ To use your host IDE with Breeze: `pyenv `_, `pyenv-virtualenv

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r775996933 ## File path: dev/breeze/src/airflow_breeze/ci/build_params.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r775999084 ## File path: README.md ## @@ -84,9 +84,9 @@ Apache Airflow is tested with: | | Main version (dev) | Stable version (2.2.3) |

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r775999084 ## File path: README.md ## @@ -84,9 +84,9 @@ Apache Airflow is tested with: | | Main version (dev) | Stable version (2.2.3) |

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r775999687 ## File path: README.md ## @@ -84,9 +84,9 @@ Apache Airflow is tested with: | | Main version (dev) | Stable version (2.2.3) |

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r775999084 ## File path: README.md ## @@ -84,9 +84,9 @@ Apache Airflow is tested with: | | Main version (dev) | Stable version (2.2.3) |

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r776000222 ## File path: README.md ## @@ -84,9 +84,9 @@ Apache Airflow is tested with: | | Main version (dev) | Stable version (2.2.3) |

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r776001047 ## File path: README.md ## @@ -84,9 +84,9 @@ Apache Airflow is tested with: | | Main version (dev) | Stable version (2.2.3) |

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r776001322 ## File path: README.md ## @@ -84,9 +84,9 @@ Apache Airflow is tested with: | | Main version (dev) | Stable version (2.2.3) |

[GitHub] [airflow] potiuk commented on a change in pull request #20517: fix README support matrix

2021-12-28 Thread GitBox
potiuk commented on a change in pull request #20517: URL: https://github.com/apache/airflow/pull/20517#discussion_r776001988 ## File path: README.md ## @@ -84,9 +84,9 @@ Apache Airflow is tested with: | | Main version (dev) | Stable version (2.2.3) |

  1   2   3   >