[GitHub] [airflow] potiuk commented on a diff in pull request #33881: Remove tasks annotation in `AppflowHook`

2023-08-29 Thread via GitHub
potiuk commented on code in PR #33881: URL: https://github.com/apache/airflow/pull/33881#discussion_r1309685611 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -24,7 +24,6 @@ if TYPE_CHECKING: from mypy_boto3_appflow.client import AppflowClient -from

[GitHub] [airflow] potiuk commented on a diff in pull request #33849: Refactor unneeded 'continue' jumps around the repo

2023-08-29 Thread via GitHub
potiuk commented on code in PR #33849: URL: https://github.com/apache/airflow/pull/33849#discussion_r1309681971 ## airflow/serialization/serialized_objects.py: ## @@ -825,9 +822,10 @@ def serialize_mapped_operator(cls, op: MappedOperator) -> dict[str, Any]: try:

[airflow] branch main updated: Early delete a Dataproc cluster if started in the ERROR state. (#33668)

2023-08-29 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d361761dee Early delete a Dataproc cluster if

[GitHub] [airflow] potiuk closed issue #33667: Google Cloud Dataproc cluster creation should eagerly delete ERROR state clusters.

2023-08-29 Thread via GitHub
potiuk closed issue #33667: Google Cloud Dataproc cluster creation should eagerly delete ERROR state clusters. URL: https://github.com/apache/airflow/issues/33667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk merged pull request #33668: Early delete a Dataproc cluster if started in the ERROR state.

2023-08-29 Thread via GitHub
potiuk merged PR #33668: URL: https://github.com/apache/airflow/pull/33668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #33715: allow impersonation_chain to be set on Google Cloud connection

2023-08-29 Thread via GitHub
potiuk commented on PR #33715: URL: https://github.com/apache/airflow/pull/33715#issuecomment-1698512862 > @potiuk thanks, i was already modifying that file in this PR. i've added a note there about precedence Yeah. That's what I was about. The thing is that we are not only do a

[airflow] branch main updated: allow impersonation_chain to be set on Google Cloud connection (#33715)

2023-08-29 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 075afe5a2a allow impersonation_chain to be set on

[GitHub] [airflow] potiuk merged pull request #33715: allow impersonation_chain to be set on Google Cloud connection

2023-08-29 Thread via GitHub
potiuk merged PR #33715: URL: https://github.com/apache/airflow/pull/33715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on pull request #33904: Update Azure fileshare hook to use azure-storage-file-share instead of azure-storage-file

2023-08-29 Thread via GitHub
eladkal commented on PR #33904: URL: https://github.com/apache/airflow/pull/33904#issuecomment-1698501110 We can do a major release. I think this case justify it. Add entry in provider.yaml and make sure to add detailed information about what changed in the top of changelog -- This is

[GitHub] [airflow] shicholas opened a new pull request, #33906: Update setup.cfg

2023-08-29 Thread via GitHub
shicholas opened a new pull request, #33906: URL: https://github.com/apache/airflow/pull/33906 Remove unicodecsv now that it's no longer used. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] pankajastro commented on pull request #33904: Update Azure fileshare hook to use azure-storage-file-share instead of azure-storage-file

2023-08-29 Thread via GitHub
pankajastro commented on PR #33904: URL: https://github.com/apache/airflow/pull/33904#issuecomment-1698423222 Hi @potiuk / @eladkal I'm trying to update `AzureFileShareHook` to use the newly updated Azure SDK but interfaces on the Azure SDK side have changed a lot which makes it difficult

[GitHub] [airflow] Lee-W commented on issue #33875: Status of testing Providers that were prepared on August 29, 2023

2023-08-29 Thread via GitHub
Lee-W commented on issue #33875: URL: https://github.com/apache/airflow/issues/33875#issuecomment-1698405089 Verified https://github.com/apache/airflow/pull/33716, https://github.com/apache/airflow/pull/33467, https://github.com/apache/airflow/pull/33433,

[GitHub] [airflow] pankajastro opened a new pull request, #33905: [WIP] Add deprecation warning in Azure fileshare methods

2023-08-29 Thread via GitHub
pankajastro opened a new pull request, #33905: URL: https://github.com/apache/airflow/pull/33905 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] pankajastro opened a new pull request, #33904: Update Azure fileshare hook to use azure-storage-file-share instead of azure-storage-file

2023-08-29 Thread via GitHub
pankajastro opened a new pull request, #33904: URL: https://github.com/apache/airflow/pull/33904 TODO: Add why? --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] dstandish opened a new pull request, #33903: Ensure that tasks wait for running indirect setup

2023-08-29 Thread via GitHub
dstandish opened a new pull request, #33903: URL: https://github.com/apache/airflow/pull/33903 This is yet another approach to solving this one. But I feel it's the best one thus far because it does not make any changes to existing trigger rule logic, apart from pulling out some internal

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33902: allow optional password replacement

2023-08-29 Thread via GitHub
boring-cyborg[bot] commented on PR #33902: URL: https://github.com/apache/airflow/pull/33902#issuecomment-1698309029 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] lewijw opened a new pull request, #33902: allow optional password replacement

2023-08-29 Thread via GitHub
lewijw opened a new pull request, #33902: URL: https://github.com/apache/airflow/pull/33902 This is new functionality that is optional. In our k8s deployments, the postgres and redis password secrets are initialized in an init container. After this, the corresponding url secrets need to

[GitHub] [airflow] github-actions[bot] closed pull request #31134: Add support to trigger Azure Functions from Airflow

2023-08-29 Thread via GitHub
github-actions[bot] closed pull request #31134: Add support to trigger Azure Functions from Airflow URL: https://github.com/apache/airflow/pull/31134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch constraints-main updated: Updating constraints. Github run id:6018095361

2023-08-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 9d39c9b3e9 Updating

[GitHub] [airflow] vandonr-amz opened a new pull request, #33901: Fix inheritance chain in security manager

2023-08-29 Thread via GitHub
vandonr-amz opened a new pull request, #33901: URL: https://github.com/apache/airflow/pull/33901 There is currently a weird situation with the security managers, where the `AirflowSecurityManager`, which is supposed to be the more generic construct, inherits from

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33900: Update synapse.py to fix timeout bug

2023-08-29 Thread via GitHub
boring-cyborg[bot] commented on PR #33900: URL: https://github.com/apache/airflow/pull/33900#issuecomment-1698234790 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] karthikkadajji opened a new pull request, #33900: Update synapse.py to fix timeout bug

2023-08-29 Thread via GitHub
karthikkadajji opened a new pull request, #33900: URL: https://github.com/apache/airflow/pull/33900 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] o-nikolas commented on a diff in pull request #33881: Remove tasks annotation in `AppflowHook`

2023-08-29 Thread via GitHub
o-nikolas commented on code in PR #33881: URL: https://github.com/apache/airflow/pull/33881#discussion_r1309412539 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -24,7 +24,6 @@ if TYPE_CHECKING: from mypy_boto3_appflow.client import AppflowClient -from

[airflow] branch main updated: Remove explicit str concat from Airflow providers package and tests (#33860)

2023-08-29 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3ef770e3d2 Remove explicit str concat from

[GitHub] [airflow] hussein-awala merged pull request #33860: Remove explicit str concat from Airflow providers package and tests

2023-08-29 Thread via GitHub
hussein-awala merged PR #33860: URL: https://github.com/apache/airflow/pull/33860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] o-nikolas commented on a diff in pull request #33849: Refactor unneeded 'continue' jumps around the repo

2023-08-29 Thread via GitHub
o-nikolas commented on code in PR #33849: URL: https://github.com/apache/airflow/pull/33849#discussion_r1309394034 ## airflow/serialization/serialized_objects.py: ## @@ -825,9 +822,10 @@ def serialize_mapped_operator(cls, op: MappedOperator) -> dict[str, Any]:

[GitHub] [airflow] melugoyal commented on pull request #33715: allow impersonation_chain to be set on Google Cloud connection

2023-08-29 Thread via GitHub
melugoyal commented on PR #33715: URL: https://github.com/apache/airflow/pull/33715#issuecomment-1698160036 @potiuk thanks, i was already modifying that file in this PR. i've added a note there about precedence -- This is an automated message from the Apache Git Service. To respond to

[airflow] branch constraints-main updated: Updating constraints. Github run id:6016878745

2023-08-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e4491f4da4 Updating

[GitHub] [airflow] Taragolis commented on a diff in pull request #33720: Optimise and migrate to SA2-compatible syntax for TaskReschedule

2023-08-29 Thread via GitHub
Taragolis commented on code in PR #33720: URL: https://github.com/apache/airflow/pull/33720#discussion_r1309348422 ## airflow/models/taskreschedule.py: ## @@ -142,9 +154,93 @@ def find_for_task_instance( :param try_number: Look for TaskReschedule of the given

[GitHub] [airflow] Taragolis commented on a diff in pull request #33720: Optimise and migrate to SA2-compatible syntax for TaskReschedule

2023-08-29 Thread via GitHub
Taragolis commented on code in PR #33720: URL: https://github.com/apache/airflow/pull/33720#discussion_r1306689074 ## tests/ti_deps/deps/test_ready_to_reschedule_dep.py: ## @@ -64,118 +76,127 @@ def _get_mapped_task_reschedule(self, reschedule_date): ) return

[GitHub] [airflow] llamageddon83 commented on issue #32928: Airflow progressive slowness

2023-08-29 Thread via GitHub
llamageddon83 commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1698049513 Hi @potiuk Please find my answers in line below: Is it possible that you do check which tasks are in "running" state for some time when it happens and maybe try to

[GitHub] [airflow] hussein-awala commented on a diff in pull request #33857: replace unnecessary dict comprehension by dict() in providers

2023-08-29 Thread via GitHub
hussein-awala commented on code in PR #33857: URL: https://github.com/apache/airflow/pull/33857#discussion_r1309288674 ## airflow/providers/google/cloud/operators/bigquery.py: ## @@ -1039,7 +1039,7 @@ def execute(self, context: Context): self.log.info("Total

[airflow] branch main updated (3f3edee3f5 -> 49d8864c7e)

2023-08-29 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 3f3edee3f5 Fix files expression for rev heads pre-commit (#33899) add 49d8864c7e replace lambda by def in

[airflow] branch main updated (b37eaae157 -> 3f3edee3f5)

2023-08-29 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b37eaae157 Cleanup: remove remnants of 'shutdown' task instance state (#33893) add 3f3edee3f5 Fix files

[GitHub] [airflow] dstandish merged pull request #33899: Fix files expression for rev heads pre-commit

2023-08-29 Thread via GitHub
dstandish merged PR #33899: URL: https://github.com/apache/airflow/pull/33899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] hussein-awala commented on a diff in pull request #33864: Replace single quotes by double quotes in tests

2023-08-29 Thread via GitHub
hussein-awala commented on code in PR #33864: URL: https://github.com/apache/airflow/pull/33864#discussion_r1309307096 ## tests/providers/google/cloud/hooks/test_mlengine.py: ## @@ -1009,11 +1009,11 @@ def test_delete_version(self, mock_get_conn, mock_project_id):

[GitHub] [airflow] hussein-awala merged pull request #33861: Remove unnecessary start of range from tests

2023-08-29 Thread via GitHub
hussein-awala merged PR #33861: URL: https://github.com/apache/airflow/pull/33861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (49d8864c7e -> f9e92223c2)

2023-08-29 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 49d8864c7e replace lambda by def in tests to simplify the debugging (#33856) add f9e92223c2 Remove

[GitHub] [airflow-site] potiuk commented on pull request #857: Adding information about Open Data Discovery (ODD) integration

2023-08-29 Thread via GitHub
potiuk commented on PR #857: URL: https://github.com/apache/airflow-site/pull/857#issuecomment-1698016593 Could you change it with the link to the Github project? the link you proposed does not refer to airflow in any way and it's unclear why it would be mentioned on Airflow's ecosystem

[airflow] branch main updated: Cleanup: remove remnants of 'shutdown' task instance state (#33893)

2023-08-29 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b37eaae157 Cleanup: remove remnants of 'shutdown'

[GitHub] [airflow] potiuk merged pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
potiuk merged PR #33893: URL: https://github.com/apache/airflow/pull/33893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] dstandish opened a new pull request, #33899: Fix files expression for rev heads pre-commit

2023-08-29 Thread via GitHub
dstandish opened a new pull request, #33899: URL: https://github.com/apache/airflow/pull/33899 Was missing airflow/utils/db.py and the pre-commit script itself. Also, not worth printing out a message in this scenario. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] eumiro opened a new pull request, #33898: Refactor regex in providers

2023-08-29 Thread via GitHub
eumiro opened a new pull request, #33898: URL: https://github.com/apache/airflow/pull/33898 Replace `match(r"^…$", …)` with `fullmatch(r"…"), remove unneeded escaping backslashes, and `search` for text instead of `sub` replacing it. -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk closed issue #33896: Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled.

2023-08-29 Thread via GitHub
potiuk closed issue #33896: Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled. URL: https://github.com/apache/airflow/issues/33896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] Taragolis commented on issue #33894: AWS connection doesn't convert verify option to bool

2023-08-29 Thread via GitHub
Taragolis commented on issue #33894: URL: https://github.com/apache/airflow/issues/33894#issuecomment-1697884740 Ups 臘 , I mean `"verify": false` in your case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow-site] RamanDamayeu opened a new pull request, #857: Adding information about Open Data Discovery (ODD) integration

2023-08-29 Thread via GitHub
RamanDamayeu opened a new pull request, #857: URL: https://github.com/apache/airflow-site/pull/857 Adding information about Open Data Discovery (ODD) to the list of "Tools integrating with Airflow". It leverages Listeners capabilities of Airflow. Implemented with

[GitHub] [airflow] potiuk commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
potiuk commented on code in PR #33893: URL: https://github.com/apache/airflow/pull/33893#discussion_r1309154222 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -76,7 +76,6 @@ The possible states for a Task Instance are: * ``queued``: The task has been assigned to an

[GitHub] [airflow] potiuk commented on pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
potiuk commented on PR #33893: URL: https://github.com/apache/airflow/pull/33893#issuecomment-1697867204 > We need also to update the diagram in the page Diagram has been already updated in the previous PR :) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] eladkal commented on pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
eladkal commented on PR #33893: URL: https://github.com/apache/airflow/pull/33893#issuecomment-1697865311 We need also to update the diagram in the page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] iw-pavan opened a new issue, #33896: Scheduler and triggerer crashes in daemon mode when statsd metrics are enabled.

2023-08-29 Thread via GitHub
iw-pavan opened a new issue, #33896: URL: https://github.com/apache/airflow/issues/33896 ### Apache Airflow version 2.7.0 ### What happened When we run scheduler/triggerer with statsd metrics enabled it crashes with db commit errors with -D argument. But when we run

[GitHub] [airflow] jedcunningham merged pull request #33892: Add minimum requirement for sqlalchemy to 1.4.24

2023-08-29 Thread via GitHub
jedcunningham merged PR #33892: URL: https://github.com/apache/airflow/pull/33892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (fe27031382 -> bfab7daffe)

2023-08-29 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from fe27031382 Fix MappedTaskGroup tasks not respecting upstream dependency (#33732) add bfab7daffe Add

[GitHub] [airflow] Taragolis commented on pull request #33720: Optimise and migrate to SA2-compatible syntax for TaskReschedule

2023-08-29 Thread via GitHub
Taragolis commented on PR #33720: URL: https://github.com/apache/airflow/pull/33720#issuecomment-1697845252 > wit flakey behaviour: 5-10 sequential fail, 2-3 success, and again failure 臘 臘 臘 臘 臘 臘 臘 臘 臘 臘 臘 臘 臘 I've forgot about assignments: `stmt = stmt.order_by()` instead of

[GitHub] [airflow] buu-nguyen opened a new issue, #33895: Search Function Not Working in Airflow UI

2023-08-29 Thread via GitHub
buu-nguyen opened a new issue, #33895: URL: https://github.com/apache/airflow/issues/33895 ### Apache Airflow version 2.7.0 ### What happened Actual Behavior: Upon entering a keyword in the search bar, no search results are shown, and the UI remains unchanged. The

[GitHub] [airflow] ephraimbuddy closed issue #33446: Task group gets marked as upstream_failed when dynamically mapped with expand_kwargs even though all upstream tasks were skipped or successfully

2023-08-29 Thread via GitHub
ephraimbuddy closed issue #33446: Task group gets marked as upstream_failed when dynamically mapped with expand_kwargs even though all upstream tasks were skipped or successfully finished. URL: https://github.com/apache/airflow/issues/33446 -- This is an automated message from the Apache

[GitHub] [airflow] ephraimbuddy merged pull request #33732: Fix MappedTaskGroup tasks not respecting upstream dependency

2023-08-29 Thread via GitHub
ephraimbuddy merged PR #33732: URL: https://github.com/apache/airflow/pull/33732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] vincbeck commented on a diff in pull request #33213: Implement `is_authorized()` in auth manager

2023-08-29 Thread via GitHub
vincbeck commented on code in PR #33213: URL: https://github.com/apache/airflow/pull/33213#discussion_r1309104106 ## airflow/auth/managers/models/resource_details.py: ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[airflow] branch main updated: Fix MappedTaskGroup tasks not respecting upstream dependency (#33732)

2023-08-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fe27031382 Fix MappedTaskGroup tasks not

[GitHub] [airflow] vincbeck merged pull request #33828: Add Amazon SNS Notifier

2023-08-29 Thread via GitHub
vincbeck merged PR #33828: URL: https://github.com/apache/airflow/pull/33828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] vincbeck commented on pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
vincbeck commented on PR #28900: URL: https://github.com/apache/airflow/pull/28900#issuecomment-169827 Thanks for the review @potiuk ! Yep, the explanations are very clear and helped me a lot while addressing them. It should be okay now besides one comment, which I rather do in a

[airflow] branch main updated (1f0e673ce3 -> 869f84e9c3)

2023-08-29 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 1f0e673ce3 Suspend qubole provider (#33889) add 869f84e9c3 Add Amazon SNS Notifier (#33828) No new revisions

[GitHub] [airflow] Taragolis commented on issue #33894: AWS connection doesn't convert verify option to bool

2023-08-29 Thread via GitHub
Taragolis commented on issue #33894: URL: https://github.com/apache/airflow/issues/33894#issuecomment-1697774801 @derbeneviv Did you try to use ```"verify": true``` instead? "True" it is not valid JSON boolean, it is expected literals `true` or `false` -- This is an automated message

[GitHub] [airflow] ephraimbuddy commented on issue #33875: Status of testing Providers that were prepared on August 29, 2023

2023-08-29 Thread via GitHub
ephraimbuddy commented on issue #33875: URL: https://github.com/apache/airflow/issues/33875#issuecomment-1697774040 Verified the changes in https://github.com/apache/airflow/pull/33851 and https://github.com/apache/airflow/pull/33457 -- This is an automated message from the Apache Git

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1309075951 ## airflow/models/taskinstance.py: ## @@ -371,6 +373,802 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance,

[GitHub] [airflow] potiuk commented on pull request #33715: allow impersonation_chain to be set on Google Cloud connection

2023-08-29 Thread via GitHub
potiuk commented on PR #33715: URL: https://github.com/apache/airflow/pull/33715#issuecomment-1697754997 You can click "Suggest Changes on this page" to see where it comes from - you will get PR open in the right file when you use it -- This is an automated message from the Apache Git

[GitHub] [airflow] Bisk1 commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
Bisk1 commented on code in PR #33893: URL: https://github.com/apache/airflow/pull/33893#discussion_r1309061275 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -76,7 +76,6 @@ The possible states for a Task Instance are: * ``queued``: The task has been assigned to an

[GitHub] [airflow] potiuk commented on pull request #33715: allow impersonation_chain to be set on Google Cloud connection

2023-08-29 Thread via GitHub
potiuk commented on PR #33715: URL: https://github.com/apache/airflow/pull/33715#issuecomment-1697750415 https://airflow.apache.org/docs/apache-airflow-providers-google/stable/connections/gcp.html -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] Bisk1 commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
Bisk1 commented on code in PR #33893: URL: https://github.com/apache/airflow/pull/33893#discussion_r1309061275 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -76,7 +76,6 @@ The possible states for a Task Instance are: * ``queued``: The task has been assigned to an

[GitHub] [airflow] Bisk1 commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
Bisk1 commented on code in PR #33893: URL: https://github.com/apache/airflow/pull/33893#discussion_r1309061275 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -76,7 +76,6 @@ The possible states for a Task Instance are: * ``queued``: The task has been assigned to an

[GitHub] [airflow] boring-cyborg[bot] commented on issue #33894: AWS connection doesn't convert verify option to bool

2023-08-29 Thread via GitHub
boring-cyborg[bot] commented on issue #33894: URL: https://github.com/apache/airflow/issues/33894#issuecomment-1697745333 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[GitHub] [airflow] potiuk merged pull request #33889: Suspend qubole provider

2023-08-29 Thread via GitHub
potiuk merged PR #33889: URL: https://github.com/apache/airflow/pull/33889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (3b3650e87d -> 1f0e673ce3)

2023-08-29 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 3b3650e87d fix entry in Google provider CHANGELOG.rst (#33890) add 1f0e673ce3 Suspend qubole provider (#33889)

[GitHub] [airflow] melugoyal commented on pull request #33715: allow impersonation_chain to be set on Google Cloud connection

2023-08-29 Thread via GitHub
melugoyal commented on PR #33715: URL: https://github.com/apache/airflow/pull/33715#issuecomment-1697742585 @potiuk where would such a migration doc be added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] derbeneviv opened a new issue, #33894: AWS connection doesn't convert verify option to bool

2023-08-29 Thread via GitHub
derbeneviv opened a new issue, #33894: URL: https://github.com/apache/airflow/issues/33894 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened # Versions: * Apache airflow 2.5.3 (can't update to later right now) *

[GitHub] [airflow] jedcunningham commented on a diff in pull request #33889: Suspend qubole provider

2023-08-29 Thread via GitHub
jedcunningham commented on code in PR #33889: URL: https://github.com/apache/airflow/pull/33889#discussion_r1309052872 ## airflow/providers/SUSPENDING_AND_RESUMING_PROVIDERS.rst: ## @@ -20,7 +20,7 @@ Suspending providers As of April 2023, we have the possibility to suspend

[GitHub] [airflow] uranusjr commented on a diff in pull request #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
uranusjr commented on code in PR #33893: URL: https://github.com/apache/airflow/pull/33893#discussion_r1309052714 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -76,7 +76,6 @@ The possible states for a Task Instance are: * ``queued``: The task has been assigned to an

[GitHub] [airflow] Bisk1 commented on pull request #33746: Refactor: remove unused state - SHUTDOWN

2023-08-29 Thread via GitHub
Bisk1 commented on PR #33746: URL: https://github.com/apache/airflow/pull/33746#issuecomment-1697735376 > This requires also documentation update https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/tasks.html#task-instances @eladkal

[GitHub] [airflow] Bisk1 opened a new pull request, #33893: Cleanup: remove remnants of 'shutdown' task instance state

2023-08-29 Thread via GitHub
Bisk1 opened a new pull request, #33893: URL: https://github.com/apache/airflow/pull/33893 Follow-up of #33746 - several mentions of 'shutdown' task were left behind, e.g. in docs --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1309045128 ## airflow/models/taskinstance.py: ## @@ -371,6 +373,802 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance,

[GitHub] [airflow] raphaelsimeon commented on issue #33688: Tasks taking too long time after 2.7.0 Airflow update

2023-08-29 Thread via GitHub
raphaelsimeon commented on issue #33688: URL: https://github.com/apache/airflow/issues/33688#issuecomment-1697700661 Hello there ! Following [this Slack discussion,](https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1693298060235109) I'm adding a few logs for a similar issue : -

[GitHub] [airflow] potiuk commented on issue #33887: Airflow db migrate AttributeError: 'Session' object has no attribute 'scalars'

2023-08-29 Thread via GitHub
potiuk commented on issue #33887: URL: https://github.com/apache/airflow/issues/33887#issuecomment-1697687135 Yeah. Constraints woudl work as @Taragolis mentione.. Also manually bumping sqlalchemy should help. However we shoudl indeed have a minimum version set if we are relying on

[GitHub] [airflow] potiuk opened a new pull request, #33892: Add minimum requirement for sqlalchemy to 1.4.24

2023-08-29 Thread via GitHub
potiuk opened a new pull request, #33892: URL: https://github.com/apache/airflow/pull/33892 Some of the recent sqlalchemy 2 changes used features tha were added in 1.4.24 sqlalchemy (session.scalar). We need to bump the minimum version to avoid accidental problems with people

[GitHub] [airflow] potiuk commented on pull request #33889: Suspend qubole provider

2023-08-29 Thread via GitHub
potiuk commented on PR #33889: URL: https://github.com/apache/airflow/pull/33889#issuecomment-1697658002 Way better: ![image](https://github.com/apache/airflow/assets/595491/143aef28-8813-4f13-95e7-1de3a8699474) -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] potiuk commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
potiuk commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308997364 ## airflow/models/taskinstance.py: ## @@ -186,23 +188,23 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

2023-08-29 Thread via GitHub
vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308992469 ## airflow/models/taskinstance.py: ## @@ -186,23 +188,23 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def

[GitHub] [airflow] abhishekbhakat commented on pull request #33885: Raise variable not found if session returns empty

2023-08-29 Thread via GitHub
abhishekbhakat commented on PR #33885: URL: https://github.com/apache/airflow/pull/33885#issuecomment-1697635902 @potiuk Added the test. And tried with removing the code, below is the result with test failing. ``` FAILED

[GitHub] [airflow] Github-dm-CDE commented on issue #33688: Tasks taking too long time after 2.7.0 Airflow update

2023-08-29 Thread via GitHub
Github-dm-CDE commented on issue #33688: URL: https://github.com/apache/airflow/issues/33688#issuecomment-1697628036 > Any chance to see the logs with debug turned on for tasks as asked above @Github-dm-CDE ? And a bit more info on the deployment of yours ? Regarding the logs, I

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #33732: Fix MappedTaskGroup tasks not respecting upstream dependency

2023-08-29 Thread via GitHub
ephraimbuddy commented on code in PR #33732: URL: https://github.com/apache/airflow/pull/33732#discussion_r1308961539 ## airflow/decorators/task_group.py: ## @@ -132,11 +132,14 @@ def expand(self, **kwargs: OperatorExpandArgument) -> DAGNode:

[GitHub] [airflow] potiuk commented on pull request #33889: Suspend qubole provider

2023-08-29 Thread via GitHub
potiuk commented on PR #33889: URL: https://github.com/apache/airflow/pull/33889#issuecomment-1697603704 Interestingly enough @Taragolis boto is held still by something else as well: https://github.com/apache/airflow/actions/runs/6012796736/job/16308910701#step:5:17858 (but

[GitHub] [airflow] Taragolis commented on issue #33887: Airflow db migrate AttributeError: 'Session' object has no attribute 'scalars'

2023-08-29 Thread via GitHub
Taragolis commented on issue #33887: URL: https://github.com/apache/airflow/issues/33887#issuecomment-1697596433 @aipatr which version of `sqlalchemy` you have installed in Airflow environment? I guess it less then

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #33732: Fix MappedTaskGroup tasks not respecting upstream dependency

2023-08-29 Thread via GitHub
ephraimbuddy commented on code in PR #33732: URL: https://github.com/apache/airflow/pull/33732#discussion_r1308946744 ## airflow/decorators/task_group.py: ## @@ -132,11 +132,14 @@ def expand(self, **kwargs: OperatorExpandArgument) -> DAGNode:

[GitHub] [airflow] uranusjr commented on a diff in pull request #33732: Fix MappedTaskGroup tasks not respecting upstream dependency

2023-08-29 Thread via GitHub
uranusjr commented on code in PR #33732: URL: https://github.com/apache/airflow/pull/33732#discussion_r1308941671 ## airflow/decorators/task_group.py: ## @@ -132,11 +132,14 @@ def expand(self, **kwargs: OperatorExpandArgument) -> DAGNode:

[GitHub] [airflow] uranusjr commented on a diff in pull request #33732: Fix MappedTaskGroup tasks not respecting upstream dependency

2023-08-29 Thread via GitHub
uranusjr commented on code in PR #33732: URL: https://github.com/apache/airflow/pull/33732#discussion_r1308938544 ## airflow/decorators/task_group.py: ## @@ -132,11 +132,14 @@ def expand(self, **kwargs: OperatorExpandArgument) -> DAGNode:

[GitHub] [airflow] uranusjr commented on a diff in pull request #33732: Fix MappedTaskGroup tasks not respecting upstream dependency

2023-08-29 Thread via GitHub
uranusjr commented on code in PR #33732: URL: https://github.com/apache/airflow/pull/33732#discussion_r1308938544 ## airflow/decorators/task_group.py: ## @@ -132,11 +132,14 @@ def expand(self, **kwargs: OperatorExpandArgument) -> DAGNode:

[GitHub] [airflow] potiuk commented on pull request #33885: Raise variable not found if session returns empty

2023-08-29 Thread via GitHub
potiuk commented on PR #33885: URL: https://github.com/apache/airflow/pull/33885#issuecomment-1697574875 Is it possible to add a test for that one? Should be easy following other tests in https://github.com/apache/airflow/tree/main/tests/api_connexion/endpoints. - and at the same time you

[GitHub] [airflow] phanikumv closed pull request #33700: Refactor Sqlalchemy queries to 2.0 style (Part 8)

2023-08-29 Thread via GitHub
phanikumv closed pull request #33700: Refactor Sqlalchemy queries to 2.0 style (Part 8) URL: https://github.com/apache/airflow/pull/33700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated (0d49d1fed9 -> 3b3650e87d)

2023-08-29 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 0d49d1fed9 Allow to disable openlineage at operator level (#33685) add 3b3650e87d fix entry in Google provider

[GitHub] [airflow] eladkal merged pull request #33890: fix entry in Google provider CHANGELOG.rst

2023-08-29 Thread via GitHub
eladkal merged PR #33890: URL: https://github.com/apache/airflow/pull/33890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] phanikumv opened a new pull request, #33891: SqlAlchemy 2.0 changes for `taskreschedule.py`

2023-08-29 Thread via GitHub
phanikumv opened a new pull request, #33891: URL: https://github.com/apache/airflow/pull/33891 related to: https://github.com/apache/airflow/issues/28723 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] Taragolis commented on a diff in pull request #33881: Remove tasks annotation in `AppflowHook`

2023-08-29 Thread via GitHub
Taragolis commented on code in PR #33881: URL: https://github.com/apache/airflow/pull/33881#discussion_r1308834912 ## airflow/providers/amazon/aws/hooks/appflow.py: ## @@ -24,7 +24,6 @@ if TYPE_CHECKING: from mypy_boto3_appflow.client import AppflowClient -from

  1   2   3   >