Re: [PR] Refactor use Path.touch to create empty files [airflow]

2023-10-13 Thread via GitHub
uranusjr commented on code in PR #34379: URL: https://github.com/apache/airflow/pull/34379#discussion_r1357853624 ## airflow/utils/log/file_task_handler.py: ## @@ -479,9 +479,9 @@ def _init_file(self, ti): self._prepare_log_folder(Path(full_path).parent) if n

Re: [PR] Created INSTALL.md and working to improve it [airflow]

2023-10-13 Thread via GitHub
uranusjr commented on code in PR #34714: URL: https://github.com/apache/airflow/pull/34714#discussion_r1357874912 ## INSTALL.md: ## @@ -0,0 +1,236 @@ +# INSTALL / BUILD instructions for Apache Airflow + +This is a generic installation method that requires a number of dependencie

[PR] Add trigger as a valid option for the db clean command [airflow]

2023-10-13 Thread via GitHub
syedahsn opened a new pull request, #34908: URL: https://github.com/apache/airflow/pull/34908 closes: #34906 This is a potential solution to the issue mentioned above. There is an existing command, `airflow db clean` that removes old records from the DB. This command currently does not

[I] apache-airflow-providers-google 10.9.0 fails to list GCS objects [airflow]

2023-10-13 Thread via GitHub
atrbgithub opened a new issue, #34909: URL: https://github.com/apache/airflow/issues/34909 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened This affects Airflow 2.7.2. It appears that the 10.9.0 version of apache-airflow-provide

Re: [PR] Add example PSRP DAG [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on code in PR #34907: URL: https://github.com/apache/airflow/pull/34907#discussion_r1357983602 ## tests/system/providers/microsoft/psrp/example_psrp.py: ## @@ -0,0 +1,79 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

[PR] Add missing header into `common.sql` changelog [airflow]

2023-10-13 Thread via GitHub
Taragolis opened a new pull request, #34910: URL: https://github.com/apache/airflow/pull/34910 This changes fix incorrect rendering **Basics** documentation menu, and return back change log link Doc render samples **Was** ![image](https://github.com/ap

Re: [PR] Use base classes for AWS Lambda Operators/Sensors [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on code in PR #34890: URL: https://github.com/apache/airflow/pull/34890#discussion_r1358018273 ## airflow/providers/amazon/aws/operators/lambda_function.py: ## @@ -62,13 +61,15 @@ class LambdaCreateFunctionOperator(BaseOperator): :param aws_conn_id: The

Re: [PR] Add example PSRP DAG [airflow]

2023-10-13 Thread via GitHub
arjunanan6 commented on code in PR #34907: URL: https://github.com/apache/airflow/pull/34907#discussion_r1358041410 ## tests/system/providers/microsoft/psrp/example_psrp.py: ## @@ -0,0 +1,79 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

Re: [PR] Add example PSRP DAG [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on code in PR #34907: URL: https://github.com/apache/airflow/pull/34907#discussion_r1358055068 ## tests/system/providers/microsoft/psrp/example_psrp.py: ## @@ -0,0 +1,79 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Add example PSRP DAG [airflow]

2023-10-13 Thread via GitHub
arjunanan6 commented on code in PR #34907: URL: https://github.com/apache/airflow/pull/34907#discussion_r1358058876 ## tests/system/providers/microsoft/psrp/example_psrp.py: ## @@ -0,0 +1,79 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

Re: [PR] Fix hardcoded container name in remote logging option for Azure Blob Storage [airflow]

2023-10-13 Thread via GitHub
eladkal commented on code in PR #32779: URL: https://github.com/apache/airflow/pull/32779#discussion_r1358064357 ## airflow/providers/microsoft/azure/provider.yaml: ## @@ -298,3 +298,17 @@ logging: extra-links: - airflow.providers.microsoft.azure.operators.data_factory.Az

Re: [PR] Glue DataBrew operator [airflow]

2023-10-13 Thread via GitHub
eladkal commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1358067248 ## airflow/providers/amazon/aws/hooks/databrew.py: ## @@ -0,0 +1,68 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] allow changing of config file from default for the KubernetesResourceBaseOperator [airflow]

2023-10-13 Thread via GitHub
eladkal commented on PR #34819: URL: https://github.com/apache/airflow/pull/34819#issuecomment-1761271366 tests are failing @chapm250 can you look into it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Add example PSRP DAG [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on code in PR #34907: URL: https://github.com/apache/airflow/pull/34907#discussion_r1358071018 ## docs/apache-airflow-providers-microsoft-psrp/index.rst: ## @@ -48,6 +48,7 @@ :maxdepth: 1 :caption: Resources +Example DAGs

Re: [PR] Add example PSRP DAG [airflow]

2023-10-13 Thread via GitHub
arjunanan6 commented on code in PR #34907: URL: https://github.com/apache/airflow/pull/34907#discussion_r1358074815 ## docs/apache-airflow-providers-microsoft-psrp/index.rst: ## @@ -48,6 +48,7 @@ :maxdepth: 1 :caption: Resources +Example DAGs

Re: [PR] Add example PSRP DAG [airflow]

2023-10-13 Thread via GitHub
arjunanan6 commented on code in PR #34907: URL: https://github.com/apache/airflow/pull/34907#discussion_r1358077521 ## docs/apache-airflow-providers-microsoft-psrp/index.rst: ## @@ -48,6 +48,7 @@ :maxdepth: 1 :caption: Resources +Example DAGs

Re: [PR] Add use_krb5ccache option to SparkSubmitHook [airflow]

2023-10-13 Thread via GitHub
eladkal commented on code in PR #34386: URL: https://github.com/apache/airflow/pull/34386#discussion_r1358077855 ## airflow/security/kerberos.py: ## @@ -59,10 +63,7 @@ def renew_from_kt(principal: str | None, keytab: str, exit_on_fail: bool = True) # minutes to give oursel

Re: [PR] Airflow 2.7.2 has been released [airflow]

2023-10-13 Thread via GitHub
ephraimbuddy commented on PR #34885: URL: https://github.com/apache/airflow/pull/34885#issuecomment-1761296831 I'm not sure why the build images workflow is getting cancelled. Any ideas? cc @potiuk -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Glue DataBrew operator [airflow]

2023-10-13 Thread via GitHub
ellisms commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1358091079 ## airflow/providers/amazon/aws/hooks/databrew.py: ## @@ -0,0 +1,68 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Add missing header into `common.sql` changelog [airflow]

2023-10-13 Thread via GitHub
eladkal merged PR #34910: URL: https://github.com/apache/airflow/pull/34910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow] branch main updated: Add missing header into `common.sql` changelog (#34910)

2023-10-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 128f6b9e40 Add missing header into `common.sql` ch

Re: [PR] Remove unused argument metadata from es_read and make clearly private [airflow]

2023-10-13 Thread via GitHub
eladkal merged PR #34790: URL: https://github.com/apache/airflow/pull/34790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow] branch main updated: Remove unused argument metadata from es_read and make clearly private (#34790)

2023-10-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0e5890bdcb Remove unused argument metadata from es

[PR] Update system tests for Google Sheets operators [airflow]

2023-10-13 Thread via GitHub
MaksYermak opened a new pull request, #34911: URL: https://github.com/apache/airflow/pull/34911 In this PR I have updated the system test for Google Sheets operators. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://gith

Re: [PR] Use None instead of empty data structures when no ElasticSearch logs [airflow]

2023-10-13 Thread via GitHub
eladkal commented on PR #34793: URL: https://github.com/apache/airflow/pull/34793#issuecomment-1761303968 @dstandish can you please rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] fix(gcp/op/vertex): typecast ListEndpoints to avoid DAG run blocker [airflow]

2023-10-13 Thread via GitHub
eladkal commented on PR #34582: URL: https://github.com/apache/airflow/pull/34582#issuecomment-1761320270 > > I think iter on ListEndpointsPager returns a list of ListEndpoints which needs a second iter to get Endpoint > > `ListEndpointsPager` actually returns an object of `ListEndpoi

Re: [PR] Refactor DataFusionInstanceLink usage [airflow]

2023-10-13 Thread via GitHub
eladkal merged PR #34514: URL: https://github.com/apache/airflow/pull/34514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow] branch main updated: Refactor DataFusionInstanceLink usage (#34514)

2023-10-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d27d0bb60b Refactor DataFusionInstanceLink usage (

[PR] Update docs errors.rst - Mention sentry "transport" configuration option [airflow]

2023-10-13 Thread via GitHub
luispedroemg opened a new pull request, #34912: URL: https://github.com/apache/airflow/pull/34912 Added reference to sentry "transport" configuration option and how to set it up. --- **^ Add meaningful description above** Read the **[Pull Request Gui

[PR] Add extra fields to plugins endpoint [airflow]

2023-10-13 Thread via GitHub
ephraimbuddy opened a new pull request, #34913: URL: https://github.com/apache/airflow/pull/34913 I added three extra fields, ti_deps, timetables, and listeners which I think are worth having since they will help in visualizing if those are included in a plugin. I also found out that

[PR] Type Check for retries [airflow]

2023-10-13 Thread via GitHub
kandharvishnu opened a new pull request, #34914: URL: https://github.com/apache/airflow/pull/34914 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guide

Re: [PR] Type Check for retries [airflow]

2023-10-13 Thread via GitHub
boring-cyborg[bot] commented on PR #34914: URL: https://github.com/apache/airflow/pull/34914#issuecomment-1761374358 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Create operators for VertexAI Pipeline Job [airflow]

2023-10-13 Thread via GitHub
MaksYermak opened a new pull request, #34915: URL: https://github.com/apache/airflow/pull/34915 In this PR I have added a new operators for working with Pipeline Job for Google Cloud Vertex AI service. --- **^ Add meaningful description above** Read the **[Pu

Re: [I] Scheduler is spending most of its time in clear_not_launched_queued_tasks function [airflow]

2023-10-13 Thread via GitHub
dirrao commented on issue #34877: URL: https://github.com/apache/airflow/issues/34877#issuecomment-1761396289 @ROVAN1220 Thanks for the inputs. I am working on the MR to address the performance issue. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Adding payload arg as a templated field for Synapse SparkBatchOperator [airflow]

2023-10-13 Thread via GitHub
phanikumv commented on code in PR #34896: URL: https://github.com/apache/airflow/pull/34896#discussion_r1358171259 ## airflow/providers/microsoft/azure/operators/synapse.py: ## @@ -49,6 +49,7 @@ class AzureSynapseRunSparkBatchOperator(BaseOperator): template_fields: Sequenc

Re: [PR] Error handling for when Azure container log cannot be read in properly. [airflow]

2023-10-13 Thread via GitHub
eladkal commented on PR #34627: URL: https://github.com/apache/airflow/pull/34627#issuecomment-1761406538 Merging after checking with @Taragolis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Error handling for when Azure container log cannot be read in properly. [airflow]

2023-10-13 Thread via GitHub
eladkal merged PR #34627: URL: https://github.com/apache/airflow/pull/34627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [I] Jobs in Azure Containers restart infinitely if logger crashes, despite retries being set to off. [airflow]

2023-10-13 Thread via GitHub
eladkal closed issue #34516: Jobs in Azure Containers restart infinitely if logger crashes, despite retries being set to off. URL: https://github.com/apache/airflow/issues/34516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Error handling for when Azure container log cannot be read in properly. [airflow]

2023-10-13 Thread via GitHub
boring-cyborg[bot] commented on PR #34627: URL: https://github.com/apache/airflow/pull/34627#issuecomment-1761406715 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

[airflow] branch main updated: Error handling for when Azure container log cannot be read in properly. (#34627)

2023-10-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 546c850a43 Error handling for when Azure container

[PR] Prepare docs 1st wave of Providers in October 2023 [airflow]

2023-10-13 Thread via GitHub
eladkal opened a new pull request, #34916: URL: https://github.com/apache/airflow/pull/34916 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)

[I] Contents of DAG files are assumed to have not changed [airflow]

2023-10-13 Thread via GitHub
indexKevinBoak opened a new issue, #34917: URL: https://github.com/apache/airflow/issues/34917 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened Version 2.1.4 A python file containing a single DAG definition was somehow lin

Re: [I] Contents of DAG files are assumed to have not changed [airflow]

2023-10-13 Thread via GitHub
boring-cyborg[bot] commented on issue #34917: URL: https://github.com/apache/airflow/issues/34917#issuecomment-1761419090 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] Type Check for retries [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on code in PR #34914: URL: https://github.com/apache/airflow/pull/34914#discussion_r1358185661 ## airflow/models/dag.py: ## @@ -475,6 +475,8 @@ def __init__( self.user_defined_filters = user_defined_filters if default_args and not isinstance

Re: [PR] Create operators for VertexAI Pipeline Job [airflow]

2023-10-13 Thread via GitHub
eladkal commented on code in PR #34915: URL: https://github.com/apache/airflow/pull/34915#discussion_r1358188397 ## airflow/providers/google/cloud/hooks/vertex_ai/pipeline_job.py: ## @@ -0,0 +1,414 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more co

Re: [I] Contents of DAG files are assumed to have not changed [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on issue #34917: URL: https://github.com/apache/airflow/issues/34917#issuecomment-1761434123 > Version 2.1.4 > A python file containing a single DAG definition was somehow linked to multiple DAGs. Could you provide simple examples which could be tested on modern

Re: [PR] Create operators for VertexAI Pipeline Job [airflow]

2023-10-13 Thread via GitHub
MaksYermak commented on code in PR #34915: URL: https://github.com/apache/airflow/pull/34915#discussion_r1358206459 ## airflow/providers/google/cloud/hooks/vertex_ai/pipeline_job.py: ## @@ -0,0 +1,414 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Prepare docs 1st wave of Providers in October 2023 [airflow]

2023-10-13 Thread via GitHub
josh-fell commented on PR #34916: URL: https://github.com/apache/airflow/pull/34916#issuecomment-1761453760 Naïve question, but should we be bumping the minor version of the providers rather than the patch version based on the policy or is there some nuance to the version change? > .

Re: [PR] Prepare docs 1st wave of Providers in October 2023 [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on code in PR #34916: URL: https://github.com/apache/airflow/pull/34916#discussion_r1358202810 ## airflow/providers/amazon/CHANGELOG.rst: ## @@ -26,6 +26,59 @@ Changelog - +8.8.0 +. + +.. note:: + This release of provider is only available fo

Re: [I] Scheduler is spending most of its time in clear_not_launched_queued_tasks function [airflow]

2023-10-13 Thread via GitHub
mattp- commented on issue #34877: URL: https://github.com/apache/airflow/issues/34877#issuecomment-1761502806 @dirrao I think that may be a chatgpt AI comment lol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Prepare docs 1st wave of Providers in October 2023 [airflow]

2023-10-13 Thread via GitHub
eladkal commented on code in PR #34916: URL: https://github.com/apache/airflow/pull/34916#discussion_r1358253594 ## airflow/providers/amazon/CHANGELOG.rst: ## @@ -26,6 +26,59 @@ Changelog - +8.8.0 +. + +.. note:: + This release of provider is only available for

Re: [PR] Use auth manager `is_authorized_` APIs to check user permissions in Rest API [airflow]

2023-10-13 Thread via GitHub
vincbeck commented on code in PR #34317: URL: https://github.com/apache/airflow/pull/34317#discussion_r1358254738 ## airflow/www/security_manager.py: ## @@ -738,24 +633,9 @@ def create_perm_vm_for_all_dag(self) -> None: def check_authorization( self, perms

Re: [PR] Prepare docs 1st wave of Providers in October 2023 [airflow]

2023-10-13 Thread via GitHub
eladkal commented on PR #34916: URL: https://github.com/apache/airflow/pull/34916#issuecomment-1761510806 > Naïve question, but should we be bumping the minor version of the providers rather than the patch version based on the policy or is there some nuance to the version change? yea

[airflow] 01/01: Temporarily disable PyPI constrainst generation

2023-10-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch temporarily-disable-pypi-constraints-generation in repository https://gitbox.apache.org/repos/asf/airflow.git commit f86e12cbe7f039894f4ad5acf1d6c69896062a6c Author: Jarek Potiuk AuthorDate: Fri

[PR] Temporarily disable PyPI constrainst generation [airflow]

2023-10-13 Thread via GitHub
potiuk opened a new pull request, #34918: URL: https://github.com/apache/airflow/pull/34918 PIP recently started backtracking with constraint generation and in order to fix it, more thorough investigation is needed. Source constraints generation works fine, only PyPI one is a problem.

[airflow] branch temporarily-disable-pypi-constraints-generation created (now f86e12cbe7)

2023-10-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch temporarily-disable-pypi-constraints-generation in repository https://gitbox.apache.org/repos/asf/airflow.git at f86e12cbe7 Temporarily disable PyPI constrainst generation This branch incl

Re: [PR] Airflow 2.7.2 has been released [airflow]

2023-10-13 Thread via GitHub
potiuk commented on PR #34885: URL: https://github.com/apache/airflow/pull/34885#issuecomment-1761546636 (at least CI image `pip` backtracting). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Airflow 2.7.2 has been released [airflow]

2023-10-13 Thread via GitHub
potiuk commented on PR #34885: URL: https://github.com/apache/airflow/pull/34885#issuecomment-1761546122 Still traveling, but this should fix it: https://github.com/apache/airflow/pull/34918 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Temporarily disable PyPI constrainst generation [airflow]

2023-10-13 Thread via GitHub
potiuk merged PR #34918: URL: https://github.com/apache/airflow/pull/34918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated: Temporarily disable PyPI constrainst generation (#34918)

2023-10-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new aad573e686 Temporarily disable PyPI constrainst gen

[PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
utkarsharma2 opened a new pull request, #34921: URL: https://github.com/apache/airflow/pull/34921 This PR is part of our larger effort to add first-class integrations to support LLMOps that was presented at Airflow Summit. This PR specifically adds the Cohere Provider. Cohere is a renowned

[PR] Airflow-34909 - Fix gcs listing - ensure blobs are loaded [airflow]

2023-10-13 Thread via GitHub
atrbgithub opened a new pull request, #34919: URL: https://github.com/apache/airflow/pull/34919 This fixes #34909 Performing the list of the blobs appears to force the blobs to be loaded rather than lazily loaded. --- **^ Add meaningful description abov

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
phanikumv commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358315651 ## docs/apache-airflow-providers-cohere/operators/cohere.rst: ## @@ -0,0 +1,57 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contr

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
phanikumv commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358315651 ## docs/apache-airflow-providers-cohere/operators/cohere.rst: ## @@ -0,0 +1,57 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contr

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
kaxil commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358319073 ## airflow/providers/cohere/provider.yaml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
utkarsharma2 commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358324760 ## docs/apache-airflow-providers-cohere/operators/cohere.rst: ## @@ -0,0 +1,57 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more co

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
pankajastro commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358325668 ## airflow/providers/cohere/provider.yaml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Add description to pools view [airflow]

2023-10-13 Thread via GitHub
vchiapaikeo commented on PR #34862: URL: https://github.com/apache/airflow/pull/34862#issuecomment-1761575624 Ah I see. Wasn't sure if you were referring to browser memory or server memory. I [profiled the render template code](https://gist.github.com/vchiapaikeo/b3b86f0566e8a52c8587a4ca7f3

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
pankajastro commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358322783 ## airflow/providers/cohere/hooks/cohere.py: ## @@ -0,0 +1,72 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Refactor: Remove trailing whitespace from strings [airflow]

2023-10-13 Thread via GitHub
eladkal commented on PR #34121: URL: https://github.com/apache/airflow/pull/34121#issuecomment-1761603105 lets see if https://github.com/apache/airflow/pull/34918 fix the build issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] Grouping of connections [airflow]

2023-10-13 Thread via GitHub
anthonynassar commented on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-1761580879 Any updates related to this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
kaxil commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358337751 ## airflow/providers/cohere/provider.yaml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[PR] Migrate legacy version of AI Platform Prediction to VertexAI [airflow]

2023-10-13 Thread via GitHub
VladaZakharova opened a new pull request, #34922: URL: https://github.com/apache/airflow/pull/34922 This PR migrates all MLEngine operators to use VertexAI. - creates new operators to list, add and remove version aliases in the Model. - new operator to set desired version of Model a

Re: [PR] Adding payload arg as a templated field for Synapse SparkBatchOperator [airflow]

2023-10-13 Thread via GitHub
narayave commented on code in PR #34896: URL: https://github.com/apache/airflow/pull/34896#discussion_r1358347543 ## airflow/providers/microsoft/azure/operators/synapse.py: ## @@ -49,6 +49,7 @@ class AzureSynapseRunSparkBatchOperator(BaseOperator): template_fields: Sequence

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
pankajastro commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358349958 ## airflow/providers/cohere/provider.yaml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Adding payload arg as a templated field for Synapse SparkBatchOperator [airflow]

2023-10-13 Thread via GitHub
narayave commented on PR #34896: URL: https://github.com/apache/airflow/pull/34896#issuecomment-1761629209 I'm a first-time contributor could I get help with creating a unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Support split_statements AthenaOperator [Amazon provider] [airflow]

2023-10-13 Thread via GitHub
eladkal commented on issue #34583: URL: https://github.com/apache/airflow/issues/34583#issuecomment-1761641778 > Another alternative would be to use [PyAthena](https://github.com/laughingman7743/PyAthena/) in conjunction with DBApiHook, but this would introduce an additional dependency.

Re: [I] Support Personal access token method for Tableau Connection [airflow]

2023-10-13 Thread via GitHub
baruch-shteken commented on issue #25904: URL: https://github.com/apache/airflow/issues/25904#issuecomment-1761646107 I started working on fixing this issue. I read the [Tableau Python SDK docs](https://tableau.github.io/server-client-python/docs/api-ref#personalaccesstokenauth-class) an

Re: [I] Airflow 2.7.1 can not start Scheduler & trigger [airflow]

2023-10-13 Thread via GitHub
Bisk1 commented on issue #34816: URL: https://github.com/apache/airflow/issues/34816#issuecomment-1761672715 I tested a couple of versions and can confirm it, the regression took place between 2.6.2 and 2.6.3 - in 2.6.3 (and later), after starting triggerer with -D option, `airflow-triggere

Re: [PR] Fix hardcoded container name in remote logging option for Azure Blob Storage [airflow]

2023-10-13 Thread via GitHub
eladkal merged PR #32779: URL: https://github.com/apache/airflow/pull/32779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow] branch main updated: Fix hardcoded container name in remote logging option for Azure Blob Storage (#32779)

2023-10-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8e383e87e1 Fix hardcoded container name in remote

Re: [PR] Airflow 2.7.2 has been released [airflow]

2023-10-13 Thread via GitHub
ephraimbuddy commented on PR #34885: URL: https://github.com/apache/airflow/pull/34885#issuecomment-1761711405 > Still traveling, but this should fix it: #34918 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Airflow 2.7.2 has been released [airflow]

2023-10-13 Thread via GitHub
ephraimbuddy merged PR #34885: URL: https://github.com/apache/airflow/pull/34885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

[airflow] branch main updated: Airflow 2.7.2 has been released (#34885)

2023-10-13 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5c63bb1a6e Airflow 2.7.2 has been released

[PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-13 Thread via GitHub
vincbeck opened a new pull request, #34924: URL: https://github.com/apache/airflow/pull/34924 Multiple authentications are possible for the Rest API. [See documentation](https://airflow.apache.org/docs/apache-airflow/stable/security/api.html). With AIP-56, all these configurations besides t

[PR] Update dags.rst docs to put SubDag deprecation note right after the SubDag… [airflow]

2023-10-13 Thread via GitHub
jayljohnson opened a new pull request, #34925: URL: https://github.com/apache/airflow/pull/34925 … section heading To save time for people by letting them know up front that SubDag feature is deprecated and TaskGroup's should be used instead. ---

Re: [PR] Update dags.rst docs to put SubDag deprecation note right after the SubDag… [airflow]

2023-10-13 Thread via GitHub
boring-cyborg[bot] commented on PR #34925: URL: https://github.com/apache/airflow/pull/34925#issuecomment-1761726484 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Remove offset-based pagination from `list_jobs` function in `DatabricksHook` [airflow]

2023-10-13 Thread via GitHub
oleksiidav opened a new pull request, #34926: URL: https://github.com/apache/airflow/pull/34926 Databricks has deprecated the offset parameter from [ListJobs API](https://docs.databricks.com/api/workspace/jobs/list), and to soften and control the inevitable breaking change for Airflow users

Re: [PR] Tableau_conn refreshes for every api call to support PAT [airflow]

2023-10-13 Thread via GitHub
boring-cyborg[bot] commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1761731423 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Tableau_conn refreshes for every api call to support PAT [airflow]

2023-10-13 Thread via GitHub
baruch-shteken opened a new pull request, #34927: URL: https://github.com/apache/airflow/pull/34927 closes: #25904 I read the [Tableau Python SDK docs](https://tableau.github.io/server-client-python/docs/api-ref#personalaccesstokenauth-class) and I didn't see any mean

Re: [PR] Remove offset-based pagination from `list_jobs` function in `DatabricksHook` [airflow]

2023-10-13 Thread via GitHub
oleksiidav commented on PR #34926: URL: https://github.com/apache/airflow/pull/34926#issuecomment-1761740255 @alexott could you please take a look and assign a maintainer to review if you can? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] Sets default waiter duration to 70 days [airflow]

2023-10-13 Thread via GitHub
123MwanjeMike opened a new pull request, #34928: URL: https://github.com/apache/airflow/pull/34928 Closes #34889 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull

Re: [PR] Sets default waiter duration to 70 days [airflow]

2023-10-13 Thread via GitHub
boring-cyborg[bot] commented on PR #34928: URL: https://github.com/apache/airflow/pull/34928#issuecomment-1761752013 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

Re: [I] Airflow 2.7.1 can not start Scheduler & trigger [airflow]

2023-10-13 Thread via GitHub
ThuanDoHung commented on issue #34816: URL: https://github.com/apache/airflow/issues/34816#issuecomment-1761794857 > I tested a couple of versions and can confirm it, the regression took place between 2.6.2 and 2.6.3 - in 2.6.3 (and later), after starting triggerer with -D option, `airflow-

Re: [PR] Use auth manager `is_authorized_` APIs to check user permissions in Rest API [airflow]

2023-10-13 Thread via GitHub
vincbeck commented on code in PR #34317: URL: https://github.com/apache/airflow/pull/34317#discussion_r1358503642 ## airflow/www/extensions/init_jinja_globals.py: ## @@ -69,10 +70,13 @@ def prepare_jinja_globals(): "git_version": git_version, "k8s_or_k8

Re: [PR] Remove offset-based pagination from `list_jobs` function in `DatabricksHook` [airflow]

2023-10-13 Thread via GitHub
eladkal commented on PR #34926: URL: https://github.com/apache/airflow/pull/34926#issuecomment-1761820002 > This is a follow-up to https://github.com/apache/airflow/pull/33472. Airflow users passing offsets to list_jobs have been receiving deprecation warnings for the last month. htt

Re: [PR] Add Cohere Provider [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on code in PR #34921: URL: https://github.com/apache/airflow/pull/34921#discussion_r1358511709 ## airflow/providers/cohere/hooks/cohere.py: ## @@ -0,0 +1,72 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agr

Re: [PR] Enable pgvector support for Postgres provider [airflow]

2023-10-13 Thread via GitHub
Taragolis commented on code in PR #34891: URL: https://github.com/apache/airflow/pull/34891#discussion_r1358562950 ## airflow/providers/postgres/operators/postgres.py: ## @@ -82,3 +87,61 @@ def __init__( AirflowProviderDeprecationWarning, stacklevel=2,

Re: [PR] Use auth manager `is_authorized_` APIs to check user permissions in Rest API [airflow]

2023-10-13 Thread via GitHub
vincbeck commented on code in PR #34317: URL: https://github.com/apache/airflow/pull/34317#discussion_r1358577475 ## airflow/www/extensions/init_jinja_globals.py: ## @@ -69,10 +70,13 @@ def prepare_jinja_globals(): "git_version": git_version, "k8s_or_k8

Re: [I] Airflow retries despite setting retries = 0 [airflow]

2023-10-13 Thread via GitHub
boring-cyborg[bot] commented on issue #34929: URL: https://github.com/apache/airflow/issues/34929#issuecomment-1761955392 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

  1   2   3   >