gbonazzoli opened a new issue, #34937:
URL: https://github.com/apache/airflow/issues/34937
### Official Helm Chart version
1.11.0 (latest released)
### Apache Airflow version
2.7.1
### Kubernetes Version
1.28.2
### Helm Chart configuration
The
tadeha opened a new pull request, #876:
URL: https://github.com/apache/airflow-site/pull/876
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
tadeha commented on PR #876:
URL: https://github.com/apache/airflow-site/pull/876#issuecomment-1762702650
We at Snapp would like to share how using Airflow has helped us save time
and resources on various tasks.
--
This is an automated message from the Apache Git Service.
To respond to th
eladkal merged PR #34911:
URL: https://github.com/apache/airflow/pull/34911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new b067051d3b Update system tests for Google Sheets o
zechigan commented on issue #23361:
URL: https://github.com/apache/airflow/issues/23361#issuecomment-1762710445
> Just to follow up here on the deadlock issue I saw which, I think, is
unrelated to the load issues associated with the new GridView though I'm happy
to hear those will be fixed
eladkal closed issue #34820: Azure Container Instance Operator uses deprecated
"network profile" arg
URL: https://github.com/apache/airflow/issues/34820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
eladkal commented on issue #34820:
URL: https://github.com/apache/airflow/issues/34820#issuecomment-1762713323
closing as task is completed and it seems more like a support question.
If further support is needed please use Github Discussion / Stackoverflow
--
This is an automated messag
eladkal opened a new pull request, #34938:
URL: https://github.com/apache/airflow/pull/34938
Following https://github.com/apache/airflow/pull/33956 PR
https://github.com/aws/serverless-application-model/pull/3282 has been merged
and released in
https://github.com/aws/serverless-application
eladkal commented on PR #34137:
URL: https://github.com/apache/airflow/pull/34137#issuecomment-1762776491
> Apart from the missing tests, what else needs to be fixed?
I think that is all but we will take closer look in 2nd review once
everything is ready
--
This is an automated mes
ealebed commented on issue #34930:
URL: https://github.com/apache/airflow/issues/34930#issuecomment-1762787572
**apache-airflow-providers-samba==4.3.0rc1** has been tested with our
examples DAGs (on staging Airflow and test Google Cloud Composer environments)
--
This is an automated messa
arjunanan6 commented on PR #34907:
URL: https://github.com/apache/airflow/pull/34907#issuecomment-1762822249
@Taragolis Looks like all tests pass now, and the docs look okay locally as
well. Is this ready?
--
This is an automated message from the Apache Git Service.
To respond to the mes
hussein-awala opened a new pull request, #34939:
URL: https://github.com/apache/airflow/pull/34939
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
hussein-awala opened a new pull request, #34940:
URL: https://github.com/apache/airflow/pull/34940
This PR moves checking the read access on DAG resource to `requires_access`
when `dag_id` parameter is not None, it's not a bug fix, both versions of code
do the exact same thing.
--
This
potiuk opened a new pull request, #34941:
URL: https://github.com/apache/airflow/pull/34941
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*
potiuk commented on issue #34816:
URL: https://github.com/apache/airflow/issues/34816#issuecomment-1762994839
Very cool analysis indeed. It all makes perfect sense. Thanks for both -
analysis and the fix!
--
This is an automated message from the Apache Git Service.
To respond to the messa
potiuk merged PR #34931:
URL: https://github.com/apache/airflow/pull/34931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk closed issue #34816: Airflow 2.7.1 can not start Scheduler & trigger
URL: https://github.com/apache/airflow/issues/34816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 9c1e8c2830 Fix triggerer thread crash in daemon mod
cjames23 commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1762995522
If the checks fail after this merge from main do you want me to include any
fixes here for the breeze mypy issue? I think it just needs to be changed from
ignore[misc] to ignore[attr-d
hussein-awala opened a new pull request, #34942:
URL: https://github.com/apache/airflow/pull/34942
This PR updates the required permissions for some endpoints:
- `update_dag_run_state`, `clear_dag_run` and `set_dag_run_note` -> it
replaces `can read dag` by `can edit dag` similar to wha
potiuk opened a new pull request, #34943:
URL: https://github.com/apache/airflow/pull/34943
WTForms 3.1.0 released 10th of October 2023 introduced a breaking change in
the way QuerySelectChoices fields are handled.
See details in https://github.com/dpgaspar/Flask-AppBuilder/issues/2137
eladkal commented on PR #34938:
URL: https://github.com/apache/airflow/pull/34938#issuecomment-1763053204
> LGTM! The failed tests and static checks don't seem related to this PR 🤔
Yes it will be fixed in https://github.com/apache/airflow/pull/34941
--
This is an automated message f
potiuk merged PR #34943:
URL: https://github.com/apache/airflow/pull/34943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 6b5d3697f5 Limit WTForms to below 3.1.0 (#34943)
6b
hussein-awala opened a new pull request, #34944:
URL: https://github.com/apache/airflow/pull/34944
This PR revert a change added by mistake to #33810, this change introduced a
bug in the dags count in the webserver home page.
(https://github.com/apache/airflow/commit/b470c6bdcc801bcd57c4008
Bisk1 opened a new pull request, #34945:
URL: https://github.com/apache/airflow/pull/34945
This refactoring is a follow-up of
https://github.com/apache/airflow/pull/34931
- unified approach to daemon process creation and moved all daemon-related
code to shared util daemon_utils.py.
-
Bisk1 commented on PR #34945:
URL: https://github.com/apache/airflow/pull/34945#issuecomment-1763057616
Tested those commands manually and looks good. Unfortunately standard Python
test frameworks can't handle forking processes well so no automated tests.
--
This is an automated message
potiuk opened a new pull request, #34946:
URL: https://github.com/apache/airflow/pull/34946
The sentry-sdk 1.32.0 released on 11th of October fixed handling of utcnow
to make it future-compatible with Python 3.12. The breadcrumb timestamp
returned was naive and now it is timezone aware with
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 91581c4991 Fix tests to respond to Python 3.12 hand
potiuk merged PR #34946:
URL: https://github.com/apache/airflow/pull/34946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
eladkal commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1763061002
> If the checks fail after this merge from main do you want me to include
any fixes here for the breeze mypy issue? I think it just needs to be changed
from ignore[misc] to ignore[attr-
potiuk commented on PR #34938:
URL: https://github.com/apache/airflow/pull/34938#issuecomment-1763061366
There are few other tests failing because other dependency releases also
caused problems:
WTForms breaking FAB: Workarounded in #34943
Sentry: #34946
I rebased also #34
potiuk commented on PR #34944:
URL: https://github.com/apache/airflow/pull/34944#issuecomment-1763061756
I wonder if we could have a unit test for that one to avoid similar
brekages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1359505166
##
airflow/www/security_manager.py:
##
@@ -269,125 +272,47 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_reada
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1359506835
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1359507417
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1359507817
##
airflow/auth/managers/fab/fab_auth_manager.py:
##
@@ -65,22 +79,24 @@
CLICommand,
)
-_MAP_METHOD_NAME_TO_FAB_ACTION_NAME: dict[ResourceMethod, str]
potiuk commented on PR #34942:
URL: https://github.com/apache/airflow/pull/34942#issuecomment-1763091741
Oh yeah. Two days ago I noticed the same problems while reviewing
https://github.com/apache/airflow/pull/34317
See my comments here:
https://github.com/apache/airflow/pull/34317#d
potiuk commented on PR #34942:
URL: https://github.com/apache/airflow/pull/34942#issuecomment-1763094792
(also this change can be cherry-pickable ot 2.7.3 so that's why I think it
should be merged first and cherry-picked) - provisionally marked it for 2.7.3.
--
This is an automated messag
potiuk commented on PR #34317:
URL: https://github.com/apache/airflow/pull/34317#issuecomment-1763096270
Re-reviewed, only few comments left. Also possibly
https://github.com/apache/airflow/pull/34942 should be merged first.
--
This is an automated message from the Apache Git Service.
To
hussein-awala commented on PR #34942:
URL: https://github.com/apache/airflow/pull/34942#issuecomment-1763105010
> And maybe it makes sense to merge this change first and
https://github.com/apache/airflow/pull/34317 afterwards to clearly separate fix
from the Auth manager refactor?
I
potiuk merged PR #34941:
URL: https://github.com/apache/airflow/pull/34941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1763123380
Fixed https://github.com/apache/airflow/pull/34941 and few other issues that
caused broken main. Rebasing/resolving conflicts (generally regenerating breeze
images with. `breeze setup re
potiuk commented on PR #34938:
URL: https://github.com/apache/airflow/pull/34938#issuecomment-1763123706
Rebased after merging https://github.com/apache/airflow/pull/34941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
pierrejeambrun merged PR #34933:
URL: https://github.com/apache/airflow/pull/34933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@a
This is an automated email from the ASF dual-hosted git repository.
pierrejeambrun pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 5155e7ff20 Update recording of SVG output to rich-click 1.7.0 (#34941)
add f8b947eeb5 D401 Support - WWW (
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new f8614c1bb3 Updating con
hussein-awala commented on PR #34944:
URL: https://github.com/apache/airflow/pull/34944#issuecomment-1763190947
> I wonder if we could have a unit test for that one to avoid similar
brekages?
I just added a test for it, it fails without this change.
--
This is an automated message
hussein-awala merged PR #34939:
URL: https://github.com/apache/airflow/pull/34939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ai
This is an automated email from the ASF dual-hosted git repository.
husseinawala pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 33ec72948f Return only the TIs of the readabl
RNHTTR opened a new pull request, #34947:
URL: https://github.com/apache/airflow/pull/34947
Closes: #33482
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pul
hussein-awala opened a new pull request, #34949:
URL: https://github.com/apache/airflow/pull/34949
In all the other views, we use the permission `delete` for muldelete action
and edit for all the set actions, but in SlaMiss, we use these permissions:
:
with pytest.raises(KeyError):
Variable.get
Zhenye-Na commented on code in PR #34791:
URL: https://github.com/apache/airflow/pull/34791#discussion_r1359746101
##
tests/cli/commands/test_variable_command.py:
##
@@ -49,6 +49,15 @@ def test_variables_set(self):
with pytest.raises(KeyError):
Variable.get
Zhenye-Na commented on code in PR #34791:
URL: https://github.com/apache/airflow/pull/34791#discussion_r1359746101
##
tests/cli/commands/test_variable_command.py:
##
@@ -49,6 +49,15 @@ def test_variables_set(self):
with pytest.raises(KeyError):
Variable.get
eladkal merged PR #34938:
URL: https://github.com/apache/airflow/pull/34938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 27443ec512 update moto version (#34938)
27443ec512
eladkal merged PR #34944:
URL: https://github.com/apache/airflow/pull/34944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 54e7e0824d Fix the dags count filter in webserver
kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1763290879
Prometheus and alertmanager are different apps. So they have different
app.kubernetes.io/name
https://github.com/prometheus-community/helm-charts/blob/f57ff6651817b23c21daa7d5c
63 matches
Mail list logo
