eladkal commented on code in PR #33796:
URL: https://github.com/apache/airflow/pull/33796#discussion_r1367842425
##
airflow/providers/apache/druid/CHANGELOG.rst:
##
@@ -27,6 +27,19 @@
Changelog
-
+4.0.0
+.
+
+Features
+
+
+* ``Add druid ingestion
eladkal commented on code in PR #33796:
URL: https://github.com/apache/airflow/pull/33796#discussion_r1367842425
##
airflow/providers/apache/druid/CHANGELOG.rst:
##
@@ -27,6 +27,19 @@
Changelog
-
+4.0.0
+.
+
+Features
+
+
+* ``Add druid ingestion
eladkal commented on PR #35059:
URL: https://github.com/apache/airflow/pull/35059#issuecomment-1774002746
Static checks are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
eladkal commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1367841685
##
airflow/providers/amazon/aws/operators/athena.py:
##
@@ -163,3 +167,132 @@ def on_kill(self) -> None:
"Polling Athena for query with id
eladkal commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1367841259
##
clients/gen/common.sh:
##
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
eladkal commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367840823
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
amoghrajesh commented on code in PR #34874:
URL: https://github.com/apache/airflow/pull/34874#discussion_r1367835597
##
airflow/providers/google/cloud/operators/cloud_run.py:
##
@@ -270,6 +271,7 @@ def __init__(
project_id: str,
region: str,
job_name:
zhenghanyang commented on issue #34950:
URL: https://github.com/apache/airflow/issues/34950#issuecomment-1773978385
Yes, then just comment following three lines in
"/home/airflow/.local/lib/python3.8/site-packages/flask_sqlalchemy/__init__.py",
webserver can work normally.
```python
dirrao commented on PR #34985:
URL: https://github.com/apache/airflow/pull/34985#issuecomment-1773974950
@hussein-awala Did you get a chance to test it? Any findings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on PR #33900:
URL: https://github.com/apache/airflow/pull/33900#issuecomment-1773951712
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for
github-actions[bot] closed pull request #33915: Take into account removed
upstream tasks for non-mapped tasks.
URL: https://github.com/apache/airflow/pull/33915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on PR #35106:
URL: https://github.com/apache/airflow/pull/35106#issuecomment-1773950066
Example flaky failure here:
https://github.com/apache/airflow/actions/runs/6598526836/job/17926985195
--
This is an automated message from the Apache Git Service.
To respond to the
potiuk opened a new pull request, #35106:
URL: https://github.com/apache/airflow/pull/35106
The `test_volume_mount` in k8s relied on "retrieved from mount\n" printed to
log as retrieved from K8S pod. Howver, due to the way how logs are retrieved,
sometimes the log printed contains the EOL
potiuk commented on PR #35105:
URL: https://github.com/apache/airflow/pull/35105#issuecomment-1773933323
This should be idone via try/finally or (better) following context_manager
(and tests shoudl be fixed)
--
This is an automated message from the Apache Git Service.
To respond to the
potiuk commented on PR #34635:
URL: https://github.com/apache/airflow/pull/34635#issuecomment-1773932972
docs need fixing for that one (and rebase).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 256cc90644 Updating
potiuk commented on PR #34809:
URL: https://github.com/apache/airflow/pull/34809#issuecomment-1773929085
I've added `full tests needed label adn rebased it -> likely the issues are
because only subset of docs was built due to selective checks. With `full tests
needed` label, all of them
Taragolis commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1367799591
##
airflow/providers/amazon/aws/operators/athena.py:
##
@@ -163,3 +167,132 @@ def on_kill(self) -> None:
"Polling Athena for query with id
bolkedebruin commented on code in PR #34729:
URL: https://github.com/apache/airflow/pull/34729#discussion_r1367798191
##
airflow/io/store/__init__.py:
##
Review Comment:
Yes I think it will be extended for example with `dataframe` and potentially
`catalog`.
--
This
eladkal commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1367768708
##
airflow/providers/amazon/aws/operators/athena.py:
##
@@ -163,3 +167,132 @@ def on_kill(self) -> None:
"Polling Athena for query with id
makrushin-evgenii commented on issue #35015:
URL: https://github.com/apache/airflow/issues/35015#issuecomment-1773911953
Submit a PR: https://github.com/apache/airflow/pull/35105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
makrushin-evgenii opened a new pull request, #35105:
URL: https://github.com/apache/airflow/pull/35105
This methods change current directory. And second call with same directory
will raise `no such file or directory` error. So I add `cwd` call to change to
origin directory
closes:
bolkedebruin commented on code in PR #34729:
URL: https://github.com/apache/airflow/pull/34729#discussion_r1367792359
##
tests/system/providers/common/io/example_file_transfer_local_to_s3.py:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
bolkedebruin commented on code in PR #34729:
URL: https://github.com/apache/airflow/pull/34729#discussion_r1367792301
##
airflow/providers/common/io/provider.yaml:
##
Review Comment:
That's okay to me, but don't consider it part of this PR. It's complex as it
is.
--
bolkedebruin commented on code in PR #34729:
URL: https://github.com/apache/airflow/pull/34729#discussion_r1367792225
##
airflow/io/store/path.py:
##
@@ -0,0 +1,680 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
bolkedebruin commented on code in PR #34729:
URL: https://github.com/apache/airflow/pull/34729#discussion_r1367791852
##
airflow/providers/common/io/operators/file_transfer.py:
##
@@ -0,0 +1,82 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
bolkedebruin commented on code in PR #34729:
URL: https://github.com/apache/airflow/pull/34729#discussion_r1367791730
##
airflow/io/__init__.py:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
eladkal commented on issue #35030:
URL: https://github.com/apache/airflow/issues/35030#issuecomment-1773910368
Thank you everyone.
Providers are released
I invite everyone to help improve providers for the next release, a list of
open issues can be found
eladkal closed issue #35030: Status of testing Providers that were prepared on
October 18, 2023
URL: https://github.com/apache/airflow/issues/35030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch add-documentation-2023-10-18
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
was 8dbe6f99a3 Add documentation for packages - 2023-10-18
The revisions that were on this
eladkal merged PR #877:
URL: https://github.com/apache/airflow-site/pull/877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Author: eladkal
Date: Sat Oct 21 19:58:51 2023
New Revision: 64654
Log:
Release Airflow Providers on 2023-10-21
Added:
release/airflow/providers/apache-airflow-providers-amazon-8.9.0.tar.gz
- copied unchanged from r64653,
jens-scheffler-bosch commented on PR #35085:
URL: https://github.com/apache/airflow/pull/35085#issuecomment-1773898293
2.8.0 is also okay. We have (for our setup) no dependency. No pressure from
my side.
--
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 7d80b7d5e4 Refactor shorter defaults (#34350)
eladkal merged PR #34350:
URL: https://github.com/apache/airflow/pull/34350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jens-scheffler-bosch commented on code in PR #34729:
URL: https://github.com/apache/airflow/pull/34729#discussion_r1367761520
##
airflow/io/store/__init__.py:
##
Review Comment:
What is the reason that we have a sub-package `store` below `airflow.io` if
there are no other
eladkal commented on PR #34809:
URL: https://github.com/apache/airflow/pull/34809#issuecomment-1773892784
> Thanks. What's the best way for me to retry the failed test?
Just did. Lets see
--
This is an automated message from the Apache Git Service.
To respond to the message, please
RNHTTR commented on PR #34809:
URL: https://github.com/apache/airflow/pull/34809#issuecomment-1773877109
Thanks. What's the best way for me to retry the failed test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
pierrejeambrun commented on PR #35086:
URL: https://github.com/apache/airflow/pull/35086#issuecomment-1773876805
Thank you for the reviews.
I agree, both updating the release process and image caching are important
and should be done in follow up steps.
@potiuk I will address
eladkal commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1367768793
##
airflow/providers/amazon/aws/operators/athena.py:
##
@@ -163,3 +167,132 @@ def on_kill(self) -> None:
"Polling Athena for query with id
eladkal commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1367768793
##
airflow/providers/amazon/aws/operators/athena.py:
##
@@ -163,3 +167,132 @@ def on_kill(self) -> None:
"Polling Athena for query with id
eladkal commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1367768708
##
airflow/providers/amazon/aws/operators/athena.py:
##
@@ -163,3 +167,132 @@ def on_kill(self) -> None:
"Polling Athena for query with id
eladkal commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1367768793
##
airflow/providers/amazon/aws/operators/athena.py:
##
@@ -163,3 +167,132 @@ def on_kill(self) -> None:
"Polling Athena for query with id
eladkal opened a new pull request, #35103:
URL: https://github.com/apache/airflow/pull/35103
See https://github.com/apache/airflow/pull/35090#discussion_r1367768708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
eladkal commented on code in PR #35090:
URL: https://github.com/apache/airflow/pull/35090#discussion_r1367768708
##
airflow/providers/amazon/aws/operators/athena.py:
##
@@ -163,3 +167,132 @@ def on_kill(self) -> None:
"Polling Athena for query with id
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1773860191
I've applied the fix here to truncate `airflow.fullname` to return at most
40 chars.
--
This is an automated message from the Apache Git Service.
To respond to the message,
hussein-awala commented on code in PR #34729:
URL: https://github.com/apache/airflow/pull/34729#discussion_r1367713729
##
airflow/io/__init__.py:
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
potiuk commented on PR #34350:
URL: https://github.com/apache/airflow/pull/34350#issuecomment-1773847455
Rebased to see if it works with latest main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on PR #34809:
URL: https://github.com/apache/airflow/pull/34809#issuecomment-1773846644
Rebased. Let's see if the fix works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on PR #35085:
URL: https://github.com/apache/airflow/pull/35085#issuecomment-1773846413
Well. Just changed it to 2.8.0. It won't make it to 2.7.3 because we have
quite heavy refactor for AIP-58 and we won't be able to cherry-pick this change
cleanly. Sorry for that :(
--
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new a562174296 Fix handling selective docs builds for
potiuk merged PR #35102:
URL: https://github.com/apache/airflow/pull/35102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jens-scheffler-bosch commented on PR #35085:
URL: https://github.com/apache/airflow/pull/35085#issuecomment-1773840832
FYI @wolfdn Your fix is going to be integrated in 2.7.3 :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 5973c6a217 Add instructions on how you can debug
potiuk merged PR #35101:
URL: https://github.com/apache/airflow/pull/35101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from dc2e8522bf Use airflow released in PyPI for k8s test environment
(#35099)
add 4198146f49 Upgrade to Flask
potiuk merged PR #35085:
URL: https://github.com/apache/airflow/pull/35085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on PR #35102:
URL: https://github.com/apache/airflow/pull/35102#issuecomment-1773834304
I found also a duplication @Taragolis @amoghrajesh -> so the docs build
params used their own version of converting from short-hand to filters, and I
know made them common.
--
This
potiuk commented on code in PR #35102:
URL: https://github.com/apache/airflow/pull/35102#discussion_r1367747958
##
dev/breeze/src/airflow_breeze/params/doc_build_params.py:
##
@@ -20,20 +20,30 @@
from dataclasses import dataclass
from airflow_breeze.branch_defaults import
amoghrajesh commented on code in PR #35102:
URL: https://github.com/apache/airflow/pull/35102#discussion_r1367747019
##
dev/breeze/src/airflow_breeze/params/doc_build_params.py:
##
@@ -20,20 +20,30 @@
from dataclasses import dataclass
from airflow_breeze.branch_defaults
amoghrajesh commented on code in PR #35101:
URL: https://github.com/apache/airflow/pull/35101#discussion_r1367746460
##
BREEZE.rst:
##
@@ -2649,3 +2649,50 @@ This will also remove breeze from the folder:
``${HOME}.local/bin/``
.. code-block:: bash
pipx uninstall
potiuk commented on PR #34809:
URL: https://github.com/apache/airflow/pull/34809#issuecomment-1773825770
https://github.com/apache/airflow/pull/35102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk opened a new pull request, #35102:
URL: https://github.com/apache/airflow/pull/35102
The #35069 and #35087 that switched from `--package-filter` to shorthand
package names in CI did not handle all the cases - special package names such
as "apache-airflow" or "helm-chart" were
hussein-awala commented on code in PR #35101:
URL: https://github.com/apache/airflow/pull/35101#discussion_r1367742062
##
BREEZE.rst:
##
@@ -2649,3 +2649,50 @@ This will also remove breeze from the folder:
``${HOME}.local/bin/``
.. code-block:: bash
pipx uninstall
potiuk commented on PR #34809:
URL: https://github.com/apache/airflow/pull/34809#issuecomment-1773817679
> Is this just a flaky test? It builds fine locally
Likely one more fix to recently completed `docs-build` command for selective
docs building - let me see.
--
This is an
potiuk commented on PR #35097:
URL: https://github.com/apache/airflow/pull/35097#issuecomment-1773816055
Yeah but it does matter and I think we should explain it to educate the
users. Similarly as the user who asked the question about PEP8 conflicting with
our advice, they might not
RNHTTR commented on PR #34809:
URL: https://github.com/apache/airflow/pull/34809#issuecomment-1773811868
Is this just a flaky test? It builds fine locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
potiuk commented on PR #35101:
URL: https://github.com/apache/airflow/pull/35101#issuecomment-1773809275
Since we are going to work on more of changes similar to
https://github.com/apache/airflow/pull/35086 I've figured that it might be
non-obvious how to easily configure your IDE to run
potiuk opened a new pull request, #35101:
URL: https://github.com/apache/airflow/pull/35101
It could be unclear how to debug Breeze using IDE debuggers, this change
provides an explanation including screenshot from PyCharm.
---
**^ Add meaningful
RNHTTR commented on PR #35097:
URL: https://github.com/apache/airflow/pull/35097#issuecomment-1773804072
I did add this blurb about imports:
> Note that import statements also count as top-level code. So, if you have
an import statement that takes a long time or the imported module
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367730805
##
dev/breeze/src/airflow_breeze/commands/sbom_commands.py:
##
@@ -291,25 +291,74 @@ def generate_providers_requirements(
with
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367733237
##
dev/breeze/src/airflow_breeze/utils/cdxgen.py:
##
@@ -217,28 +231,41 @@ def get_requirements_for_provider(
)
-def
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367733237
##
dev/breeze/src/airflow_breeze/utils/cdxgen.py:
##
@@ -217,28 +231,41 @@ def get_requirements_for_provider(
)
-def
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367733237
##
dev/breeze/src/airflow_breeze/utils/cdxgen.py:
##
@@ -217,28 +231,41 @@ def get_requirements_for_provider(
)
-def
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367733237
##
dev/breeze/src/airflow_breeze/utils/cdxgen.py:
##
@@ -217,28 +231,41 @@ def get_requirements_for_provider(
)
-def
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367730805
##
dev/breeze/src/airflow_breeze/commands/sbom_commands.py:
##
@@ -291,25 +291,74 @@ def generate_providers_requirements(
with
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367730404
##
dev/breeze/src/airflow_breeze/commands/sbom_commands.py:
##
@@ -291,25 +291,74 @@ def generate_providers_requirements(
with
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367730181
##
dev/breeze/src/airflow_breeze/commands/sbom_commands.py:
##
@@ -291,25 +291,74 @@ def generate_providers_requirements(
with
Joffreybvn commented on code in PR #34964:
URL: https://github.com/apache/airflow/pull/34964#discussion_r1367719098
##
airflow/models/baseoperator.py:
##
@@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo):
return result
def __getstate__(self):
-state =
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367726001
##
dev/breeze/src/airflow_breeze/commands/sbom_commands.py:
##
@@ -291,25 +291,74 @@ def generate_providers_requirements(
with
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367725810
##
dev/breeze/src/airflow_breeze/commands/sbom_commands.py:
##
@@ -291,25 +291,74 @@ def generate_providers_requirements(
with
Joffreybvn commented on code in PR #34964:
URL: https://github.com/apache/airflow/pull/34964#discussion_r1367725602
##
airflow/utils/log/logging_mixin.py:
##
@@ -68,14 +68,43 @@ class LoggingMixin:
"""Convenience super-class to have a logger configured with the class
potiuk commented on code in PR #35086:
URL: https://github.com/apache/airflow/pull/35086#discussion_r1367724733
##
dev/breeze/src/airflow_breeze/commands/sbom_commands.py:
##
@@ -321,14 +370,14 @@ def generate_providers_requirements(
pool.apply_async(
123MwanjeMike commented on issue #35030:
URL: https://github.com/apache/airflow/issues/35030#issuecomment-1773781269
#34972 works fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Bisk1 commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1367723811
##
airflow/cli/commands/daemon_utils.py:
##
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
potiuk commented on PR #35086:
URL: https://github.com/apache/airflow/pull/35086#issuecomment-1773778101
All looks good I have just a few general comments (and some improvement
proposals / test results will come as inline comments).
1. We will need this "all-airflow" images only
Joffreybvn commented on code in PR #34964:
URL: https://github.com/apache/airflow/pull/34964#discussion_r1367719098
##
airflow/models/baseoperator.py:
##
@@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo):
return result
def __getstate__(self):
-state =
Joffreybvn commented on code in PR #34964:
URL: https://github.com/apache/airflow/pull/34964#discussion_r1367719098
##
airflow/models/baseoperator.py:
##
@@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo):
return result
def __getstate__(self):
-state =
This is an automated email from the ASF dual-hosted git repository.
bolke pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new dc2e8522bf Use airflow released in PyPI for k8s
bolkedebruin merged PR #35099:
URL: https://github.com/apache/airflow/pull/35099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk opened a new pull request, #35099:
URL: https://github.com/apache/airflow/pull/35099
So far we've been using ".[cncf.kubernetes]" as requirement for creating
kubernetes test virtualenve (in k8s_requirements.txt).
This becomes problematic when we add a new pre-installed
potiuk commented on PR #35097:
URL: https://github.com/apache/airflow/pull/35097#issuecomment-1773764486
One thing worth mentioning that even 0.3 s is pretty impactful. All our DAGs
are parsed in DAG file process in a separately forked processes - so if such
'pandas' import happens at top
Taragolis commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1367714633
##
airflow/cli/commands/daemon_utils.py:
##
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
potiuk commented on PR #35097:
URL: https://github.com/apache/airflow/pull/35097#issuecomment-1773761513
I like the idea of mentioning and being explicit about expensive APIs but I
think there is a value in mentioning the imports, because not many people are
aware how big of an impact
vchiapaikeo commented on issue #32870:
URL: https://github.com/apache/airflow/issues/32870#issuecomment-1773745424
@GaryLiuTelus , I know this is a bit old for you now but did you try
changing the gcp_conn_id to one that defaults to `project_B` by any chance?
That should allow the BQ query
eladkal closed issue #35089: Conditional Task Skip option
URL: https://github.com/apache/airflow/issues/35089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 645d52f129 Add `use_krb5ccache` option to
eladkal merged PR #34386:
URL: https://github.com/apache/airflow/pull/34386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eladkal closed issue #11246: SparkSubmitHook Kerberos ccache support
URL: https://github.com/apache/airflow/issues/11246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eladkal commented on PR #35096:
URL: https://github.com/apache/airflow/pull/35096#issuecomment-1773721000
> Can you please add a unit test for the new code which validates a positive
and negative case as well?
yes unit test is required here
--
This is an automated message from the
1 - 100 of 103 matches
Mail list logo
