[PR] Improve Code Coverage for Base Executor [airflow]

2023-10-29 Thread via GitHub
Owen-CH-Leung opened a new pull request, #35260: URL: https://github.com/apache/airflow/pull/35260 As per #35127 , this PR adds more unit tests for `BaseExecutor` and improves the code coverage to 100%. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Relax mandatory requirement for `start_date` when `schedule=None` [airflow]

2023-10-29 Thread via GitHub
vishnucoder1 commented on issue #35199: URL: https://github.com/apache/airflow/issues/35199#issuecomment-1784496687 @profwacko @yash-jain221 Would you mind I work on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[I] Allow jinja templating connection ids for all third party operators [airflow]

2023-10-29 Thread via GitHub
kimminw00 opened a new issue, #35259: URL: https://github.com/apache/airflow/issues/35259 ### Description We use staging and prod S3s(Ceph for example) in our office. So there are often cases where DAGs are running with connection ids changed. We prefer to use Param rather than

Re: [PR] Fix AzureContainerInstanceOperator remove_on_error [airflow]

2023-10-29 Thread via GitHub
eladkal commented on PR #35212: URL: https://github.com/apache/airflow/pull/35212#issuecomment-1784439635 Can you please add unit test to cover this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Allow custom columns in cli dags list [airflow]

2023-10-29 Thread via GitHub
jtmiclat commented on PR #35250: URL: https://github.com/apache/airflow/pull/35250#issuecomment-1784432516 @hussein-awala Thank you for your comments! I think both are good suggestions and pushed some changes to reflect them. 1. I changed the parameter to just columns with

Re: [I] Auto-refresh and DAG double-trigger issues when toggling pause [airflow]

2023-10-29 Thread via GitHub
William-Yi-Weng commented on issue #35220: URL: https://github.com/apache/airflow/issues/35220#issuecomment-1784365993 Is that expected that DAGs trigger immediately for last scheduled task even catchup=True once they are re-enabled since 2.7 for DeltaDataIntervalTimetable? -- This is an

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375559213 ## tests/operators/test_python.py: ## @@ -844,17 +848,30 @@ def f(exit_code): assert ti.state == expected_state +venv_cache_path =

Re: [PR] Replace print by logger.info in db_cleanup util [airflow]

2023-10-29 Thread via GitHub
github-actions[bot] closed pull request #33862: Replace print by logger.info in db_cleanup util URL: https://github.com/apache/airflow/pull/33862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add bandit to pre-commit to detect common security issues [airflow]

2023-10-29 Thread via GitHub
github-actions[bot] closed pull request #34247: Add bandit to pre-commit to detect common security issues URL: https://github.com/apache/airflow/pull/34247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix: added re-raising of exceptions to dag.test() execution [airflow]

2023-10-29 Thread via GitHub
github-actions[bot] commented on PR #34311: URL: https://github.com/apache/airflow/pull/34311#issuecomment-1784285791 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [I] Issue with slim image: ModuleNotFoundError: No module named 'psycopg2' [airflow]

2023-10-29 Thread via GitHub
potiuk commented on issue #35255: URL: https://github.com/apache/airflow/issues/35255#issuecomment-1784280819 > > That is expected that is why it is a slim image. > > You need provide additional dependencies (Debian or/and Python packages) by your own > > I thought it should have

Re: [PR] Bugfix/prevent concurrency with cached venv [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35258: URL: https://github.com/apache/airflow/pull/35258#issuecomment-1784278368 BTW. @jens-scheffler-bosch - first test suites are getting green in https://github.com/apache/airflow/pull/35160, so I confirm it fixes the original problem too. -- This is an

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375550277 ## tests/operators/test_python.py: ## @@ -844,17 +848,30 @@ def f(exit_code): assert ti.state == expected_state +venv_cache_path =

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375550277 ## tests/operators/test_python.py: ## @@ -844,17 +848,30 @@ def f(exit_code): assert ti.state == expected_state +venv_cache_path =

Re: [PR] Handle left-over termination logs from previous runs with same cache [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35252: URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784275810 > But reading comments in https://github.com/apache/airflow/pull/35258 hope it is okay to revert the termination log fix. Absolutely. As if "replace with generated dir which makes

Re: [PR] Handle left-over termination logs from previous runs with same cache [airflow]

2023-10-29 Thread via GitHub
jens-scheffler-bosch commented on PR #35252: URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784274264 > > Termination log is just "one" thin but I now just realized that all venv script input, output, logs and temp files are also created in the venv cache folder. This is

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
jens-scheffler-bosch commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375538516 ## tests/operators/test_python.py: ## @@ -844,17 +848,30 @@ def f(exit_code): assert ti.state == expected_state +venv_cache_path =

Re: [PR] Bugfix/prevent concurrency with cached venv [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35258: URL: https://github.com/apache/airflow/pull/35258#issuecomment-1784263022 > * Revers the efforts of @potiuk in [Handle left-over termination logs from previous runs with same cache  #35252](https://github.com/apache/airflow/pull/35252) - Sorry as termination

[PR] Bugfix/prevent concurrency with cached venv [airflow]

2023-10-29 Thread via GitHub
jens-scheffler-bosch opened a new pull request, #35258: URL: https://github.com/apache/airflow/pull/35258 This PR reverts PR #35252 as the fix made in this PR just fixed one side effect. Unfortunately when initially the PR #33355 was created I did not see that all temporary scripts

Re: [PR] Handle left-over termination logs from previous runs with same cache [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35252: URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784257754 > Sorry, I was off during the day and just now this PR jumped into my eyes. Reading the fix description and looking through the code I fear we have a more severe problem that we

Re: [PR] Add operator to invoke Azure-Synapse pipeline [airflow]

2023-10-29 Thread via GitHub
ambika-garg commented on code in PR #35091: URL: https://github.com/apache/airflow/pull/35091#discussion_r1375530876 ## CONTRIBUTING.rst: ## Review Comment: Hi, after configuring git client to handle line endings, I am unable to start Breeze, it is exists with the error

[PR] Fix weight_rule property type in mappedoperator [airflow]

2023-10-29 Thread via GitHub
hussein-awala opened a new pull request, #35257: URL: https://github.com/apache/airflow/pull/35257 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(airflow) 43/44: Fix subtle bug in mocking processor_agent in our tests (#35221)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 69538406f3f1aef0389d5240df5aea11625bba61 Author: Jarek Potiuk AuthorDate: Fri Oct 27 21:31:14 2023 +0200

(airflow) 31/44: Bump @babel/traverse from 7.16.0 to 7.23.2 in /airflow/www (#34988)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 80a237073a3f49ec62f33b5ab836096d137dfb44 Author: Dependabot [bot]

(airflow) 39/44: Fix typo s/overriden/overridden/ (#35128)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit cd0a4ed8f88b38a2c6e25ba829f1507860dc23d6 Author: hugo-syn <61210734+hugo-...@users.noreply.github.com>

(airflow) 35/44: doc change (#35075)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b95a66437c8d31eeb7efb9a3543412962466e218 Author: Shubham Raj

(airflow) 44/44: Added example for defaults in conn.extras (#35165)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit eb86d6057c911d80c8e6767cd2a1dbedce8fc5ac Author: Vedran Kolka

(airflow) 37/44: Fix test connection with codemirror and extra (#35122)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 0b16c358b09a35cd6b3653e4edec11a6149679f3 Author: Victor Chiapaikeo AuthorDate: Mon Oct 23 22:18:00 2023

(airflow) 40/44: Update datasets.rst issue with running example code (#35035)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit dd67de8d7bf82bbb4290697609d58d44c1ddb9dc Author: Erik Farmer <5082725+erik-far...@users.noreply.github.com>

(airflow) 33/44: Fix usage of cron-descriptor since BC in v1.3.0 (#34836)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 66def301b1907d9386f26d2602d3ad1ffa7c49c6 Author: Quentin Bray AuthorDate: Thu Oct 19 19:07:50 2023 +0200

(airflow) 26/44: Enhancement: Added Code from Image as Text (#34868)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit af642b5d7d21de71b69310930b39a4228af8ef93 Author: Aadya <101169283+theaa...@users.noreply.github.com>

(airflow) 22/44: Fix triggerer thread crash in daemon mode (#34931)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit cf5715d2c94cfc04c910e96333e81c244c6148b0 Author: Daniel Dyląg AuthorDate: Sat Oct 14 17:56:24 2023 +0200

(airflow) 38/44: Fix Scheduler crash looping when dagrun creation fails (#35135)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b16439e156077deec4ee287c58ef0ede6621c6f6 Author: Ephraim Anierobi AuthorDate: Mon Oct 23 19:39:37 2023

(airflow) 05/44: Mark tasks with `all_skipped` trigger rule as `skipped` if any task is in `upstream_failed` state (#34392)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 7ec3e92580a83235f91652692f6bc16951887e63 Author: Tamara Janina Fingerlin

(airflow) 09/44: docs: remove extraneous '>' in provider section name (#34813)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 553af43c6e6ba163e15d6c94aaddc8b93d767296 Author: Wonseok Yang <62360849+dead-1...@users.noreply.github.com>

(airflow) 15/44: Fix the broken file link (#34826)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 6fd2ba5df82494dc321348d3c5b0f9e162a83f26 Author: Shiqi Guo <39219120+guoshiqi0...@users.noreply.github.com>

(airflow) 27/44: Update docs errors.rst - Mention sentry "transport" configuration option (#34912)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 074ea9ec7a9958533d95575c4060f4fd83288bae Author: luispedroemg

(airflow) 17/44: Doc: Add info on getting variables and config in custom secrets backend (#34834)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit e3e326eb349a3bd0fc2e9e43ad4c4aba28665c9d Author: Aakcht AuthorDate: Thu Oct 12 02:32:08 2023 +0600

(airflow) 07/44: Remove warning about max_tis per query > parallelism (#34742)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 6ffe86525057806dd4f4e7846e33c007abe0ecec Author: Daniel Standish

(airflow) 24/44: Fix the dags count filter in webserver home page (#34944)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 78de303b000a725d7d9716f0aea973224cc4fbaf Author: Hussein Awala AuthorDate: Sun Oct 15 07:25:34 2023 +0200

(airflow) 18/44: Add session configuration to deployment manager's responsibilities. (#34866)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit a6a837d68f3e25c8573bba63a3810e7f2d7d13be Author: Jarek Potiuk AuthorDate: Wed Oct 11 17:44:24 2023 -0300

(airflow) 19/44: fix(TimeSensorAsync): use DAG timezone (#33406)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit f0e81adf8ba1345a05cd385dfa3406bfbe9ffb70 Author: Cassandra AuthorDate: Thu Oct 12 05:27:19 2023 +0200

(airflow) 34/44: Remove redundant variables from `example_python_operator` (#35046)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b481b8e425e91da17aab475d96c495d50be70526 Author: aeongsseu

(airflow) 21/44: Update dags.rst to put SubDag deprecation note right after the SubDag section heading (#34925)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 9262b4dacc2b2b268d9b745833f06823a9660c07 Author: jayljohnson AuthorDate: Fri Oct 13 21:31:51 2023 -0700

(airflow) 08/44: Fix imports in extra link documentation (#34547)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 84abdf6f4586dea040453d30177525e9b6ece7c7 Author: Achim Gädke

(airflow) 01/44: Add read only validation to read only fields (#33413)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 2a0106e4edf67c5905ebfcb82a6008662ae0f7ad Author: Augusto Hidalgo AuthorDate: Wed Aug 16 14:33:56 2023

(airflow) 02/44: Improve modules import in Airflow core by some of them into a type-checking block (#33755)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 265126de56708ee74236e1c60a326b8694be52a0 Author: Hussein Awala AuthorDate: Mon Aug 28 16:54:08 2023 +0200

(airflow) 36/44: Remove `mysql-connector-python` from recommended MySQL driver (#34287)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit ce7ce267077f270b7dab7f99a099ec1ac19f553d Author: Andrey Anshin AuthorDate: Fri Oct 20 21:27:53 2023 +0400

(airflow) 14/44: Fixing typo in airflow kerberos (#34827)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b7f2a97f177d1ae130ecee097dd29b671da5997e Author: Amogh Desai AuthorDate: Mon Oct 9 23:58:17 2023 +0530

(airflow) 28/44: Some improvements/fixes for dag_run and task_instance endpoints (#34942)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 199d17aed240b7f46fe920d3151167a4e3c247f2 Author: Hussein Awala AuthorDate: Mon Oct 16 16:40:26 2023 +0200

(airflow) 04/44: Correct some minor typos in the `breeze.rst` doc

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 003e1d9dc280320c35c3a90ce47f679ddb3164f3 Author: Arpita kesharwani

(airflow) 16/44: Executors doc update (#34324)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 05639e19da1b9c649394254d0e50692236b9ad3d Author: Niko Oliveira AuthorDate: Tue Oct 10 11:47:33 2023 -0700

(airflow) 29/44: Update documentation to enable test connection (#34905)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 4fdc9c9936a606e560d9f7f3c2b3d8a92e500965 Author: vatsrahul1001

(airflow) 41/44: Add TriggerRule missing value in rest API (#35194)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b493d4e60190c858b00723de8b5a811695adb514 Author: Pankaj Singh

(airflow) 06/44: Fix typo re schedule vs schedule_interval (#34743)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b3a0df058e94c612b639121d20bbb400682480fd Author: Daniel Standish

(airflow) 42/44: Fix test_retry_handling_job (#34326)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit e678fe160c97c976dbec8fe0e2d6ef296a1ac751 Author: Daniel Dyląg AuthorDate: Thu Sep 14 12:03:46 2023 +0200

(airflow) 23/44: Return only the TIs of the readable dags when ~ is provided as a dag_id (#34939)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit bfb5f585de73ed2c29dabe1431ea4f69bd1bc20b Author: Hussein Awala AuthorDate: Sun Oct 15 00:01:00 2023 +0200

(airflow) 32/44: Fix `get_plugin_info` for class based listeners. (#35022)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit a5df4a8b20f9467d2bf4b3ffa643e3fd150c48fc Author: Jakub Dardzinski AuthorDate: Wed Oct 18 21:42:39 2023

(airflow) 11/44: Remove unused set from `SchedulerJobRunner` (#34810)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 979a4e442923f88d862e282d9d4d66d0298be81f Author: Jed Cunningham

(airflow) 13/44: Fixes python_callable function assignment context kwargs example in params.rst (#34759)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 5433a77e25d2957d078ff49152900d7f309c37f7 Author: Filippo Alimonda AuthorDate: Mon Oct 9 04:26:53 2023

(airflow) 30/44: Bump undici from 5.19.1 to 5.26.3 in /airflow/www (#34971)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 93b8eccaec2479b6dcfa5a81a940850f351108c6 Author: Dependabot [bot]

(airflow) 10/44: Add missing multiple_outputs=True param in the TaskFlow example (#34812)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b6815f8e4fe825a695284565fbf3f86fd29e2fc8 Author: Pankaj Koti AuthorDate: Sun Oct 8 06:05:29 2023 -0700

(airflow) 25/44: Fix typo in error message when `render_content` method is not implemented (#34952)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 04da77ef65c2ad4cedfd681571bf9fa2c0d0b7d9 Author: Utkarsh Sharma AuthorDate: Sun Oct 15 21:27:21 2023 +0530

(airflow) 12/44: Fix variables substitution in Airflow Documentation (#34462)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 2f4f449b941e1d5908934cd60a45dd6726fdaa42 Author: Andrey Anshin AuthorDate: Sun Oct 8 22:51:05 2023 +0400

(airflow) 20/44: REST API: Fix wrong plugin schema (#34858)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 07790488d47110a758d635a7445f4664a97cbe7c Author: Ephraim Anierobi AuthorDate: Thu Oct 12 12:56:42 2023

(airflow) 03/44: Use latest LTS clients of Oracle MySQL and MariaDB (#33722)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 5975620a57305dd573925efe90a682f0a6847e73 Author: Andrey Anshin AuthorDate: Sat Sep 16 21:09:33 2023 +0400

(airflow) branch v2-7-test updated (a2b0a6aab8 -> eb86d6057c)

2023-10-29 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git from a2b0a6aab8 Fix tests to respond to Python 3.12 handling of utcnow in sentry-sdk (#34946) new

Re: [I] Issue with slim image: ModuleNotFoundError: No module named 'psycopg2' [airflow]

2023-10-29 Thread via GitHub
Taragolis commented on issue #35255: URL: https://github.com/apache/airflow/issues/35255#issuecomment-1784250033 It have enough dependency to start with SQLite and Sequential executor, this is not suitable for production, but for support all DB backends it would be required also drivers

Re: [PR] Add a public interface for custom weight_rule implementation [airflow]

2023-10-29 Thread via GitHub
hussein-awala commented on PR #35210: URL: https://github.com/apache/airflow/pull/35210#issuecomment-1784249764 I had to make some changes to provide a task instance instead of a task to get_weight method. I tested it in Breeze (CeleryExecutor + Postgres) with this dag: ```python

Re: [I] datetime.utcnow and datetime.utcfromtimestamp are deprecated in Python 3.12 [airflow]

2023-10-29 Thread via GitHub
Gui-FernandesBR commented on issue #32344: URL: https://github.com/apache/airflow/issues/32344#issuecomment-1784238479 Any updates on this one? Python 3.12 was released a few weeks ago. The warning persists: ```txt DeprecationWarning:

Re: [PR] Handle left-over termination logs from previous runs with same cache [airflow]

2023-10-29 Thread via GitHub
jens-scheffler-bosch commented on PR #35252: URL: https://github.com/apache/airflow/pull/35252#issuecomment-1784237922 Sorry, I was off during the day and just now this PR jumped into my eyes. Reading the fix description and looking through the code I fear we have a more severe problem

Re: [PR] enhance druid connection parameters [airflow]

2023-10-29 Thread via GitHub
blcksrx commented on code in PR #35244: URL: https://github.com/apache/airflow/pull/35244#discussion_r1375516133 ## docs/apache-airflow-providers-apache-druid/connections/druid.rst: ## @@ -0,0 +1,48 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

Re: [I] Implement pre-commit plugins for VSCode/PyCharm/Intellij maybe [airflow]

2023-10-29 Thread via GitHub
potiuk commented on issue #35253: URL: https://github.com/apache/airflow/issues/35253#issuecomment-1784221686 > Black uses a protocol for this which allows integration with any ide that supports this. So they integrate with intellij / vscode etc without too much effort. > >

Re: [PR] Add description on what goes into the next release [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35245: URL: https://github.com/apache/airflow/pull/35245#issuecomment-1784219592 > I think it is important to mention semver somewhere, and maybe link to the spec in case users want more details about core release policy. Yep. Added a short chapter - linking

Re: [I] Issue with slim image: ModuleNotFoundError: No module named 'psycopg2' [airflow]

2023-10-29 Thread via GitHub
RonaldGalea commented on issue #35255: URL: https://github.com/apache/airflow/issues/35255#issuecomment-1784212443 > That is expected that is why it is a slim image. > You need provide additional dependencies (Debian or/and Python packages) by your own I thought it should have

(airflow) branch v2-7-test updated (6748e17965 -> a2b0a6aab8)

2023-10-29 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git from 6748e17965 Bump azure-mgmt-containerinstance (#34738) new 65310cba9e Fix bulding and publishing of the

(airflow) 02/02: Fix tests to respond to Python 3.12 handling of utcnow in sentry-sdk (#34946)

2023-10-29 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit a2b0a6aab814a773a7ba0a14f648a77d1dfdbb82 Author: Jarek Potiuk AuthorDate: Sat Oct 14 19:38:50 2023 +0200 Fix

(airflow) 01/02: Fix bulding and publishing of the documentation (Breeze merge conflicts)

2023-10-29 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 65310cba9e4f093f28372d5cd2ae2ecb2d8d10a0 Author: Jarek Potiuk AuthorDate: Sun Oct 29 20:52:33 2023 +0100 Fix

Re: [I] Relax mandatory requirement for `start_date` when `schedule=None` [airflow]

2023-10-29 Thread via GitHub
potiuk commented on issue #35199: URL: https://github.com/apache/airflow/issues/35199#issuecomment-1784207068 Fist with good PR wins then ? Srsly - talk to each other and decide who takes it :) -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35160: URL: https://github.com/apache/airflow/pull/35160#issuecomment-1784206337 Just MSSQL is a bit unstable - that has not changed :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(airflow) branch v2-7-test updated (11320c4a15 -> 6748e17965)

2023-10-29 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git from 11320c4a15 Add __init__ to params subpackage (#34710) new 5712271ff7 Add missing asterisk for MsSQL on

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35160: URL: https://github.com/apache/airflow/pull/35160#issuecomment-1784196280 Good numbers also for Public runners: We had minimum on average (excluding MSSQL which is a bit longer) - 5x 35 minutes for "core change" PR on Public runers = 175 build mintes .

Re: [I] Issue with slim image: ModuleNotFoundError: No module named 'psycopg2' [airflow]

2023-10-29 Thread via GitHub
Taragolis closed issue #35255: Issue with slim image: ModuleNotFoundError: No module named 'psycopg2' URL: https://github.com/apache/airflow/issues/35255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Issue with slim image: ModuleNotFoundError: No module named 'psycopg2' [airflow]

2023-10-29 Thread via GitHub
Taragolis commented on issue #35255: URL: https://github.com/apache/airflow/issues/35255#issuecomment-1784195520 That is expected that is why it is a slim image. You need provide additional dependencies (Debian or/and Python packages) by your own -- This is an automated message from

(airflow) branch main updated: Feature: Allow description to be passed in when using variables CLI (#34791)

2023-10-29 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 77ae1defd9 Feature: Allow description to be

Re: [PR] Feature: Allow description to be passed in when using variables CLI [airflow]

2023-10-29 Thread via GitHub
eladkal merged PR #34791: URL: https://github.com/apache/airflow/pull/34791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] CLI: Variables set should allow to set description [airflow]

2023-10-29 Thread via GitHub
eladkal closed issue #34756: CLI: Variables set should allow to set description URL: https://github.com/apache/airflow/issues/34756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Implement Dag SLAs [airflow]

2023-10-29 Thread via GitHub
syun64 commented on PR #33532: URL: https://github.com/apache/airflow/pull/33532#issuecomment-1784187011 This PR requires the patch from https://github.com/apache/airflow/pull/35256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Bug fix fetch_callback of Partial Subset DAG [airflow]

2023-10-29 Thread via GitHub
syun64 opened a new pull request, #35256: URL: https://github.com/apache/airflow/pull/35256 I believe that there may be a bug where if a partial_subset dag is generated on a DAG with `on_success_callback` or `on_failure_callback` functions defined on it, then it might try

Re: [PR] Add description on what goes into the next release [airflow]

2023-10-29 Thread via GitHub
pierrejeambrun commented on PR #35245: URL: https://github.com/apache/airflow/pull/35245#issuecomment-1784179373 Maybe just link to the Semver section in that same readme ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[I] Issue with slim image: ModuleNotFoundError: No module named 'psycopg2' [airflow]

2023-10-29 Thread via GitHub
RonaldGalea opened a new issue, #35255: URL: https://github.com/apache/airflow/issues/35255 ### Apache Airflow version 2.7.2 ### What happened I tried to use the slim docker image version for running dockerized airflow, as explained in the

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375477256 ## tests/jobs/test_triggerer_job.py: ## @@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None): return dag_model, run, trigger_orm,

[I] Quarantined test_trigger_logging_sensitive_info test [airflow]

2023-10-29 Thread via GitHub
potiuk opened a new issue, #35254: URL: https://github.com/apache/airflow/issues/35254 ### Body The test `airfow/tests/jobs/test_triggerrer_job.py::test_trigger_logging_sensitive_info` has a weird and race'y behaviour - that got exposed when implementing #83221. As a result it's

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375471350 ## tests/jobs/test_triggerer_job.py: ## @@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None): return dag_model, run, trigger_orm,

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375471350 ## tests/jobs/test_triggerer_job.py: ## @@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None): return dag_model, run, trigger_orm,

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375471350 ## tests/jobs/test_triggerer_job.py: ## @@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None): return dag_model, run, trigger_orm,

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375471350 ## tests/jobs/test_triggerer_job.py: ## @@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None): return dag_model, run, trigger_orm,

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
hussein-awala commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375469882 ## tests/jobs/test_triggerer_job.py: ## @@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None): return dag_model, run, trigger_orm,

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on PR #35160: URL: https://github.com/apache/airflow/pull/35160#issuecomment-1784152557 I got the first "fully green pass" (Quarantined tests are green but really "skipped" so I will need to fix that one). Looking for more reviews while adding some best practices

Re: [PR] Improve testing harness to separate DB and non-DB tests [airflow]

2023-10-29 Thread via GitHub
potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1375463230 ## tests/jobs/test_triggerer_job.py: ## @@ -110,6 +112,9 @@ def create_trigger_in_db(session, trigger, operator=None): return dag_model, run, trigger_orm,

  1   2   >