Re: [PR] Avoid too many conflicts when generating breeze images [airflow]

2023-11-08 Thread via GitHub
potiuk merged PR #35508: URL: https://github.com/apache/airflow/pull/35508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Avoid too many conflicts when generating breeze images (#35508)

2023-11-08 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 77a7f999b6 Avoid too many conflicts when generating

[PR] Update the connection for pinecone provider [airflow]

2023-11-08 Thread via GitHub
utkarsharma2 opened a new pull request, #35523: URL: https://github.com/apache/airflow/pull/35523 Pinecone uses the Project ID instead of Project Name, this PR updates the Pinecone connection to use Project ID. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Move Jens Scheffler to committer role [airflow]

2023-11-08 Thread via GitHub
jscheffl commented on PR #35522: URL: https://github.com/apache/airflow/pull/35522#issuecomment-1801296657 > Would you be so kind to also add Amogh Rajesh and Pankaj Koti to project.rst ? Due to all the Summit announcement -> vacation things we have not followed all the steps and they are a

Re: [PR] Move Jens Scheffler to committer role [airflow]

2023-11-08 Thread via GitHub
potiuk commented on PR #35522: URL: https://github.com/apache/airflow/pull/35522#issuecomment-1801297952 Ahh @pankajkoti added himself in separate PR so all good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Move Jens Scheffler to committer role [airflow]

2023-11-08 Thread via GitHub
potiuk commented on PR #35522: URL: https://github.com/apache/airflow/pull/35522#issuecomment-1801298316 > In the RST it was mentioned that the "Step 7" shall be done after Step 6 - setup of self-hosted runners. Are Rajesh and Pankaj also setup on the self-hosted runners already, adding the

Re: [PR] Move Jens Scheffler to committer role [airflow]

2023-11-08 Thread via GitHub
potiuk merged PR #35522: URL: https://github.com/apache/airflow/pull/35522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (77a7f999b6 -> 69281abbec)

2023-11-08 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 77a7f999b6 Avoid too many conflicts when generating breeze images (#35508) add 69281abbec Move Jens Scheffler to

Re: [PR] Add Pankaj Koti to the list of committers in project.rst [airflow]

2023-11-08 Thread via GitHub
potiuk merged PR #35521: URL: https://github.com/apache/airflow/pull/35521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (69281abbec -> 5f223b6f88)

2023-11-08 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 69281abbec Move Jens Scheffler to committer role (#35522) add 5f223b6f88 Add Pankaj Koti to the list of committers

Re: [PR] Add support for catchup="ignore_first" to disable catchup for the first DagRun [airflow]

2023-11-08 Thread via GitHub
BasPH commented on PR #35392: URL: https://github.com/apache/airflow/pull/35392#issuecomment-1801309200 With these new proposed changes ("enable"/"disable"/"ignore_first"), this means a breaking change and thus release in Airflow 3. I'm still seeing the current behavior leading to a lot of

Re: [PR] Update the connection for pinecone provider [airflow]

2023-11-08 Thread via GitHub
pankajkoti merged PR #35523: URL: https://github.com/apache/airflow/pull/35523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airfl

(airflow) branch main updated: Update the connection for pinecone provider (#35523)

2023-11-08 Thread pankajkoti
This is an automated email from the ASF dual-hosted git repository. pankajkoti pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5ed74bf835 Update the connection for pinecone p

Re: [PR] Move Jens Scheffler to committer role [airflow]

2023-11-08 Thread via GitHub
pankajkoti commented on PR #35522: URL: https://github.com/apache/airflow/pull/35522#issuecomment-1801320328 yes, wished to check that the CI is working fine for me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Move Jens Scheffler to committer role [airflow]

2023-11-08 Thread via GitHub
pankajkoti commented on PR #35522: URL: https://github.com/apache/airflow/pull/35522#issuecomment-180130 btw, also @amoghrajesh has a PR for himself: https://github.com/apache/airflow/pull/35520 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] Airflow Triggerer facing frequent restarts [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #33647: URL: https://github.com/apache/airflow/issues/33647#issuecomment-1801324111 There is no other source of information for that than public issues if there are no updates, it means that there are no updates, generally. Possibly at some point in time before the

Re: [PR] Move Jens Scheffler to committer role [airflow]

2023-11-08 Thread via GitHub
potiuk commented on PR #35522: URL: https://github.com/apache/airflow/pull/35522#issuecomment-1801326611 > btw, also @amoghrajesh has a PR for himself: #35520 Yep. Just merged :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Adding amoghrajesh as committer [airflow]

2023-11-08 Thread via GitHub
potiuk merged PR #35520: URL: https://github.com/apache/airflow/pull/35520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Adding amoghrajesh as committer (#35520)

2023-11-08 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8e0936fbd0 Adding amoghrajesh as committer (#35520)

Re: [I] Airflow Triggerer facing frequent restarts [airflow]

2023-11-08 Thread via GitHub
shubhransh-eb commented on issue #33647: URL: https://github.com/apache/airflow/issues/33647#issuecomment-1801327618 Thank you for the input and advice @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] Tasks are stuck in running state. "select 1" query stuck in idle in transaction [airflow]

2023-11-08 Thread via GitHub
boring-cyborg[bot] commented on issue #35524: URL: https://github.com/apache/airflow/issues/35524#issuecomment-1801352264 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Tasks are stuck in running state. "select 1" query stuck in idle in transaction [airflow]

2023-11-08 Thread via GitHub
deepak4babu opened a new issue, #35524: URL: https://github.com/apache/airflow/issues/35524 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened Airflow version: 2.6.2, 2.7.1 Postgresql Version: 13.11 In our airflow setup,

Re: [I] Connexion 3 breaks init-views [airflow]

2023-11-08 Thread via GitHub
moiseenkov commented on issue #35234: URL: https://github.com/apache/airflow/issues/35234#issuecomment-1801376901 > > > Also after this comment @vincbeck @jedcunningham - I think we should re-evaluate the result of our discussion whether Auth Mnagers should return FlaskApi from #34349 - bec

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1801413829 @Eric-Mendes I think you don't have install `time-machine` into the [local virtual environment](https://github.com/apache/airflow/blob/main/LOCAL_VIRTUALENV.rst) You also

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-08 Thread via GitHub
mhenc commented on PR #35312: URL: https://github.com/apache/airflow/pull/35312#issuecomment-1801430231 Finally I made the tests green. There were some changes required. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1801592051 I think yes we need an additional escalation level for execution timeout. The problem of current implementation that we raise an error in handler function and have no idea

Re: [PR] Added support for multiple cron expressions [airflow]

2023-11-08 Thread via GitHub
allebacco commented on PR #35337: URL: https://github.com/apache/airflow/pull/35337#issuecomment-1801676220 I like the idea of scheduling with multiple CRON expressions, but I think that instead of supporting list of CRON expressions in the `schedule` argument, we should create a new `Timet

[PR] [AIP-44] Migrate run_task_by_local_task_job to Internal API [airflow]

2023-11-08 Thread via GitHub
mhenc opened a new pull request, #35527: URL: https://github.com/apache/airflow/pull/35527 closes: https://github.com/apache/airflow/issues/35526 related: https://github.com/apache/airflow/issues/35526 -- This is an automated message from the Apache Git Service. To respond to the messag

[I] PythonVirtualenvOperator crashes if any `python_callable` function is defined in the same source as DAG [airflow]

2023-11-08 Thread via GitHub
Felix-neko opened a new issue, #35529: URL: https://github.com/apache/airflow/issues/35529 ### Apache Airflow version 2.7.3 ### What happened Hi folks! I have to use `PythonVirtualenvOperator` operator and pass it `{{ dag_run }}`, `{{ task_instance }}` and other a

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1801807403 How about another option. I think we already use (depends on runner - couldbe also spawned and cgroups migh be involved - but generally it's the default) fork local task process exe

Re: [I] migrate from `dill` to `cloudpickle` for advanced serialization [airflow]

2023-11-08 Thread via GitHub
Felix-neko commented on issue #7870: URL: https://github.com/apache/airflow/issues/7870#issuecomment-1801820301 [I haven't used cloudpickle but if it ](https://github.com/apache/airflow/issues/35529) -- maybe using cloudpickle could cure this problem? -- This is an automated message from

Re: [I] Connexion 3 breaks init-views [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #35234: URL: https://github.com/apache/airflow/issues/35234#issuecomment-1801824400 > I assume that it should be done as soon as possible because it blocks upgrade of Werkzeug up to version 3.0.1 that patches [vulnerability issue](https://nvd.nist.gov/vuln/detail/C

Re: [I] Connexion 3 breaks init-views [airflow]

2023-11-08 Thread via GitHub
RobbeSneyders commented on issue #35234: URL: https://github.com/apache/airflow/issues/35234#issuecomment-1801857315 I assume that what is urgent, is not blocking the migration path to Connexion 3 in the future, by now releasing the auth managers with an interface that expects them to retur

Re: [I] migrate from `dill` to `cloudpickle` for advanced serialization [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on issue #7870: URL: https://github.com/apache/airflow/issues/7870#issuecomment-1801869029 It might help. There is also limitations for cloudpickle exists: > Cloudpickle can only be used to send objects between the exact same version of Python. -- This is an

Re: [PR] Infinite UI redirection loop after deactivating an active user [airflow]

2023-11-08 Thread via GitHub
eladkal commented on PR #35486: URL: https://github.com/apache/airflow/pull/35486#issuecomment-1801890183 BTW same issue happens if user try to login without permission on airflow homepage. It is resulted in endless redirect from homepage to login and then from login to home. We p

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1801897704 I guess this should be implemented in top of the current implementation? Correct me if I wrong. 1. Try to raise exception AirflowTaskTimeout 2. Heartbeat checker also ch

Re: [PR] Added support for multiple cron expressions [airflow]

2023-11-08 Thread via GitHub
BasPH commented on PR #35337: URL: https://github.com/apache/airflow/pull/35337#issuecomment-1801907960 @allebacco Internally everything becomes a Timetable, so implementing a MultiCronExpressionTimetable is fine. However, I do suggest that we provide a "simpler" interface to users by allow

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1801908221 YEp. @Taragolis . That would be me idea. It comes from the assumption that in order to REALLY be able to handle all timeouts you need to do it from a separate process - because as y

Re: [PR] enhance druid connection parameters [airflow]

2023-11-08 Thread via GitHub
potiuk commented on code in PR #35244: URL: https://github.com/apache/airflow/pull/35244#discussion_r1386641998 ## airflow/providers/apache/druid/hooks/druid.py: ## @@ -163,8 +167,8 @@ class DruidDbApiHook(DbApiHook): conn_name_attr = "druid_broker_conn_id" default_c

Re: [PR] enhance druid connection parameters [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on code in PR #35244: URL: https://github.com/apache/airflow/pull/35244#discussion_r1386686826 ## airflow/providers/apache/druid/hooks/druid.py: ## @@ -163,8 +167,8 @@ class DruidDbApiHook(DbApiHook): conn_name_attr = "druid_broker_conn_id" defaul

Re: [I] DAGs log view of `EmptyOperator` shows confusing error `Request URL missing protocol`. [airflow]

2023-11-08 Thread via GitHub
vchiapaikeo commented on issue #34228: URL: https://github.com/apache/airflow/issues/34228#issuecomment-1801977646 Happy to pick this up @Jyoticharan if you're no longer working on it / are stuck. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1801988073 > That is why I suggest also add grace period before kill, maybe even configurable Oh absolutely. the signal "dance" I was mentioning should involve several grace periods. U

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1802016155 Seems we know about the nature and have a plan how to resolve it, so let me pick this issue then. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1802022263 > It happend few times in my life that process did not die after SIGKILL and that was at times when the whole OS/installation got heavily broken) ![giphy](https://github.c

Re: [PR] Prevent assignment of non JSON serializable values to DagRun.conf dict [airflow]

2023-11-08 Thread via GitHub
PashkPashk commented on PR #35096: URL: https://github.com/apache/airflow/pull/35096#issuecomment-1802057847 I’ve been mistaken about hybrid_property, cause it doesn’t work correctly with mypy, should be using declared_attr instead. I also am not really sure how to deal with test_seriali

Re: [PR] Prevent assignment of non JSON serializable values to DagRun.conf dict [airflow]

2023-11-08 Thread via GitHub
PashkPashk commented on code in PR #35096: URL: https://github.com/apache/airflow/pull/35096#discussion_r1386758077 ## airflow/models/dagrun.py: ## @@ -258,6 +281,14 @@ def validate_run_id(self, key: str, run_id: str) -> str | None: ) return run_id +

Re: [I] DAGs log view of `EmptyOperator` shows confusing error `Request URL missing protocol`. [airflow]

2023-11-08 Thread via GitHub
vchiapaikeo commented on issue #34228: URL: https://github.com/apache/airflow/issues/34228#issuecomment-1802058680 Looks like this is a result of this block https://github.com/apache/airflow/commit/672ee7f0e175dd7edb041218850d0cd556d62106#diff-e7f34f73940eb52d92bb991abedc1c963431c5373c12dff7

[PR] feature(providers): added `OpsgenieNotifier` [airflow]

2023-11-08 Thread via GitHub
Eric-Mendes opened a new pull request, #35530: URL: https://github.com/apache/airflow/pull/35530 closes: #35516 Added an `OpsgenieNotifier`. It is almost the exact same implementation as `OpsgenieCreateAlertOperator`, but given that now notifiers exist, I assum

Re: [PR] feature(providers): added `OpsgenieNotifier` [airflow]

2023-11-08 Thread via GitHub
boring-cyborg[bot] commented on PR #35530: URL: https://github.com/apache/airflow/pull/35530#issuecomment-1802067040 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

Re: [PR] Fix async KPO by waiting pod termination in `execute_complete` before cleanup [airflow]

2023-11-08 Thread via GitHub
apilaskowski commented on PR #32467: URL: https://github.com/apache/airflow/pull/32467#issuecomment-1802097193 @hussein-awala Was this introduced back? Or is this termination problem still happening in newest versions? -- This is an automated message from the Apache Git Service. To respon

[PR] Add Gitpod workspace with a Breeze compatible python [airflow]

2023-11-08 Thread via GitHub
sgromme opened a new pull request, #35531: URL: https://github.com/apache/airflow/pull/35531 The default Gitpod workspace installs python 3.12. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airfl

[PR] Exclude `pyenv` and `nvm` files from git and Apache Rat [airflow]

2023-11-08 Thread via GitHub
Taragolis opened a new pull request, #35532: URL: https://github.com/apache/airflow/pull/35532 Add `.nvmrc` into the gitignore, we don't need to track it as it usual local specific Add `.nvmrc` and `.python-version` into rat-excludes for prevent errors in local static c

Re: [PR] Add Gitpod workspace with a Breeze compatible python [airflow]

2023-11-08 Thread via GitHub
potiuk merged PR #35531: URL: https://github.com/apache/airflow/pull/35531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Add Gitpod workspace with a Breeze compatible python (#35531)

2023-11-08 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ab6e623cb1 Add Gitpod workspace with a Breeze compa

Re: [I] AIP-44 Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-08 Thread via GitHub
vincbeck closed issue #29320: AIP-44 Migrate TaskCommand._get_ti to Internal API URL: https://github.com/apache/airflow/issues/29320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-08 Thread via GitHub
vincbeck merged PR #35312: URL: https://github.com/apache/airflow/pull/35312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

(airflow) branch main updated: (AIP-44) Migrate `TaskCommand._get_ti` to Internal API (#35312)

2023-11-08 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1e1adc569f (AIP-44) Migrate `TaskCommand._get_ti`

Re: [I] Connexion 3 breaks init-views [airflow]

2023-11-08 Thread via GitHub
vincbeck commented on issue #35234: URL: https://github.com/apache/airflow/issues/35234#issuecomment-1802181398 > I assume that what is urgent, is not blocking the migration path to Connexion 3 in the future, by now releasing the auth managers with an interface that expects them to return a

Re: [I] Connexion 3 breaks init-views [airflow]

2023-11-08 Thread via GitHub
vincbeck commented on issue #35234: URL: https://github.com/apache/airflow/issues/35234#issuecomment-1802183437 But I agree, the sooner, the better so if you (or someone else) is interested into that change, it is very welcome. If you go down that path feel free to tag, I'll be happy to rev

Re: [I] Connexion 3 breaks init-views [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #35234: URL: https://github.com/apache/airflow/issues/35234#issuecomment-1802184641 > Auth manager interface is not public, yet. It will take some time before having the interface considered as public so we will be able to change the interface > But I agree,

Re: [PR] Add a check for not templateable fields [airflow]

2023-11-08 Thread via GitHub
gdavoian commented on PR #29821: URL: https://github.com/apache/airflow/pull/29821#issuecomment-1802186567 @potiuk do you have any ideas on how it would fit into `BaseOperator`? Because I can only think about something like `templateable_fields` (the exact naming isn't important at the mome

[I] AthenaOperator behaviour changed in 2.7.3 [airflow]

2023-11-08 Thread via GitHub
nenkie76 opened a new issue, #35533: URL: https://github.com/apache/airflow/issues/35533 ### Apache Airflow version 2.7.3 ### What happened Airflow update from 2.7.2 to 2.7.3. (Astronomer 9.4.0 => 9.5.0) has changed the way SQL statements are parsed for Athena. Endlines

Re: [I] AthenaOperator behaviour changed in 2.7.3 [airflow]

2023-11-08 Thread via GitHub
boring-cyborg[bot] commented on issue #35533: URL: https://github.com/apache/airflow/issues/35533#issuecomment-1802237362 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-08 Thread via GitHub
Eric-Mendes commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1802255056 Tested it and opened the PR @Taragolis. Thanks for the guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-08 Thread via GitHub
Eric-Mendes commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1802257666 @utkarsharma2 I didn't know about Apprise, but it seems nice. I'll probably end up using it, but since PagerDuty has its own notifier I still feel like this is a cohesive featu

Re: [PR] [AIP-44] Migrate run_task_by_local_task_job to Internal API [airflow]

2023-11-08 Thread via GitHub
vincbeck commented on code in PR #35527: URL: https://github.com/apache/airflow/pull/35527#discussion_r1386904424 ## airflow/models/taskinstance.py: ## @@ -2025,6 +2060,7 @@ def check_and_change_state_before_execution( ignore_ti_state: bool = False, mark_succes

Re: [I] AIP-56 - FAB AM - Move FAB auth manager to new provider [airflow]

2023-11-08 Thread via GitHub
vincbeck commented on issue #32210: URL: https://github.com/apache/airflow/issues/32210#issuecomment-1802266267 I would like to start this discussion. I think everyone agrees that (if not, please call it out!),if possible, we should move the FAB auth manager to a new provider. If I remember

Re: [I] AIP-56 - Use is_authorized() API across all airflow to check permissions [airflow]

2023-11-08 Thread via GitHub
vincbeck closed issue #32205: AIP-56 - Use is_authorized() API across all airflow to check permissions URL: https://github.com/apache/airflow/issues/32205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] DagRun not highlighted when accessed via `Run Id` hyperlink in `/dagrun/list/` [airflow]

2023-11-08 Thread via GitHub
boring-cyborg[bot] commented on issue #35535: URL: https://github.com/apache/airflow/issues/35535#issuecomment-1802287251 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] DagRun not highlighted when accessed via `Run Id` hyperlink in `/dagrun/list/` [airflow]

2023-11-08 Thread via GitHub
sinwoobang opened a new issue, #35535: URL: https://github.com/apache/airflow/issues/35535 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened The Dag Details page is displayed, but the specific DagRun corresponding to the selected

Re: [I] DagRun not highlighted when accessed via `Run Id` hyperlink in `/dagrun/list/` [airflow]

2023-11-08 Thread via GitHub
sinwoobang closed issue #35535: DagRun not highlighted when accessed via `Run Id` hyperlink in `/dagrun/list/` URL: https://github.com/apache/airflow/issues/35535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] DagRun not highlighted when accessed via `Run Id` hyperlink in `/dagrun/list/` [airflow]

2023-11-08 Thread via GitHub
sinwoobang commented on issue #35535: URL: https://github.com/apache/airflow/issues/35535#issuecomment-1802292605 I found a same issue on https://github.com/apache/airflow/issues/34723. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Base date for fetching dag grid view must include selected run_id [airflow]

2023-11-08 Thread via GitHub
sinwoobang commented on PR #34887: URL: https://github.com/apache/airflow/pull/34887#issuecomment-1802300696 This bug significantly impacts the efficiency of navigating DagRuns, particularly when dealing with a high volume of items. The ability to quickly identify a specific DagRun is criti

Re: [I] AthenaOperator behaviour changed in 2.7.3 [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on issue #35533: URL: https://github.com/apache/airflow/issues/35533#issuecomment-1802339909 I've unable to reproduce on Airflow 2.7.3 and latest amazon provider (8.10.0) ```python import pendulum from airflow.models.dag import DAG from airflow.provider

Re: [PR] feature(providers): added `OpsgenieNotifier` [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on code in PR #35530: URL: https://github.com/apache/airflow/pull/35530#discussion_r1386979341 ## airflow/providers/opsgenie/notifications/opsgenie.py: ## @@ -0,0 +1,150 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

(airflow) branch main updated: Exclude `pyenv` and `nvm` files from git and Apache Rat (#35532)

2023-11-08 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2f980bd597 Exclude `pyenv` and `nvm` files from

Re: [PR] Exclude `pyenv` and `nvm` files from git and Apache Rat [airflow]

2023-11-08 Thread via GitHub
Taragolis merged PR #35532: URL: https://github.com/apache/airflow/pull/35532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Improve error handling in AWS Links [airflow]

2023-11-08 Thread via GitHub
eladkal merged PR #35518: URL: https://github.com/apache/airflow/pull/35518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

(airflow) branch main updated: Improve error handling in AWS Links (#35518)

2023-11-08 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 16ffc87ff4 Improve error handling in AWS Links (#3

Re: [I] AIP-56 - FAB AM - Move FAB auth manager to new provider [airflow]

2023-11-08 Thread via GitHub
jedcunningham commented on issue #32210: URL: https://github.com/apache/airflow/issues/32210#issuecomment-1802362341 Yeah, my concern was around the db. Things like [this](https://github.com/apache/airflow/blob/16ffc87ff42f702221f6cb7e42e08bc208183cf1/airflow/utils/db.py#L725) and [this](h

Re: [PR] feature(providers): added `OpsgenieNotifier` [airflow]

2023-11-08 Thread via GitHub
Eric-Mendes commented on code in PR #35530: URL: https://github.com/apache/airflow/pull/35530#discussion_r1387001825 ## airflow/providers/opsgenie/notifications/opsgenie.py: ## @@ -0,0 +1,150 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

Re: [I] AIP-56 - FAB AM - Move FAB auth manager to new provider [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #32210: URL: https://github.com/apache/airflow/issues/32210#issuecomment-1802381205 I think it should not be too difficult to add though as a provider capability. I'v done that for configuration it took me few days, and DB migration seems like way simpler problem t

Re: [PR] Relax mandatory requirement for start_date when schedule=None [airflow]

2023-11-08 Thread via GitHub
vishnucoder1 commented on PR #35356: URL: https://github.com/apache/airflow/pull/35356#issuecomment-1802392615 @uranusjr Do we need to fail explicitly for non None Schedule and empty start date? In this case, it will start the job based on schedule I believe. -- This is an automated messa

Re: [PR] Fix AzureContainerInstanceOperator remove_on_error [airflow]

2023-11-08 Thread via GitHub
eladkal merged PR #35212: URL: https://github.com/apache/airflow/pull/35212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

(airflow) branch main updated: Fix AzureContainerInstanceOperator remove_on_error (#35212)

2023-11-08 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 22d583403b Fix AzureContainerInstanceOperator remo

Re: [I] AIP-56 - FAB AM - Move FAB auth manager to new provider [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #32210: URL: https://github.com/apache/airflow/issues/32210#issuecomment-1802392679 It literally looks like a hook wher you can discover "if" a given provider supports migration and hook it in, and a way to query providers to see if they "need" migration (to accou

Re: [I] AIP-56 - FAB AM - Move FAB auth manager to new provider [airflow]

2023-11-08 Thread via GitHub
jedcunningham commented on issue #32210: URL: https://github.com/apache/airflow/issues/32210#issuecomment-1802412740 Unfortunately I think there is a bit more complexity here. The db cli is very "core" centric right now. We'd have to support downgrade `--from-version`, `--to-version` and fr

Re: [PR] feature(providers): added `OpsgenieNotifier` [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on PR #35530: URL: https://github.com/apache/airflow/pull/35530#issuecomment-1802421525 Need to fix [Static Checks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst), you could run locally `breeze static-checks {id-of-failed-check} --all-files` e.g. `b

[PR] Add log lookup exception for empty op subtypes [airflow]

2023-11-08 Thread via GitHub
vchiapaikeo opened a new pull request, #35536: URL: https://github.com/apache/airflow/pull/35536 closes: https://github.com/apache/airflow/issues/34228 https://github.com/apache/airflow/assets/9200263/9fee2c1a-b66c-4fc3-a4f6-56baa2b93c3f";> --- **^

Re: [I] DAGs log view of `EmptyOperator` shows confusing error `Request URL missing protocol`. [airflow]

2023-11-08 Thread via GitHub
vchiapaikeo commented on issue #34228: URL: https://github.com/apache/airflow/issues/34228#issuecomment-1802433060 Sure - here's a draft: https://github.com/apache/airflow/pull/35536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] AIP-56 - FAB AM - Move FAB auth manager to new provider [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #32210: URL: https://github.com/apache/airflow/issues/32210#issuecomment-1802438049 > Unfortunately I think there is a bit more complexity here. The db cli is very "core" centric right now. We'd have to support downgrade `--from-version`, `--to-version` and friends

Re: [I] AIP-56 - FAB AM - Move FAB auth manager to new provider [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #32210: URL: https://github.com/apache/airflow/issues/32210#issuecomment-1802443299 Also. purely from the speed of delivering security fixes (which we had plenty of in FAB). We could also handle bugfixes later - we would not have to wait with releasing a security r

Re: [I] AIP-56 - FAB AM - Move FAB auth manager to new provider [airflow]

2023-11-08 Thread via GitHub
potiuk commented on issue #32210: URL: https://github.com/apache/airflow/issues/32210#issuecomment-1802445643 (I just added it to "security improvements" project because of the last point cc: @hussein-awala @pierrejeambrun @eladkal) -- This is an automated message from the Apache Git Serv

Re: [I] AthenaOperator behaviour changed in 2.7.3 [airflow]

2023-11-08 Thread via GitHub
nenkie76 commented on issue #35533: URL: https://github.com/apache/airflow/issues/35533#issuecomment-1802447704 @Taragolis is you task and query actually completing in Athena? My task log in Airflow also outputs `\n ` in log, while then, later it fails: ``` [2023-11-08, 07:20

[PR] Prepare docs 1st wave of Providers November 2023 [airflow]

2023-11-08 Thread via GitHub
eladkal opened a new pull request, #35537: URL: https://github.com/apache/airflow/pull/35537 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [I] AthenaOperator behaviour changed in 2.7.3 [airflow]

2023-11-08 Thread via GitHub
jedcunningham commented on issue #35533: URL: https://github.com/apache/airflow/issues/35533#issuecomment-1802462672 For reference, the provider version jumped from 8.7.1 to 8.10.0, and it's most likely an issue in that provider update not core. -- This is an automated message from the Ap

Re: [PR] Prepare docs 1st wave of Providers November 2023 [airflow]

2023-11-08 Thread via GitHub
potiuk closed pull request #35537: Prepare docs 1st wave of Providers November 2023 URL: https://github.com/apache/airflow/pull/35537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Prepare docs 1st wave of Providers November 2023 [airflow]

2023-11-08 Thread via GitHub
potiuk commented on PR #35537: URL: https://github.com/apache/airflow/pull/35537#issuecomment-1802466432 Added "allow suspended provider changes" label and closed/reopened to rebuild :) Otherwise it was failing -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Prepare docs 1st wave of Providers November 2023 [airflow]

2023-11-08 Thread via GitHub
eladkal commented on PR #35537: URL: https://github.com/apache/airflow/pull/35537#issuecomment-1802466911 > Added "allow suspended provider changes" label and closed/reopened to rebuild :) Otherwise it was failing yep thanks I will add it to the release guide -- This is an autom

Re: [I] AthenaOperator behaviour changed in 2.7.3 [airflow]

2023-11-08 Thread via GitHub
Taragolis commented on issue #35533: URL: https://github.com/apache/airflow/issues/35533#issuecomment-1802480220 > is you task and query actually completing in Athena? Yep, works fine ![image](https://github.com/apache/airflow/assets/3998685/ab4e7440-7da4-4046-881e-179893dc33a5

  1   2   >