vagi8 commented on issue #35253:
URL: https://github.com/apache/airflow/issues/35253#issuecomment-1805256120
Sure, I will go ahead and create a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on issue #35253:
URL: https://github.com/apache/airflow/issues/35253#issuecomment-1805254488
> Hey @potiuk, I would love to do it. But I guess there is already an
extension for
[vscode](https://marketplace.visualstudio.com/items?itemName=elagil.pre-commit-helper)
which
danielvdende commented on issue #35540:
URL: https://github.com/apache/airflow/issues/35540#issuecomment-1805202615
Tested my change (35212), works as expected
Daniel
On 9 Nov 2023 at 19:07 +0100, Joffrey Bienvenu ***@***.***>, wrote:
> There is something wrong with the
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 57282d067a Updating
Joffreybvn commented on code in PR #35560:
URL: https://github.com/apache/airflow/pull/35560#discussion_r1388954539
##
airflow/providers/http/operators/http.py:
##
@@ -162,16 +163,16 @@ def execute(self, context: Context) -> Any:
def execute_sync(self, context: Context) ->
pubudu91 commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1388950665
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation
eladkal commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1388924796
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation
eladkal commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1388924796
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 522576b9c0 Add default to navbar_text_color and
eladkal merged PR #35553:
URL: https://github.com/apache/airflow/pull/35553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Bowrna commented on issue #31826:
URL: https://github.com/apache/airflow/issues/31826#issuecomment-1805100512
I am currently working on this issue and hope to raise a PR ( at least in
draft mode) by end of this week.
--
This is an automated message from the Apache Git Service.
To
Bowrna commented on issue #33426:
URL: https://github.com/apache/airflow/issues/33426#issuecomment-1805099545
sure @potiuk Please let me know if you need any details from me on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uranusjr commented on PR #34947:
URL: https://github.com/apache/airflow/pull/34947#issuecomment-1805051722
A couple of minor questions, otherwise lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
uranusjr commented on code in PR #34947:
URL: https://github.com/apache/airflow/pull/34947#discussion_r1388872154
##
airflow/api_connexion/schemas/dag_schema.py:
##
@@ -109,7 +109,7 @@ class DAGDetailSchema(DAGSchema):
is_active = fields.Method("get_is_active",
uranusjr commented on code in PR #34947:
URL: https://github.com/apache/airflow/pull/34947#discussion_r1388871914
##
airflow/api_connexion/openapi/v1.yaml:
##
Review Comment:
Are quote changes in this file needed? They are obscuring the actual
addition…
##
Usiel commented on issue #29416:
URL: https://github.com/apache/airflow/issues/29416#issuecomment-1805031834
I think this issue is solved by https://github.com/apache/airflow/pull/32709
already.
--
This is an automated message from the Apache Git Service.
To respond to the message,
o-nikolas commented on issue #35490:
URL: https://github.com/apache/airflow/issues/35490#issuecomment-1804920164
I started working on this one and there is a bit of nuance that I didn't
expect.
Many of the config options are lists of dicts. Take tags for example, the
type is:
dstandish commented on PR #35392:
URL: https://github.com/apache/airflow/pull/35392#issuecomment-1804880615
Yeah maybe Bas misunderstood what this PR does. I'll let him comment.
Re configurability, I'm making a general point. For example see this PR
github-actions[bot] commented on PR #33680:
URL: https://github.com/apache/airflow/pull/33680#issuecomment-1804872727
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for
github-actions[bot] commented on PR #34600:
URL: https://github.com/apache/airflow/pull/34600#issuecomment-1804872673
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for
github-actions[bot] commented on PR #33288:
URL: https://github.com/apache/airflow/pull/33288#issuecomment-1804872764
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for
github-actions[bot] commented on issue #35174:
URL: https://github.com/apache/airflow/issues/35174#issuecomment-1804872625
This issue has been automatically marked as stale because it has been open
for 14 days with no response from the author. It will be closed in next 7 days
if no further
vagi8 commented on issue #35253:
URL: https://github.com/apache/airflow/issues/35253#issuecomment-1804871249
Hey @potiuk, I would love to do it. But I guess there is already an
extension for
[vscode](https://marketplace.visualstudio.com/items?itemName=elagil.pre-commit-helper)
which does
caitpj opened a new pull request, #35564:
URL: https://github.com/apache/airflow/pull/35564
When hovering over the Airflow logo in the top left, the pinwheel part of
the logo cuts across the text part of the logo. This is (subjectively) poor
design. In order to stop this from happening,
boring-cyborg[bot] commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1804869053
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
gdavoian commented on PR #35546:
URL: https://github.com/apache/airflow/pull/35546#issuecomment-1804835276
I think that having an alternative (and more customizable) way of sending
email notifications via callbacks is a good thing, but in most cases, the basic
mechanism implemented via the
jscheffl commented on issue #35542:
URL: https://github.com/apache/airflow/issues/35542#issuecomment-1804821868
I had the same observation some time ago which went into discussion
https://github.com/apache/airflow/discussions/32471
I proposed to implement an improvement because we
hussein-awala commented on PR #35392:
URL: https://github.com/apache/airflow/pull/35392#issuecomment-1804814819
> Bas is not saying catchup false is not intuitive in general, he's talking
about the specific behavior that a run is immediately created even when catchup
is false.
IMHO
Eric-Mendes commented on code in PR #35530:
URL: https://github.com/apache/airflow/pull/35530#discussion_r1388671223
##
airflow/providers/opsgenie/notifications/opsgenie.py:
##
@@ -0,0 +1,150 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
potiuk commented on issue #32210:
URL: https://github.com/apache/airflow/issues/32210#issuecomment-1804797765
Yeah. It might simplify things indeed. Rather than merging the commands we
could keep them separate and simply provider coudl check at the initialization
of the auth manager if
hussein-awala commented on PR #35546:
URL: https://github.com/apache/airflow/pull/35546#issuecomment-1804794043
Since email is the only field we can exclude, I wonder if the user really
needs it.
We have an alternative way to achieve that without using the email,
email_on_retry, and
dstandish commented on PR #35392:
URL: https://github.com/apache/airflow/pull/35392#issuecomment-1804792199
I agree with Bas, I think we are way too eager to make everything
configurable and we need to be more opinionated sometimes, and just pick a
behavior. More configuration means more
jscheffl commented on issue #35549:
URL: https://github.com/apache/airflow/issues/35549#issuecomment-1804790124
Mhm, as we have ~90 providers meaning as you need to run a test for each
provider (minus a few that are installed per default) you need to install ~80
times a python env with
dstandish commented on PR #35392:
URL: https://github.com/apache/airflow/pull/35392#issuecomment-1804789929
Bas is not saying catchup false is not intuitive in general, he's talking
about the specific behavior that a run is immediately created even when catchup
is false.
--
This is an
hussein-awala commented on issue #32210:
URL: https://github.com/apache/airflow/issues/32210#issuecomment-1804781739
> Also. purely from the speed of delivering security fixes (which we had
plenty of in FAB). We could also handle bugfixes faster - we would not have to
wait with releasing a
jedcunningham commented on code in PR #35460:
URL: https://github.com/apache/airflow/pull/35460#discussion_r1388642381
##
airflow/config_templates/config.yml:
##
@@ -1828,6 +1828,21 @@ webserver:
type: boolean
example: ~
default: "False"
+
hussein-awala commented on PR #35392:
URL: https://github.com/apache/airflow/pull/35392#issuecomment-1804762730
> I have yet to find the first person that finds catchup's False current
behavior logical
Actually, I find it logical and necessary in some cases -> I have a daily
dag
hussein-awala commented on PR #35185:
URL: https://github.com/apache/airflow/pull/35185#issuecomment-1804748263
> My best guess is that this is what is failing:
>
>
Taragolis commented on issue #35563:
URL: https://github.com/apache/airflow/issues/35563#issuecomment-1804729325
I think it might be fix in
[8.11.0](https://github.com/apache/airflow/issues/35540), it would be nice if
you could check
Reference PR:
-
cliebBS opened a new issue, #35563:
URL: https://github.com/apache/airflow/issues/35563
### Apache Airflow version
2.7.3
### What happened
When using the `RdsDeleteDbInstanceOperator` to delete an RDS instance in my
DAG, sometimes it misses the fact that the instance
hussein-awala commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1804715689
> Just wondering, any reason why we can't use `ruff` implementation
https://docs.astral.sh/ruff/rules/#flake8-bandit-s ?
I checked it when I started working on this PR, and
jedcunningham commented on issue #32210:
URL: https://github.com/apache/airflow/issues/32210#issuecomment-1804715097
Fair point on being able to decouple core from a specific FAB version. I
hadn't considered that aspect, and that does make it worthwhile.
I worry that having `airflow
ivan-afonichkin commented on PR #35382:
URL: https://github.com/apache/airflow/pull/35382#issuecomment-1804672452
@ryanahamilton @ashb @bbovenzi @pierrejeambrun hey :), you seem to be the
owners? Could you please take a look?
--
This is an automated message from the Apache Git Service.
potiuk commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1804659215
> Just wondering, any reason why we can't use `ruff` implementation
https://docs.astral.sh/ruff/rules/#flake8-bandit-s ?
Sounds like good idea :)
--
This is an automated
potiuk commented on code in PR #35554:
URL: https://github.com/apache/airflow/pull/35554#discussion_r1388561671
##
tests/decorators/test_branch_virtualenv.py:
##
@@ -25,7 +25,11 @@
pytestmark = pytest.mark.db_test
-class Test_BranchPythonDecoratedOperator:
+class
Taragolis commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1804573465
Just wondering, any reason why we can't use `ruff` implementation
https://docs.astral.sh/ruff/rules/#flake8-bandit-s ?
--
This is an automated message from the Apache Git Service.
Taragolis commented on issue #35559:
URL: https://github.com/apache/airflow/issues/35559#issuecomment-1804514872
> somehow like AWS Secret Manager
You could use [AWS Secret
jscheffl commented on code in PR #35554:
URL: https://github.com/apache/airflow/pull/35554#discussion_r1388488726
##
tests/decorators/test_branch_virtualenv.py:
##
@@ -25,7 +25,11 @@
pytestmark = pytest.mark.db_test
-class Test_BranchPythonDecoratedOperator:
+class
vincbeck commented on PR #35527:
URL: https://github.com/apache/airflow/pull/35527#issuecomment-1804469528
Tests are failing but LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Taragolis commented on code in PR #35530:
URL: https://github.com/apache/airflow/pull/35530#discussion_r1388469452
##
tests/system/providers/opsgenie/example_opsgenie_notifier.py:
##
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
vincbeck opened a new pull request, #35562:
URL: https://github.com/apache/airflow/pull/35562
Add batch version of some `is_authorized_*` APIs in auth manager. Allow
optimizing, if desired, on the auth manager level when checking permissions on
multi resources at the same time.
potiuk commented on issue #35549:
URL: https://github.com/apache/airflow/issues/35549#issuecomment-1804414102
Not really, It must be a real unit test because we will need to downgrade
dependencies of the provider and then we have to run complete set of tests for
the provider - and all
potiuk merged PR #35556:
URL: https://github.com/apache/airflow/pull/35556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new da86802370 Consolidate and simplify usage of
Taragolis commented on code in PR #35530:
URL: https://github.com/apache/airflow/pull/35530#discussion_r1388449127
##
airflow/providers/opsgenie/notifications/opsgenie.py:
##
@@ -0,0 +1,150 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
RNHTTR commented on issue #35549:
URL: https://github.com/apache/airflow/issues/35549#issuecomment-1804375679
Would this be implemented as a pre-commit hook?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on PR #35556:
URL: https://github.com/apache/airflow/pull/35556#issuecomment-1804350911
That one looks like good to go :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new f7919002cc Establishing init container + sidecar
potiuk merged PR #35548:
URL: https://github.com/apache/airflow/pull/35548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Taragolis closed issue #35550: Airflow scheduler restart casuing up_for_retry
jobs also to be marked as failed.
URL: https://github.com/apache/airflow/issues/35550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
boring-cyborg[bot] commented on PR #35546:
URL: https://github.com/apache/airflow/pull/35546#issuecomment-1804316048
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new addbd587e2 Allow email field to be templated
potiuk merged PR #35546:
URL: https://github.com/apache/airflow/pull/35546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Joffreybvn commented on issue #35540:
URL: https://github.com/apache/airflow/issues/35540#issuecomment-1804313345
**There is something wrong with the HttpOperator**. The new pagination
functionality doesn't behave like expected with `deferrable=False`. But, it
works fine when deferred.
Joffreybvn opened a new pull request, #35560:
URL: https://github.com/apache/airflow/pull/35560
---
**^ Add meaningful description above**
Read the **[Pull Request
Eric-Mendes commented on code in PR #35530:
URL: https://github.com/apache/airflow/pull/35530#discussion_r1388359810
##
airflow/providers/opsgenie/notifications/opsgenie.py:
##
@@ -0,0 +1,150 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 3c5f5b50a4 Remove `sqla` module from security
potiuk merged PR #35557:
URL: https://github.com/apache/airflow/pull/35557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Eric-Mendes commented on code in PR #35530:
URL: https://github.com/apache/airflow/pull/35530#discussion_r1388339827
##
airflow/providers/opsgenie/notifications/opsgenie.py:
##
@@ -0,0 +1,150 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Eric-Mendes commented on code in PR #35530:
URL: https://github.com/apache/airflow/pull/35530#discussion_r1388339827
##
airflow/providers/opsgenie/notifications/opsgenie.py:
##
@@ -0,0 +1,150 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
alejandrofm opened a new issue, #35559:
URL: https://github.com/apache/airflow/issues/35559
### Description
The general idea is to add a column on "variables" and in "connections" that
shows the last time it was accessed, somehow like AWS Secret Manager
### Use case/motivation
V0lantis commented on issue #35558:
URL: https://github.com/apache/airflow/issues/35558#issuecomment-1804240391
After a lot of investigation, I am pretty sure the problem comes from the
[following
snippet](https://github.com/apache/airflow/blob/main/airflow/timetables/_cron.py#L131-L140):
V0lantis opened a new issue, #35558:
URL: https://github.com/apache/airflow/issues/35558
### Apache Airflow version
Other Airflow 2 version (please specify below)
### What happened
After the time shift which happen in Europe during the last 29th morning of
October, we
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 0d449bda7c Updating
This is an automated email from the ASF dual-hosted git repository.
vincbeck pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 8b1cade0d1 Use resource ID to perform
vincbeck closed issue #35138: AIP-56 - Override model Flask views
URL: https://github.com/apache/airflow/issues/35138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vincbeck merged PR #35380:
URL: https://github.com/apache/airflow/pull/35380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 8cd1a7ed3f Stabilize remaining BranchDecoratedOperators tests (#35554)
add 90f7aabafe Fixed chown : usage in
potiuk merged PR #3:
URL: https://github.com/apache/airflow/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on PR #35557:
URL: https://github.com/apache/airflow/pull/35557#issuecomment-1804086340
I love the direction it takes :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vincbeck opened a new pull request, #35557:
URL: https://github.com/apache/airflow/pull/35557
There are 4 layers of security managers:
- `airflow.www.fab_security.manager.BaseSecurityManager`
- `airflow.www.fab_security.sqla.manager.SecurityManager`
-
sinwoobang commented on PR #35551:
URL: https://github.com/apache/airflow/pull/35551#issuecomment-1804022963
@potiuk Thank you for the review. I looked around Great Expectations as per
your request. Pydantic V2 has been supported on Great Expectations since 8th
Sep according to this commit
Pavel-Malyutin commented on issue #35529:
URL: https://github.com/apache/airflow/issues/35529#issuecomment-1804012021
We also faced a similar problem. We will be glad to see a fix in the next
releases :)
--
This is an automated message from the Apache Git Service.
To respond to the
potiuk merged PR #35554:
URL: https://github.com/apache/airflow/pull/35554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 8cd1a7ed3f Stabilize remaining
potiuk opened a new pull request, #35556:
URL: https://github.com/apache/airflow/pull/35556
With recent changes where we largely switched to use primarily short version
of packages rather than `apache-airflow-providers-*` and filters, there were
several places where get_available_packages
timonviola commented on issue #32585:
URL: https://github.com/apache/airflow/issues/32585#issuecomment-1803992117
I can confirm that this is still happening.
```
name = "apache-airflow"
version = "2.7.2"
name = "apache-airflow-providers-apache-kafka"
version = "1.2.0"
potiuk commented on PR #3:
URL: https://github.com/apache/airflow/pull/3#issuecomment-1803987800
This should disappear:
--
This is an automated message from the Apache Git
potiuk opened a new pull request, #3:
URL: https://github.com/apache/airflow/pull/3
Aftere Debian Bookworm upgrade (#35376) chown started to compplain about
using comma instead of colon. This PR fixes the usage.
---
**^ Add meaningful
potiuk opened a new pull request, #35554:
URL: https://github.com/apache/airflow/pull/35554
As a follow-up after #35511 it turned out that we have THREE tests which are
named Test_BranchDecoratedOperator - because they were copied originally from
the "Python" one - there is a Python,
ephraimbuddy commented on code in PR #35000:
URL: https://github.com/apache/airflow/pull/35000#discussion_r1388104870
##
airflow/security/permissions.py:
##
@@ -19,7 +19,6 @@
# Resource Constants
RESOURCE_ACTION = "Permissions"
RESOURCE_ADMIN_MENU = "Admin"
-RESOURCE_AIRFLOW
potiuk commented on issue #35377:
URL: https://github.com/apache/airflow/issues/35377#issuecomment-1803948857
Marked it as good first issue - maybe someone will be able to reproduce and
fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
potiuk commented on issue #35552:
URL: https://github.com/apache/airflow/issues/35552#issuecomment-1803946585
Good ideas!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
utkarsharma2 commented on code in PR #35530:
URL: https://github.com/apache/airflow/pull/35530#discussion_r1388080760
##
airflow/providers/opsgenie/notifications/opsgenie.py:
##
@@ -0,0 +1,150 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
vincbeck commented on code in PR #35527:
URL: https://github.com/apache/airflow/pull/35527#discussion_r1388063159
##
airflow/models/taskinstance.py:
##
@@ -2107,47 +2147,80 @@ def check_and_change_state_before_execution(
ignore_ti_state=ignore_ti_state,
utkarsharma2 commented on issue #35540:
URL: https://github.com/apache/airflow/issues/35540#issuecomment-1803908091
+1 Tested my changes, working as expected.
Thanks,
Utkarsh Sharma
On Thu, Nov 9, 2023 at 5:46 PM Jakub Dardzinski ***@***.***>
wrote:
> #35428
vincbeck commented on code in PR #35000:
URL: https://github.com/apache/airflow/pull/35000#discussion_r1388061633
##
airflow/security/permissions.py:
##
@@ -19,7 +19,6 @@
# Resource Constants
RESOURCE_ACTION = "Permissions"
RESOURCE_ADMIN_MENU = "Admin"
-RESOURCE_AIRFLOW =
vchiapaikeo commented on code in PR #35505:
URL: https://github.com/apache/airflow/pull/35505#discussion_r1388031929
##
airflow/config_templates/config.yml:
##
@@ -1614,6 +1614,13 @@ webserver:
type: string
example: ~
default: "#fff"
+navbar_text_color:
vchiapaikeo opened a new pull request, #35553:
URL: https://github.com/apache/airflow/pull/35553
Follow up from a comment in https://github.com/apache/airflow/pull/35505
Adding a default value to the navbar_text_color config
## Test Plan
Added overrides
mhenc commented on code in PR #35527:
URL: https://github.com/apache/airflow/pull/35527#discussion_r1388029938
##
airflow/models/taskinstance.py:
##
@@ -2025,6 +2060,7 @@ def check_and_change_state_before_execution(
ignore_ti_state: bool = False,
mark_success:
1 - 100 of 158 matches
Mail list logo
