ylnsnv commented on code in PR #35547:
URL: https://github.com/apache/airflow/pull/35547#discussion_r1390719284
##
airflow/providers/openai/operators/openai.py:
##
@@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator):
"""
Operator that accepts input text to
cesar-vermeulen commented on issue #35566:
URL: https://github.com/apache/airflow/issues/35566#issuecomment-1807615506
Hello @potiuk
I'm more than happy to contribute, however, the reason I created this issue
(which I did not explain good enough), was also to determine the reason why
uranusjr commented on code in PR #35017:
URL: https://github.com/apache/airflow/pull/35017#discussion_r1390706598
##
docs/apache-airflow/core-concepts/operators.rst:
##
@@ -185,10 +185,23 @@ This will fail with ``TemplateNotFound: cat script.sh``,
but we can prevent airf
ylnsnv commented on PR #35547:
URL: https://github.com/apache/airflow/pull/35547#issuecomment-1807596113
> @ylnsnv Overall changes look good to me, just a few minor things. Also,
can you mention the docs where you found the specific types accepted by OpenAI
API? just curious :)
utkarsharma2 commented on PR #35547:
URL: https://github.com/apache/airflow/pull/35547#issuecomment-1807585313
@ylnsnv Overall changes look good to me, just a few minor things. Also, can
you mention the docs where you found the specific types accepted by OpenAI API?
just curious :)
--
utkarsharma2 commented on code in PR #35547:
URL: https://github.com/apache/airflow/pull/35547#discussion_r1390691032
##
airflow/providers/openai/operators/openai.py:
##
@@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator):
"""
Operator that accepts input
utkarsharma2 commented on code in PR #35547:
URL: https://github.com/apache/airflow/pull/35547#discussion_r1390691032
##
airflow/providers/openai/operators/openai.py:
##
@@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator):
"""
Operator that accepts input
ylnsnv commented on code in PR #35547:
URL: https://github.com/apache/airflow/pull/35547#discussion_r1390689573
##
airflow/providers/openai/operators/openai.py:
##
@@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator):
"""
Operator that accepts input text to
MPParsley commented on issue #34595:
URL: https://github.com/apache/airflow/issues/34595#issuecomment-1807579405
Indeed, it was about redis and statsd but the problem with
airflow-run-airflow-migrations remains.
--
This is an automated message from the Apache Git Service.
To respond to
ylnsnv commented on code in PR #35547:
URL: https://github.com/apache/airflow/pull/35547#discussion_r1390686468
##
airflow/providers/openai/operators/openai.py:
##
@@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator):
"""
Operator that accepts input text to
utkarsharma2 commented on code in PR #35547:
URL: https://github.com/apache/airflow/pull/35547#discussion_r1390685637
##
airflow/providers/openai/operators/openai.py:
##
@@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator):
"""
Operator that accepts input
utkarsharma2 commented on code in PR #35547:
URL: https://github.com/apache/airflow/pull/35547#discussion_r1390685136
##
airflow/providers/openai/operators/openai.py:
##
@@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator):
"""
Operator that accepts input
utkarsharma2 commented on code in PR #35547:
URL: https://github.com/apache/airflow/pull/35547#discussion_r1390682879
##
airflow/providers/openai/operators/openai.py:
##
@@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator):
"""
Operator that accepts input
boushphong commented on issue #35157:
URL: https://github.com/apache/airflow/issues/35157#issuecomment-1807569905
> What you think should happen instead
Should be an error in scheduler logs that a timeout had been reached.
I did a quick check. There is error logic logic on branch
boushphong commented on issue #35157:
URL: https://github.com/apache/airflow/issues/35157#issuecomment-1807557295
Let me work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ambika-garg commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1390604894
##
airflow/providers/microsoft/azure/hooks/synapse_pipeline.py:
##
Review Comment:
My motivation is to keep code modular and easy to maintain. The
michalsosn commented on code in PR #35017:
URL: https://github.com/apache/airflow/pull/35017#discussion_r1390545309
##
airflow/template/templater.py:
##
@@ -155,6 +167,8 @@ def render_template(
return self._render(template, context)
if isinstance(value,
github-actions[bot] commented on PR #34342:
URL: https://github.com/apache/airflow/pull/34342#issuecomment-1807293834
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for
github-actions[bot] closed pull request #33009: Merge datasets and dag
dependencies graphs
URL: https://github.com/apache/airflow/pull/33009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] closed pull request #34578: Reduce round trips to db when
evaluating setup tasks
URL: https://github.com/apache/airflow/pull/34578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on issue #26186:
URL: https://github.com/apache/airflow/issues/26186#issuecomment-1807292311
If y ou can move it forward, that would be cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on PR #35586:
URL: https://github.com/apache/airflow/pull/35586#issuecomment-1807277210
Looks green now :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eladkal commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1390493251
##
airflow/providers/microsoft/azure/hooks/synapse_pipeline.py:
##
Review Comment:
What is the motivation for a new file?
can't the hook be in the existed
boring-cyborg[bot] commented on PR #35593:
URL: https://github.com/apache/airflow/pull/35593#issuecomment-1807251131
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
shohamy7 opened a new pull request, #35593:
URL: https://github.com/apache/airflow/pull/35593
---
This PR resolve this issue #34595
closes: #34595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
eladkal opened a new issue, #35592:
URL: https://github.com/apache/airflow/issues/35592
### Body
I have a kind request for all the contributors to the latest provider
packages release.
Could you please help us to test the RC versions of the providers?
The guidelines on
eladkal opened a new pull request, #893:
URL: https://github.com/apache/airflow-site/pull/893
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch add-documentation-2023-11-12
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
at 01a34a28a8 Add documentation for packages - 2023-11-12
This branch includes the
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to annotated tag providers-http/4.7.0rc2
in repository https://gitbox.apache.org/repos/asf/airflow.git
*** WARNING: tag providers-http/4.7.0rc2 was modified! ***
from 4f5e482c1f (commit)
to
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to annotated tag providers-discord/3.4.1rc2
in repository https://gitbox.apache.org/repos/asf/airflow.git
*** WARNING: tag providers-discord/3.4.1rc2 was modified! ***
from 4f5e482c1f (commit)
Author: eladkal
Date: Sun Nov 12 21:25:25 2023
New Revision: 65233
Log:
Add artifacts for Airflow Providers 2023-11-12
Added:
dev/airflow/providers/apache-airflow-providers-discord-3.4.1.tar.gz (with
props)
dev/airflow/providers/apache-airflow-providers-discord-3.4.1.tar.gz.asc
Joffreybvn opened a new pull request, #35591:
URL: https://github.com/apache/airflow/pull/35591
Hello,
This PR makes possible to parameterize HttpHook's `auth_type` from the
Connection UI. In a Connection extra settings, the reserved `"auth_kwargs"`
field can be used
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 4f5e482c1f Bump minimum pre-commit version
potiuk merged PR #35590:
URL: https://github.com/apache/airflow/pull/35590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk opened a new pull request, #35590:
URL: https://github.com/apache/airflow/pull/35590
---
**^ Add meaningful description above**
Read the **[Pull Request
renzepost commented on issue #26186:
URL: https://github.com/apache/airflow/issues/26186#issuecomment-1807229762
I can fix the SIGINT issue. I think the problem is in the fact that the TTY
is set to raw mode, so in order to send the SIGINT signal to the subprocess,
you need to listen for
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new de5b3a60b5 Prepare docs 1st wave of Providers
eladkal merged PR #35589:
URL: https://github.com/apache/airflow/pull/35589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hussein-awala opened a new pull request, #33371:
URL: https://github.com/apache/airflow/pull/33371
This PR updates the labels used in `runs-on` to migrate the workflows to the
new GHA runners running on Airflow EKS cluster, and managed by an Actions
Runner Controller (ARC).
hussein-awala closed pull request #33371: Migrate the CI workflows to the new
runners on EKS cluster
URL: https://github.com/apache/airflow/pull/33371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 938885f5b5 add comment for schema (#35588)
potiuk merged PR #35588:
URL: https://github.com/apache/airflow/pull/35588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eladkal opened a new pull request, #35589:
URL: https://github.com/apache/airflow/pull/35589
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
potiuk commented on PR #35547:
URL: https://github.com/apache/airflow/pull/35547#issuecomment-180776
LGTM but I'd love @utkarsharma2 to take a look as this is so fresh
contribution :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
potiuk commented on PR #35527:
URL: https://github.com/apache/airflow/pull/35527#issuecomment-1807221503
Yep. Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on PR #35578:
URL: https://github.com/apache/airflow/pull/35578#issuecomment-1807220517
It fails tests though :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
potiuk commented on PR #35586:
URL: https://github.com/apache/airflow/pull/35586#issuecomment-1807219557
All right .
I **think** that one is already going to be green... One example for easier
review (but there are more in the CI job output):
eladkal commented on PR #35210:
URL: https://github.com/apache/airflow/pull/35210#issuecomment-1807219135
This looks really good!
I will find time this week to test it as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new a9a1b0d990 Update providers metadata 2023-11-12
eladkal merged PR #35587:
URL: https://github.com/apache/airflow/pull/35587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
romsharon98 opened a new pull request, #35588:
URL: https://github.com/apache/airflow/pull/35588
It's not a straight forward that the schema is changeable.
I needed to check the elasticsearch-secret for knowing schema is a part of
connection and then changed it to https.
Thought it
eladkal commented on issue #35540:
URL: https://github.com/apache/airflow/issues/35540#issuecomment-1807211677
Thank you everyone.
Providers are released (http and discord providers are excluded and RC2 will
follow shortly)
I invite everyone to help improve providers for the next
eladkal closed issue #35540: Status of testing Providers that were prepared on
November 08, 2023
URL: https://github.com/apache/airflow/issues/35540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
eladkal opened a new pull request, #35587:
URL: https://github.com/apache/airflow/pull/35587
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch add-documentation-2023-11-08
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
was 8c91aa5df4 Remove http and discord providers
The revisions that were on this branch are
eladkal merged PR #891:
URL: https://github.com/apache/airflow-site/pull/891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Author: eladkal
Date: Sun Nov 12 18:43:28 2023
New Revision: 65227
Log:
Release Airflow Providers on 2023-11-12
Added:
release/airflow/providers/apache-airflow-providers-amazon-8.11.0.tar.gz
- copied unchanged from r65226,
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch add-documentation-2023-11-08
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
from ec013cbb6e Add documentation for packages - 2023-11-08
add 8c91aa5df4 Remove http
This is an automated email from the ASF dual-hosted git repository.
jscheffl pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 0b995602e6 Make raw HTML descriptions
jscheffl merged PR #35460:
URL: https://github.com/apache/airflow/pull/35460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on issue #33426:
URL: https://github.com/apache/airflow/issues/33426#issuecomment-1807198703
Yeah. Start with the docs. I think we might want to do more of a consistency
push when we add traces and then we can clean it up and make some consistent
approach.
--
This is an
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new cd296d2068 KubernetesExecutor observability
potiuk closed issue #31957: Airflow Observability Improvement Request
URL: https://github.com/apache/airflow/issues/31957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk merged PR #35579:
URL: https://github.com/apache/airflow/pull/35579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on PR #35460:
URL: https://github.com/apache/airflow/pull/35460#issuecomment-1807191661
> > I think the only thing we need is `.significant` change description for
relese notes.
>
> @potiuk how about the one already in? -->
jscheffl commented on PR #35460:
URL: https://github.com/apache/airflow/pull/35460#issuecomment-1807189564
> I think the only thing we need is `.significant` change description for
relese notes.
@potiuk how about the one already in? -->
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 5a6dcfd865 Refactor docker operator attribute
potiuk merged PR #35571:
URL: https://github.com/apache/airflow/pull/35571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 4b63e36dbf Fix Scheduler and triggerer crashes in
potiuk merged PR #35181:
URL: https://github.com/apache/airflow/pull/35181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 6779c49812 Merge AWS DMS tests into the single
potiuk merged PR #35585:
URL: https://github.com/apache/airflow/pull/35585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 0baa73116a Updating
potiuk commented on PR #35460:
URL: https://github.com/apache/airflow/pull/35460#issuecomment-1807170478
I think the only thing we need is `.significant` change description for
relese notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
potiuk commented on PR #35460:
URL: https://github.com/apache/airflow/pull/35460#issuecomment-1807170156
Looks like all checks passed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on PR #35586:
URL: https://github.com/apache/airflow/pull/35586#issuecomment-1807162221
I know there is a lot of code moved here, but I think the easiest way to
review (except the regular - code quality) is to see result of this one run.
Anyone should be able review
potiuk opened a new pull request, #35586:
URL: https://github.com/apache/airflow/pull/35586
This PR moves the functionality of preparing provider packages from a python
script inside Breeze CI image to breeze Python package.
This is the first of the series of moves that will simplify
hussein-awala commented on issue #32585:
URL: https://github.com/apache/airflow/issues/32585#issuecomment-1807152803
> I can confirm that this is still happening.
>
> ```
> name = "apache-airflow"
> version = "2.7.2"
>
> name = "apache-airflow-providers-apache-kafka"
>
dstandish commented on PR #35392:
URL: https://github.com/apache/airflow/pull/35392#issuecomment-1807149863
> > @hussein-awala can you explain what `ignore_first` means, i.e. what the
behavior is as compared with `enable`, perhaps with some examples?
>
> Yes, I will add some examples
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new dc74d3327e Feature/add templating for PVC
eladkal closed issue #32581: Add Templating for logs PVC storageClassName
URL: https://github.com/apache/airflow/issues/32581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eladkal merged PR #35581:
URL: https://github.com/apache/airflow/pull/35581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Taragolis opened a new pull request, #35585:
URL: https://github.com/apache/airflow/pull/35585
related: https://github.com/apache/airflow/issues/35442
---
**^ Add meaningful description above**
Read the **[Pull Request
Taragolis commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1390385985
##
tests/providers/microsoft/azure/hooks/test_azure_synapse_pipeline.py:
##
Review Comment:
Need to rename this module to
84 matches
Mail list logo