Re: [PR] Added get_extra_dejson method with nested parameter in Connection [airflow]

2024-05-26 Thread via GitHub
dabla commented on PR #39811: URL: https://github.com/apache/airflow/pull/39811#issuecomment-2132699936 > Maybe we should fix it in the UI side rather than try to create workaround? Connection UI itself provided by [FAB](https://flask-appbuilder.readthedocs.io/en/latest/), there is

Re: [I] Status of testing Providers that were prepared on May 26, 2024 [airflow]

2024-05-26 Thread via GitHub
grrolland commented on issue #39842: URL: https://github.com/apache/airflow/issues/39842#issuecomment-2132646560 Provider sftp: 4.10.1rc1 All my changes checked too. All is fine.

Re: [I] Executor reports task instance (...) finished (failed) although the task says it's queued [airflow]

2024-05-26 Thread via GitHub
nghilethanh-atherlabs commented on issue #39717: URL: https://github.com/apache/airflow/issues/39717#issuecomment-2132605772 similar issue here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Status of testing Providers that were prepared on May 26, 2024 [airflow]

2024-05-26 Thread via GitHub
EricGao888 commented on issue #39842: URL: https://github.com/apache/airflow/issues/39842#issuecomment-2132580821 Hi @eladkal , I've tested #39627 and it is working fine. THX : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] Incorrect notation for datasets changed during runtime. [airflow]

2024-05-26 Thread via GitHub
phi-friday opened a new issue, #39863: URL: https://github.com/apache/airflow/issues/39863 ### Apache Airflow version 2.9.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When I modified the dataset during runtime, as

(airflow) branch main updated: Switch AzureDataLakeStorageV2Hook to use DefaultAzureCredential for managed identity/workload auth (#38497)

2024-05-26 Thread weilee
This is an automated email from the ASF dual-hosted git repository. weilee pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d5f81a4e2d Switch AzureDataLakeStorageV2Hook to

Re: [PR] Switch AzureDataLakeStorageV2Hook to use ManagedIdentityCredential for managed identity/workload auth [airflow]

2024-05-26 Thread via GitHub
Lee-W merged PR #38497: URL: https://github.com/apache/airflow/pull/38497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FIX bug duplicated add base_folder to oss_remote_log_location in oss_wri… [airflow]

2024-05-26 Thread via GitHub
github-actions[bot] commented on PR #38917: URL: https://github.com/apache/airflow/pull/38917#issuecomment-2132447040 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[PR] Add running tests against 2 7 [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new pull request, #39862: URL: https://github.com/apache/airflow/pull/39862 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Add a warning message to KPO to warn of one second interval logs duplication [airflow]

2024-05-26 Thread via GitHub
fdemiane commented on PR #39861: URL: https://github.com/apache/airflow/pull/39861#issuecomment-2132400208 I opened this pull request for #39236 pull request, but I am not really sure if this is the correct way to go, as this is a rare occurrence, and logs might get polluted (space

Re: [I] KubernetesPodOperator duplicating logs when interrupted [airflow]

2024-05-26 Thread via GitHub
fdemiane commented on issue #39236: URL: https://github.com/apache/airflow/issues/39236#issuecomment-2132400038 I opened a pull request, but I am not really sure if this is the correct way to go, as this is a rare occurrence, and logs might get polluted (space consumed is minimal, but

(airflow) branch main updated: Change type definition for `provider_info_cache` decorator (#39750)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4dffec4d92 Change type definition for

Re: [PR] Change type definition for `provider_info_cache` decorator [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39750: URL: https://github.com/apache/airflow/pull/39750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Add a warning message to KPO to warn of one second interval logs duplication [airflow]

2024-05-26 Thread via GitHub
fdemiane opened a new pull request, #39861: URL: https://github.com/apache/airflow/pull/39861 Add a warning message to KPO to warn of one second interval logs duplication. The KubernetesPodOperator is duplicating the last one second logs when a pod is interrupted, and this is because

(airflow) branch main updated: Improve typing for allowed/failed_states in TriggerDagRunOperator (#39855)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ad7cb99fcd Improve typing for

Re: [PR] Improve typing for allowed/failed_states in TriggerDagRunOperator [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39855: URL: https://github.com/apache/airflow/pull/39855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Resolving EMR notebook deprecated warnings [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39829: URL: https://github.com/apache/airflow/pull/39829#issuecomment-2132396512 Can you resolve conflicts please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(airflow) branch main updated (7ad6b98f58 -> aec3f80278)

2024-05-26 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 7ad6b98f58 remove deprecation drill (#39732) add aec3f80278 Bump docker version to 7.1.0 (#39839) No new

Re: [PR] Bump docker version to 7.1.0 [airflow]

2024-05-26 Thread via GitHub
eladkal merged PR #39839: URL: https://github.com/apache/airflow/pull/39839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Retry connecting to database when Jobs heartbeat [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39770: URL: https://github.com/apache/airflow/pull/39770#issuecomment-2132391294 I think better approach is to extract internal method and use `@retry_db_transaction` decorator. -- This is an automated message from the Apache Git Service. To respond to the

(airflow) branch main updated: remove deprecation drill (#39732)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7ad6b98f58 remove deprecation drill (#39732)

Re: [PR] remove deprecation drill [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39732: URL: https://github.com/apache/airflow/pull/39732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Status of testing Providers that were prepared on May 26, 2024 [airflow]

2024-05-26 Thread via GitHub
shahar1 commented on issue #39842: URL: https://github.com/apache/airflow/issues/39842#issuecomment-2132388607 #39695 is working fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] KubernetesPodOperator duplicating logs when interrupted [airflow]

2024-05-26 Thread via GitHub
fdemiane commented on issue #39236: URL: https://github.com/apache/airflow/issues/39236#issuecomment-2132387258 If we actually look at the logs, the logs that have been duplicated are within one second. If we look at the code

Re: [PR] Add DAGify in the list of tools in the Apache Airflow ecosystem [airflow-site]

2024-05-26 Thread via GitHub
potiuk commented on PR #1015: URL: https://github.com/apache/airflow-site/pull/1015#issuecomment-2132384607 > This is linked to Issue: #1016 There is no need for an issue. PR is enough. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add `mssql` integration tests and relocate existing unit tests [airflow]

2024-05-26 Thread via GitHub
potiuk commented on code in PR #39831: URL: https://github.com/apache/airflow/pull/39831#discussion_r1615320846 ## .github/workflows/integration-tests.yml: ## @@ -140,6 +140,11 @@ jobs: breeze testing integration-tests --integration qdrant breeze down

Re: [I] Status of testing Providers that were prepared on May 26, 2024 [airflow]

2024-05-26 Thread via GitHub
potiuk commented on issue #39842: URL: https://github.com/apache/airflow/issues/39842#issuecomment-2132380088 All my changes checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Status of testing Providers that were prepared on May 26, 2024 [airflow]

2024-05-26 Thread via GitHub
gopidesupavan commented on issue #39842: URL: https://github.com/apache/airflow/issues/39842#issuecomment-2132372298 Hi @eladkal , i have tested #39592 , it is working fine. thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Neo4j SQL Misnomer [airflow]

2024-05-26 Thread via GitHub
boring-cyborg[bot] commented on issue #39860: URL: https://github.com/apache/airflow/issues/39860#issuecomment-2132370017 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[I] Neo4j SQL Misnomer [airflow]

2024-05-26 Thread via GitHub
ThomasThelen opened a new issue, #39860: URL: https://github.com/apache/airflow/issues/39860 ### Apache Airflow Provider(s) neo4j ### Versions of Apache Airflow Providers _No response_ ### Apache Airflow version 2.9.0 ### Operating System

(airflow) branch main updated: Quarantine test_backfill_failed_dag_with_upstream_failed_task (#39859)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8615419b77 Quarantine

Re: [PR] Quarantine test_backfill_failed_dag_with_upstream_failed_task [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39859: URL: https://github.com/apache/airflow/pull/39859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix openlineage dbt test for openlineage 1.15 [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39857: URL: https://github.com/apache/airflow/pull/39857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] OpenLineage 1.15.0 breaks dbt openlineage integration when running on top of Airlfow 2.9.1 [airflow]

2024-05-26 Thread via GitHub
potiuk closed issue #39854: OpenLineage 1.15.0 breaks dbt openlineage integration when running on top of Airlfow 2.9.1 URL: https://github.com/apache/airflow/issues/39854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(airflow) branch main updated (df0790d2c5 -> 9c034abdec)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from df0790d2c5 Remove redundant code from Dockerfile (#39833) add 9c034abdec Fix openlineage dbt test for openlineage

(airflow) branch main updated (2201154252 -> df0790d2c5)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2201154252 Fix long-standing side-effect of test replacing formatter (#39853) add df0790d2c5 Remove redundant

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-26 Thread via GitHub
boring-cyborg[bot] commented on PR #39833: URL: https://github.com/apache/airflow/pull/39833#issuecomment-2132343782 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39833: URL: https://github.com/apache/airflow/pull/39833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39833: URL: https://github.com/apache/airflow/pull/39833#issuecomment-2132343239 Non-DB tests fixed already in main. merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Quarantine test_backfill_failed_dag_with_upstream_failed_task [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new pull request, #39859: URL: https://github.com/apache/airflow/pull/39859 Related issue: #39858 --- **^ Add meaningful description above** Read the **[Pull Request

[I] Quarantined test_backfill_failed_dag_with_upstream_failed_task test due to Deadlock [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new issue, #39858: URL: https://github.com/apache/airflow/issues/39858 ### Body The test `test_backfill_failed_dag_with_upstream_failed_task` in tests/jobs/test_backfill_job.py often fails due to deadlock detected. Here is typical stack trace/error:

Re: [PR] Fix openlineage dbt test for openlineage 1.15 [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39857: URL: https://github.com/apache/airflow/pull/39857#issuecomment-2132311549 cc: @mobuchowski @kacpermuda @JDarDagran -> I am not sure if this is the right fix and whether the change was intentional - it suspiciously looks like a breaking change introduce by v1

[PR] Fix openlineage dbt test for openlineage 1.15 [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new pull request, #39857: URL: https://github.com/apache/airflow/pull/39857 The new openlinege 1.15.0 changes type of Run and Job object from dict to classes and the test was testing it for dict key. This PR fixes it so that the test works for both variants - before

Re: [I] "Add Dag Run" /dagrun/add page issue [airflow]

2024-05-26 Thread via GitHub
boring-cyborg[bot] commented on issue #39856: URL: https://github.com/apache/airflow/issues/39856#issuecomment-2132302236 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[I] "Add Dag Run" /dagrun/add page issue [airflow]

2024-05-26 Thread via GitHub
fliaj opened a new issue, #39856: URL: https://github.com/apache/airflow/issues/39856 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.8.1 ### What happened? 1. I created DAG

[PR] Improve typing for allowed/failed_states in TriggerDagRunOperator [airflow]

2024-05-26 Thread via GitHub
josh-fell opened a new pull request, #39855: URL: https://github.com/apache/airflow/pull/39855 This surfaces another explicit option when specifying `allowed_states` and/or `failed_states` -- using the DagRunState enum -- when DAG authors look at the Python API docs for this operator. Also

Re: [I] OpenLineage 1.15.0 breaks dbt openlineage integration when running on top of Airlfow 2.9.1 [airflow]

2024-05-26 Thread via GitHub
potiuk commented on issue #39854: URL: https://github.com/apache/airflow/issues/39854#issuecomment-2132299271 That's the change vs. regular PRs where it works fine: ``` < openlineage-integration-common==1.14.0 < openlineage-python==1.14.0 < openlineage_sql==1.14.0 --- >

[I] OpenLineage 1.15.0 breaks dbt openlineage integration when running on top of Airlfow 2.9.1 [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new issue, #39854: URL: https://github.com/apache/airflow/issues/39854 ### Body The lates openlineage libraries (1.15.0) break dbt integration when running tests in Airflow 2.9.1 compatibility tests. Example failure:

(airflow) branch main updated: Fix long-standing side-effect of test replacing formatter (#39853)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2201154252 Fix long-standing side-effect of test

Re: [PR] Fix long-standing side-effect of test replacing formatter [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39853: URL: https://github.com/apache/airflow/pull/39853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add `mssql` integration tests and relocate existing unit tests [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39831: URL: https://github.com/apache/airflow/pull/39831#issuecomment-2132296236 One more thing: you also need to add Mssql as individual integration to test in `.github/workflows/integration-tests.yml`. This way the integration tests will be run on public runners

(airflow) branch main updated (1fc551b146 -> 993053ad3e)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 1fc551b146 Fail image build in case dependencies are not regenerated (#39847) add 993053ad3e Also limit

Re: [PR] Also limit concurrent uv downloads when building [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39852: URL: https://github.com/apache/airflow/pull/39852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix long-standing side-effect of test replacing formatter [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new pull request, #39853: URL: https://github.com/apache/airflow/pull/39853 There was a long-standing test that had a side-effect of replacing formatter and recently it started to fail in PRs. This PR patches the formatter only for time of the tests.

Re: [PR] Add `mssql` integration tests and relocate existing unit tests [airflow]

2024-05-26 Thread via GitHub
shahar1 commented on code in PR #39831: URL: https://github.com/apache/airflow/pull/39831#discussion_r1615264975 ## tests/integration/providers/google/cloud/transfers/test_mssql_to_gcs.py: ## @@ -17,102 +17,65 @@ # under the License. from __future__ import annotations

[PR] Also limit concurrent uv downloads when building [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new pull request, #39852: URL: https://github.com/apache/airflow/pull/39852 Follow up after #39810 - we have two places where we should set the limits - also in common.sh. --- **^ Add meaningful description above** Read the **[Pull

Re: [PR] Correctly select task in DAG Graph View when clicking on its name [airflow]

2024-05-26 Thread via GitHub
jonhspyro commented on code in PR #38782: URL: https://github.com/apache/airflow/pull/38782#discussion_r1614807696 ## airflow/www/static/js/dag/details/graph/DagNode.tsx: ## @@ -126,10 +125,6 @@ const DagNode = ({ label={taskName} isOpen={isOpen}

(airflow) branch main updated: Fail image build in case dependencies are not regenerated (#39847)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1fc551b146 Fail image build in case dependencies

Re: [PR] Fail image build in case dependencies are not regenerated [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39847: URL: https://github.com/apache/airflow/pull/39847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fail image build in case dependencies are not regenerated [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39847: URL: https://github.com/apache/airflow/pull/39847#issuecomment-2132271267 Failing tests unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Upgrade to FAB 4.5.0 [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new pull request, #39851: URL: https://github.com/apache/airflow/pull/39851 --- **^ Add meaningful description above** Read the **[Pull Request

(airflow) branch main updated: uv version bump to 0.2.3 (#39848)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cda4a8604f uv version bump to 0.2.3 (#39848)

Re: [PR] uv version bump to 0.2.3 [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39848: URL: https://github.com/apache/airflow/pull/39848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] uv version bump to 0.2.3 [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39848: URL: https://github.com/apache/airflow/pull/39848#issuecomment-2132270647 Failing tests are side-effect that also affect other changes (need to be traced). -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] mypy version bump 1.10.0 [airflow]

2024-05-26 Thread via GitHub
dirrao opened a new pull request, #39850: URL: https://github.com/apache/airflow/pull/39850 mypy version bump 1.10.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] ruff version bump 0.4.5 [airflow]

2024-05-26 Thread via GitHub
dirrao opened a new pull request, #39849: URL: https://github.com/apache/airflow/pull/39849 ruff version bump 0.4.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] uv version bump to 0.2.3 [airflow]

2024-05-26 Thread via GitHub
dirrao opened a new pull request, #39848: URL: https://github.com/apache/airflow/pull/39848 uv version bump to 0.2.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Run tests for Providers also for Airflow 2.8 [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39606: URL: https://github.com/apache/airflow/pull/39606#issuecomment-2132247705 I would love to merge that one and work on 2.7 tests :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fail image build in case dependencies are not regenerated [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39847: URL: https://github.com/apache/airflow/pull/39847#issuecomment-2132244548 This is why for example https://github.com/apache/airflow/pull/39839 - failed before I regenerated the dependencies. The "build image" was not failing, but "wait for CI image" was

[PR] Fail image build in case dependencies are not regenerated [airflow]

2024-05-26 Thread via GitHub
potiuk opened a new pull request, #39847: URL: https://github.com/apache/airflow/pull/39847 When dependencies are not regenerated before pushing the PR, the CI image build should fail rather than retry with regenerated dependencies. --- **^ Add

(airflow) branch main updated: Resolving mysql deprecated operator warnings (#39725)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e3c31752f1 Resolving mysql deprecated operator

Re: [PR] Resolving mysql deprecated operator warnings [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39725: URL: https://github.com/apache/airflow/pull/39725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Resolving google bigquery deprecated warnings (#39841)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8fbf466d50 Resolving google bigquery deprecated

Re: [PR] Resolving google bigquery deprecated warnings [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39841: URL: https://github.com/apache/airflow/pull/39841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-26 Thread via GitHub
josh-fell commented on PR #39767: URL: https://github.com/apache/airflow/pull/39767#issuecomment-2132231247 Congrats @vinay2242g  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(airflow) branch main updated: Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook (#39767)

2024-05-26 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d4fe325f84 Adding params. to

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-26 Thread via GitHub
boring-cyborg[bot] commented on PR #39767: URL: https://github.com/apache/airflow/pull/39767#issuecomment-2132227676 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-26 Thread via GitHub
josh-fell merged PR #39767: URL: https://github.com/apache/airflow/pull/39767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (42e93bfc8b -> 478ac9cb87)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 42e93bfc8b helm version upgrade (#39828) add 478ac9cb87 Update Iceberg provider name in provider.yaml (#39846)

Re: [PR] Update Iceberg provider name in provider.yaml [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39846: URL: https://github.com/apache/airflow/pull/39846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39745: URL: https://github.com/apache/airflow/pull/39745#issuecomment-2132226647 Looks good @dstandish - are you good with it ? Avoiding server-side error is worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Use SKIP LOCKED instead of NOWAIT in mini scheduler [airflow]

2024-05-26 Thread via GitHub
potiuk commented on code in PR #39745: URL: https://github.com/apache/airflow/pull/39745#discussion_r1615204620 ## airflow/models/taskinstance.py: ## @@ -3476,8 +3476,13 @@ def _schedule_downstream_tasks( run_id=ti.run_id, ),

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39833: URL: https://github.com/apache/airflow/pull/39833#issuecomment-2132219330 No - it's real duplication. The pre-commit looks for file name in the comment: "# The content below is automatically copied from scripts/docker/create_prod_venv.sh" and insert the

(airflow) branch main updated: helm version upgrade (#39828)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 42e93bfc8b helm version upgrade (#39828)

Re: [PR] helm version upgrade [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39828: URL: https://github.com/apache/airflow/pull/39828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Allow FTPHook to change port number [airflow]

2024-05-26 Thread via GitHub
VelmiraPetkova commented on PR #39465: URL: https://github.com/apache/airflow/pull/39465#issuecomment-2132210801 Sorry for the delay. I updated the PR. Could you please take a look? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Update Iceberg provider name in provider.yaml [airflow]

2024-05-26 Thread via GitHub
eladkal opened a new pull request, #39846: URL: https://github.com/apache/airflow/pull/39846 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(airflow) branch main updated: Resolving ECS fargate deprecated warnings (#39834)

2024-05-26 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8a35a6abdc Resolving ECS fargate deprecated

Re: [PR] Resolving ECS fargate deprecated warnings [airflow]

2024-05-26 Thread via GitHub
eladkal merged PR #39834: URL: https://github.com/apache/airflow/pull/39834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix failing main after merging serialization fix [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39845: URL: https://github.com/apache/airflow/pull/39845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Fix failing main after merging serialization fix (#39845)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 54ed71f9b0 Fix failing main after merging

Re: [I] Status of testing Providers that were prepared on May 26, 2024 [airflow]

2024-05-26 Thread via GitHub
uzhastik commented on issue #39842: URL: https://github.com/apache/airflow/issues/39842#issuecomment-2132187569 >Provider [yandex: 3.11.1rc1](https://pypi.org/project/apache-airflow-providers-yandex/3.11.1rc1) Looks good, this version has been checked on my test dag and old active

Re: [PR] Exponential Backoff Not Functioning in BaseSensorOperator Reschedule Mode [airflow]

2024-05-26 Thread via GitHub
sanket2000 commented on PR #39823: URL: https://github.com/apache/airflow/pull/39823#issuecomment-2132182973 I would also encourage authors and participants of PR #30669 to take a look as this approach doesn't involve DB column changes proposed in the above mentioned PR -- This is an

Re: [PR] Exponential Backoff Not Functioning in BaseSensorOperator Reschedule Mode [airflow]

2024-05-26 Thread via GitHub
sanket2000 commented on PR #39823: URL: https://github.com/apache/airflow/pull/39823#issuecomment-2132182389 I have added a change, if it looks good `proke_count` can potentially be remove altogether. We can estimate the pokes based on start time and run duration. -- This is an

Re: [PR] Exponential Backoff Not Functioning in BaseSensorOperator Reschedule Mode [airflow]

2024-05-26 Thread via GitHub
sanket2000 commented on code in PR #39823: URL: https://github.com/apache/airflow/pull/39823#discussion_r1615158404 ## airflow/sensors/base.py: ## @@ -322,7 +322,7 @@ def run_duration() -> float: raise AirflowRescheduleException(reschedule_date)

(airflow) branch main updated: Image used for k8s tests copies airflow sources with airflow user (#39843)

2024-05-26 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cd25d1a458 Image used for k8s tests copies airflow

Re: [PR] Image used for k8s tests copies airflow sources with airflow user [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39843: URL: https://github.com/apache/airflow/pull/39843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Image used for k8s tests copies airflow sources with airflow user [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39843: URL: https://github.com/apache/airflow/pull/39843#issuecomment-2132171908 Merging. Other failing tests fixed in #39845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Revert "Fix TIPydantic serialization of MappedOperator (#39288)" [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39844: URL: https://github.com/apache/airflow/pull/39844#issuecomment-2132171300 Actually - there is a simple fix in #39845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Revert "Fix TIPydantic serialization of MappedOperator (#39288)" [airflow]

2024-05-26 Thread via GitHub
potiuk closed pull request #39844: Revert "Fix TIPydantic serialization of MappedOperator (#39288)" URL: https://github.com/apache/airflow/pull/39844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   >