Re: [PR] AIP-64: Add TaskInstance history table [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on code in PR #39951: URL: https://github.com/apache/airflow/pull/39951#discussion_r1634284966 ## airflow/models/taskinstancehistory.py: ## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] Adding Glue Data Quality Rule Recommendation Run [airflow]

2024-06-10 Thread via GitHub
gopidesupavan commented on PR #40014: URL: https://github.com/apache/airflow/pull/40014#issuecomment-2159918072 @syedahsn Are you setting env_id manually? I am using env_id for the database name and tablename. if it has anything `-` in the env_id it may cause issue,. I guess Athena wont al

Re: [PR] AIP-64: Add TaskInstance history table [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on code in PR #39951: URL: https://github.com/apache/airflow/pull/39951#discussion_r1634282605 ## airflow/models/taskinstancehistory.py: ## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] AIP-64: Add TaskInstance history table [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on code in PR #39951: URL: https://github.com/apache/airflow/pull/39951#discussion_r1634281806 ## airflow/models/taskinstancehistory.py: ## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] AIP-64: Add TaskInstance history table [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on code in PR #39951: URL: https://github.com/apache/airflow/pull/39951#discussion_r1634280656 ## airflow/models/__init__.py: ## @@ -120,6 +121,7 @@ def __getattr__(name): "SlaMiss": "airflow.models.slamiss", "TaskFail": "airflow.models.taskfail",

Re: [PR] Adding Glue Data Quality Rule Recommendation Run [airflow]

2024-06-10 Thread via GitHub
gopidesupavan commented on PR #40014: URL: https://github.com/apache/airflow/pull/40014#issuecomment-2159888393 Hi @syedahsn Yes, have tested locally. Just triggered one run for both the example_glue_data_quality_with_recommendation and example_glue_data_quality the outputs are below.

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
Usiel commented on PR #40156: URL: https://github.com/apache/airflow/pull/40156#issuecomment-2159841574 Ok, done. Latest push is rebased on `main`, includes the serialization as list and the additional suggestions. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
Usiel commented on PR #40156: URL: https://github.com/apache/airflow/pull/40156#issuecomment-2159822504 Apologies for the noise, was fighting with a test. I'll push another version in a bit with the incorporated comments. -- This is an automated message from the Apache Git Service. To res

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
Usiel commented on code in PR #40156: URL: https://github.com/apache/airflow/pull/40156#discussion_r1634207720 ## airflow/serialization/serialized_objects.py: ## @@ -847,10 +847,10 @@ def _serialize_params_dict(cls, params: ParamsDict | dict): return serialized_params

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on code in PR #40156: URL: https://github.com/apache/airflow/pull/40156#discussion_r1634197205 ## airflow/serialization/serialized_objects.py: ## @@ -847,10 +847,10 @@ def _serialize_params_dict(cls, params: ParamsDict | dict): return serialized_para

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on code in PR #40156: URL: https://github.com/apache/airflow/pull/40156#discussion_r1634196672 ## airflow/serialization/serialized_objects.py: ## @@ -847,10 +847,10 @@ def _serialize_params_dict(cls, params: ParamsDict | dict): return serialized_para

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on code in PR #40156: URL: https://github.com/apache/airflow/pull/40156#discussion_r1634195757 ## airflow/serialization/serialized_objects.py: ## @@ -847,10 +847,10 @@ def _serialize_params_dict(cls, params: ParamsDict | dict): return serialized_para

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
Usiel commented on PR #40156: URL: https://github.com/apache/airflow/pull/40156#issuecomment-2159715773 Serializing as a list would require some additional handling of already serialized DAGs (using a dict) though -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
Usiel commented on PR #40156: URL: https://github.com/apache/airflow/pull/40156#issuecomment-2159713678 > Instead of needing an extra key and extra nesting, should we just serialise params as list of key-value pairs instead? I like this. I disregarded it previously, because I thought

[PR] Fix minor typo in dags.rst [airflow]

2024-06-10 Thread via GitHub
bangjiehan opened a new pull request, #40169: URL: https://github.com/apache/airflow/pull/40169 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on PR #40156: URL: https://github.com/apache/airflow/pull/40156#issuecomment-2159695990 Alternatively maybe we can serialise the key order under a separate key? This is proably slightly more compact in most cases as well. -- This is an automated message from the Apache

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
uranusjr commented on PR #40156: URL: https://github.com/apache/airflow/pull/40156#issuecomment-2159693784 Instead of needing an extra key and extra nesting, should we just serialise params as list of key-value pairs instead? -- This is an automated message from the Apache Git Service. To

Re: [I] Webserver logs not showing failed login attempts [airflow]

2024-06-10 Thread via GitHub
boring-cyborg[bot] commented on issue #40168: URL: https://github.com/apache/airflow/issues/40168#issuecomment-2159686523 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Webserver logs not showing failed login attempts [airflow]

2024-06-10 Thread via GitHub
ooehlers opened a new issue, #40168: URL: https://github.com/apache/airflow/issues/40168 ### Apache Airflow version 2.9.2 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When webserver logs are enabled they do not show

Re: [PR] Add task documentation to details tab in grid view. [airflow]

2024-06-10 Thread via GitHub
tirkarthi commented on PR #39899: URL: https://github.com/apache/airflow/pull/39899#issuecomment-2159667419 Thank you very much all for constant updates to the PR. Happy to see this finally merged. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Yandex provider templating [airflow]

2024-06-10 Thread via GitHub
pavelgein commented on code in PR #40165: URL: https://github.com/apache/airflow/pull/40165#discussion_r1634085248 ## airflow/providers/yandex/operators/dataproc.py: ## @@ -37,6 +37,25 @@ class InitializationAction: timeout: int # Execution timeout +# These two functio

Re: [PR] Ensures DAG params order regardless of backend [airflow]

2024-06-10 Thread via GitHub
jedcunningham commented on code in PR #40156: URL: https://github.com/apache/airflow/pull/40156#discussion_r1634013967 ## airflow/serialization/serialized_objects.py: ## @@ -831,14 +831,17 @@ def is_serialized(val): def _serialize_params_dict(cls, params: ParamsDict | dict)

Re: [PR] Prevent start trigger initialization in scheduler [airflow]

2024-06-10 Thread via GitHub
jedcunningham commented on code in PR #39585: URL: https://github.com/apache/airflow/pull/39585#discussion_r1634005883 ## airflow/models/taskinstance.py: ## @@ -3000,12 +3019,12 @@ def _execute_task(self, context: Context, task_orig: Operator): return _execute_task(sel

Re: [PR] feat(chart): allow valueFrom in env config of components (#40095) [airflow]

2024-06-10 Thread via GitHub
jedcunningham commented on PR #40135: URL: https://github.com/apache/airflow/pull/40135#issuecomment-2159540759 Thanks @dada-engineer! Congrats on your first commit 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] feat(chart): allow valueFrom in env config of components (#40095) [airflow]

2024-06-10 Thread via GitHub
jedcunningham merged PR #40135: URL: https://github.com/apache/airflow/pull/40135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

(airflow) branch main updated: Chart: Allow valueFrom in env config of components (#40135)

2024-06-10 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 279e8b7772 Chart: Allow valueFrom in env con

Re: [PR] feat(chart): allow valueFrom in env config of components (#40095) [airflow]

2024-06-10 Thread via GitHub
boring-cyborg[bot] commented on PR #40135: URL: https://github.com/apache/airflow/pull/40135#issuecomment-2159540116 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [I] Chart: Allow to extend cleanup cronjob env with custom envs from secrets or config maps [airflow]

2024-06-10 Thread via GitHub
jedcunningham closed issue #40095: Chart: Allow to extend cleanup cronjob env with custom envs from secrets or config maps URL: https://github.com/apache/airflow/issues/40095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] SQLSensor does not time out [airflow]

2024-06-10 Thread via GitHub
github-actions[bot] commented on issue #39219: URL: https://github.com/apache/airflow/issues/39219#issuecomment-2159531213 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] SQLSensor does not time out [airflow]

2024-06-10 Thread via GitHub
github-actions[bot] closed issue #39219: SQLSensor does not time out URL: https://github.com/apache/airflow/issues/39219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Adding Glue Data Quality Rule Recommendation Run [airflow]

2024-06-10 Thread via GitHub
syedahsn commented on PR #40014: URL: https://github.com/apache/airflow/pull/40014#issuecomment-2159446182 I'm trying to run the system test locally, before I get have it running in our system test dashboard, but I'm getting some errors. In the `create_database` task, I get the following

Re: [I] Negsignal.SIGKILL error on macOS [airflow]

2024-06-10 Thread via GitHub
karanalang commented on issue #10435: URL: https://github.com/apache/airflow/issues/10435#issuecomment-2159403694 I'm seeing the same issue on GCP Composer, the job is running on Dataproc Serverless batches and Composer version is 2.6.6 (Airflow - 2.5.3) .. job completes file but i still ge

Re: [I] Logs disappearing when a task completes as failed and is up to retry [airflow]

2024-06-10 Thread via GitHub
carlospalol commented on issue #31764: URL: https://github.com/apache/airflow/issues/31764#issuecomment-2159323701 Seems related to #39496. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Adding Tiqets to the companies using airflow [airflow]

2024-06-10 Thread via GitHub
boring-cyborg[bot] commented on PR #40096: URL: https://github.com/apache/airflow/pull/40096#issuecomment-2159300165 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

(airflow) branch main updated (d504bfa5d1 -> b93b94397a)

2024-06-10 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from d504bfa5d1 Aip-61: Add validation on task `executor` field (#40030) add b93b94397a added Tiqets to the lis

Re: [PR] Adding Tiqets to the companies using airflow [airflow]

2024-06-10 Thread via GitHub
jedcunningham merged PR #40096: URL: https://github.com/apache/airflow/pull/40096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] revamp was it killed externally question [airflow]

2024-06-10 Thread via GitHub
jedcunningham commented on code in PR #40141: URL: https://github.com/apache/airflow/pull/40141#discussion_r1633835287 ## airflow/jobs/backfill_job_runner.py: ## @@ -313,9 +313,14 @@ def _manage_executor_state( and ti.state in self.STATES_COUNT_AS_RUNNING

Re: [I] Integrate Snowflake Notebook Scheduling with Apache Airflow [airflow]

2024-06-10 Thread via GitHub
boring-cyborg[bot] commented on issue #40167: URL: https://github.com/apache/airflow/issues/40167#issuecomment-2159291981 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] Yandex provider templating [airflow]

2024-06-10 Thread via GitHub
Taragolis commented on code in PR #40165: URL: https://github.com/apache/airflow/pull/40165#discussion_r1633763500 ## airflow/providers/yandex/operators/dataproc.py: ## @@ -37,6 +37,25 @@ class InitializationAction: timeout: int # Execution timeout +# These two functio

[PR] Add try number to StatusBox [airflow]

2024-06-10 Thread via GitHub
curlup opened a new pull request, #40166: URL: https://github.com/apache/airflow/pull/40166 Tiny UI improvement: If there are multiple tries of a task, show the count over the task instance status box in the DAG grid view. This improves visibility into dag history in the grid view

Re: [PR] Yandex provider templating [airflow]

2024-06-10 Thread via GitHub
boring-cyborg[bot] commented on PR #40165: URL: https://github.com/apache/airflow/pull/40165#issuecomment-2159062679 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Yandex provider templating [airflow]

2024-06-10 Thread via GitHub
pavelgein opened a new pull request, #40165: URL: https://github.com/apache/airflow/pull/40165 --- Add templating to Yandex Dataproc Operators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add support for external IdP OIDC token retrieval for Google Cloud Operators. [airflow]

2024-06-10 Thread via GitHub
dybolo commented on code in PR #39873: URL: https://github.com/apache/airflow/pull/39873#discussion_r1633653414 ## airflow/providers/google/cloud/utils/credentials_provider.py: ## @@ -426,3 +459,38 @@ def _get_project_id_from_service_account_email(service_account_email: str) ->

Re: [PR] Add support for external IdP OIDC token retrieval for Google Cloud Operators. [airflow]

2024-06-10 Thread via GitHub
moiseenkov commented on code in PR #39873: URL: https://github.com/apache/airflow/pull/39873#discussion_r1633641842 ## airflow/providers/google/cloud/utils/credentials_provider.py: ## @@ -350,6 +365,24 @@ def _get_credentials_using_credential_config_file(self): return

Re: [PR] Add support for external IdP OIDC token retrieval for Google Cloud Operators. [airflow]

2024-06-10 Thread via GitHub
dybolo commented on code in PR #39873: URL: https://github.com/apache/airflow/pull/39873#discussion_r1633636998 ## airflow/providers/google/cloud/utils/credentials_provider.py: ## @@ -350,6 +365,24 @@ def _get_credentials_using_credential_config_file(self): return cre

Re: [PR] Run system tests using `dag.test()` [airflow]

2024-06-10 Thread via GitHub
vincbeck commented on PR #39176: URL: https://github.com/apache/airflow/pull/39176#issuecomment-2158965349 Just for testing, I tried to run a system test with the backfill approach with `AwsEcsExecutor` and it seems to work (besides the issue I mentioned [here](https://apache-airflow.slack.

Re: [PR] [DNM] Prototype TypedefOperator in Airflow [airflow]

2024-06-10 Thread via GitHub
thomaschow closed pull request #40164: [DNM] Prototype TypedefOperator in Airflow URL: https://github.com/apache/airflow/pull/40164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [DNM] Prototype TypedefOperator in Airflow [airflow]

2024-06-10 Thread via GitHub
boring-cyborg[bot] commented on PR #40164: URL: https://github.com/apache/airflow/pull/40164#issuecomment-2158952276 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] [DNM] Prototype TypedefOperator in Airflow [airflow]

2024-06-10 Thread via GitHub
thomaschow opened a new pull request, #40164: URL: https://github.com/apache/airflow/pull/40164 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst

(airflow) branch main updated: Aip-61: Add validation on task `executor` field (#40030)

2024-06-10 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d504bfa5d1 Aip-61: Add validation on task `execut

Re: [PR] Aip-61: Add validation on task `executor` field [airflow]

2024-06-10 Thread via GitHub
vincbeck merged PR #40030: URL: https://github.com/apache/airflow/pull/40030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] Logs from elastic not visible in Grid menu [airflow]

2024-06-10 Thread via GitHub
sjnov11 commented on issue #39323: URL: https://github.com/apache/airflow/issues/39323#issuecomment-2158863069 Same happens to me. i am using images 2.6.3-python3.11 Grid menu logs call this API: - {host:port}/api/v1/dags/tutorial/dagRuns/scheduled__2024-06-08T00:00:00+00:00/tas

(airflow) branch main updated (74a1931c3b -> 587a5744e8)

2024-06-10 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 74a1931c3b Split Celery integration tests to "celery" and "redis" (#39994) add 587a5744e8 Add task documentatio

Re: [I] Output tasks doc in the UI [airflow]

2024-06-10 Thread via GitHub
bbovenzi closed issue #39676: Output tasks doc in the UI URL: https://github.com/apache/airflow/issues/39676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] Task level documentation in other place than Task Details [airflow]

2024-06-10 Thread via GitHub
bbovenzi closed issue #12750: Task level documentation in other place than Task Details URL: https://github.com/apache/airflow/issues/12750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add task documentation to details tab in grid view. [airflow]

2024-06-10 Thread via GitHub
bbovenzi merged PR #39899: URL: https://github.com/apache/airflow/pull/39899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Add task documentation to details tab in grid view. [airflow]

2024-06-10 Thread via GitHub
jscheffl commented on PR #39899: URL: https://github.com/apache/airflow/pull/39899#issuecomment-2158854063 GREEN - ready to get merged (finally)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Split Celery integration tests in to "redis", "rabbitmq", "sqlalchemy" [airflow]

2024-06-10 Thread via GitHub
eladkal closed issue #34032: Split Celery integration tests in to "redis", "rabbitmq", "sqlalchemy" URL: https://github.com/apache/airflow/issues/34032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

(airflow) branch main updated: Split Celery integration tests to "celery" and "redis" (#39994)

2024-06-10 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 74a1931c3b Split Celery integration tests to "cele

Re: [PR] Split Celery integration tests to "celery" and "redis" [airflow]

2024-06-10 Thread via GitHub
eladkal merged PR #39994: URL: https://github.com/apache/airflow/pull/39994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] AIP-64: Add TaskInstance history table [airflow]

2024-06-10 Thread via GitHub
ashb commented on code in PR #39951: URL: https://github.com/apache/airflow/pull/39951#discussion_r1633446647 ## airflow/migrations/versions/0146_2_10_0_add_task_instance_history.py: ## @@ -86,10 +88,6 @@ def upgrade(): ], name="task_instance_history_ti

Re: [I] Support `limit` and `offset` parameters for List task instances (batch) endpoint [airflow]

2024-06-10 Thread via GitHub
ShakaibKhan commented on issue #40038: URL: https://github.com/apache/airflow/issues/40038#issuecomment-2158596070 I can try adding this to the task instance batch endpoint. I think its just passing the `limit` and `offset` into the body and adding them to the task instance query. If no one

[PR] Fix `GCSToGCSOperator` behavior difference for moving single object [airflow]

2024-06-10 Thread via GitHub
boraberke opened a new pull request, #40162: URL: https://github.com/apache/airflow/pull/40162 `GCSToGCSOperator` did not retain the nested folder structure when moving a single object. This PR merges the logic for single and multiple objects and handles folder structure similar to what `gs

(airflow) branch main updated: Resolve aws provider deprecations in tests (#40123)

2024-06-10 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1a7a67f134 Resolve aws provider deprecations in t

Re: [PR] Resolve aws provider deprecations in tests [airflow]

2024-06-10 Thread via GitHub
vincbeck merged PR #40123: URL: https://github.com/apache/airflow/pull/40123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] EksPodOperator error with deferrable=True [airflow]

2024-06-10 Thread via GitHub
jx2lee commented on issue #39685: URL: https://github.com/apache/airflow/issues/39685#issuecomment-2158572531 Hi! If this doesn't start, can I take it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] Can't use AIRFLOW__CELERY__BROKER_URL_CMD in the Helm Chart [airflow]

2024-06-10 Thread via GitHub
jx2lee commented on issue #39985: URL: https://github.com/apache/airflow/issues/39985#issuecomment-2158562612 Hi! If it doesn't start, could i take it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

(airflow) branch openlineage-process-execution updated (44ba855e1e -> 0e2172dfa6)

2024-06-10 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a change to branch openlineage-process-execution in repository https://gitbox.apache.org/repos/asf/airflow.git discard 44ba855e1e openlineage: execute extraction and message sending in separate process disc

(airflow) branch listener-task-timeout updated (f0128ced4c -> 3d4661dac3)

2024-06-10 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a change to branch listener-task-timeout in repository https://gitbox.apache.org/repos/asf/airflow.git omit f0128ced4c local task job: add timeout, to not kill on_task_instance_success listener prematurel

Re: [PR] Add support for external IdP OIDC token retrieval for Google Cloud Operators. [airflow]

2024-06-10 Thread via GitHub
moiseenkov commented on code in PR #39873: URL: https://github.com/apache/airflow/pull/39873#discussion_r1633349736 ## airflow/providers/google/cloud/utils/credentials_provider.py: ## @@ -426,3 +459,38 @@ def _get_project_id_from_service_account_email(service_account_email: str

Re: [PR] Airflow 2.9.2 has been released [airflow]

2024-06-10 Thread via GitHub
utkarsharma2 merged PR #40159: URL: https://github.com/apache/airflow/pull/40159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

(airflow) branch main updated: Airflow 2.9.2 has been released (#40159)

2024-06-10 Thread utkarsharma
This is an automated email from the ASF dual-hosted git repository. utkarsharma pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e9d8222a19 Airflow 2.9.2 has been released (#4

Re: [PR] Chart: Default airflow version to 2.9.2 [airflow]

2024-06-10 Thread via GitHub
utkarsharma2 merged PR #40160: URL: https://github.com/apache/airflow/pull/40160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

(airflow) branch main updated: Chart: Default airflow version to 2.9.2 (#40160)

2024-06-10 Thread utkarsharma
This is an automated email from the ASF dual-hosted git repository. utkarsharma pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new aabe66f869 Chart: Default airflow version to 2

Re: [I] Databricks provider does not support Azure managed identity if more than one identity exists (e.g. ADF, AKS) [airflow]

2024-06-10 Thread via GitHub
potiuk commented on issue #38762: URL: https://github.com/apache/airflow/issues/38762#issuecomment-2158440920 Let me repeat: > Not as far as I know. But we would love Microsoft team to contribute in this and other relevant features. If anyone wants to contribute to fix this th

Re: [I] Triggering a DAG Run from the DAG Graph View does not redirect to the triggered DAG Run page [airflow]

2024-06-10 Thread via GitHub
pedro-cf commented on issue #37935: URL: https://github.com/apache/airflow/issues/37935#issuecomment-2158433014 > > Greetings @jscheffl , not sure if this was included in the 2.9.2 release, but in 2.9.2: > > If you look at the PR, it's marked as 2.10.0 milestone. sorry about th

Re: [I] Triggering a DAG Run from the DAG Graph View does not redirect to the triggered DAG Run page [airflow]

2024-06-10 Thread via GitHub
potiuk commented on issue #37935: URL: https://github.com/apache/airflow/issues/37935#issuecomment-2158428785 > Greetings @jscheffl , not sure if this was included in the 2.9.2 release, but in 2.9.2: If you look at the PR, it's marked as 2.10.0 milestone. -- This is an automated me

(airflow) branch main updated: Fix typo in providers_manager.py (#40157)

2024-06-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 072c63b539 Fix typo in providers_manager.py (#40157

Re: [PR] Fix typo in providers_manager.py [airflow]

2024-06-10 Thread via GitHub
potiuk merged PR #40157: URL: https://github.com/apache/airflow/pull/40157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] In DAG Graph View, clicking Task on it's name doesn't select the task [airflow]

2024-06-10 Thread via GitHub
pedro-cf commented on issue #37932: URL: https://github.com/apache/airflow/issues/37932#issuecomment-2158347985 Greetings @jonhspyro , is there anything preventing a merge ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Chart: Default airflow version to 2.9.2 [airflow]

2024-06-10 Thread via GitHub
ephraimbuddy commented on code in PR #40160: URL: https://github.com/apache/airflow/pull/40160#discussion_r1633177601 ## chart/newsfragments/39433.significant.rst: ## @@ -1,3 +1,3 @@ -Default Airflow image is updated to ``2.9.1`` +Default Airflow image is updated to ``2.9.2`` R

[PR] Chart: Default airflow version to 2.9.2 [airflow]

2024-06-10 Thread via GitHub
utkarsharma2 opened a new pull request, #40160: URL: https://github.com/apache/airflow/pull/40160 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [I] Status of testing of Apache Airflow 2.9.2rc1 [airflow]

2024-06-10 Thread via GitHub
ephraimbuddy closed issue #40093: Status of testing of Apache Airflow 2.9.2rc1 URL: https://github.com/apache/airflow/issues/40093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] Airflow 2.9.2 has been released [airflow]

2024-06-10 Thread via GitHub
utkarsharma2 opened a new pull request, #40159: URL: https://github.com/apache/airflow/pull/40159 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Upgrade google-ads version [airflow]

2024-06-10 Thread via GitHub
molcay commented on PR #40079: URL: https://github.com/apache/airflow/pull/40079#issuecomment-2158140205 Yes, definitely. I created the v17's PR already :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Bump google-ads version to use v17 by default [airflow]

2024-06-10 Thread via GitHub
molcay opened a new pull request, #40158: URL: https://github.com/apache/airflow/pull/40158 This PR is related to the upgrade of google-ads dependency. There is a new API version on Google Ads API and Google Ads API tends to deprecate too quickly. So we are trying to increase the dependency

(airflow-site) branch gh-pages updated (36deffa8e3 -> 0a6fd7b999)

2024-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git discard 36deffa8e3 Rewritten history to remove past gh-pages deployments new 0a6fd7b999 Rewritten history to

Re: [I] Triggering a DAG Run from the DAG Graph View does not redirect to the triggered DAG Run page [airflow]

2024-06-10 Thread via GitHub
pedro-cf commented on issue #37935: URL: https://github.com/apache/airflow/issues/37935#issuecomment-2158061744 > Okay, then I assume I now understand the mis-understanding. Please correct me if I am right: > > In 2.8.2 the main problem was the new DAG run was "hidden". This is what

Re: [I] Status of testing of Apache Airflow 2.9.2rc1 [airflow]

2024-06-10 Thread via GitHub
utkarsharma2 commented on issue #40093: URL: https://github.com/apache/airflow/issues/40093#issuecomment-2158061546 Airflow 2.9.2 has been released. Thank you all for testing this release -- This is an automated message from the Apache Git Service. To respond to the message, please log on

(airflow) branch main updated: Fix hive_partition_sensor system test (#40023)

2024-06-10 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f7708acab9 Fix hive_partition_sensor system test (

Re: [PR] Fix hive_partition_sensor system test [airflow]

2024-06-10 Thread via GitHub
eladkal merged PR #40023: URL: https://github.com/apache/airflow/pull/40023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

(airflow-site) branch main updated: Announce Apache Airflow 2.9.2 release

2024-06-10 Thread utkarsharma
This is an automated email from the ASF dual-hosted git repository. utkarsharma pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 2b3e8effd1 Announce Apache Airflow 2.9.2

Re: [PR] AIP-64: Add TaskInstance history table [airflow]

2024-06-10 Thread via GitHub
ephraimbuddy commented on code in PR #39951: URL: https://github.com/apache/airflow/pull/39951#discussion_r1633042304 ## airflow/models/taskinstancehistory.py: ## @@ -0,0 +1,128 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

Re: [PR] AIP-64: Add TaskInstance history table [airflow]

2024-06-10 Thread via GitHub
ephraimbuddy commented on PR #39951: URL: https://github.com/apache/airflow/pull/39951#issuecomment-2157991627 Apart from giving the history table a PK, I removed the onupdate cascade for taskinstance/taskinstancehistory. Let me know what you think. -- This is an automated message from th

Re: [I] DAG params ordering goes by key string length for some backends [airflow]

2024-06-10 Thread via GitHub
Usiel commented on issue #40154: URL: https://github.com/apache/airflow/issues/40154#issuecomment-2157838904 I checked the MySQL docs and found > To make lookups more efficient, MySQL also sorts the keys of a JSON object. You should be aware that the result of this ordering is subject

(airflow-site) branch 2.9.2-docs deleted (was 2173678bcd)

2024-06-10 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch 2.9.2-docs in repository https://gitbox.apache.org/repos/asf/airflow-site.git was 2173678bcd Add documentation for Apache Airflow 2.9.2 The revisions that were on this branch are s

Re: [PR] feat(chart): allow valueFrom in env config of components (#40095) [airflow]

2024-06-10 Thread via GitHub
dada-engineer commented on PR #40135: URL: https://github.com/apache/airflow/pull/40135#issuecomment-2157811304 > Could you please add a unit test for it (`helm_tests` dir) done > You also need to do apply it here. done thanks @potiuk and @jedcunningham and sorry f

Re: [PR] Add documentation for Apache Airflow 2.9.2 [airflow-site]

2024-06-10 Thread via GitHub
utkarsharma2 merged PR #1022: URL: https://github.com/apache/airflow-site/pull/1022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [I] dag callbacks not called on SSHOperator (base operator?) [airflow]

2024-06-10 Thread via GitHub
vatsrahul1001 commented on issue #40119: URL: https://github.com/apache/airflow/issues/40119#issuecomment-2157778637 @trlopes1974 I also tried apache-airflow-providers-ssh==3.11.1 and worked fine for me. Could you please try with apache-airflow-providers-ssh==3.11.1 -- This is an automate

[PR] Fix typo in providers_manager.py [airflow]

2024-06-10 Thread via GitHub
kacpermuda opened a new pull request, #40157: URL: https://github.com/apache/airflow/pull/40157 Just a typo --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_r

  1   2   >