[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446663429 ## File path: airflow/utils/log/log_reader.py ## @@ -100,6 +101,11 @@ def is_supported(self): Review comment: Can you rename `is_supported` to

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446663511 ## File path: airflow/utils/log/es_task_handler.py ## @@ -262,3 +267,25 @@ def close(self): super().close() self.closed = True + +

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446663429 ## File path: airflow/utils/log/log_reader.py ## @@ -100,6 +101,11 @@ def is_supported(self): Review comment: Can you rename is_supported to

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446663429 ## File path: airflow/utils/log/log_reader.py ## @@ -100,6 +101,11 @@ def is_supported(self): Review comment: Can you rename is_supported to

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446610398 ## File path: airflow/utils/log/log_reader.py ## @@ -100,6 +101,11 @@ def is_supported(self): return hasattr(self.log_handler, 'read') +

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446610902 ## File path: airflow/www/views.py ## @@ -760,22 +760,35 @@ def log(self, session=None): execution_date=execution_date, form=form,

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446610902 ## File path: airflow/www/views.py ## @@ -760,22 +760,35 @@ def log(self, session=None): execution_date=execution_date, form=form,

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446610398 ## File path: airflow/utils/log/log_reader.py ## @@ -100,6 +101,11 @@ def is_supported(self): return hasattr(self.log_handler, 'read') +

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446087927 ## File path: airflow/www/views.py ## @@ -1493,8 +1505,14 @@ def recurse_nodes(task, visited): form =

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446087927 ## File path: airflow/www/views.py ## @@ -1493,8 +1505,14 @@ def recurse_nodes(task, visited): form =

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446086992 ## File path: airflow/www/views.py ## @@ -760,22 +761,33 @@ def log(self, session=None): execution_date=execution_date, form=form,

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r446086461 ## File path: airflow/www/views.py ## @@ -760,22 +761,33 @@ def log(self, session=None): execution_date=execution_date, form=form,

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441851779 ## File path: airflow/www/views.py ## @@ -1363,6 +1374,14 @@ def success(self): confirmed, upstream,

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441850813 ## File path: airflow/www/templates/airflow/dag.html ## @@ -366,9 +366,9 @@ var task_id = ''; var execution_date = ''; var subdag_id =

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441850197 ## File path: airflow/utils/log/logging_mixin.py ## @@ -58,6 +58,20 @@ def _set_context(self, context): set_context(self.log, context)

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441849111 ## File path: airflow/utils/log/logging_mixin.py ## @@ -58,6 +58,20 @@ def _set_context(self, context): set_context(self.log, context)