[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-08-29 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1309723602 ## airflow/jobs/scheduler_job_runner.py: ## @@ -86,6 +86,10 @@ DR = DagRun DM = DagModel +# type alias for task concurrency map, +# (dag_id, run_id, task_group_i

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-08-18 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1298112077 ## airflow/decorators/task_group.py: ## @@ -184,6 +184,7 @@ def task_group( ui_color: str = "CornflowerBlue", ui_fgcolor: str = "#000", add_suffix_on_

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-17 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264984045 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +288,51 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .wher

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264885796 ## airflow/serialization/serialized_objects.py: ## @@ -1401,6 +1401,8 @@ def serialize_task_group(cls, task_group: TaskGroup) -> dict[str, Any] | None:

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264869235 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +288,51 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .wher

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264815014 ## airflow/models/taskinstance.py: ## @@ -2580,6 +2580,35 @@ def get_num_running_task_instances(self, session: Session, same_dagrun=False) -> )

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264815014 ## airflow/models/taskinstance.py: ## @@ -2580,6 +2580,35 @@ def get_num_running_task_instances(self, session: Session, same_dagrun=False) -> )

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-16 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1264814799 ## airflow/serialization/serialized_objects.py: ## @@ -1401,6 +1401,8 @@ def serialize_task_group(cls, task_group: TaskGroup) -> dict[str, Any] | None:

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262148784 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .wher

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262147399 ## airflow/models/taskinstance.py: ## @@ -2580,6 +2580,31 @@ def get_num_running_task_instances(self, session: Session, same_dagrun=False) -> )

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262145008 ## airflow/jobs/scheduler_job_runner.py: ## @@ -513,34 +567,30 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session) -

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262141663 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .wher

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262140954 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .wher

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262138672 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .wher

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-13 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1262137124 ## airflow/jobs/scheduler_job_runner.py: ## @@ -277,9 +284,44 @@ def __get_concurrency_maps(self, states: Iterable[TaskInstanceState], session: S .wher

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255466060 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when m

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index

2023-07-07 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255388320 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when m

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index WIP

2023-07-07 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255365976 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when m

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index WIP

2023-07-07 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1255360822 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when m

[GitHub] [airflow] uranusjr commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index WIP

2023-07-03 Thread via GitHub
uranusjr commented on code in PR #32122: URL: https://github.com/apache/airflow/pull/32122#discussion_r1251549036 ## airflow/decorators/task_group.py: ## @@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]: # TODO: fixme when m