Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-30 Thread via GitHub
potiuk merged PR #38169: URL: https://github.com/apache/airflow/pull/38169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-29 Thread via GitHub
ying-w commented on PR #38169: URL: https://github.com/apache/airflow/pull/38169#issuecomment-2027931420 i think i fixed the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-21 Thread via GitHub
shahar1 commented on PR #38169: URL: https://github.com/apache/airflow/pull/38169#issuecomment-2013463439 > cloud/hooks/test_bigquery.py > I need some help figuring out how to write a test. I see that there is a cloud/operators/test_bigquery.py file with a `impersonation_chain

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-20 Thread via GitHub
ying-w commented on PR #38169: URL: https://github.com/apache/airflow/pull/38169#issuecomment-2011174045 I need some help figuring out how to write a test. I see that there is a cloud/operators/test_bigquery.py file with a `impersonation_chain` call but no `impersonation_chain` call in clou

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-17 Thread via GitHub
ying-w commented on PR #38169: URL: https://github.com/apache/airflow/pull/38169#issuecomment-2002927103 i'll do another pass at it sometime this week -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-16 Thread via GitHub
eladkal commented on code in PR #38169: URL: https://github.com/apache/airflow/pull/38169#discussion_r1527205822 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -190,6 +190,7 @@ class GoogleBaseHook(BaseHook): If set as a sequence, the identities from the

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-16 Thread via GitHub
eladkal commented on PR #38169: URL: https://github.com/apache/airflow/pull/38169#issuecomment-2002057323 Can you add unit test to cover the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-16 Thread via GitHub
ying-w commented on code in PR #38169: URL: https://github.com/apache/airflow/pull/38169#discussion_r1527202747 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -190,6 +190,7 @@ class GoogleBaseHook(BaseHook): If set as a sequence, the identities from the

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-16 Thread via GitHub
eladkal commented on code in PR #38169: URL: https://github.com/apache/airflow/pull/38169#discussion_r1527200404 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -190,6 +190,7 @@ class GoogleBaseHook(BaseHook): If set as a sequence, the identities from the

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-16 Thread via GitHub
eladkal commented on code in PR #38169: URL: https://github.com/apache/airflow/pull/38169#discussion_r1527200404 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -190,6 +190,7 @@ class GoogleBaseHook(BaseHook): If set as a sequence, the identities from the

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-16 Thread via GitHub
ying-w commented on code in PR #38169: URL: https://github.com/apache/airflow/pull/38169#discussion_r1527197740 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -190,6 +190,7 @@ class GoogleBaseHook(BaseHook): If set as a sequence, the identities from the