potiuk merged PR #37072:
URL: https://github.com/apache/airflow/pull/37072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
VladaZakharova closed pull request #37072: Add
GKEStartKueueInsideClusterOperator to support Kueue inside clusters
URL: https://github.com/apache/airflow/pull/37072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941186088
> ```
> Based on this documentation for
[Kueue](https://kueue.sigs.k8s.io/docs/installation/) the conditions to meet
before we actually can install Kueue are different from th
raphaelauv commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941163935
```
Based on this documentation for
[Kueue](https://kueue.sigs.k8s.io/docs/installation/) the conditions to meet
before we actually can install Kueue are different from the condit
VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941160640
Hi @eladkal !
Can you please check changes in this PR too? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941154392
> create a GKE is calling GCP API
>
> deploy a https://github.com/kubernetes-sigs/kueue is calling K8S API not
GCP API
Based on this documentation for
[Kueue](https
raphaelauv commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1940982879
create a GKE is calling GCP API
deploy a https://github.com/kubernetes-sigs/kueue is calling K8S API not GCP
API
--
This is an automated message from the Apache Git
VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1940964341
> why build operators specific to GKE ?
All the operators that we have for operations on cluster (create and delete)
were implemented as a part of google provider as GKE o
raphaelauv commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1930353671
why build operators specific to GKE ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1929625614
Hi @raphaelauv ! As i have checked the KubernetesCreateResourceOperator is
not using any specific hook method to call create_from_yaml() from kubernetes
client. The logic that we
VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1916680545
> There is already KubernetesCreateResourceOperator
>
> For creating any resource in k8s
Yes, thank you for the idea, it makes sense to inherit existing logic from
t
raphaelauv commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1916527506
There is already KubernetesCreateResourceOperator
For creating any resource in k8s
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1916355819
Okay, then maybe it makes sense to convert this operator to just method call
inside operators for CreateClusterQueue and CreateLocalQueue? WDYT?
--
This is an automated message
dirrao commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1916339750
> Why add an operator in airflow to install `kueue` in a GKE ?
>
> the installation thanks to kubectl is not enough ?
https://github.com/kubernetes-sigs/kueue?tab=readme-ov-file#in
dirrao commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1916289946
> > We usually use infrastructure as code to install the cluster and
additional things together. what is the significance installing Kueue alone?
>
> Not true, we have an opera
hussein-awala commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1916205910
> We usually use infrastructure as code to install the cluster and
additional things together. what is the significance installing Kueue alone?
Not true, we have an operator
VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1916161115
Hey @dirrao @raphaelauv !
Thank you for looking my changes.
This operator is the first one in a set operators that are needed to cover
functionality we have for GKE clusters
raphaelauv commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1915062317
Why add an operator in airflow to install `kueue` in a GKE ?
the installation thanks to kubectl is not enough ?
https://github.com/kubernetes-sigs/kueue?tab=readme-ov-file#ins
VladaZakharova opened a new pull request, #37072:
URL: https://github.com/apache/airflow/pull/37072
This PR adds the ability to install Kueue inside specific types of clusters
in GKE.
For more details please check:
https://cloud.google.com/kubernetes-engine/docs/tutorials/kueue-intro#cre
19 matches
Mail list logo
