Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-21 Thread via GitHub
potiuk merged PR #37575: URL: https://github.com/apache/airflow/pull/37575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1498172066 ## tests/providers/apache/hive/hooks/test_hive.py: ## @@ -17,22 +17,13 @@ # under the License. from __future__ import annotations -import pytest - -from airflow im

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-21 Thread via GitHub
Taragolis commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1497485603 ## tests/serialization/serializers/test_serializers.py: ## @@ -26,19 +27,22 @@ import pytest from dateutil.tz import tzutc from deltalake import DeltaTable +from

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-21 Thread via GitHub
Dev-iL commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1497308622 ## tests/serialization/serializers/test_serializers.py: ## @@ -26,19 +27,22 @@ import pytest from dateutil.tz import tzutc from deltalake import DeltaTable +from pa

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-21 Thread via GitHub
Taragolis commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1497218249 ## tests/serialization/serializers/test_serializers.py: ## @@ -26,19 +27,22 @@ import pytest from dateutil.tz import tzutc from deltalake import DeltaTable +from

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-21 Thread via GitHub
Dev-iL commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1497145333 ## tests/serialization/serializers/test_serializers.py: ## @@ -26,19 +27,22 @@ import pytest from dateutil.tz import tzutc from deltalake import DeltaTable +from pa

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-21 Thread via GitHub
Dev-iL commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1497145333 ## tests/serialization/serializers/test_serializers.py: ## @@ -26,19 +27,22 @@ import pytest from dateutil.tz import tzutc from deltalake import DeltaTable +from pa

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-20 Thread via GitHub
hussein-awala commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1496687314 ## airflow/__init__.py: ## @@ -91,6 +84,16 @@ def __getattr__(name: str): # PEP-562: Lazy loaded attributes on python modules module_path, attr_name,

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-20 Thread via GitHub
Taragolis commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1496676280 ## tests/providers/apache/hive/hooks/test_hive.py: ## @@ -17,22 +17,13 @@ # under the License. from __future__ import annotations -import pytest - -from airflow

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-20 Thread via GitHub
Taragolis commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1496672314 ## tests/providers/apache/hive/hooks/test_hive.py: ## @@ -17,22 +17,13 @@ # under the License. from __future__ import annotations -import pytest - -from airflow

Re: [PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-20 Thread via GitHub
Taragolis commented on PR #37575: URL: https://github.com/apache/airflow/pull/37575#issuecomment-1955290776 I do not delete this constants for two reason: - Maybe some old version of provider still use it - Maybe some users use it, which is not practical -- This is an automated messa

[PR] Deprecate PY* constants into the airflow module [airflow]

2024-02-20 Thread via GitHub
Taragolis opened a new pull request, #37575: URL: https://github.com/apache/airflow/pull/37575 First constant was added in https://github.com/apache/airflow/pull/7517 for validate is Airflow run on Python >= 3.7 and if not use backport support of [PEP-562](https://peps.pytho