Taragolis merged PR #35037:
URL: https://github.com/apache/airflow/pull/35037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1368916014
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
uranusjr commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1368327181
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
eladkal commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367840823
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:para
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367505181
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367381836
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:pa
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367332799
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
vincbeck commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367328736
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367326682
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
vincbeck commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367313528
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364704230
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:pa
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364704230
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:pa
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364704230
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:pa
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364694485
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364691218
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364689097
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364685496
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:pa
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364681170
##
tests/providers/amazon/aws/hooks/test_s3.py:
##
@@ -1047,6 +1047,33 @@ def
test_download_file_with_preserve_name_file_already_exists(self, tmp_path):
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364680241
##
tests/providers/amazon/aws/hooks/test_s3.py:
##
@@ -1047,6 +1047,33 @@ def
test_download_file_with_preserve_name_file_already_exists(self, tmp_path):
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364679959
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364676943
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:pa
ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364661974
##
airflow/providers/amazon/aws/hooks/s3.py:
##
@@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:par
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364522281
##
tests/providers/amazon/aws/hooks/test_s3.py:
##
@@ -1047,6 +1047,33 @@ def
test_download_file_with_preserve_name_file_already_exists(self, tmp_path):
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364522281
##
tests/providers/amazon/aws/hooks/test_s3.py:
##
@@ -1047,6 +1047,33 @@ def
test_download_file_with_preserve_name_file_already_exists(self, tmp_path):
Taragolis commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1364518573
##
tests/providers/amazon/aws/hooks/test_s3.py:
##
@@ -1047,6 +1047,33 @@ def
test_download_file_with_preserve_name_file_already_exists(self, tmp_path):
ferruzzi opened a new pull request, #35037:
URL: https://github.com/apache/airflow/pull/35037
Hey all. I thought I'd take this one on. I think I got the code
implemented but I can't seem to get the mocking in the unit test set up right.
I'd love some suggestions.
Closes: https://
26 matches
Mail list logo
