Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
Taragolis commented on code in PR #36611: URL: https://github.com/apache/airflow/pull/36611#discussion_r1442706434 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -149,7 +149,7 @@ On **all operating systems**, you need to run database migrations and create the .

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
jtommi commented on code in PR #36611: URL: https://github.com/apache/airflow/pull/36611#discussion_r1442737460 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -149,7 +149,7 @@ On **all operating systems**, you need to run database migrations and create the .. c

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on code in PR #36611: URL: https://github.com/apache/airflow/pull/36611#discussion_r1442801474 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -149,7 +149,7 @@ On **all operating systems**, you need to run database migrations and create the .. c

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on code in PR #36611: URL: https://github.com/apache/airflow/pull/36611#discussion_r1442801474 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -149,7 +149,7 @@ On **all operating systems**, you need to run database migrations and create the .. c

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1878572621 > Also (not included in this PR), the message after initialization for me looked like this (Docker-Desktop on Windows 11): > [2024-01-05T09:51:47.658+] {override.py:1820} INFO

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1878577152 And just a general command @jtommi - the fact that something does not work for `you` - is not always a reason to change things - because it maybe YOU have specific problem which needs t

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1878580249 And also another comment - I am not 100% sure it works now - it might it be it does not and our tests simply did not catch it, it's just we need to understand what's going on (and also

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1878585046 BTW. By a quick look it is quite possible it does not work. The `aiflow-init` container runs `airflow version` which I think COULD in the past initialize the DB as side effect but

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
jtommi commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1878724030 Thanks for all those insights, very helpful. I'm really sorry to have wasted both of your time @potiuk and @Taragolis I was pretty confident because doing `docker-compose up airflow

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1878760174 Those are all good questions - and I think they need proper fixes. I think "why" it's not a good question. Better question is "how we can improve it" because as you see - there are some

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
Taragolis commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1879133056 > The aiflow-init container runs airflow version which I think COULD in the past initialize the DB as side effect but this could have changed since. I guess it still work, and j

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1879140967 > > And according to the dependencies it should run initialise DB after Postgres started and before scheduler/webserver/worker/triggerer > Ah ... So looks like I am sti

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
Taragolis commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1879156230 I guess so because we have requirements for Docker Compose V2 now. My personal docker compose file for testing something internal on RC versions of Airflow/Providers also a bit

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-01-05 Thread via GitHub
potiuk commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1879158475 So yeah. in this case I'd simply remove the "init" instructions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1953299893 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-02-24 Thread via GitHub
github-actions[bot] closed pull request #36611: Fix docker compose command in "Running Airflow in Docker" URL: https://github.com/apache/airflow/pull/36611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to