vincbeck closed pull request #34966: Fix error handling in
EksCreateClusterOperator in deferrable mode
URL: https://github.com/apache/airflow/pull/34966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
syedahsn commented on PR #34966:
URL: https://github.com/apache/airflow/pull/34966#issuecomment-1847661038
We can close this PR now that #36079 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
theaadya commented on PR #34966:
URL: https://github.com/apache/airflow/pull/34966#issuecomment-1812632302
I tried to work on this one but didn't get the time. I'll try to get back,
but in the meantime, others are welcome to take up this issue.
--
This is an automated message from the Apa
vincbeck commented on PR #34966:
URL: https://github.com/apache/airflow/pull/34966#issuecomment-1810556368
Where are we at on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
syedahsn commented on PR #34966:
URL: https://github.com/apache/airflow/pull/34966#issuecomment-1778192202
Looking at this, it looks like a few things were missing.
1. The first is that the `EksCreateClusterTrigger` does not set a status as
`failed`, which means
[this](https://githu
Taragolis commented on PR #34966:
URL: https://github.com/apache/airflow/pull/34966#issuecomment-1774987910
I have no idea I do not use EKS on deferrable mode, but seems like
`EksDeleteClusterTrigger` completely broken, not only things listed in
https://github.com/apache/airflow/issues/3484
theaadya commented on PR #34966:
URL: https://github.com/apache/airflow/pull/34966#issuecomment-1774961011
> I created a set of test cases to evaluate the functionality of the
`execute_failed` function. In the unit test for accessing the `else` part of
the function, `KeyError` for 'exceptio
theaadya commented on PR #34966:
URL: https://github.com/apache/airflow/pull/34966#issuecomment-1767683896
I created a set of test cases to evaluate the functionality of the
`execute_failed` function. In the unit test for accessing the `else` part of
the function, `KeyError` for 'exception'
Lee-W commented on code in PR #34966:
URL: https://github.com/apache/airflow/pull/34966#discussion_r1363088819
##
airflow/providers/amazon/aws/operators/eks.py:
##
@@ -397,10 +397,10 @@ def deferrable_create_cluster_next(self, context:
Context, event: dict[str, Any]
theaadya commented on code in PR #34966:
URL: https://github.com/apache/airflow/pull/34966#discussion_r1361522739
##
airflow/providers/amazon/aws/operators/eks.py:
##
@@ -397,10 +397,10 @@ def deferrable_create_cluster_next(self, context:
Context, event: dict[str, Any]
Taragolis commented on code in PR #34966:
URL: https://github.com/apache/airflow/pull/34966#discussion_r1360820902
##
airflow/providers/amazon/aws/operators/eks.py:
##
@@ -397,10 +397,10 @@ def deferrable_create_cluster_next(self, context:
Context, event: dict[str, Any]
Taragolis commented on code in PR #34966:
URL: https://github.com/apache/airflow/pull/34966#discussion_r1360827505
##
airflow/providers/amazon/aws/operators/eks.py:
##
@@ -397,10 +397,10 @@ def deferrable_create_cluster_next(self, context:
Context, event: dict[str, Any]
vincbeck commented on PR #34966:
URL: https://github.com/apache/airflow/pull/34966#issuecomment-1764642390
@Taragolis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
theaadya opened a new pull request, #34966:
URL: https://github.com/apache/airflow/pull/34966
closes: #34844
Corrected typo and modified if-else condition. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
14 matches
Mail list logo
