Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-07 Thread via GitHub
vincbeck merged PR #36079: URL: https://github.com/apache/airflow/pull/36079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-07 Thread via GitHub
syedahsn commented on PR #36079: URL: https://github.com/apache/airflow/pull/36079#issuecomment-1846055794 Sorry missed that one. Everything is passing now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-07 Thread via GitHub
vincbeck commented on PR #36079: URL: https://github.com/apache/airflow/pull/36079#issuecomment-1845611956 Static check failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-06 Thread via GitHub
syedahsn commented on code in PR #36079: URL: https://github.com/apache/airflow/pull/36079#discussion_r1418032422 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -400,9 +400,9 @@ def execute_failed(self, context: Context, event: dict[str, Any] | None = None)

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-06 Thread via GitHub
vincbeck commented on code in PR #36079: URL: https://github.com/apache/airflow/pull/36079#discussion_r1417449599 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -253,6 +253,7 @@ def __init__( self.fargate_selectors = fargate_selectors or [{"namespace":

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-06 Thread via GitHub
Taragolis commented on code in PR #36079: URL: https://github.com/apache/airflow/pull/36079#discussion_r1416922185 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -400,9 +400,9 @@ def execute_failed(self, context: Context, event: dict[str, Any] | None = None)

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-06 Thread via GitHub
Taragolis commented on code in PR #36079: URL: https://github.com/apache/airflow/pull/36079#discussion_r1416911328 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -253,6 +253,7 @@ def __init__( self.fargate_selectors = fargate_selectors or [{"namespace":

[PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-05 Thread via GitHub
syedahsn opened a new pull request, #36079: URL: https://github.com/apache/airflow/pull/36079 This PR addresses the issues that were discovered out in the `EksCreateClusterOperator` deferrable mode. There are several changes made. 1. `EksCreateClusterTrigger` did not set a status as