dolfinus opened a new pull request, #36628:
URL: https://github.com/apache/airflow/pull/36628
---
* Deploy Airflow using Heml chart 1.10.0 with `dags.gitSync.enabled=True`
* After testing git sync is working as expected, set
`dags.persistence.enabled=tru
dolfinus opened a new pull request, #34331:
URL: https://github.com/apache/airflow/pull/34331
---
* Deploy Airflow using Heml chart 1.10.0 with `dags.gitSync.enabled=True`
* After testing git sync is working as expected, set
`dags.persistence.enabled=tru
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1817453658
So?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
romsharon98 commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826353980
This pr will solve the problem.
But isnt this solution is better?
https://github.com/apache/airflow/pull/30896
Because in the current solution we will add git-ssh even though w
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826396118
> even though we don't need it
Please describe this in more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
potiuk commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826437589
I would strongly discourage using both git-sync and persistence. I am very
close to propose (I did have a PR in the past about it) such combo should be
forbidden because it leads to very
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826720961
I'd rather prefer to show some kind of warning such a case than completely
forbid it. Some users may successfully use this combination, there is no
statistics related to this
--
Th
potiuk commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826801975
> I'd rather prefer to show some kind of warning in such a case than
completely forbid it. Some users may successfully use this combination, there
is no statistics related to this
potiuk commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826802063
> I'd rather prefer to show some kind of warning in such a case than
completely forbid it. Some users may successfully use this combination, there
is no statistics related to this
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826802369
No idea, and I'm not interested in this kind if solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
potiuk commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826802597
> No idea, and I'm not interested in this kind if solution.
Pity. You loose opportunity to become one of 2700 contributors to Airflow.
--
This is an automated message from the A
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826804501
> You loose opportunity to become one of 2700 contributors to Airflow.
I already am.
If maintainers are not interested of merging PR which avoids producing wrong
pod descr
potiuk commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1826808549
> If maintainers are not interested of merging PR which avoids producing
wrong pod description, and instead prefer to do nothing with that for months -
ok, but very pitty to hear.
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1858766092
What exactly are we waiting here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
potiuk commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1858849417
We are waiting to hear from others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dolfinus closed pull request #34331: Fix passing dags.gitSync.sshKeySecret with
dags.persistence.enabled=true
URL: https://github.com/apache/airflow/pull/34331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1858872711
If nobody is interested in this, I don't see any reason to keep this open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
amoskueez commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1872933817
we are interested in this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
potiuk commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1872936159
> we are interested in this
Feel free to create PR and lead it completion then @amoskueez . Nothing more
is needed here.
--
This is an automated message from the Apache Git Serv
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1879609628
Second try: #36628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #36628:
URL: https://github.com/apache/airflow/pull/36628#issuecomment-1977708307
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] closed pull request #36628: Fix passing
dags.gitSync.sshKeySecret with dags.persistence.enabled=true
URL: https://github.com/apache/airflow/pull/36628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jedcunningham commented on code in PR #36628:
URL: https://github.com/apache/airflow/pull/36628#discussion_r1459645537
##
chart/templates/dag-processor/dag-processor-deployment.yaml:
##
Review Comment:
I think this was right before. If the dag processor is on, I think it ma
github-actions[bot] commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1783948819
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1784019903
Could anyone take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
eladkal commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1784551760
> Could anyone take a look?
needs rebase and resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
dolfinus closed pull request #34331: Fix passing dags.gitSync.sshKeySecret with
dags.persistence.enabled=true
URL: https://github.com/apache/airflow/pull/34331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dolfinus commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1786794770
> needs rebase and resolve conflicts
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
eladkal commented on PR #34331:
URL: https://github.com/apache/airflow/pull/34331#issuecomment-1788488979
@hussein-awala can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
29 matches
Mail list logo
