boring-cyborg[bot] commented on PR #34785:
URL: https://github.com/apache/airflow/pull/34785#issuecomment-1806184902
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
eladkal merged PR #34785:
URL: https://github.com/apache/airflow/pull/34785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
shahar1 commented on PR #34785:
URL: https://github.com/apache/airflow/pull/34785#issuecomment-1805317492
@eladkal Could you please take a look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
shahar1 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1367934383
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAINED
champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1367691594
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAI
asafeunico commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1367102802
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAIN
champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1348054361
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAI
champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1348070993
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAI
champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1348070993
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAI
champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1348054361
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAI
champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1348054361
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAI
champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1348054361
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAI
champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1348054361
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAI
hussein-awala commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1347968624
##
airflow/providers/google/cloud/hooks/dataflow.py:
##
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DR
boring-cyborg[bot] commented on PR #34785:
URL: https://github.com/apache/airflow/pull/34785#issuecomment-1749542234
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
champon1020 opened a new pull request, #34785:
URL: https://github.com/apache/airflow/pull/34785
Fix the the logic of checking dataflow job state in
_check_dataflow_job_state method.
related: #34767
The `expected_terminal_state` parameter was introduced to Dataflow
16 matches
Mail list logo