Re: [PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-13 Thread via GitHub
kisssam commented on PR #39568: URL: https://github.com/apache/airflow/pull/39568#issuecomment-2107122252 On testing on a Cloud Composer environment with `apache-airflow-providers-google==10.18.0rc2`, all other test cases except the scenario where a task starts with a hyphen fails.

Re: [PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-12 Thread via GitHub
boring-cyborg[bot] commented on PR #39568: URL: https://github.com/apache/airflow/pull/39568#issuecomment-2106335858 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-12 Thread via GitHub
eladkal merged PR #39568: URL: https://github.com/apache/airflow/pull/39568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-12 Thread via GitHub
kisssam commented on PR #39568: URL: https://github.com/apache/airflow/pull/39568#issuecomment-2106273245 > > Setting the regex as `LABEL_REGEX = re.compile(r"^[\w-]{0,63}$")` since the documentation [1] indicates that label values can start with numbers, hyphen and underscore as well. >

Re: [PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-12 Thread via GitHub
shahar1 commented on PR #39568: URL: https://github.com/apache/airflow/pull/39568#issuecomment-2106263247 > Setting the regex as `LABEL_REGEX = re.compile(r"^[\w-]{0,63}$")` since the documentation [1] indicates that label values can start with numbers, hyphen and underscore as well. >

Re: [PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-12 Thread via GitHub
kisssam commented on PR #39568: URL: https://github.com/apache/airflow/pull/39568#issuecomment-2106197125 Setting the regex as `LABEL_REGEX = re.compile(r"^[\w-]{0,63}$")` since the documentation [1] mentioned that label values can start with hyphen and underscore as well. [1

Re: [PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-11 Thread via GitHub
boring-cyborg[bot] commented on PR #39568: URL: https://github.com/apache/airflow/pull/39568#issuecomment-210531 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-11 Thread via GitHub
kisssam opened a new pull request, #39568: URL: https://github.com/apache/airflow/pull/39568 --- This updates the label value validation logic for BigQuery label values as documented in the [public documentation](https://cloud.google.com/bigquery/docs/labels-intro#req