Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-07 Thread via GitHub
vincbeck commented on PR #35488: URL: https://github.com/apache/airflow/pull/35488#issuecomment-1800022626 [Providers Airflow 2.5 compatibility check](https://github.com/apache/airflow/actions/runs/6788678339/job/18455385993?pr=35488#logs) is failing because some of the features (e.g. `Base

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-16 Thread via GitHub
o-nikolas commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1396269524 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397518067 ## docs/docker-stack/changelog.rst: ## @@ -50,6 +50,9 @@ Airflow 2.7 * 2.7.3 + * Add ``libxmlsec1`` and ``libxmlsec1-dev`` libraries to dev PROD image and ``l

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397519685 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397523275 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397573793 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397574713 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397582191 ## airflow/providers/amazon/aws/auth_manager/views/auth.py: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397584007 ## airflow/providers/amazon/provider.yaml: ## @@ -895,6 +896,20 @@ config: type: boolean example: "True" default: "True" + aws_auth_manag

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397583430 ## airflow/providers/amazon/provider.yaml: ## @@ -895,6 +896,20 @@ config: type: boolean example: "True" default: "True" + aws_auth_manag

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397591869 ## airflow/www/security_manager.py: ## @@ -355,3 +347,20 @@ def _is_authorized_category_menu(self, category: str) -> Callable: return lambda action, resour

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
eladkal commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397646758 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pytho

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
eladkal commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397652516 ## airflow/providers/amazon/provider.yaml: ## @@ -895,6 +896,28 @@ config: type: boolean example: "True" default: "True" + aws_auth_manage

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397660836 ## airflow/providers/amazon/provider.yaml: ## @@ -895,6 +896,28 @@ config: type: boolean example: "True" default: "True" + aws_auth_manag

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397663449 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pyth

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
eladkal commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397695145 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pytho

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397708435 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pyth

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
o-nikolas commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397738543 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
o-nikolas commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397740330 ## airflow/providers/amazon/aws/auth_manager/views/auth.py: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397764045 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397767536 ## airflow/providers/amazon/aws/auth_manager/views/auth.py: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
o-nikolas commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397768377 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397768910 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pyth

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397771183 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397771183 ## airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
eladkal commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397776679 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pytho

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397787681 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pyth

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
eladkal commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397834145 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pytho

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
eladkal commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397834145 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pytho

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-17 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397913840 ## airflow/providers/amazon/provider.yaml: ## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - pyth

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-20 Thread via GitHub
ferruzzi commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1399796152 ## airflow/providers/amazon/provider.yaml: ## @@ -897,6 +900,28 @@ config: type: boolean example: "True" default: "True" + aws_auth_manag

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-20 Thread via GitHub
ferruzzi commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1399802344 ## airflow/www/security_manager.py: ## @@ -355,3 +347,20 @@ def _is_authorized_category_menu(self, category: str) -> Callable: return lambda action, resour

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-20 Thread via GitHub
ferruzzi commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1399802344 ## airflow/www/security_manager.py: ## @@ -355,3 +347,20 @@ def _is_authorized_category_menu(self, category: str) -> Callable: return lambda action, resour

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-20 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1399815358 ## airflow/www/security_manager.py: ## @@ -355,3 +347,20 @@ def _is_authorized_category_menu(self, category: str) -> Callable: return lambda action, resour

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-20 Thread via GitHub
ferruzzi commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1399839074 ## airflow/providers/amazon/aws/auth_manager/views/auth.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-20 Thread via GitHub
ferruzzi commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1399844229 ## airflow/providers/amazon/aws/auth_manager/views/auth.py: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-21 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1400839791 ## airflow/providers/amazon/aws/auth_manager/views/auth.py: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-21 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1400855441 ## airflow/providers/amazon/aws/auth_manager/views/auth.py: ## @@ -0,0 +1,145 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-21 Thread via GitHub
vincbeck merged PR #35488: URL: https://github.com/apache/airflow/pull/35488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-22 Thread via GitHub
utkarsharma2 commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1402036628 ## airflow/auth/managers/base_auth_manager.py: ## @@ -83,21 +83,29 @@ def get_api_endpoints(self) -> None | FlaskApi: """Return API endpoint(s) definiti

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-22 Thread via GitHub
vincbeck commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1402320587 ## airflow/auth/managers/base_auth_manager.py: ## @@ -83,21 +83,29 @@ def get_api_endpoints(self) -> None | FlaskApi: """Return API endpoint(s) definition f