potiuk commented on PR #34945:
URL: https://github.com/apache/airflow/pull/34945#issuecomment-1776738164
Nice one @Bisk1 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
potiuk merged PR #34945:
URL: https://github.com/apache/airflow/pull/34945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on PR #34945:
URL: https://github.com/apache/airflow/pull/34945#issuecomment-1776076860
@Taragolis ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Bisk1 commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1369154410
##
airflow/cli/commands/internal_api_command.py:
##
@@ -148,60 +139,54 @@ def kill_proc(signum, _):
gunicorn_master_proc.kill()
sys.exit(0
Bisk1 commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1369154410
##
airflow/cli/commands/internal_api_command.py:
##
@@ -148,60 +139,54 @@ def kill_proc(signum, _):
gunicorn_master_proc.kill()
sys.exit(0
Bisk1 commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1369152054
##
airflow/cli/commands/celery_command.py:
##
@@ -68,28 +67,7 @@ def flower(args):
if args.flower_conf:
options.append(f"--conf={args.flower_conf}")
-
Bisk1 commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1369152541
##
airflow/cli/commands/celery_command.py:
##
@@ -214,33 +187,31 @@ def worker(args):
# executed.
maybe_patch_concurrency(["-P", pool])
-if args
daniel-dylag-openx commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1369137222
##
airflow/cli/commands/celery_command.py:
##
@@ -214,33 +187,31 @@ def worker(args):
# executed.
maybe_patch_concurrency(["-P", pool])
potiuk commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1368962020
##
airflow/cli/commands/internal_api_command.py:
##
@@ -148,60 +139,54 @@ def kill_proc(signum, _):
gunicorn_master_proc.kill()
sys.exit(
potiuk commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1368938322
##
airflow/cli/commands/celery_command.py:
##
@@ -214,33 +187,31 @@ def worker(args):
# executed.
maybe_patch_concurrency(["-P", pool])
-if arg
potiuk commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1368935064
##
airflow/cli/commands/celery_command.py:
##
@@ -68,28 +67,7 @@ def flower(args):
if args.flower_conf:
options.append(f"--conf={args.flower_conf}")
-
Bisk1 commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1367723811
##
airflow/cli/commands/daemon_utils.py:
##
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. S
Taragolis commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1367714633
##
airflow/cli/commands/daemon_utils.py:
##
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements
Bisk1 commented on PR #34945:
URL: https://github.com/apache/airflow/pull/34945#issuecomment-1763474577
converting to draft becuase I still need to fix some unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Bisk1 commented on PR #34945:
URL: https://github.com/apache/airflow/pull/34945#issuecomment-1763057616
Tested those commands manually and looks good. Unfortunately standard Python
test frameworks can't handle forking processes well so no automated tests.
--
This is an automated message
Bisk1 opened a new pull request, #34945:
URL: https://github.com/apache/airflow/pull/34945
This refactoring is a follow-up of
https://github.com/apache/airflow/pull/34931
- unified approach to daemon process creation and moved all daemon-related
code to shared util daemon_utils.py.
-
16 matches
Mail list logo
