Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

potiuk commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-185956 LGTM :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

potiuk merged PR #35547: URL: https://github.com/apache/airflow/pull/35547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-1810504403 Hi @potiuk , I hope I'm not intruding or overstepping again, but I wanted to quickly check if there's anything else needed on my PR for it to be merge-ready. Thanks for your

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

potiuk commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391709973 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input text to

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391343236 ## tests/providers/openai/operators/test_openai.py: ## @@ -34,3 +36,30 @@ def test_execute_with_input_text(): embeddings = operator.execute(context) assert

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391336892 ## tests/providers/openai/operators/test_openai.py: ## @@ -34,3 +36,30 @@ def test_execute_with_input_text(): embeddings = operator.execute(context) assert

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391317221 ## tests/providers/openai/operators/test_openai.py: ## @@ -34,3 +36,30 @@ def test_execute_with_input_text(): embeddings = operator.execute(context)

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391319485 ## tests/providers/openai/operators/test_openai.py: ## @@ -34,3 +36,30 @@ def test_execute_with_input_text(): embeddings = operator.execute(context)

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391317221 ## tests/providers/openai/operators/test_openai.py: ## @@ -34,3 +36,30 @@ def test_execute_with_input_text(): embeddings = operator.execute(context)

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391315739 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input te

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391283588 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input text to

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391273148 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input te

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390719284 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input text to

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1391177321 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input text to

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390719284 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input text to

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-1807596113 > @ylnsnv Overall changes look good to me, just a few minor things. Also, can you mention the docs where you found the specific types accepted by OpenAI API? just curious :) First

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-1807585313 @ylnsnv Overall changes look good to me, just a few minor things. Also, can you mention the docs where you found the specific types accepted by OpenAI API? just curious :) -- Th

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390691032 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input te

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390691032 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input te

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390689573 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input text to

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390686468 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input text to

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390685637 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input te

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390685136 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input te

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

utkarsharma2 commented on code in PR #35547: URL: https://github.com/apache/airflow/pull/35547#discussion_r1390682879 ## airflow/providers/openai/operators/openai.py: ## @@ -31,41 +32,46 @@ class OpenAIEmbeddingOperator(BaseOperator): """ Operator that accepts input te

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

potiuk commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-180776 LGTM but I'd love @utkarsharma2 to take a look as this is so fresh contribution :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-1803726566 > > @potiuk hi! can you please review my changes in your free time? :) > > Generally - unless you have good reasons to know someone **SHOULD** review something we do not have a cus

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

potiuk commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-1803719465 > @potiuk hi! can you please review my changes in your free time? :) Generally - unless you have good reasons to know someone **SHOULD** review something we do not have a custom to

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-1803713464 @potiuk hi! can you please review my changes in your free time? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv commented on PR #35547: URL: https://github.com/apache/airflow/pull/35547#issuecomment-1803580324 WIP, do not review yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[PR] Refine Type Handling in OpenAI Embedding Operator to Match OpenAI Typings [airflow]

ylnsnv opened a new pull request, #35547: URL: https://github.com/apache/airflow/pull/35547 ## Summary This PR refines the `OpenAIEmbeddingOperator` to accurately reflect and support the extended range of input types it can handle for generating embeddings ([by OpenAI official API](