stuart23 opened a new pull request, #37480:
URL: https://github.com/apache/airflow/pull/37480
For tasks that belong to task groups, the emitted metric format is
`airflow.dagduration` and therefore it is
not being picked up by the existing airflow_task_dur
boring-cyborg[bot] commented on PR #37480:
URL: https://github.com/apache/airflow/pull/37480#issuecomment-1948452203
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
Taragolis commented on PR #37480:
URL: https://github.com/apache/airflow/pull/37480#issuecomment-1948601359
https://github.com/apache/airflow/blob/35c1a1a024e652c001930bf42416e06d3c20cf95/chart/files/statsd-mappings.yml#L18-L23
--
This is an automated message from the Apache Git Service.
stuart23 commented on PR #37480:
URL: https://github.com/apache/airflow/pull/37480#issuecomment-1948807283
>
https://github.com/apache/airflow/blob/35c1a1a024e652c001930bf42416e06d3c20cf95/chart/files/statsd-mappings.yml#L18-L23
This is fully backwards compatible, it will ship more me
jedcunningham commented on code in PR #37480:
URL: https://github.com/apache/airflow/pull/37480#discussion_r1492994507
##
chart/files/statsd-mappings.yml:
##
@@ -52,6 +52,13 @@ mappings:
dag_id: "$1"
task_id: "$2"
+ - match: airflow.dag.*.*.*.duration
Review Co
jedcunningham commented on PR #37480:
URL: https://github.com/apache/airflow/pull/37480#issuecomment-1949358805
> This is fully backwards compatible, it will ship more metrics than already
exist and won't change any existing metrics
The chart just remaps, it doesn't exclude metrics th
stuart23 commented on code in PR #37480:
URL: https://github.com/apache/airflow/pull/37480#discussion_r1496701748
##
chart/files/statsd-mappings.yml:
##
@@ -52,6 +52,13 @@ mappings:
dag_id: "$1"
task_id: "$2"
+ - match: airflow.dag.*.*.*.duration
Review Comment
stuart23 commented on PR #37480:
URL: https://github.com/apache/airflow/pull/37480#issuecomment-1955445221
OK I guess I was just looking at our implementation that drops all
non-matching metrics. Seems like there isn't going to be a good solution to
unpack taskgroup tasks. I really hope we
jedcunningham commented on code in PR #37480:
URL: https://github.com/apache/airflow/pull/37480#discussion_r1496950583
##
chart/files/statsd-mappings.yml:
##
@@ -52,6 +52,13 @@ mappings:
dag_id: "$1"
task_id: "$2"
+ - match: airflow.dag.*.*.*.duration
Review Co
jedcunningham closed pull request #37480: Update statsd-mappings.yml
URL: https://github.com/apache/airflow/pull/37480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
10 matches
Mail list logo
