Lee-W opened a new pull request, #36749:
URL: https://github.com/apache/airflow/pull/36749
#36471
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-req
dirrao commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1451121124
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -535,6 +537,7 @@ def execute(self, context: Context):
def execute_sync(self, context: Context):
Lee-W commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1451415591
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -535,6 +537,7 @@ def execute(self, context: Context):
def execute_sync(self, context: Context):
Lee-W commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1451418594
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -670,10 +680,16 @@ def write_logs(self, pod: k8s.V1Pod):
def post_complete_action(self, *, pod, remo
amoghrajesh commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1451915291
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -573,10 +575,17 @@ def execute_sync(self, context: Context):
self.pod, istio_enabled
Lee-W commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1451998425
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -670,10 +679,16 @@ def write_logs(self, pod: k8s.V1Pod):
def post_complete_action(self, *, pod, remo
dstandish commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1453772696
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -670,10 +680,16 @@ def write_logs(self, pod: k8s.V1Pod):
def post_complete_action(self, *, pod,
dstandish commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1453772696
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -670,10 +680,16 @@ def write_logs(self, pod: k8s.V1Pod):
def post_complete_action(self, *, pod,
dstandish commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1453774397
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -573,10 +575,17 @@ def execute_sync(self, context: Context):
self.pod, istio_enabled,
jedcunningham commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1453905335
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -573,10 +575,17 @@ def execute_sync(self, context: Context):
self.pod, istio_enabl
Lee-W commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1454952681
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -826,7 +842,11 @@ def on_kill(self) -> None:
}
if self.termination_grace_period i
Lee-W commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1455038360
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -573,10 +575,17 @@ def execute_sync(self, context: Context):
self.pod, istio_enabled, self
jedcunningham commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1458204102
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -573,10 +575,17 @@ def execute_sync(self, context: Context):
self.pod, istio_enabl
jedcunningham commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1458206012
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -670,10 +678,15 @@ def write_logs(self, pod: k8s.V1Pod):
def post_complete_action(self, *, p
Lee-W commented on code in PR #36749:
URL: https://github.com/apache/airflow/pull/36749#discussion_r1458229220
##
airflow/providers/cncf/kubernetes/operators/pod.py:
##
@@ -573,10 +575,17 @@ def execute_sync(self, context: Context):
self.pod, istio_enabled, self
eladkal merged PR #36749:
URL: https://github.com/apache/airflow/pull/36749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
16 matches
Mail list logo