[PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-12 Thread via GitHub
Lee-W opened a new pull request, #36749: URL: https://github.com/apache/airflow/pull/36749 #36471 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-req

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-12 Thread via GitHub
dirrao commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1451121124 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -535,6 +537,7 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-13 Thread via GitHub
Lee-W commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1451415591 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -535,6 +537,7 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-13 Thread via GitHub
Lee-W commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1451418594 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -670,10 +680,16 @@ def write_logs(self, pod: k8s.V1Pod): def post_complete_action(self, *, pod, remo

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-14 Thread via GitHub
amoghrajesh commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1451915291 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -573,10 +575,17 @@ def execute_sync(self, context: Context): self.pod, istio_enabled

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-14 Thread via GitHub
Lee-W commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1451998425 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -670,10 +679,16 @@ def write_logs(self, pod: k8s.V1Pod): def post_complete_action(self, *, pod, remo

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-16 Thread via GitHub
dstandish commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1453772696 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -670,10 +680,16 @@ def write_logs(self, pod: k8s.V1Pod): def post_complete_action(self, *, pod,

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-16 Thread via GitHub
dstandish commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1453772696 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -670,10 +680,16 @@ def write_logs(self, pod: k8s.V1Pod): def post_complete_action(self, *, pod,

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-16 Thread via GitHub
dstandish commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1453774397 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -573,10 +575,17 @@ def execute_sync(self, context: Context): self.pod, istio_enabled,

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-16 Thread via GitHub
jedcunningham commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1453905335 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -573,10 +575,17 @@ def execute_sync(self, context: Context): self.pod, istio_enabl

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-17 Thread via GitHub
Lee-W commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1454952681 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -826,7 +842,11 @@ def on_kill(self) -> None: } if self.termination_grace_period i

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-17 Thread via GitHub
Lee-W commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1455038360 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -573,10 +575,17 @@ def execute_sync(self, context: Context): self.pod, istio_enabled, self

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-18 Thread via GitHub
jedcunningham commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1458204102 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -573,10 +575,17 @@ def execute_sync(self, context: Context): self.pod, istio_enabl

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-18 Thread via GitHub
jedcunningham commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1458206012 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -670,10 +678,15 @@ def write_logs(self, pod: k8s.V1Pod): def post_complete_action(self, *, p

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-18 Thread via GitHub
Lee-W commented on code in PR #36749: URL: https://github.com/apache/airflow/pull/36749#discussion_r1458229220 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -573,10 +575,17 @@ def execute_sync(self, context: Context): self.pod, istio_enabled, self

Re: [PR] avoid retrying after KubernetesPodOperator has been marked as failed [airflow]

2024-01-20 Thread via GitHub
eladkal merged PR #36749: URL: https://github.com/apache/airflow/pull/36749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.