pankajastro merged PR #36849:
URL: https://github.com/apache/airflow/pull/36849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1463100649
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -639,6 +689,7 @@ async def get_sync_hook(self) -> Any:
self._sync_hook = await
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1463100649
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -639,6 +689,7 @@ async def get_sync_hook(self) -> Any:
self._sync_hook = await
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1463062271
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -639,6 +689,7 @@ async def get_sync_hook(self) -> Any:
self._sync_hook = await
pankajastro commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1463026613
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -639,6 +689,7 @@ async def get_sync_hook(self) -> Any:
self._sync_hook = await
nathadfield commented on PR #36849:
URL: https://github.com/apache/airflow/pull/36849#issuecomment-1905667804
It would be great to get some attention on this and #36903 from the
reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
m1racoli commented on PR #36849:
URL: https://github.com/apache/airflow/pull/36849#issuecomment-1900519634
> > This PR is expected to immediately resolve any issues around lack of
support of impersonation chain with gcloud-aio based deferrable tasks as long
the corresponding hooks and
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1458846533
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -623,6 +628,51 @@ def test_connection(self):
return status, message
+class
m1racoli commented on PR #36849:
URL: https://github.com/apache/airflow/pull/36849#issuecomment-1900209030
> This PR is expected to immediately resolve any issues around lack of
support of impersonation chain with gcloud-aio based deferrable tasks as long
the corresponding hooks and
m1racoli commented on PR #36849:
URL: https://github.com/apache/airflow/pull/36849#issuecomment-1900201327
> @m1racoli would you mind summarizing, assuming this PR is accepted, what
else needs to be done on this topic? It just that this problem had several
issues opened for it and several
eladkal commented on PR #36849:
URL: https://github.com/apache/airflow/pull/36849#issuecomment-187581
@m1racoli would you mind summarizing, assuming this PR is accepted, what
else needs to be done on this topic?
It just that this problem had several issues opened for it and several
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1458522587
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -3513,11 +3518,11 @@ async def get_table_client(
access to the specified project.
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1458541688
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -623,6 +628,51 @@ def test_connection(self):
return status, message
+class
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1458541688
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -623,6 +628,51 @@ def test_connection(self):
return status, message
+class
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1458541688
##
airflow/providers/google/common/hooks/base_google.py:
##
@@ -623,6 +628,51 @@ def test_connection(self):
return status, message
+class
m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1458522587
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -3513,11 +3518,11 @@ async def get_table_client(
access to the specified project.
Lee-W commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1458183618
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -3513,11 +3518,11 @@ async def get_table_client(
access to the specified project.
m1racoli opened a new pull request, #36849:
URL: https://github.com/apache/airflow/pull/36849
The class CredentialsToken implements the ability to generate access tokens
to be used in gcloud-aio clients from Google credentials objects provided by
instances of Google Cloud hooks.
18 matches
Mail list logo
