[GitHub] [beam] pawelpasterz commented on issue #11076: Run precommit portability on java 11

2020-03-16 Thread GitBox
pawelpasterz commented on issue #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076#issuecomment-599379680 @iemejia Hey! Thanks for comments. Regarding your first questions. We wanted to simulate case when beam (compiled with J8 ) cooperates with

[GitHub] [beam] iemejia commented on issue #11076: Run precommit portability on java 11

2020-03-16 Thread GitBox
iemejia commented on issue #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076#issuecomment-599387419 I see, your approach makes sense notice that my first comment is because we do not run tests as part of other VR tests, notice how slow the examples

[GitHub] [beam] mwalenia commented on issue #10949: [BEAM-9371] Add SideInputLoadTest to Java SDK

2020-03-16 Thread GitBox
mwalenia commented on issue #10949: [BEAM-9371] Add SideInputLoadTest to Java SDK URL: https://github.com/apache/beam/pull/10949#issuecomment-599388030 @Ardagan @kennknowles Can we get this moving forward? This is an automate

[GitHub] [beam] echauchot commented on issue #11055: [BEAM-9436] improve GBK

2020-03-16 Thread GitBox
echauchot commented on issue #11055: [BEAM-9436] improve GBK URL: https://github.com/apache/beam/pull/11055#issuecomment-599388900 I could not make jenkins launch the script from the PR (!) So I ran it locally here are the compared results: on a -Xms12g -Xmx20g JVM, 20 elements of K=10

[GitHub] [beam] mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#issuecomment-599389930 Run Java Precommig This is an automated message from the Apache Git Se

[GitHub] [beam] mwalenia removed a comment on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
mwalenia removed a comment on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#issuecomment-599389930 Run Java Precommig This is an automated message from the Apach

[GitHub] [beam] mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#issuecomment-59939 run java precommit This is an automated message from the Apache Git Se

[GitHub] [beam] echauchot opened a new pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
echauchot opened a new pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] echauchot edited a comment on issue #11055: [BEAM-9436] improve GBK

2020-03-16 Thread GitBox
echauchot edited a comment on issue #11055: [BEAM-9436] improve GBK URL: https://github.com/apache/beam/pull/11055#issuecomment-599388900 I could not make jenkins launch the script from the PR (!) So I ran it locally here are the compared results: on a -Xms12g -Xmx20g JVM, 20 elements

[GitHub] [beam] echauchot edited a comment on issue #11055: [BEAM-9436] improve GBK

2020-03-16 Thread GitBox
echauchot edited a comment on issue #11055: [BEAM-9436] improve GBK URL: https://github.com/apache/beam/pull/11055#issuecomment-599388900 I could not make jenkins launch the script from the PR (!) So I ran it locally here are the compared results: on a -Xms12g -Xmx20g JVM, 20 elements

[GitHub] [beam] echauchot edited a comment on issue #11055: [BEAM-9436] improve GBK

2020-03-16 Thread GitBox
echauchot edited a comment on issue #11055: [BEAM-9436] improve GBK URL: https://github.com/apache/beam/pull/11055#issuecomment-599388900 I could not make jenkins launch the script from the PR (!) So I ran it locally here are the compared results: on a -Xms12g -Xmx20g JVM, 20 elements

[GitHub] [beam] echauchot edited a comment on issue #11055: [BEAM-9436] improve GBK

2020-03-16 Thread GitBox
echauchot edited a comment on issue #11055: [BEAM-9436] improve GBK URL: https://github.com/apache/beam/pull/11055#issuecomment-599388900 I could not make jenkins launch the script from the PR (!) So I ran it locally here are the compared results: on a -Xms12g -Xmx20g JVM, 20 elements

[GitHub] [beam] iemejia edited a comment on issue #11076: Run precommit portability on java 11

2020-03-16 Thread GitBox
iemejia edited a comment on issue #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076#issuecomment-599387419 I see, your approach makes sense notice that my first comment is because we do not run examples as part of other VR tests, notice how slow the

[GitHub] [beam] iemejia edited a comment on issue #11076: Run precommit portability on java 11

2020-03-16 Thread GitBox
iemejia edited a comment on issue #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076#issuecomment-599387419 I see, your approach makes sense notice that my first comment is because we do not run examples as part of other VR tests, notice how slow the

[GitHub] [beam] pawelpasterz edited a comment on issue #11076: Run precommit portability on java 11

2020-03-16 Thread GitBox
pawelpasterz edited a comment on issue #11076: Run precommit portability on java 11 URL: https://github.com/apache/beam/pull/11076#issuecomment-599379680 @iemejia Hey! Thanks for comments. Regarding your first question. We wanted to simulate case when beam (compiled with J8 ) cooperate

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392848080 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392848153 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392852028 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy ## @@ -79,7 +79,23 @@ de

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392850806 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392850100 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] lgajowy commented on issue #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
lgajowy commented on issue #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#issuecomment-599407824 Adding @mwalenia and @kamilwu (not sure which one of you guys is available so doubling my chances ;) ). Please one of you, take a

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-16 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-599409159 @tweise can you assist with diagnosing the errors in Flink? I don't know how to approach it ---

[GitHub] [beam] mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#issuecomment-599410945 Run TFRecord IOIT This is an automated message from the Apache Git Ser

[GitHub] [beam] mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#issuecomment-599411463 Run Java TFRecordIO Performance Test This is an automated message from

[GitHub] [beam] mwalenia removed a comment on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
mwalenia removed a comment on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#issuecomment-599410945 Run TFRecord IOIT This is an automated message from the Apache

[GitHub] [beam] echauchot commented on issue #11055: [BEAM-9436] improve GBK

2020-03-16 Thread GitBox
echauchot commented on issue #11055: [BEAM-9436] improve GBK URL: https://github.com/apache/beam/pull/11055#issuecomment-599413582 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] echauchot commented on issue #11055: [BEAM-9436] improve GBK

2020-03-16 Thread GitBox
echauchot commented on issue #11055: [BEAM-9436] improve GBK URL: https://github.com/apache/beam/pull/11055#issuecomment-599413530 relaunching build because of flakiness This is an automated message from the Apache Git Service

[GitHub] [beam] echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392860650 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy #

[GitHub] [beam] echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392861222 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy #

[GitHub] [beam] echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392861467 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy ## @@ -79,7 +79,23 @@

[GitHub] [beam] echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#issuecomment-599415534 thanks Lukasz for the prompt review ! Indeed there will be some availability issues in the coming weeks. I'm, for myslef, worki

[GitHub] [beam] echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392865231 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy #

[GitHub] [beam] mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
mwalenia commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#issuecomment-599421354 LGTM, thanks for the contribution! This is an automated message from t

[beam] branch master updated: [BEAM-9346] Improve the efficiency of TFRecordIO (#11122)

2020-03-16 Thread mwalenia
This is an automated email from the ASF dual-hosted git repository. mwalenia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new f731211 [BEAM-9346] Improve the efficiency of T

[GitHub] [beam] mwalenia merged pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
mwalenia merged pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] mwalenia commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
mwalenia commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392895171 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy ##

[GitHub] [beam] mwalenia commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
mwalenia commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#discussion_r392883872 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy ## @@ -79,7 +79,23 @@ d

[GitHub] [beam] kamilwu commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource

2020-03-16 Thread GitBox
kamilwu commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource URL: https://github.com/apache/beam/pull/11040#issuecomment-599442967 @EDjur Could you create a JIRA ticket regarding `gcs_location` value provider evaluation and assign it to me afte

[GitHub] [beam] EDjur commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource

2020-03-16 Thread GitBox
EDjur commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource URL: https://github.com/apache/beam/pull/11040#issuecomment-599450124 Sure, JIRA ticket is at https://issues.apache.org/jira/browse/BEAM-9506 ---

[GitHub] [beam] kamilwu commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource

2020-03-16 Thread GitBox
kamilwu commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource URL: https://github.com/apache/beam/pull/11040#issuecomment-599459578 LGTM, let's wait for @pabloem's final review as well

[GitHub] [beam] kamilwu opened a new pull request #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-16 Thread GitBox
kamilwu opened a new pull request #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] piotr-szuberski opened a new pull request #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
piotr-szuberski opened a new pull request #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137 ….matchSingleFileSpec The code before masked the actual failure exception. The MatchResult usecase assumes th

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599492032 retest this please This is an automated message

[GitHub] [beam] kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-16 Thread GitBox
kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r392966450 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-16 Thread GitBox
kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r392972669 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-16 Thread GitBox
kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#issuecomment-599507221 Run Python PreCommit This is an automated message from the Apache Gi

[GitHub] [beam] mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599508375 retest this please This is an automated

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599508653 retest this please This is an automated message

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599508448 retest this please This is an automated message

[GitHub] [beam] mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599508448 retest this please This is an automated

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599508375 retest this please This is an automated message

[GitHub] [beam] mwalenia commented on issue #11135: Add spark structured streaming runner to GBK load tests

2020-03-16 Thread GitBox
mwalenia commented on issue #11135: Add spark structured streaming runner to GBK load tests URL: https://github.com/apache/beam/pull/11135#issuecomment-599510302 Run Java PreCommit This is an automated message from the Apache

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599512502 retest this please This is an automated message

[GitHub] [beam] mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599508653 retest this please This is an automated

[GitHub] [beam] mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia removed a comment on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599512502 retest this please This is an automated

[GitHub] [beam] kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-16 Thread GitBox
kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r392991557 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-16 Thread GitBox
kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393005385 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-16 Thread GitBox
kamilwu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393007213 ## File path: website/src/documentation/patterns/ai-platform.md ###

[GitHub] [beam] aromanenko-dev commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
aromanenko-dev commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#issuecomment-599536461 retest this please This is an automated message from the Apache G

[GitHub] [beam] kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-16 Thread GitBox
kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#issuecomment-599543541 Run Python PreCommit This is an automated message from the Apache Gi

[GitHub] [beam] pawelpasterz closed pull request #10878: Implement precommit portability test to run on java 11

2020-03-16 Thread GitBox
pawelpasterz closed pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] pawelpasterz closed pull request #10882: Implement java precommit dataflow examples tests to run on java 11

2020-03-16 Thread GitBox
pawelpasterz closed pull request #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882 This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599560521 retest this please This is an automated message

[GitHub] [beam] kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-16 Thread GitBox
kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#issuecomment-599565108 R: @ibzib Can I ask you for a review? This is an automated message f

[GitHub] [beam] kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-16 Thread GitBox
kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#issuecomment-599565761 Also a note: although this PR might look like a rework of the existing side input test, it's better to it as a completely different,

[GitHub] [beam] kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-16 Thread GitBox
kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#issuecomment-599567346 A PR with Java's version (very similar to this one): https://github.com/apache/beam/pull/10949 -

[GitHub] [beam] kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK

2020-03-16 Thread GitBox
kamilwu commented on issue #11136: [BEAM-7505] Add side input load test to Python SDK URL: https://github.com/apache/beam/pull/11136#issuecomment-599567583 cc: @Ardagan This is an automated message from the Apache Git Servi

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599583839 run java precommit This is an automated message

[GitHub] [beam] mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems…

2020-03-16 Thread GitBox
mwalenia commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-599584214 run java precommit This is an automated message

[GitHub] [beam] mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-16 Thread GitBox
mwalenia commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-599593986 @mxm Would you be able to help with diagnosing problems plaguing the Flink cluster when running these tests? --

[GitHub] [beam] lukecwik commented on issue #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write

2020-03-16 Thread GitBox
lukecwik commented on issue #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write URL: https://github.com/apache/beam/pull/9758#issuecomment-599607658 Run Java PreCommit This is an automated message

[GitHub] [beam] wenchenglu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-03-16 Thread GitBox
wenchenglu commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton URL: https://github.com/apache/beam/pull/11075#discussion_r393146109 ## File path: website/src/documentation/patterns/ai-platform.md

[GitHub] [beam] robertwb commented on issue #10760: Dataframe transforms

2020-03-16 Thread GitBox
robertwb commented on issue #10760: Dataframe transforms URL: https://github.com/apache/beam/pull/10760#issuecomment-599630007 R: @TheNeuralBit this is ready for review. This is an automated message from the Apache Git Service

[beam] branch master updated (f731211 -> 55d374e)

2020-03-16 Thread robertwb
This is an automated email from the ASF dual-hosted git repository. robertwb pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from f731211 [BEAM-9346] Improve the efficiency of TFRecordIO (#11122) add cf3ce65 [BEAM-9433] Create expansion ser

[GitHub] [beam] robertwb merged pull request #11048: [BEAM-9433] Create expansion service artifact for common Java IOs.

2020-03-16 Thread GitBox
robertwb merged pull request #11048: [BEAM-9433] Create expansion service artifact for common Java IOs. URL: https://github.com/apache/beam/pull/11048 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [beam] udim commented on issue #10528: [BEAM-9064] Add pytype checks to tox

2020-03-16 Thread GitBox
udim commented on issue #10528: [BEAM-9064] Add pytype checks to tox URL: https://github.com/apache/beam/pull/10528#issuecomment-599631368 I'll try to get this in this week This is an automated message from the Apache Git

[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.

2020-03-16 Thread GitBox
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script. URL: https://github.com/apache/beam/pull/11123#issuecomment-599638654 Python 3.5 and 3.7 postcommits flaked because of BEAM-8866 This

[GitHub] [beam] aromanenko-dev commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
aromanenko-dev commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#issuecomment-599641222 > The test case waits for 5 elements from shardReadersPool: I think I disagree here - `fetchedRecords` will contain only 4 e

[GitHub] [beam] aromanenko-dev edited a comment on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
aromanenko-dev edited a comment on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#issuecomment-599641222 > The test case waits for 5 elements from shardReadersPool: I think I disagree here - `fetchedRecords` will contain o

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
aromanenko-dev commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#discussion_r393165574 ## File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardReadersPool.java #

[GitHub] [beam] aromanenko-dev commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
aromanenko-dev commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#discussion_r393167162 ## File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardReadersPool.java #

[GitHub] [beam] aromanenko-dev edited a comment on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
aromanenko-dev edited a comment on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#issuecomment-599641222 > The test case waits for 5 elements from shardReadersPool: @suztomo I think I disagree here - `fetchedRecords` will

[GitHub] [beam] mxm commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java

2020-03-16 Thread GitBox
mxm commented on issue #10386: [BEAM-8972] Add Jenkins job with Combine test for portable Java URL: https://github.com/apache/beam/pull/10386#issuecomment-599648213 Your root transform executes in an environment. This is not allowed in portability. We introduced READ support to implement c

[GitHub] [beam] amaliujia commented on issue #11130: [BEAM-8070] Preserve type for empty array

2020-03-16 Thread GitBox
amaliujia commented on issue #11130: [BEAM-8070] Preserve type for empty array URL: https://github.com/apache/beam/pull/11130#issuecomment-599648855 Could you add a unit test for this change? This is an automated message from

[GitHub] [beam] suztomo commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
suztomo commented on issue #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#issuecomment-599653019 @aromanenko-dev You're right. `fetchedRecords` only contains 4 elements. My understanding for the test was incorrect. --

[GitHub] [beam] udim commented on issue #11038: [BEAM-7746] More typing fixes

2020-03-16 Thread GitBox
udim commented on issue #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#issuecomment-599654214 Looking at this today This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes

2020-03-16 Thread GitBox
chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r393183860 ## File path: sdks/python/apache_beam/io/iobase.py ## @@ -244,7 +272,7 @@ def is_bounded(self): return True -cl

[GitHub] [beam] chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes

2020-03-16 Thread GitBox
chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r393185957 ## File path: sdks/python/apache_beam/runners/pipeline_context.py ## @@ -48,19 +55,33 @@ from apache_beam.coders.code

[GitHub] [beam] chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes

2020-03-16 Thread GitBox
chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r393187482 ## File path: sdks/python/apache_beam/runners/worker/sdk_worker.py ## @@ -171,7 +172,7 @@ def get_responses(): self

[GitHub] [beam] chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes

2020-03-16 Thread GitBox
chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r393187810 ## File path: sdks/python/apache_beam/runners/worker/sdk_worker.py ## @@ -724,8 +738,9 @@ def pull_responses(): rea

[GitHub] [beam] chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes

2020-03-16 Thread GitBox
chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r393190055 ## File path: sdks/python/apache_beam/utils/sentinel.py ## @@ -0,0 +1,30 @@ +# +# Licensed to the Apache Software Founda

[GitHub] [beam] angoenka commented on issue #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle

2020-03-16 Thread GitBox
angoenka commented on issue #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle URL: https://github.com/apache/beam/pull/11071#issuecomment-599678465 Run Python PreCommit This is an automated message from the Apache

[GitHub] [beam] amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2020-03-16 Thread GitBox
amaliujia commented on issue #11081: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch URL: https://github.com/apache/beam/pull/11081#issuecomment-599679066 Run Java PreCommit This is an automated m

[GitHub] [beam] jfarr commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
jfarr commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#discussion_r393216743 ## File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardReadersPool.java ##

[GitHub] [beam] jfarr commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky

2020-03-16 Thread GitBox
jfarr commented on a change in pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#discussion_r393222652 ## File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/ShardReadersPool.java ##

[GitHub] [beam] aaltay commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-03-16 Thread GitBox
aaltay commented on issue #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#issuecomment-599709980 If this is a common pattern (another one from: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sd

[GitHub] [beam] angoenka merged pull request #11129: [BEAM-9504] Sickbay streaming test for batch VR

2020-03-16 Thread GitBox
angoenka merged pull request #11129: [BEAM-9504] Sickbay streaming test for batch VR URL: https://github.com/apache/beam/pull/11129 This is an automated message from the Apache Git Service. To respond to the message, please

[beam] branch master updated: [BEAM-9504] Sickbay streaming test for batch VR

2020-03-16 Thread goenka
This is an automated email from the ASF dual-hosted git repository. goenka pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new 61da25f [BEAM-9504] Sickbay streaming test for ba

[GitHub] [beam] angoenka commented on issue #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle

2020-03-16 Thread GitBox
angoenka commented on issue #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle URL: https://github.com/apache/beam/pull/11071#issuecomment-599723118 Python Precommits passing: https://builds.apache.org/job/beam_PreCommit_Python_Phrase/1603/ -

[GitHub] [beam] lukecwik commented on issue #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write

2020-03-16 Thread GitBox
lukecwik commented on issue #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write URL: https://github.com/apache/beam/pull/9758#issuecomment-599724511 Run Java PreCommit This is an automated message

  1   2   >