[GitHub] [calcite] chunweilei commented on a change in pull request #1173: [CALCITE-3006] Example code on site cannot compile

chunweilei commented on a change in pull request #1173: [CALCITE-3006] Example code on site cannot compile URL: https://github.com/apache/calcite/pull/1173#discussion_r276516388 ## File path: site/_docs/index.md ## @@ -50,8 +50,7 @@ Connection connection =

[GitHub] [calcite] hsyuan commented on a change in pull request #1173: [CALCITE-3006] Example code on site cannot compile

hsyuan commented on a change in pull request #1173: [CALCITE-3006] Example code on site cannot compile URL: https://github.com/apache/calcite/pull/1173#discussion_r276513630 ## File path: site/_docs/index.md ## @@ -50,8 +50,7 @@ Connection connection = CalciteConnection

[GitHub] [calcite] hsyuan commented on a change in pull request #1172: [CALCITE-3007] Type mismatch for ANY subquery in project (Vineet Garg)

hsyuan commented on a change in pull request #1172: [CALCITE-3007] Type mismatch for ANY subquery in project (Vineet Garg) URL: https://github.com/apache/calcite/pull/1172#discussion_r276513254 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

[GitHub] [calcite] chunweilei opened a new pull request #1173: [CALCITE-3006] Example code on site cannot compile

chunweilei opened a new pull request #1173: [CALCITE-3006] Example code on site cannot compile URL: https://github.com/apache/calcite/pull/1173 JIRA: https://issues.apache.org/jira/browse/CALCITE-3006 This is an automated

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon

pengzhiwei2018 commented on a change in pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon URL: https://github.com/apache/calcite/pull/783#discussion_r276231276 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -937,6

[GitHub] [calcite] vineetgarg02 commented on issue #1161: [CALCITE-2986] Wrong results with =ANY subquery

vineetgarg02 commented on issue #1161: [CALCITE-2986] Wrong results with =ANY subquery URL: https://github.com/apache/calcite/pull/1161#issuecomment-484331692 > In your test case, deptno in table dept is distinct. Can you use another column that is not distinct? @hsyuan Thanks for

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276497848 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276497024 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276496556 ## File path:

[GitHub] [calcite] vineetgarg02 opened a new pull request #1172: [CALCITE-3007] Type mismatch for ANY subquery in project (Vineet Garg)

vineetgarg02 opened a new pull request #1172: [CALCITE-3007] Type mismatch for ANY subquery in project (Vineet Garg) URL: https://github.com/apache/calcite/pull/1172 This is an automated message from the Apache Git Service.

[GitHub] [calcite] hsyuan commented on issue #1170: [CALCITE-3008] Create AuxiliaryConverterFactory

hsyuan commented on issue #1170: [CALCITE-3008] Create AuxiliaryConverterFactory URL: https://github.com/apache/calcite/pull/1170#issuecomment-484309002 Let's discuss in JIRA. This is an automated message from the Apache Git

[calcite-avatica] branch master updated: [CALCITE-2882] Connection properties are lost after timeout (bake)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new f3997b5 [CALCITE-2882] Connection

[GitHub] [calcite-avatica] zabetak closed pull request #86: [CALCITE-2882] Set dirty true when open connection

zabetak closed pull request #86: [CALCITE-2882] Set dirty true when open connection URL: https://github.com/apache/calcite-avatica/pull/86 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] jcamachor commented on a change in pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

jcamachor commented on a change in pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#discussion_r276472711 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] jcamachor commented on a change in pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

jcamachor commented on a change in pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#discussion_r276472812 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] jcamachor commented on a change in pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

jcamachor commented on a change in pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171#discussion_r276472832 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] walterddr commented on issue #1170: [CALCITE-3008] Create AuxiliaryConverterFactory

walterddr commented on issue #1170: [CALCITE-3008] Create AuxiliaryConverterFactory URL: https://github.com/apache/calcite/pull/1170#issuecomment-484299674 > Why do you want pass factory class instead of just interface AuxiliaryConverter in SqlToRelConverter? That's actually a good

[GitHub] [calcite] hsyuan commented on issue #1161: [CALCITE-2986] Wrong results with =ANY subquery

hsyuan commented on issue #1161: [CALCITE-2986] Wrong results with =ANY subquery URL: https://github.com/apache/calcite/pull/1161#issuecomment-484280029 In your test case, deptno in table dept is distinct. Can you use another column that is not distinct?

[GitHub] [calcite] vineetgarg02 commented on issue #1161: [CALCITE-2986] Wrong results with =ANY subquery

vineetgarg02 commented on issue #1161: [CALCITE-2986] Wrong results with =ANY subquery URL: https://github.com/apache/calcite/pull/1161#issuecomment-484279139 > Can you add a test case that the join key on inner rel is not distinct? @hsyuan Can you please clarify what do you mean by

[GitHub] [calcite] vineetgarg02 opened a new pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule

vineetgarg02 opened a new pull request #1171: [CALCITE-3011] Support for joins with AggregateJoinTransposeRule URL: https://github.com/apache/calcite/pull/1171 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] my7ym commented on a change in pull request #1152: [CALCITE-2962] RelStructuredTypeFlattener generates wrong types for n…

my7ym commented on a change in pull request #1152: [CALCITE-2962] RelStructuredTypeFlattener generates wrong types for n… URL: https://github.com/apache/calcite/pull/1152#discussion_r276382850 ## File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml

[GitHub] [calcite] walterddr opened a new pull request #1170: [CALCITE-3008] Create AuxiliaryConverterFactory

walterddr opened a new pull request #1170: [CALCITE-3008] Create AuxiliaryConverterFactory URL: https://github.com/apache/calcite/pull/1170 This fixes: https://issues.apache.org/jira/browse/CALCITE-3008 This is an

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276323531 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276323531 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276323531 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276314512 ## File path:

[GitHub] [calcite] rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276310289 ## File path:

[GitHub] [calcite] chunweilei edited a comment on issue #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon

chunweilei edited a comment on issue #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon URL: https://github.com/apache/calcite/pull/783#issuecomment-484144523 I think it should add some negative test cases.

[GitHub] [calcite] chunweilei commented on issue #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon

chunweilei commented on issue #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon URL: https://github.com/apache/calcite/pull/783#issuecomment-484144523 I think it should add some negative cases.

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276227660 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276225826 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276256521 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276286737 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276241515 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276285868 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276232058 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276226630 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276251059 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276217765 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276284557 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276223091 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276249367 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276286371 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276246151 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276257340 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276234096 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276292360 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276233637 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276293033 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276237088 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276224848 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276250468 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276288101 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276231059 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276228589 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)

zabetak commented on a change in pull request #1020: [CALCITE-2812] Add algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1020#discussion_r276232747 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon

chunweilei commented on a change in pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon URL: https://github.com/apache/calcite/pull/783#discussion_r276258448 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -937,6

[GitHub] [calcite] chunweilei commented on a change in pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon

chunweilei commented on a change in pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon URL: https://github.com/apache/calcite/pull/783#discussion_r276258448 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -937,6

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon

pengzhiwei2018 commented on a change in pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon URL: https://github.com/apache/calcite/pull/783#discussion_r276231276 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -937,6

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276195652 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276167803 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276165624 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276167803 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276167803 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276165624 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] danny0405 opened a new pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f…

danny0405 opened a new pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f… URL: https://github.com/apache/calcite/pull/1169 …or in subquery with non-equi condition This is an automated

[GitHub] [calcite] julianhyde commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

julianhyde commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276159830 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -243,6

[GitHub] [calcite] julianhyde commented on issue #1150: [CALCITE-2985] Add the JSON_STORAGE_SIZE function

julianhyde commented on issue #1150: [CALCITE-2985] Add the JSON_STORAGE_SIZE function URL: https://github.com/apache/calcite/pull/1150#issuecomment-484004538 Let's discuss in JIRA. Github is not the place for design discussions.

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276142271 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276143058 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r276145290 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] XuQianJin-Stars commented on issue #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

XuQianJin-Stars commented on issue #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#issuecomment-483995130 This PR will be updated after [CALCITE-2846](https://issues.apache.org/jira/browse/CALCITE-2846).

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

XuQianJin-Stars opened a new pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168 Some string functions including LEFT, RIGHT are not implemented now. It would be great if these functions can be implemented.

[GitHub] [calcite] chunweilei edited a comment on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

chunweilei edited a comment on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-483975946 > Overall, it looks good but I will do another more careful pass in the following days ;) Sure.

[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-483975946 > Overall, it looks good but I will do another more careful pass in the following days ;) Sure. Appreciate

[GitHub] [calcite] chunweilei commented on issue #1166: [CALCITE-3004] RexOver is incorrectly pushed down in ProjectSetOpTran…

chunweilei commented on issue #1166: [CALCITE-3004] RexOver is incorrectly pushed down in ProjectSetOpTran… URL: https://github.com/apache/calcite/pull/1166#issuecomment-483964433 @julianhyde @zhztheplayer, could you please review the PR? Thanks a lot.

[GitHub] [calcite] chunweilei commented on a change in pull request #1167: [CALCITE-3009] It should fail if there are duplicate keys in a .xml file

chunweilei commented on a change in pull request #1167: [CALCITE-3009] It should fail if there are duplicate keys in a .xml file URL: https://github.com/apache/calcite/pull/1167#discussion_r276103161 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

[GitHub] [calcite] chunweilei opened a new pull request #1167: [CALCITE-3009] It should fail if there are duplicate keys in a .xml file

chunweilei opened a new pull request #1167: [CALCITE-3009] It should fail if there are duplicate keys in a .xml file URL: https://github.com/apache/calcite/pull/1167 JIRA: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-3009?filter=allopenissues

[GitHub] [calcite] zabetak commented on a change in pull request #1152: [CALCITE-2962] RelStructuredTypeFlattener generates wrong types for n…

zabetak commented on a change in pull request #1152: [CALCITE-2962] RelStructuredTypeFlattener generates wrong types for n… URL: https://github.com/apache/calcite/pull/1152#discussion_r276102717 ## File path:

[GitHub] [calcite] zabetak commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

zabetak commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-483961672 Overall, it looks good but I will do another more careful pass in the following days ;)