[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279246435 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableThetaJoin

[calcite-avatica] annotated tag rel/avatica-1.14.0 updated (4fe0f9b -> 0e628e5)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to annotated tag rel/avatica-1.14.0 in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git. *** WARNING: tag rel/avatica-1.14.0 was modified! *** from 4fe0f9b (commit) to

[calcite-avatica] branch master updated: [CALCITE-3033] Add navigation item for avatica-go HOWTO documentation

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new 5468f33 [CALCITE-3033] Add navi

[calcite-avatica] branch master updated (5c754cf -> 3393c57)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git. from 5c754cf [CALCITE-2939] NPE when executeBatch array type (Bake) new dcbb9db [CALCITE-2988] Prep

[GitHub] [calcite] FaxianZhao opened a new pull request #1188: [CALCITE-3034] Test case description is not match code logical

FaxianZhao opened a new pull request #1188: [CALCITE-3034] Test case description is not match code logical URL: https://github.com/apache/calcite/pull/1188 The javadoc of the o.a.c.t.CsvTest#testFilterableWhere2 is 'Filter that can be partly handled by CsvFilterableTable.' Actually it

svn commit: r33810 - in /release/calcite: apache-calcite-avatica-1.12.0/ apache-calcite-avatica-1.14.0/

Author: francischuang Date: Mon Apr 29 06:04:07 2019 New Revision: 33810 Log: Release apache-calcite-avatica-1.14.0 Added: release/calcite/apache-calcite-avatica-1.14.0/ release/calcite/apache-calcite-avatica-1.14.0/apache-calcite-avatica-1.14.0-src.tar.gz (with props) release/ca

[GitHub] [calcite] chunweilei commented on a change in pull request #1185: [CALCITE-3012] areColumnsUnique for FULL OUTER JOIN could return wrong answer when ignoreNulls is false

chunweilei commented on a change in pull request #1185: [CALCITE-3012] areColumnsUnique for FULL OUTER JOIN could return wrong answer when ignoreNulls is false URL: https://github.com/apache/calcite/pull/1185#discussion_r279240184 ## File path: core/src/test/java/org/apache/calcite

[GitHub] [calcite] my7ym commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field

my7ym commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field URL: https://github.com/apache/calcite/pull/1186#discussion_r279240103 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java ## @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279240531 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableThetaJoin.ja

[calcite-avatica-go] branch master updated: [CALCITE-3033] Move release process to separate HOWTO document to be consistent with how the avatica docs are structured

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git The following commit(s) were added to refs/heads/master by this push: new a8df670 [CALCITE-3033] Move

[GitHub] [calcite] hsyuan removed a comment on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan removed a comment on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#issuecomment-487456325 Our common agreement is Rename EnumerableThetaJoin to NestedLoopJoin, and keep EnumerableCorrelate unchanged. I

[GitHub] [calcite] hsyuan commented on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#issuecomment-487456325 Our common agreement is Rename EnumerableThetaJoin to NestedLoopJoin, and keep EnumerableCorrelate unchanged. If you do

[calcite-avatica-go] tag v3.3.0-rc0 created (now b897f20)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to tag v3.3.0-rc0 in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. at b897f20 (commit) No new revisions were added by this update.

[calcite-avatica-go] tag v3.3.0 created (now b897f20)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to tag v3.3.0 in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. at b897f20 (commit) No new revisions were added by this update.

[calcite-avatica-go] branch master updated: [CALCITE-3032] Improve release script

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git The following commit(s) were added to refs/heads/master by this push: new 3fd5360 [CALCITE-3032] Impro

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279240026 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableThetaJoin

[calcite-avatica-go] branch master updated (3fd5360 -> 8cbd923)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 3fd5360 [CALCITE-3032] Improve release script new 8cbd923 [CALCITE-3032] Simplify docker-co

[GitHub] [calcite] chunweilei commented on a change in pull request #1185: [CALCITE-3012] areColumnsUnique for FULL OUTER JOIN could return wrong answer when ignoreNulls is false

chunweilei commented on a change in pull request #1185: [CALCITE-3012] areColumnsUnique for FULL OUTER JOIN could return wrong answer when ignoreNulls is false URL: https://github.com/apache/calcite/pull/1185#discussion_r279239723 ## File path: core/src/main/java/org/apache/calcit

[GitHub] [calcite] chunweilei commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field

chunweilei commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field URL: https://github.com/apache/calcite/pull/1186#discussion_r279225979 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279236014 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableThetaJoin.ja

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r279232979 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java #

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r279232979 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java #

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r279232979 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java #

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

XuQianJin-Stars commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r279232979 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java #

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

pengzhiwei2018 commented on a change in pull request #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#discussion_r279232292 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279230560 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230

[GitHub] [calcite] XuQianJin-Stars commented on issue #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT

XuQianJin-Stars commented on issue #1168: [CALCITE-3005] Implement string functions: LEFT, RIGHT URL: https://github.com/apache/calcite/pull/1168#issuecomment-487440494 hi @pengzhiwei2018 Could you please take your time to review this PR? --

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279228078 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230,6

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279228408 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.jav

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279227866 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279226679 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230,6

[GitHub] [calcite] chunweilei commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field

chunweilei commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field URL: https://github.com/apache/calcite/pull/1186#discussion_r279225979 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279226492 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279226373 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.

[GitHub] [calcite] danny0405 commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f…

danny0405 commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f… URL: https://github.com/apache/calcite/pull/1169#discussion_r279225786 ## File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.x

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279223481 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279218729 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.jav

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279214406 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230,6

[GitHub] [calcite] hsyuan commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f…

hsyuan commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f… URL: https://github.com/apache/calcite/pull/1169#discussion_r279214148 ## File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml

[GitHub] [calcite] my7ym commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field

my7ym commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field URL: https://github.com/apache/calcite/pull/1186#discussion_r279203643 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java ## @@

[GitHub] [calcite] chunweilei commented on issue #1182: [CALCITE-2292] Query result is wrong when table is implemented with F…

chunweilei commented on issue #1182: [CALCITE-2292] Query result is wrong when table is implemented with F… URL: https://github.com/apache/calcite/pull/1182#issuecomment-487382929 @hsyuan @zabetak , could you please review this PR? Thanks~~ -

[GitHub] [calcite] chunweilei commented on a change in pull request #1182: [CALCITE-2292] Query result is wrong when table is implemented with F…

chunweilei commented on a change in pull request #1182: [CALCITE-2292] Query result is wrong when table is implemented with F… URL: https://github.com/apache/calcite/pull/1182#discussion_r278919079 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.j

[GitHub] [calcite] zhztheplayer opened a new pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N…

zhztheplayer opened a new pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N… URL: https://github.com/apache/calcite/pull/1187 …ULL after being converted to SQL-oriented This is an autom

[GitHub] [calcite] zhztheplayer closed pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N…

zhztheplayer closed pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N… URL: https://github.com/apache/calcite/pull/1187 This is an automated message from the Apache Git Service. To res

[GitHub] [calcite] zhztheplayer opened a new pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N…

zhztheplayer opened a new pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N… URL: https://github.com/apache/calcite/pull/1187 …ULL after being converted to SQL-oriented This is an autom

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N…

zhztheplayer commented on a change in pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N… URL: https://github.com/apache/calcite/pull/1187#discussion_r279188925 ## File path: core/src/main/java/org/apache/calcite/jdbc/JavaTypeFactoryImpl.java

[GitHub] [calcite] zhztheplayer closed pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N…

zhztheplayer closed pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N… URL: https://github.com/apache/calcite/pull/1187 This is an automated message from the Apache Git Service. To res

[GitHub] [calcite] zhztheplayer opened a new pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N…

zhztheplayer opened a new pull request #1187: [CALCITE-3029] Java-oriented field type is wrongly forced to be NOT N… URL: https://github.com/apache/calcite/pull/1187 …ULL after being converted to SQL-oriented This is an autom

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279187850 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279187820 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279182010 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230,6

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279181915 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230,6