danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279187850
##########
File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java
##########
@@ -16,13 +16,61 @@
*/
package org.apache.calcite.rel.core;
+import org.apache.calcite.linq4j.CorrelateJoinType;
+
import java.util.Locale;
/**
* Enumeration of join types.
*/
public enum JoinRelType {
- INNER, LEFT, RIGHT, FULL;
+ /**
+ * Inner join.
+ */
+ INNER,
+
+ /**
+ * Left-outer join.
+ */
+ LEFT,
+
+ /**
+ * Right-outer join.
+ */
+ RIGHT,
Review comment:
+1 to treat it as future, thx @zabetak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
