[GitHub] [calcite] zoudan opened a new pull request, #3010: [CALCITE-5408] Return type of PERCENTILE_CONT should be the same as sort expression

zoudan opened a new pull request, #3010: URL: https://github.com/apache/calcite/pull/3010 Return type of PERCENTILE_CONT should be the same as sort expression -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] libenchao commented on a diff in pull request #3006: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

libenchao commented on code in PR #3006: URL: https://github.com/apache/calcite/pull/3006#discussion_r1053918469 ## core/src/main/java/org/apache/calcite/sql/SqlPivot.java: ## @@ -195,5 +197,17 @@ static class Operator extends SqlSpecialOperator { Operator(SqlKind kind) {

[GitHub] [calcite] olivrlee commented on a diff in pull request #3009: CALCITE-5447/ DATE_TRUNC() function for BIG_QUERY

olivrlee commented on code in PR #3009: URL: https://github.com/apache/calcite/pull/3009#discussion_r1053806093 ## babel/src/test/resources/sql/redshift.iq: ## @@ -1238,7 +1238,7 @@ select date_part(minute, time '02:08:01'); select date_part(minute, date '2009-01-01'); !ok

[GitHub] [calcite] vvysotskyi commented on a diff in pull request #3006: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

vvysotskyi commented on code in PR #3006: URL: https://github.com/apache/calcite/pull/3006#discussion_r1053728428 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -6653,13 +6654,44 @@ private void checkLiteral2(String expression, String

[GitHub] [calcite] tanclary opened a new pull request, #3008: [CALCITE-5436] Implement DATE_SUB, TIME_SUB, TIMESTAMP_SUB (compatible w/ BigQuery)

tanclary opened a new pull request, #3008: URL: https://github.com/apache/calcite/pull/3008 Add support for BigQuery's DATE_SUB, TIME_SUB, and TIMESTAMP_SUB functions. Create MINUS_DATE2 operator to handle subtracting an interval from a timestamp, time, or date expression. This differs

[GitHub] [calcite-avatica] freastro opened a new pull request, #201: [CALCITE-5443] Reset update count when checking for more results

freastro opened a new pull request, #201: URL: https://github.com/apache/calcite-avatica/pull/201 Modifies `AvaticaStatement#getMoreResults()` to match the requirement from the JavaDoc indicating that subsequent calls to `getUpdateCount()` should return `-1`. -- This is an automated

[GitHub] [calcite] libenchao commented on a diff in pull request #2968: [CALCITE-5354] JDBC with UNNEST not working

libenchao commented on code in PR #2968: URL: https://github.com/apache/calcite/pull/2968#discussion_r1052155773 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -2442,18 +2472,27 @@ private void convertUnnest(Blackboard bb, SqlCall call,

[GitHub] [calcite] libenchao commented on a diff in pull request #3006: [CALCITE-5439] Validation of Pivot fails after creating a deep copy of SqlNode

libenchao commented on code in PR #3006: URL: https://github.com/apache/calcite/pull/3006#discussion_r1052145202 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -6653,13 +6654,44 @@ private void checkLiteral2(String expression, String

[GitHub] [calcite] JiajunBernoulli commented on pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli commented on PR #2997: URL: https://github.com/apache/calcite/pull/2997#issuecomment-1357496002 > LGTM, with the suggestions I made. > > Also, improve the commit message and bug summary. Mention MySQL, JDBC adapter, GROUP BY WITH ROLLUP, ORDER BY. Thanks for

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli commented on code in PR #2997: URL: https://github.com/apache/calcite/pull/2997#discussion_r1052095333 ## core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java: ## @@ -868,19 +867,35 @@ public Result visit(Sort e) { if

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli commented on code in PR #2997: URL: https://github.com/apache/calcite/pull/2997#discussion_r1052093557 ## core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java: ## @@ -868,19 +867,35 @@ public Result visit(Sort e) { if

[GitHub] [calcite] hannerwang commented on a diff in pull request #2745: [CALCITE-4512] GROUP BY expression with argument name same with SELEC…

hannerwang commented on code in PR #2745: URL: https://github.com/apache/calcite/pull/2745#discussion_r1051847750 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6590,20 +6593,25 @@ static class ExtendedExpander extends Expander { final

[GitHub] [calcite] julianhyde commented on a diff in pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

julianhyde commented on code in PR #2997: URL: https://github.com/apache/calcite/pull/2997#discussion_r1051695803 ## core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java: ## @@ -868,19 +867,35 @@ public Result visit(Sort e) { if (hasTrickyRollup(e,

[GitHub] [calcite] snuyanzin commented on pull request #3007: [CALCITE-5440] Bump gradle from 7.4.2 to 7.6

snuyanzin commented on PR #3007: URL: https://github.com/apache/calcite/pull/3007#issuecomment-1356726972 looks like there are still issues with `./gradlew javadocAggregate` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2968: [CALCITE-5354] JDBC with UNNEST not working

JiajunBernoulli commented on code in PR #2968: URL: https://github.com/apache/calcite/pull/2968#discussion_r1051511326 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -2442,18 +2472,27 @@ private void convertUnnest(Blackboard bb, SqlCall call,

[GitHub] [calcite] snuyanzin opened a new pull request, #3007: [CALCITE-5440] Bump gradle from 7.4.2 to 7.6

snuyanzin opened a new pull request, #3007: URL: https://github.com/apache/calcite/pull/3007 `sourceCompatibility` and `targetCompatibility` removed in latest gradle. Currently there is one warning in output for `./gradlew help --warning-mode=all` ``` > Task

[GitHub] [calcite] mkou commented on pull request #2973: [CALCITE-5180] Implement some of the overloads for BigQuery's DATE and TIMESTAMP

mkou commented on PR #2973: URL: https://github.com/apache/calcite/pull/2973#issuecomment-1356124354 Hey Julian, Yes we agree this is what I meant > > Le 16 déc. 2022 à 18:52, Julian Hyde ***@***.***> a écrit : > >  > @mkou, In SqlLibraryOperators, the

[GitHub] [calcite] julianhyde commented on a diff in pull request #2919: [CALCITE-5298] CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager

julianhyde commented on code in PR #2919: URL: https://github.com/apache/calcite/pull/2919#discussion_r1051297728 ## core/src/main/java/org/apache/calcite/util/Util.java: ## @@ -1048,6 +1048,19 @@ public static String getStackTrace(Throwable t) { return sw.toString(); }

[GitHub] [calcite] julianhyde commented on pull request #2973: [CALCITE-5180] Implement some of the overloads for BigQuery's DATE and TIMESTAMP

julianhyde commented on PR #2973: URL: https://github.com/apache/calcite/pull/2973#issuecomment-1355981493 @mkou, In `SqlLibraryOperators`, the `TIMESTAMP` function should return a Calcite `TIMESTAMP`, `DATE` will return `DATE`, and there is no `DATETIME` function. Elsewhere (or in

[GitHub] [calcite] mkou commented on pull request #2973: [CALCITE-5180] Implement some of the overloads for BigQuery's DATE and TIMESTAMP

mkou commented on PR #2973: URL: https://github.com/apache/calcite/pull/2973#issuecomment-1355746946 > I see this was last month, I just want to make sure that there is better visibility on that and that indeed we agree that BQ TIMESTAMP => Calcite TIMESTAMP WITH LOCAL TIMEZONW

[GitHub] [calcite] risdenk commented on a diff in pull request #2919: [CALCITE-5298] CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager

risdenk commented on code in PR #2919: URL: https://github.com/apache/calcite/pull/2919#discussion_r1050847408 ## core/src/main/java/org/apache/calcite/util/Util.java: ## @@ -1048,6 +1048,19 @@ public static String getStackTrace(Throwable t) { return sw.toString(); }

[GitHub] [calcite] zabetak closed pull request #3004: [CALCITE-5433] Druid tests hang/fail intermittently in CI

zabetak closed pull request #3004: [CALCITE-5433] Druid tests hang/fail intermittently in CI URL: https://github.com/apache/calcite/pull/3004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite-avatica] stoty opened a new pull request, #200: CALCITE-5065 Update phoenixdb information on website

stoty opened a new pull request, #200: URL: https://github.com/apache/calcite-avatica/pull/200 Change-Id: I8e83abf31aa47d54af8db6365121976a7d3ccf3f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite-avatica] stoty opened a new pull request, #199: CALCITE-5438 Document transparent_reconnection property

stoty opened a new pull request, #199: URL: https://github.com/apache/calcite-avatica/pull/199 Change-Id: If8d199c58cd974c2739f617d96153d36f0ae12d7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] bchapuis merged pull request #3002: [CALCITE-5417] Upgrade Proj4J from 1.1.5 to 1.2.2

bchapuis merged PR #3002: URL: https://github.com/apache/calcite/pull/3002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] bchapuis merged pull request #2924: [CALCITE-5281] Add ST_Explode for geometry

bchapuis merged PR #2924: URL: https://github.com/apache/calcite/pull/2924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] julianhyde commented on a diff in pull request #3002: [CALCITE-5417] Upgrade Proj4J from 1.1.5 to 1.2.2

julianhyde commented on code in PR #3002: URL: https://github.com/apache/calcite/pull/3002#discussion_r1049151469 ## core/src/main/java/org/apache/calcite/runtime/CalciteResource.java: ## @@ -66,6 +66,9 @@ public interface CalciteResource { @BaseMessage("Geo-spatial

[GitHub] [calcite] jbalint commented on a diff in pull request #2745: [CALCITE-4512] GROUP BY expression with argument name same with SELEC…

jbalint commented on code in PR #2745: URL: https://github.com/apache/calcite/pull/2745#discussion_r1049077069 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6590,20 +6593,25 @@ static class ExtendedExpander extends Expander { final

[GitHub] [calcite] OS-veracardoso commented on a diff in pull request #1299: [CALCITE-3100] cast(? as DATE) won't work with PreparedStatement

OS-veracardoso commented on code in PR #1299: URL: https://github.com/apache/calcite/pull/1299#discussion_r1048238523 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java: ## @@ -727,11 +736,38 @@ private Expression

[GitHub] [calcite] bchapuis opened a new pull request, #3002: [CALCITE-5417] Upgrade Proj4J from 1.2.0 to 1.2.1

bchapuis opened a new pull request, #3002: URL: https://github.com/apache/calcite/pull/3002 This PR is intended at testing Proj4J version 1.2.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] bchapuis merged pull request #2989: [CALCITE-5280] Add geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union)

bchapuis merged PR #2989: URL: https://github.com/apache/calcite/pull/2989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] bchapuis merged pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis merged PR #2962: URL: https://github.com/apache/calcite/pull/2962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] julianhyde commented on a diff in pull request #3000: [CALCITE-5423] Implement TIMESTAMP_DIFF function (compatible with BigQuery)

julianhyde commented on code in PR #3000: URL: https://github.com/apache/calcite/pull/3000#discussion_r1046138609 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7534,6 +7534,10 @@ private static void

[GitHub] [calcite] rubenada merged pull request #2982: [CALCITE-5394] RelToSql converter fails when semi-join is under a joi…

rubenada merged PR #2982: URL: https://github.com/apache/calcite/pull/2982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] rubenada merged pull request #2983: [CALCITE-5395] RelToSql converter fails when SELECT * is under a semi…

rubenada merged PR #2983: URL: https://github.com/apache/calcite/pull/2983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] dssysolyatin merged pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

dssysolyatin merged PR #2977: URL: https://github.com/apache/calcite/pull/2977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] tanclary commented on a diff in pull request #3000: [CALCITE-5423] Implement TIMESTAMP_DIFF function (compatible with BigQuery)

tanclary commented on code in PR #3000: URL: https://github.com/apache/calcite/pull/3000#discussion_r1045517177 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7534,6 +7534,10 @@ private static void checkArrayConcatAggFuncFails(SqlOperatorFixture

[GitHub] [calcite] julianhyde commented on a diff in pull request #3000: [CALCITE-5423] Implement TIMESTAMP_DIFF function (compatible with BigQuery)

julianhyde commented on code in PR #3000: URL: https://github.com/apache/calcite/pull/3000#discussion_r1045344772 ## core/src/main/java/org/apache/calcite/sql/fun/SqlTimestampDiffFunction.java: ## @@ -94,7 +105,10 @@ private static RelDataType

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

dssysolyatin commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1045286809 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] julianhyde opened a new pull request, #3001: [CALCITE-5417] Upgrade Proj4J from 1.1.5 to 1.2.0, and restore it as an included dependency

julianhyde opened a new pull request, #3001: URL: https://github.com/apache/calcite/pull/3001 In [CALCITE-5399] we removed Proj4J as a dependency due to licensing issues with the EPSG data set. In this change we upgrade Proj4J to version 1.2.0, which no longer includes the EPSG data set

[GitHub] [calcite] julianhyde closed pull request #2999: [CALCITE-5428] Drop minimum Guava version to 16.0.1.

julianhyde closed pull request #2999: [CALCITE-5428] Drop minimum Guava version to 16.0.1. URL: https://github.com/apache/calcite/pull/2999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] libenchao commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

libenchao commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1045031294 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] libenchao closed pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

libenchao closed pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values URL: https://github.com/apache/calcite/pull/2847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] tanclary opened a new pull request, #3000: [CALCITE-5423] Implement TIMESTAMP_DIFF function (compatible with BigQuery)

tanclary opened a new pull request, #3000: URL: https://github.com/apache/calcite/pull/3000 Implement BigQuery's TIMESTAMP_DIFF function whose parameter order differs from the standard TIMESTAMPDIFF. Add function call to parser to avoid generic function call throwing error when trying to

[GitHub] [calcite] gianm commented on pull request #2999: [CALCITE-5428] Drop minimum Guava version to 16.0.1.

gianm commented on PR #2999: URL: https://github.com/apache/calcite/pull/2999#issuecomment-1344803417 Hmm. The "Checks" tab says "This job was skipped" for "Linux (JDK 8), Oldest Guava, America/New_York Timezone". I think we need that to run to verify that this change works properly. Does

[GitHub] [calcite] gianm opened a new pull request, #2999: [CALCITE-5428] Drop minimum Guava version to 16.0.1.

gianm opened a new pull request, #2999: URL: https://github.com/apache/calcite/pull/2999 See https://issues.apache.org/jira/browse/CALCITE-5428. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

dssysolyatin commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1044438897 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

dssysolyatin commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1044438897 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] JiajunBernoulli commented on pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

JiajunBernoulli commented on PR #2847: URL: https://github.com/apache/calcite/pull/2847#issuecomment-1343698418 Never mind, thank you for your review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] asfgit closed pull request #2980: [CALCITE-5389] Add STARTS_WITH() and ENDS_WITH() for BIG_QUERY

asfgit closed pull request #2980: [CALCITE-5389] Add STARTS_WITH() and ENDS_WITH() for BIG_QUERY URL: https://github.com/apache/calcite/pull/2980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] libenchao commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

libenchao commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r1040282037 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java: ## @@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory

[GitHub] [calcite] libenchao commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

libenchao commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r1042836225 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java: ## @@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory

[GitHub] [calcite] freastro commented on pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

freastro commented on PR #2995: URL: https://github.com/apache/calcite/pull/2995#issuecomment-1341427184 @asolimando, just saw your comment about not squashing commits. I'll stop doing that unless requested. If it helps, it looks like GitHub can compare between commits even if they were

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

julianhyde commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1042567249 ## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite-avatica] freastro commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

freastro commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1042559515 ## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] julianhyde closed pull request #2998: [CALCITE-5360] Implement BigQuery TIMESTAMP_ADD

julianhyde closed pull request #2998: [CALCITE-5360] Implement BigQuery TIMESTAMP_ADD URL: https://github.com/apache/calcite/pull/2998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] asolimando commented on pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

asolimando commented on PR #2995: URL: https://github.com/apache/calcite/pull/2995#issuecomment-1341266724 > @asolimando, thanks for reviewing! I've made the changes you've requested. The Avatica PR this depends on is still in review. But let me know if you have any other suggestions.

[GitHub] [calcite] asolimando commented on a diff in pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

asolimando commented on code in PR #2995: URL: https://github.com/apache/calcite/pull/2995#discussion_r1042450001 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2006,15 +1997,11 @@ public static long toLong(Timestamp v) { return toLong(v,

[GitHub] [calcite] asolimando commented on a diff in pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

asolimando commented on code in PR #2995: URL: https://github.com/apache/calcite/pull/2995#discussion_r1042448897 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2172,7 +2163,11 @@ public static String timeWithLocalTimeZoneToString(int v, TimeZone

[GitHub] [calcite-avatica] freastro commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

freastro commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1042355103 ## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite-avatica] asolimando commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

asolimando commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041992735 ## core/src/test/java/org/apache/calcite/avatica/util/DateAccessorTest.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

julianhyde commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041977848 ## core/src/test/java/org/apache/calcite/avatica/util/DateAccessorTest.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite-avatica] asolimando commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

asolimando commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041953622 ## core/src/test/java/org/apache/calcite/avatica/util/TimeFromNumberAccessorTest.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

julianhyde commented on code in PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#discussion_r1041634873 ## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromUtilDateAccessorTest.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r1041636188 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java: ## @@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory

[GitHub] [calcite] julianhyde commented on pull request #2980: [CALCITE-5389] Add STARTS_WITH() and ENDS_WITH() for BIG_QUERY

julianhyde commented on PR #2980: URL: https://github.com/apache/calcite/pull/2980#issuecomment-1340012823 I'm reviewing now (as of 8b92384761). I saw you merged with main. Best not to do that - or to squash/rebase. Just append commits, and you or the reviewer can squash/rebase after

[GitHub] [calcite] julianhyde closed pull request #2985: [CALCITE-5393] Support MySQL VALUE operator parse

julianhyde closed pull request #2985: [CALCITE-5393] Support MySQL VALUE operator parse URL: https://github.com/apache/calcite/pull/2985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] julianhyde commented on a diff in pull request #2998: [CALCITE-5360] Implement BigQuery TIMESTAMP_ADD

julianhyde commented on code in PR #2998: URL: https://github.com/apache/calcite/pull/2998#discussion_r1040631072 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4824,7 +4824,7 @@ SqlNode IntervalLiteralOrExpression() : | e = CompoundIdentifier()

[GitHub] [calcite] libenchao commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

libenchao commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r1040282037 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java: ## @@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory

[GitHub] [calcite] freastro commented on pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

freastro commented on PR #2995: URL: https://github.com/apache/calcite/pull/2995#issuecomment-1338514460 @asolimando, thanks for reviewing! I've made the changes you've requested. The Avatica PR this depends on is still in review. But let me know if you have any other suggestions. --

[GitHub] [calcite] freastro commented on a diff in pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

freastro commented on code in PR #2995: URL: https://github.com/apache/calcite/pull/2995#discussion_r1040280334 ## testkit/src/main/java/org/apache/calcite/test/QuidemTest.java: ## @@ -293,6 +293,7 @@ public Connection connect(String name) throws Exception {

[GitHub] [calcite] freastro commented on a diff in pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

freastro commented on code in PR #2995: URL: https://github.com/apache/calcite/pull/2995#discussion_r1040275313 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2172,7 +2163,11 @@ public static String timeWithLocalTimeZoneToString(int v, TimeZone

[GitHub] [calcite] freastro commented on a diff in pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

freastro commented on code in PR #2995: URL: https://github.com/apache/calcite/pull/2995#discussion_r1040273603 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2006,15 +1997,11 @@ public static long toLong(Timestamp v) { return toLong(v,

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

JiajunBernoulli commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r1040264729 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java: ## @@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory

[GitHub] [calcite] strongduanmu commented on a diff in pull request #2985: [CALCITE-5393] Support MySQL VALUE operator parse

strongduanmu commented on code in PR #2985: URL: https://github.com/apache/calcite/pull/2985#discussion_r1040253872 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -4585,6 +4585,23 @@ void checkPeriodPredicate(Checker checker) {

[GitHub] [calcite] strongduanmu commented on a diff in pull request #2985: [CALCITE-5393] Support MySQL VALUE operator parse

strongduanmu commented on code in PR #2985: URL: https://github.com/apache/calcite/pull/2985#discussion_r1040250599 ## core/src/main/java/org/apache/calcite/runtime/CalciteResource.java: ## @@ -995,4 +995,6 @@ ExInstWithCause failedToAccessField( @BaseMessage("A table

[GitHub] [calcite] bchapuis commented on a diff in pull request #2924: [CALCITE-5281] Add ST_Explode function

bchapuis commented on code in PR #2924: URL: https://github.com/apache/calcite/pull/2924#discussion_r1040173058 ## core/src/test/java/org/apache/calcite/test/SpatialTypeTableFunctionsTest.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] bchapuis commented on a diff in pull request #2924: [CALCITE-5281] Add ST_Explode function

bchapuis commented on code in PR #2924: URL: https://github.com/apache/calcite/pull/2924#discussion_r1040172590 ## core/src/test/java/org/apache/calcite/test/SpatialTypeTableFunctionsTest.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] bchapuis commented on a diff in pull request #2924: [CALCITE-5281] Add ST_Explode function

bchapuis commented on code in PR #2924: URL: https://github.com/apache/calcite/pull/2924#discussion_r1040133298 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] bchapuis commented on a diff in pull request #2924: [CALCITE-5281] Add ST_Explode function

bchapuis commented on code in PR #2924: URL: https://github.com/apache/calcite/pull/2924#discussion_r1040132270 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] bchapuis commented on a diff in pull request #2924: [CALCITE-5281] Add ST_Explode function

bchapuis commented on code in PR #2924: URL: https://github.com/apache/calcite/pull/2924#discussion_r1040131506 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] tanclary opened a new pull request, #2998: [CALCITE-5360] Implement BigQuery TIMESTAMP_ADD

tanclary opened a new pull request, #2998: URL: https://github.com/apache/calcite/pull/2998 Implement BigQuery's TIMESTAMP_ADD. This implementation is similar to that of the standard timestampadd but accounts for the difference in operand number and type. JIRA issue

[GitHub] [calcite] julianhyde commented on a diff in pull request #2985: [CALCITE-5393] Support MySQL VALUE operator parse

julianhyde commented on code in PR #2985: URL: https://github.com/apache/calcite/pull/2985#discussion_r1038925433 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -4585,6 +4585,23 @@ void checkPeriodPredicate(Checker checker) {

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1039889386 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] rubenada commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

rubenada commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1039714696 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] libenchao commented on a diff in pull request #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

libenchao commented on code in PR #2847: URL: https://github.com/apache/calcite/pull/2847#discussion_r1039714710 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java: ## @@ -104,14 +104,15 @@ public TypeCoercionImpl(RelDataTypeFactory

[GitHub] [calcite] rubenada commented on pull request #2982: [CALCITE-5394] RelToSql converter fails when semi-join is under a joi…

rubenada commented on PR #2982: URL: https://github.com/apache/calcite/pull/2982#issuecomment-1337477793 @JiajunBernoulli the fix LGTM, but I am not very familiar with SqlToRelConverter's logic. Let's wait to see if some other contributor that knows this part of the code better can take

[GitHub] [calcite] rubenada commented on pull request #2983: [CALCITE-5395] RelToSql converter fails when SELECT * is under a semi…

rubenada commented on PR #2983: URL: https://github.com/apache/calcite/pull/2983#issuecomment-1337477401 @JiajunBernoulli the fix LGTM, but I am not very familiar with SqlToRelConverter's logic. Let's wait to see if some other contributor that knows this part of the code better can take

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli commented on code in PR #2997: URL: https://github.com/apache/calcite/pull/2997#discussion_r1039640366 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -672,9 +672,11 @@ private static String toSql(RelNode root, SqlDialect

[GitHub] [calcite] LeonidChistov commented on a diff in pull request #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

LeonidChistov commented on code in PR #2997: URL: https://github.com/apache/calcite/pull/2997#discussion_r1039293894 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -672,9 +672,11 @@ private static String toSql(RelNode root, SqlDialect

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1039023021 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] libenchao commented on a diff in pull request #2968: [CALCITE-5354] JDBC with UNNEST not working

libenchao commented on code in PR #2968: URL: https://github.com/apache/calcite/pull/2968#discussion_r1038972799 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -2442,18 +2472,27 @@ private void convertUnnest(Blackboard bb, SqlCall call,

[GitHub] [calcite] JiajunBernoulli opened a new pull request, #2997: [CALCITE-5416] RelToSql converter generates invalid code when merging…

JiajunBernoulli opened a new pull request, #2997: URL: https://github.com/apache/calcite/pull/2997 … rollup and sort clauses -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] bchapuis commented on a diff in pull request #2989: [CALCITE-5280] Add geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union)

bchapuis commented on code in PR #2989: URL: https://github.com/apache/calcite/pull/2989#discussion_r1038801545 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java: ## @@ -16,6 +16,15 @@ */ package org.apache.calcite.sql.fun; +import

[GitHub] [calcite] libenchao commented on a diff in pull request #2974: [CALCITE-5209] ArrayIndexOutOfBoundsException during SqlToRelConverter for group-by on `case` having `in` expression predicates

libenchao commented on code in PR #2974: URL: https://github.com/apache/calcite/pull/2974#discussion_r1038794437 ## core/src/test/resources/sql/agg.iq: ## @@ -3467,4 +3467,38 @@ order by ename, deptno; !ok +# Test cases for [CALCITE-5209] ArrayIndexOutOfBoundsException

[GitHub] [calcite] bchapuis commented on a diff in pull request #2989: [CALCITE-5280] Add geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union)

bchapuis commented on code in PR #2989: URL: https://github.com/apache/calcite/pull/2989#discussion_r1037646857 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java: ## @@ -16,6 +16,15 @@ */ package org.apache.calcite.sql.fun; +import

[GitHub] [calcite] bchapuis commented on a diff in pull request #2989: [CALCITE-5280] Add geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union)

bchapuis commented on code in PR #2989: URL: https://github.com/apache/calcite/pull/2989#discussion_r1037646857 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java: ## @@ -16,6 +16,15 @@ */ package org.apache.calcite.sql.fun; +import

[GitHub] [calcite] libenchao commented on a diff in pull request #2974: [CALCITE-5209] ArrayIndexOutOfBoundsException during SqlToRelConverter for group-by on `case` having `in` expression predicates

libenchao commented on code in PR #2974: URL: https://github.com/apache/calcite/pull/2974#discussion_r1038789810 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -6374,10 +6390,13 @@ private static class SubQuery { final SqlNode node;

[GitHub] [calcite] libenchao merged pull request #2993: [CALCITE-5410] Assertion error on PERCENT_REMAINDER operator with DECIMAL type

libenchao merged PR #2993: URL: https://github.com/apache/calcite/pull/2993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] libenchao commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

libenchao commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1038754777 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

<    1   2   3   4   5   6   7   8   9   10   >