[GitHub] [calcite] twdsilva commented on pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on PR #2876: URL: https://github.com/apache/calcite/pull/2876#issuecomment-1336037626 > @twdsilva thanks for the PR, I think it's a very useful feature, I still share the doubts that @julianhyde raised in a [jira

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038666780 ## core/src/test/java/org/apache/calcite/test/MaterializedViewRelOptRulesTest.java: ## @@ -338,6 +341,104 @@ protected final MaterializedViewFixture sql(String

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r103869 ## core/src/test/java/org/apache/calcite/test/TestMetadataHandlers.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r103851 ## core/src/test/java/org/apache/calcite/test/MaterializedViewRelOptRulesTest.java: ## @@ -338,6 +341,104 @@ protected final MaterializedViewFixture sql(String

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038666586 ## core/src/test/java/org/apache/calcite/test/MaterializedViewRelOptRulesTest.java: ## @@ -338,6 +341,104 @@ protected final MaterializedViewFixture sql(String

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038666571 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -3027,6 +3028,43 @@ private void checkSarg(String message, Sarg sarg, is(false));

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038666387 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -3027,6 +3028,43 @@ private void checkSarg(String message, Sarg sarg, is(false));

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038666309 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -3027,6 +3028,43 @@ private void checkSarg(String message, Sarg sarg, is(false));

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038666170 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -3027,6 +3028,43 @@ private void checkSarg(String message, Sarg sarg, is(false));

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038666155 ## core/src/main/java/org/apache/calcite/rex/RexInterpreter.java: ## @@ -342,22 +346,15 @@ private static Comparable ceil(RexCall call, List values) { default:

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038666134 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665983 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665246 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665518 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665617 ## core/src/test/java/org/apache/calcite/test/MaterializedViewRelOptRulesTest.java: ## @@ -338,6 +341,104 @@ protected final MaterializedViewFixture sql(String

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665587 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665549 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665518 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665274 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665246 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665187 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665131 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -1252,6 +1285,193 @@ protected RexNode

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038665019 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java: ## @@ -910,6 +942,53 @@ protected SqlFunction

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038664898 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java: ## @@ -910,6 +942,53 @@ protected SqlFunction

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038664727 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java: ## @@ -910,6 +942,53 @@ protected SqlFunction

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038664620 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java: ## @@ -910,6 +942,53 @@ protected SqlFunction

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038664589 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java: ## @@ -910,6 +942,53 @@ protected SqlFunction

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038664537 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java: ## @@ -292,10 +298,36 @@ otherCompensationPred)));

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r1038664497 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java: ## @@ -292,10 +298,36 @@ otherCompensationPred)));

[GitHub] [calcite] jamesstarr opened a new pull request, #2996: [CALCITE-5418] Fixing Nested Correlated Subquery Expansion

jamesstarr opened a new pull request, #2996: URL: https://github.com/apache/calcite/pull/2996 Check projects and filters correlate id to make sure the scope of the correlation is correct. Join's correlate id is not populated correctly in SqlToRel, so join's may still be improperly

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1038610731 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1038614126 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1038610731 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1038610731 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1038610731 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1038610731 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] bchapuis commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

bchapuis commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1038610731 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] asolimando commented on pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

asolimando commented on PR #2995: URL: https://github.com/apache/calcite/pull/2995#issuecomment-1335424889 I just noticed that we are relying here on another PR from Avatica which is not yet in (https://github.com/apache/calcite-avatica/pull/197), which incidentally fails when run on a

[GitHub] [calcite-avatica] asolimando commented on pull request #197: [CALCITE-2989] Use ISO calendar system when accessing Date/Time/Timestamp from a number

asolimando commented on PR #197: URL: https://github.com/apache/calcite-avatica/pull/197#issuecomment-1335420683 @freastro, tests should pass in all TZs, you cannot assume a specific one so you can't hardcode your expected values, you need to derive them dynamically, see if

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

dssysolyatin commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1038245590 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] rubenada commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

rubenada commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1038240351 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] asolimando commented on a diff in pull request #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

asolimando commented on code in PR #2995: URL: https://github.com/apache/calcite/pull/2995#discussion_r1038191382 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -2006,15 +1997,11 @@ public static long toLong(Timestamp v) { return toLong(v,

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

dssysolyatin commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1038206955 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

dssysolyatin commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1038206955 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] rubenada commented on a diff in pull request #2977: [CALCITE-5388] No result when using ROW_NUMBER in two common table expressions

rubenada commented on code in PR #2977: URL: https://github.com/apache/calcite/pull/2977#discussion_r1038180423 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java: ## @@ -693,7 +696,7 @@ private static Pair getPartitionIterator( }

[GitHub] [calcite] rubenada commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

rubenada commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1037942435 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite] rubenada commented on a diff in pull request #2962: [CALCITE-5362] Geometry measurement functions

rubenada commented on code in PR #2962: URL: https://github.com/apache/calcite/pull/2962#discussion_r1037941963 ## core/src/main/java/org/apache/calcite/runtime/SpatialTypeFunctions.java: ## @@ -1318,6 +1322,195 @@ public static Geometry ST_Translate(Geometry geom, BigDecimal

[GitHub] [calcite-avatica] julianhyde merged pull request #198: [CALCITE-5415] In ByteString, add 'startsWith' and 'endsWith' methods

julianhyde merged PR #198: URL: https://github.com/apache/calcite-avatica/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] freastro opened a new pull request, #2995: [CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and unix timestamps

freastro opened a new pull request, #2995: URL: https://github.com/apache/calcite/pull/2995 Converting java.sql types to unix timestamps requires extra steps to also convert to the correct calendar. Unix timestamps should follow the proleptic Gregorian calendar as defined by ISO-8601. Java

[GitHub] [calcite] freastro closed pull request #2972: [CALCITE-2989] Use ISO calendar system when converting from java.sql.Date/Time/Timestamp to a unix timestamp

freastro closed pull request #2972: [CALCITE-2989] Use ISO calendar system when converting from java.sql.Date/Time/Timestamp to a unix timestamp URL: https://github.com/apache/calcite/pull/2972 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] freastro commented on pull request #2972: [CALCITE-2989] Use ISO calendar system when converting from java.sql.Date/Time/Timestamp to a unix timestamp

freastro commented on PR #2972: URL: https://github.com/apache/calcite/pull/2972#issuecomment-1334647767 Will reopen targeting the CALCITE-5414 JIRA issue instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] bchapuis commented on a diff in pull request #2989: [CALCITE-5280] Add geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union)

bchapuis commented on code in PR #2989: URL: https://github.com/apache/calcite/pull/2989#discussion_r1037646857 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java: ## @@ -16,6 +16,15 @@ */ package org.apache.calcite.sql.fun; +import

[GitHub] [calcite] julianhyde commented on a diff in pull request #2989: [CALCITE-5280] Add geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union)

julianhyde commented on code in PR #2989: URL: https://github.com/apache/calcite/pull/2989#discussion_r1037570371 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java: ## @@ -16,6 +16,15 @@ */ package org.apache.calcite.sql.fun; +import

[GitHub] [calcite] bchapuis merged pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis merged PR #2988: URL: https://github.com/apache/calcite/pull/2988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] zabetak commented on pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

zabetak commented on PR #2988: URL: https://github.com/apache/calcite/pull/2988#issuecomment-1333504823 @bchapuis Thanks for pushing this forward! You are correct; either you click "Rebase and merge" button or you do the same thing via command line. Sharing also another link that you may

[GitHub] [calcite] alex-plekhanov opened a new pull request, #2993: [CALCITE-5410] Assertion error on PERCENT_REMAINDER operator with DECIMAL type

alex-plekhanov opened a new pull request, #2993: URL: https://github.com/apache/calcite/pull/2993 PERCENT_REMAINDER operator should have the same return type inference as MOD operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] julianhyde closed pull request #2978: [CALCITE-5385] Add BigQuery as supported library for implemented functions

julianhyde closed pull request #2978: [CALCITE-5385] Add BigQuery as supported library for implemented functions URL: https://github.com/apache/calcite/pull/2978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] tanclary opened a new pull request, #2992: [CALCITE-5404] Implement BigQuery's POW() and TRUNC() math functions

tanclary opened a new pull request, #2992: URL: https://github.com/apache/calcite/pull/2992 Add support for BigQuery's POW() and TRUNC() mathematical functions by mapping them to the existing implementations for POWER() and TRUNCATE() respectively. -- This is an automated message from

[GitHub] [calcite] bchapuis commented on pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on PR #2988: URL: https://github.com/apache/calcite/pull/2988#issuecomment-1332752664 @zabetak Thanks a lot for your help. I just reread the [develop documentation](https://calcite.apache.org/develop/) in prevision of merging the PR. To keep the history clean, I

[GitHub] [calcite] julianhyde commented on a diff in pull request #2978: [CALCITE-5385] Add BigQuery as supported library for implemented functions

julianhyde commented on code in PR #2978: URL: https://github.com/apache/calcite/pull/2978#discussion_r1036312316 ## gradle.properties: ## @@ -27,7 +27,7 @@ systemProp.org.gradle.internal.publish.checksums.insecure=true # This is version for Calcite itself # Note: it should

[GitHub] [calcite] julianhyde closed pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

julianhyde closed pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal URL: https://github.com/apache/calcite/pull/2819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] libenchao closed pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

libenchao closed pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation URL: https://github.com/apache/calcite/pull/2868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] julianhyde commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

julianhyde commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1035407621 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] julianhyde commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

julianhyde commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1035403678 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] jbalint merged pull request #2890: [CALCITE-5259] Add getParameterRowType method to Planner interface

jbalint merged PR #2890: URL: https://github.com/apache/calcite/pull/2890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] jbalint commented on a diff in pull request #2890: [CALCITE-5259] Add getParameterRowType method to Planner interface

jbalint commented on code in PR #2890: URL: https://github.com/apache/calcite/pull/2890#discussion_r1035051360 ## core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java: ## @@ -237,6 +237,15 @@ private void ready() { return Pair.of(validatedNode, type); } +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034935144 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034935144 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034935144 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034935144 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE`

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2890: [CALCITE-5259] Add getParameterRowType method to Planner interface

dssysolyatin commented on code in PR #2890: URL: https://github.com/apache/calcite/pull/2890#discussion_r1034930593 ## core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java: ## @@ -237,6 +237,15 @@ private void ready() { return Pair.of(validatedNode, type); }

[GitHub] [calcite] jbalint commented on a diff in pull request #2890: [CALCITE-5259] Add getParameterRowType method to Planner interface

jbalint commented on code in PR #2890: URL: https://github.com/apache/calcite/pull/2890#discussion_r1034916228 ## core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java: ## @@ -237,6 +237,15 @@ private void ready() { return Pair.of(validatedNode, type); } +

[GitHub] [calcite] jbalint merged pull request #2860: [CALCITE-5217] Add support for INTERVAL qualifier for Firebolt

jbalint merged PR #2860: URL: https://github.com/apache/calcite/pull/2860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] dssysolyatin commented on pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

dssysolyatin commented on PR #2819: URL: https://github.com/apache/calcite/pull/2819#issuecomment-1330769024 @julianhyde if you have time, please review this PR again. This PR is actively used in one of our project, I have to fix conflicts quite often. Thanks ! -- This is an automated

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034797722 ## core/build.gradle.kts: ## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034797722 ## core/build.gradle.kts: ## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034797722 ## core/build.gradle.kts: ## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034737271 ## core/build.gradle.kts: ## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") +

[GitHub] [calcite] bchapuis commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

bchapuis commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034723743 ## core/src/main/java/org/apache/calcite/runtime/ProjectionTransformer.java: ## @@ -40,6 +40,14 @@ /** * Transforms the projection of a geometry. + * + * This

[GitHub] [calcite] zabetak commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

zabetak commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034587984 ## site/_docs/howto.md: ## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE` *

[GitHub] [calcite] libenchao commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

libenchao commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1330293444 @julianhyde Very thanks for the reminder  , I did plan to do that while merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] julianhyde commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

julianhyde commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1330281838 @libenchao when you merge, please change the commit message to something that doesn’t start with “fix” -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] rubenada commented on a diff in pull request #2988: [CALCITE-5399] Remove Proj4J from the api dependencies

rubenada commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034434709 ## core/src/main/java/org/apache/calcite/runtime/ProjectionTransformer.java: ## @@ -40,6 +40,14 @@ /** * Transforms the projection of a geometry. + * + * This

[GitHub] [calcite] libenchao commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

libenchao commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1329982053 I'm ok with finishing it to another separate issue. This PR now looks good to me. The CI failure seems unrelated, I'll merge it. -- This is an automated message from the Apache Git

[GitHub] [calcite-avatica] snuyanzin closed pull request #195: [CALCITE-5374] Upgrade jackson from 2.10.0 to 2.14.1

snuyanzin closed pull request #195: [CALCITE-5374] Upgrade jackson from 2.10.0 to 2.14.1 URL: https://github.com/apache/calcite-avatica/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] bchapuis closed pull request #2917: [CALCITE-5280] Add geometry aggregate functions

bchapuis closed pull request #2917: [CALCITE-5280] Add geometry aggregate functions URL: https://github.com/apache/calcite/pull/2917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] snuyanzin merged pull request #2987: Upgrade jackson to 2.14.1

snuyanzin merged PR #2987: URL: https://github.com/apache/calcite/pull/2987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] bchapuis opened a new pull request, #2988: Remove Proj4J from the api dependencies

bchapuis opened a new pull request, #2988: URL: https://github.com/apache/calcite/pull/2988 Proj4J uses the EPSG dataset and has restricting terms of use. Making Proj4J a compileOnly dependency addresses this issue. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] snuyanzin opened a new pull request, #2987: Upgrade jackson to 2.14.1

snuyanzin opened a new pull request, #2987: URL: https://github.com/apache/calcite/pull/2987 Upgrade jackson to 2.14.1 to include fix for https://github.com/FasterXML/jackson-databind/issues/3665 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite-avatica] snuyanzin commented on pull request #195: [CALCITE-5374] Upgrade jackson to 2.14.0

snuyanzin commented on PR #195: URL: https://github.com/apache/calcite-avatica/pull/195#issuecomment-1329641680 Thanks for merging. If you don't mind i would update it to 2.14.1 to include fix for [ObjectMapper default heap consumption increased significantly from 2.13.x to 2.14.0

[GitHub] [calcite] ErikGoldman closed pull request #2824: Snowflake checkpoint 1

ErikGoldman closed pull request #2824: Snowflake checkpoint 1 URL: https://github.com/apache/calcite/pull/2824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite-avatica] julianhyde commented on pull request #195: [CALCITE-5374] Upgrade jackson to 2.14.0

julianhyde commented on PR #195: URL: https://github.com/apache/calcite-avatica/pull/195#issuecomment-1329633534 Now I've merged the fix into Calcite, the Avatica JDK 8 test should pass. Once it passes let's merge this PR. -- This is an automated message from the Apache Git Service. To

[GitHub] [calcite] julianhyde merged pull request #2966: [CALCITE-5374] Upgrade jackson to 2.14.0

julianhyde merged PR #2966: URL: https://github.com/apache/calcite/pull/2966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] olivrlee commented on a diff in pull request #2980: [CALCITE-5389] Add STARTS_WITH() for BIG_QUERY

olivrlee commented on code in PR #2980: URL: https://github.com/apache/calcite/pull/2980#discussion_r1033956641 ## babel/src/test/resources/sql/big-query.iq: ## @@ -2519,4 +2519,31 @@ SELECT PARSE_TIMESTAMP("%c", "Thu Dec 25 07:30:00 2008") AS parsed; !ok !}

[GitHub] [calcite] itiels commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

itiels commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1329304370 HI @libenchao, Sorry for the late reply. I agree with your conclusion, however I prefer to do that in a separate PR if it's ok with you. -- This is an automated message from

[GitHub] [calcite] zabetak closed pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

zabetak closed pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome URL: https://github.com/apache/calcite/pull/2937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] zabetak commented on pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

zabetak commented on PR #2937: URL: https://github.com/apache/calcite/pull/2937#issuecomment-1329217861 @rubenada Thanks for the reminder. I added an additional `DEFAULT` instance for the new `ZeroMaxRowsRuleConfig` and rebased against `main`. I will merge this once all tests are run. --

[GitHub] [calcite] libenchao commented on pull request #2868: [CALCITE-5230] Fix PERCENTILE_DISC return type derivation

libenchao commented on PR #2868: URL: https://github.com/apache/calcite/pull/2868#issuecomment-1329213773 @itiels Sorry to ping you. We plan to release 1.33 recently, it would be great if we can make it in this release. Do you have any comments about my last comment? -- This is an

[GitHub] [calcite] rubenada commented on pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

rubenada commented on PR #2937: URL: https://github.com/apache/calcite/pull/2937#issuecomment-1329126529 @zabetak shall we move on and merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] strongduanmu opened a new pull request, #2985: [CALCITE-5393] Support MySQL VALUE operator parse

strongduanmu opened a new pull request, #2985: URL: https://github.com/apache/calcite/pull/2985 * add `VALUE` kerword to Paser.jj for `INSERT INTO ... VALUE ...` statement * add unit test for `INSERT INTO ... VALUE ...` statement -- This is an automated message from the Apache Git

<    1   2   3   4   5   6   7   8   9   10   >