[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405929414 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405928980 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405928280 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405912405 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-06 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r404541078 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-06 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r404539667 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-06 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r404428336 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-31 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r401312442 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-31 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r400967195 ## File path: core/src/main/java/org/apache/calcite/plan/Convention.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-31 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r400966613 ## File path: core/src/main/java/org/apache/calcite/plan/Convention.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-31 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r400963183 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-31 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r400956153 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-31 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r400953759 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSubset.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-25 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r398088521 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-25 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r398088611 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSet.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-19 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r395432588 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-19 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r395432588 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-19 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r395431348 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-19 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r395431225 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/Enumerab

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-19 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r395228189 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-19 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r395217146 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-19 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r395169171 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-18 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r394761318 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-18 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r394761404 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-18 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r394761359 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSubset.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-03-18 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r394761318 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ##