[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-31 Thread via GitHub
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1092490830 ## core/src/main/java/org/apache/calcite/util/format/FormatModelUtil.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-31 Thread via GitHub
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1092488598 ## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-31 Thread via GitHub
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1092488598 ## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-31 Thread via GitHub
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1092484458 ## core/src/main/java/org/apache/calcite/sql/SqlDialect.java: ## @@ -1002,6 +1004,18 @@ protected static void unparseOffset(SqlWriter writer, @Nullable SqlNode

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-31 Thread via GitHub
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1092479733 ## core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java: ## @@ -271,6 +272,50 @@ private static TimeUnit validate(TimeUnit timeUnit) { }

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-24 Thread via GitHub
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1086039023 ## core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java: ## @@ -271,6 +272,50 @@ private static TimeUnit validate(TimeUnit timeUnit) { }

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-22 Thread via GitHub
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1083554622 ## core/src/main/java/org/apache/calcite/util/format/FormatModelUtil.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080688763 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -240,6 +281,17 @@ public MysqlSqlDialect(Context context) {

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080677876 ## core/src/main/java/org/apache/calcite/util/format/FormatModelElementAlias.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080614602 ## core/src/main/java/org/apache/calcite/sql/FormatModel.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1080608342 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -240,6 +281,17 @@ public MysqlSqlDialect(Context context) {

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tjbanghart commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073950252 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return