caicancai commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1867349263
> > @tanclary Hello, should we add corresponding tests to SqlOperatorTest
>
> @caicancai Could you clarify what you mean? I believe there are already
tests for these functions in
tanclary commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1864408110
> @tanclary Hello, should we add corresponding tests to SqlOperatorTest
Could you clarify what you mean? I believe there are already tests for these
functions in
caicancai commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1863737289
@tanclary Hello, should we add corresponding tests to SqlOperator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tanclary merged PR #3438:
URL: https://github.com/apache/calcite/pull/3438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1832873476
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1830990415
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1830945771
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1830852939
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
tanclary commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1830760578
> I'd change `writer.print(" OVER")` to `writer.keyword("OVER")` but it
looks like progress, so +1.
>
> Please check that we are not breaking things on non-BigQuery dialects. If
julianhyde commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1828955438
I'd change `writer.print(" OVER")` to `writer.keyword("OVER")` but it looks
like progress, so +1.
Please check that we are not breaking things on non-BigQuery dialects. If
tanclary commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1827098369
@julianhyde @olivrlee What do we think of this for handling the most basic
cases of PERCENTILE? I think it is a good starting point while we don't have
the functions fully implemented.
sonarcloud[bot] commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1823308264
Kudos, SonarCloud Quality Gate passed! [