caicancai commented on PR #3438:
URL: https://github.com/apache/calcite/pull/3438#issuecomment-1867349263
> > @tanclary Hello, should we add corresponding tests to SqlOperatorTest
>
> @caicancai Could you clarify what you mean? I believe there are already
tests for these functions in
caicancai commented on code in PR #3586:
URL: https://github.com/apache/calcite/pull/3586#discussion_r1434803576
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -11948,6 +11984,25 @@ void testTimestampDiff(boolean coercionEnabled) {
caicancai commented on code in PR #3586:
URL: https://github.com/apache/calcite/pull/3586#discussion_r1434801168
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -11859,6 +11859,42 @@ void testTimestampDiff(boolean coercionEnabled) {
TusharSthul closed pull request #3592: Control simplification in
RelBuilder#filter with `config.simplify()'
URL: https://github.com/apache/calcite/pull/3592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chucheng92 commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1867156919
The commit name "Add DATE_SUB test and DATE_DIFF" but you actually add
DATE_ADD and DATE_DIFF. could you recheck it?
--
This is an automated message from the Apache Git Service.
To
chucheng92 commented on code in PR #3586:
URL: https://github.com/apache/calcite/pull/3586#discussion_r1433384145
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -11859,6 +11859,42 @@ void testTimestampDiff(boolean coercionEnabled) {
mihaibudiu commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434660313
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,44 @@ private void testCurrentDateFunc(Pair pair) {
snuyanzin commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434637134
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,44 @@ private void testCurrentDateFunc(Pair pair) {
sonarcloud[bot] commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867101890
## [ {
julianhyde commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434597746
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -13686,6 +13673,31 @@ void testCastTruncates(CastType castType,
SqlOperatorFixture f)
julianhyde commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867061770
@mihaibudiu The danger with your approach is that, by working on the AST,
you automatically fix errors. E.g. you might accidentally change STARTSWITH to
STARTS_WITH and not notice
julianhyde commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434594909
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,42 @@ private void testCurrentDateFunc(Pair pair) {
julianhyde commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434594471
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -13686,6 +13673,31 @@ void testCastTruncates(CastType castType,
SqlOperatorFixture f)
mihaibudiu commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867056620
You leave the queries unchanged, and then you use a shuttle to replace the
use of `starts_with` with `startswith`.
--
This is an automated message from the Apache Git Service.
To
snuyanzin commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867055416
I didn't get how shuttle could help with different `SQLLibraries` per
alias...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mihaibudiu opened a new pull request, #3589:
URL: https://github.com/apache/calcite/pull/3589
I initially started with the goal of fixing just [CALCITE-3522],
https://issues.apache.org/jira/browse/CALCITE-3522, which is limiting the size
of decimal literals to 64 bits. The fix is to
tanclary merged PR #3565:
URL: https://github.com/apache/calcite/pull/3565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new e74ff3eaa0 [CALCITE-6156] Add ENDSWITH, STARTSWITH
sonarcloud[bot] commented on PR #3565:
URL: https://github.com/apache/calcite/pull/3565#issuecomment-1866979251
## [ {
}
@Test void
julianhyde commented on code in PR #3565:
URL: https://github.com/apache/calcite/pull/3565#discussion_r1434504495
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8878,51 +8878,106 @@ private void testCurrentDateFunc(Pair pair) {
}
@Test
sonarcloud[bot] commented on PR #3586:
URL: https://github.com/apache/calcite/pull/3586#issuecomment-1866441880
## [), I will add it in the next pr. Because
date_sub does not have a
This is an automated email from the ASF dual-hosted git repository.
asf-ci-deploy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite-site.git
The following commit(s) were added to refs/heads/main by this push:
new 121010a0c Website deployed from
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch site
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/site by this push:
new 9d75a8faf8 Site: Switch PMC Chair to Benchao
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new a816267808 Site: Switch PMC Chair to Benchao Li
32 matches
Mail list logo
